TODO:
+ The routine that makes missing directories for files that get renamed
+ down into a new sub-hierarchy doesn't properly handle the case where some
+ path elements might exist but not be a dir yet. We need to either change
+ our stash-ahead algorithm (to not require unknown path elements) or we
+ need to create a better path-making routine.
+
We need to never return a match from fattr_find() that has a basis
file. This will ensure that we don't try to give a renamed file to
a file that can't use it, while missing out on giving it to a file
that could use it.
-based-on: 25082d1ef6712a15c52a1dacb36b7f0642c23ac8
+based-on: 0773cecc1fc6462b321f96dc8cae6e11983c357d
+diff --git a/backup.c b/backup.c
+--- a/backup.c
++++ b/backup.c
+@@ -162,7 +162,7 @@ char *get_backup_name(const char *fname)
+ int ret;
+ if (backup_dir_len > 1)
+ backup_dir_buf[backup_dir_len-1] = '\0';
+- ret = make_path(backup_dir_buf, 0);
++ ret = make_path(backup_dir_buf, ACCESSPERMS, 0);
+ if (backup_dir_len > 1)
+ backup_dir_buf[backup_dir_len-1] = '/';
+ if (ret < 0)
diff --git a/compat.c b/compat.c
--- a/compat.c
+++ b/compat.c
-@@ -42,6 +42,7 @@ extern int checksum_seed;
+@@ -40,6 +40,7 @@ extern int checksum_seed;
extern int basis_dir_cnt;
extern int prune_empty_dirs;
extern int protocol_version;
extern int protect_args;
extern int preserve_uid;
extern int preserve_gid;
-@@ -122,6 +123,7 @@ void set_allow_inc_recurse(void)
+@@ -168,6 +169,7 @@ void set_allow_inc_recurse(void)
allow_inc_recurse = 0;
else if (!am_sender
&& (delete_before || delete_after
+ || detect_renamed
|| delay_updates || prune_empty_dirs))
allow_inc_recurse = 0;
- else if (am_server && !local_server
+ else if (am_server && strchr(client_info, 'i') == NULL)
diff --git a/delete.c b/delete.c
--- a/delete.c
+++ b/delete.c
extern char *backup_dir;
extern char *backup_suffix;
extern int backup_suffix_len;
-@@ -45,6 +46,8 @@ static inline int is_backup_file(char *fn)
+@@ -44,6 +45,8 @@ static inline int is_backup_file(char *fn)
* its contents, otherwise just checks for content. Returns DR_SUCCESS or
* DR_NOT_EMPTY. Note that fname must point to a MAXPATHLEN buffer! (The
* buffer is used for recursion, but returned unchanged.)
*/
static enum delret delete_dir_contents(char *fname, uint16 flags)
{
-@@ -64,7 +67,9 @@ static enum delret delete_dir_contents(char *fname, uint16 flags)
+@@ -63,7 +66,9 @@ static enum delret delete_dir_contents(char *fname, uint16 flags)
save_filters = push_local_filters(fname, dlen);
non_perishable_cnt = 0;
ret = non_perishable_cnt ? DR_NOT_EMPTY : DR_SUCCESS;
if (!dirlist->used)
-@@ -104,7 +109,8 @@ static enum delret delete_dir_contents(char *fname, uint16 flags)
+@@ -103,7 +108,8 @@ static enum delret delete_dir_contents(char *fname, uint16 flags)
if (S_ISDIR(fp->mode)) {
if (delete_dir_contents(fname, flags | DEL_RECURSE) != DR_SUCCESS)
ret = DR_NOT_EMPTY;
if (delete_item(fname, fp->mode, flags) != DR_SUCCESS)
ret = DR_NOT_EMPTY;
}
-@@ -127,6 +133,8 @@ static enum delret delete_dir_contents(char *fname, uint16 flags)
+@@ -126,6 +132,8 @@ static enum delret delete_dir_contents(char *fname, uint16 flags)
*
* Note that fbuf must point to a MAXPATHLEN buffer if the mode indicates it's
* a directory! (The buffer is used for recursion, but returned unchanged.)
*/
enum delret delete_item(char *fbuf, uint16 mode, uint16 flags)
{
+@@ -153,6 +161,9 @@ enum delret delete_item(char *fbuf, uint16 mode, uint16 flags)
+ /* OK: try to delete the directory. */
+ }
+
++ if (flags & DEL_NO_DELETIONS)
++ return DR_SUCCESS;
++
+ if (!(flags & DEL_MAKE_ROOM) && max_delete >= 0 && stats.deleted_files >= max_delete) {
+ skipped_deletes++;
+ return DR_AT_LIMIT;
diff --git a/flist.c b/flist.c
--- a/flist.c
+++ b/flist.c
-@@ -63,6 +63,7 @@ extern int non_perishable_cnt;
+@@ -65,6 +65,7 @@ extern int non_perishable_cnt;
extern int prune_empty_dirs;
extern int copy_links;
extern int copy_unsafe_links;
extern int protocol_version;
extern int sanitize_paths;
extern int munge_symlinks;
-@@ -134,6 +135,8 @@ static int64 tmp_dev, tmp_ino;
+@@ -131,6 +132,8 @@ static int64 tmp_dev = -1, tmp_ino;
#endif
static char tmp_sum[MAX_DIGEST_LEN];
+
static char empty_sum[MAX_DIGEST_LEN];
static int flist_count_offset; /* for --delete --progress */
-
-@@ -301,6 +304,45 @@ static int is_excluded(const char *fname, int is_dir, int filter_level)
- return 0;
+ static int show_filelist_progress;
+@@ -278,6 +281,45 @@ static inline int is_excluded(const char *fname, int is_dir, int filter_level)
+ return name_is_excluded(fname, is_dir ? NAME_IS_DIR : NAME_IS_FILE, filter_level);
}
+static int fattr_compare(struct file_struct **file1, struct file_struct **file2)
+ return len1 < len2 ? -1 : 1;
+
+ if (always_checksum) {
-+ diff = u_memcmp(F_SUM(f1), F_SUM(f2), checksum_len);
++ diff = u_memcmp(F_SUM(f1), F_SUM(f2), flist_csum_len);
+ if (diff)
+ return diff;
+ } else if (f1->modtime != f2->modtime)
static void send_directory(int f, struct file_list *flist,
char *fbuf, int len, int flags);
-@@ -2550,6 +2592,25 @@ struct file_list *recv_file_list(int f)
-
+@@ -2720,6 +2762,23 @@ struct file_list *recv_file_list(int f, int dir_ndx)
+ * for a non-relative transfer in recv_file_entry(). */
flist_sort_and_clean(flist, relative_paths);
+ if (detect_renamed) {
+ int j = flist->used;
+ the_fattr_list.used = j;
+ the_fattr_list.files = new_array(struct file_struct *, j);
-+ if (!the_fattr_list.files)
-+ out_of_memory("recv_file_list");
+ memcpy(the_fattr_list.files, flist->files,
+ j * sizeof (struct file_struct *));
+ qsort(the_fattr_list.files, j,
diff --git a/generator.c b/generator.c
--- a/generator.c
+++ b/generator.c
-@@ -80,6 +80,7 @@ extern char *partial_dir;
- extern int compare_dest;
- extern int copy_dest;
- extern int link_dest;
+@@ -81,6 +81,7 @@ extern int always_checksum;
+ extern int flist_csum_len;
+ extern char *partial_dir;
+ extern int alt_dest_type;
+extern int detect_renamed;
extern int whole_file;
extern int list_only;
extern int read_batch;
-@@ -97,10 +98,12 @@ extern char *tmpdir;
+@@ -99,11 +100,13 @@ extern char *tmpdir;
extern char *basis_dir[MAX_BASIS_DIRS+1];
extern struct file_list *cur_flist, *first_flist, *dir_flist;
extern filter_rule_list filter_list, daemon_filter_list;
+extern struct file_list the_fattr_list;
int maybe_ATTRS_REPORT = 0;
+ int maybe_ATTRS_ACCURATE_TIME = 0;
static dev_t dev_zero;
+static int unexplored_dirs = 1;
static int deldelay_size = 0, deldelay_cnt = 0;
static char *deldelay_buf = NULL;
static int deldelay_fd = -1;
-@@ -180,6 +183,8 @@ static int remember_delete(struct file_struct *file, const char *fname, int flag
- if (!flush_delete_delay())
- return 0;
- }
-+ if (flags & DEL_NO_DELETIONS)
-+ return DR_SUCCESS;
-
- return 1;
- }
-@@ -271,13 +276,18 @@ static void do_delayed_deletions(char *delbuf)
+@@ -268,14 +271,19 @@ static void do_delayed_deletions(char *delbuf)
* all the --delete-WHEN options. Note that the fbuf pointer must point to a
* MAXPATHLEN buffer with the name of the directory in it (the functions we
* call will append names onto the end, but the old dir value will be restored
- * on exit). */
--static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
+-static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t fs_dev)
+ * on exit).
+ *
+ * Note: --detect-rename may use this routine with DEL_NO_DELETIONS set!
+ */
-+static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev,
++static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t fs_dev,
+ int del_flags)
{
static int already_warned = 0;
+ static struct hashtable *dev_tbl;
struct file_list *dirlist;
- char delbuf[MAXPATHLEN];
- int dlen, i;
+ char *p, delbuf[MAXPATHLEN];
+ unsigned remainder;
+ int dlen, i, restore_dot = 0;
- int save_uid_ndx = uid_ndx;
if (!fbuf) {
-@@ -292,17 +302,22 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
+ change_local_filter_dir(NULL, 0, 0);
+@@ -289,17 +297,22 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t fs_dev)
maybe_send_keepalive(time(NULL), MSK_ALLOW_FLUSH);
- if (io_error && !ignore_errors) {
+ if (io_error & IOERR_GENERAL && !ignore_errors) {
- if (already_warned)
+ if (!already_warned) {
+ rprintf(FINFO,
+ unexplored_dirs--;
+
if (one_file_system) {
- if (file->flags & FLAG_TOP_DIR)
- filesystem_dev = *fs_dev;
-@@ -315,6 +330,14 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
+ if (!dev_tbl)
+ dev_tbl = hashtable_create(16, HT_KEY64);
+@@ -315,6 +328,14 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t fs_dev)
dirlist = get_dirlist(fbuf, dlen, 0);
/* If an item in dirlist is not found in flist, delete it
* from the filesystem. */
for (i = dirlist->used; i--; ) {
-@@ -327,6 +350,10 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
+@@ -327,6 +348,10 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t fs_dev)
f_name(fp, NULL));
continue;
}
/* Here we want to match regardless of file type. Replacement
* of a file with one of another type is handled separately by
* a delete_item call with a DEL_MAKE_ROOM flag. */
-@@ -335,14 +362,19 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t *fs_dev)
- if (!(fp->mode & S_IWUSR) && !am_root && (uid_t)F_OWNER(fp) == our_uid)
+@@ -335,14 +360,19 @@ static void delete_in_dir(char *fbuf, struct file_struct *file, dev_t fs_dev)
+ if (!(fp->mode & S_IWUSR) && !am_root && fp->flags & FLAG_OWNED_BY_US)
flags |= DEL_NO_UID_WRITE;
f_name(fp, delbuf);
- if (delete_during == 2) {
+ fbuf[dlen] = '\0';
+
flist_free(dirlist);
+ }
- if (!save_uid_ndx) {
-@@ -380,14 +412,122 @@ static void do_delete_pass(void)
+@@ -378,14 +408,125 @@ static void do_delete_pass(void)
|| !S_ISDIR(st.st_mode))
continue;
-- delete_in_dir(fbuf, file, &st.st_dev);
-+ delete_in_dir(fbuf, file, &st.st_dev, 0);
+- delete_in_dir(fbuf, file, st.st_dev);
++ delete_in_dir(fbuf, file, st.st_dev, 0);
}
-- delete_in_dir(NULL, NULL, &dev_zero);
-+ delete_in_dir(NULL, NULL, &dev_zero, 0);
+- delete_in_dir(NULL, NULL, dev_zero);
++ delete_in_dir(NULL, NULL, dev_zero, 0);
if (INFO_GTE(FLIST, 2) && !am_server)
rprintf(FINFO, " \r");
+ /* We use the FLAG_FILE_SENT flag to indicate when we
+ * have computed the checksum for an entry. */
+ if (!(f->flags & FLAG_FILE_SENT)) {
++ STRUCT_STAT st;
+ if (fmid->modtime == f->modtime
+ && f_name_cmp(fmid, f) == 0)
+ return -1; /* assume we can't help */
-+ file_checksum(fname, F_SUM(f), F_LENGTH(f));
++ st.st_size = F_LENGTH(f);
++ st.st_mtime = f->modtime;
++ file_checksum(fname, &st, F_SUM(f));
+ f->flags |= FLAG_FILE_SENT;
+ }
-+ diff = u_memcmp(F_SUM(fmid), F_SUM(f), checksum_len);
++ diff = u_memcmp(F_SUM(fmid), F_SUM(f), flist_csum_len);
+ if (diff) {
+ if (diff < 0)
+ low = mid + 1;
+ rprintf(FINFO, "found renamed: %s => %s\n", fname, fn);
+}
+
- int unchanged_attrs(const char *fname, struct file_struct *file, stat_x *sxp)
+ static inline int mtime_differs(STRUCT_STAT *stp, struct file_struct *file)
{
- #ifndef CAN_SET_SYMLINK_TIMES
-@@ -1048,6 +1188,7 @@ static void list_file_entry(struct file_struct *f)
+ #ifdef ST_MTIME_NSEC
+@@ -1179,6 +1320,7 @@ static void list_file_entry(struct file_struct *f)
}
}
static int phase = 0;
static int dflt_perms;
-@@ -1327,9 +1468,12 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
+@@ -1315,7 +1457,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
+ && do_stat(dn, &sx.st) < 0) {
+ if (dry_run)
+ goto parent_is_dry_missing;
+- if (make_path(fname, MKP_DROP_NAME | MKP_SKIP_SLASH) < 0) {
++ if (make_path(fname, ACCESSPERMS, MKP_DROP_NAME | MKP_SKIP_SLASH) < 0) {
+ rsyserr(FERROR_XFER, errno,
+ "recv_generator: mkdir %s failed",
+ full_fname(dn));
+@@ -1468,7 +1610,7 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
+ }
+ if (real_ret != 0 && do_mkdir(fname,file->mode|added_perms) < 0 && errno != EEXIST) {
+ if (!relative_paths || errno != ENOENT
+- || make_path(fname, MKP_DROP_NAME | MKP_SKIP_SLASH) < 0
++ || make_path(fname, ACCESSPERMS, MKP_DROP_NAME | MKP_SKIP_SLASH) < 0
+ || (do_mkdir(fname, file->mode|added_perms) < 0 && errno != EEXIST)) {
+ rsyserr(FERROR_XFER, errno,
+ "recv_generator: mkdir %s failed",
+@@ -1516,9 +1658,12 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
}
else if (delete_during && f_out != -1 && !phase
&& !(file->flags & FLAG_MISSING_DIR)) {
- if (file->flags & FLAG_CONTENT_DIR)
-- delete_in_dir(fname, file, &real_sx.st.st_dev);
+- delete_in_dir(fname, file, real_sx.st.st_dev);
- else
+ if (file->flags & FLAG_CONTENT_DIR) {
+ if (detect_renamed && real_ret != 0)
+ unexplored_dirs++;
-+ delete_in_dir(fname, file, &real_sx.st.st_dev,
++ delete_in_dir(fname, file, real_sx.st.st_dev,
+ delete_during < 0 ? DEL_NO_DELETIONS : 0);
+ } else
change_local_filter_dir(fname, strlen(fname), F_DEPTH(file));
}
- goto cleanup;
-@@ -1590,8 +1734,14 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
+ prior_dir_file = file;
+@@ -1786,8 +1931,14 @@ static void recv_generator(char *fname, struct file_struct *file, int ndx,
goto cleanup;
}
#endif
rsyserr(FERROR_XFER, stat_errno, "recv_generator: failed to stat %s",
full_fname(fname));
goto cleanup;
-@@ -2058,6 +2208,12 @@ void generate_files(int f_out, const char *local_name)
+@@ -2253,6 +2404,12 @@ void generate_files(int f_out, const char *local_name)
if (DEBUG_GTE(GENR, 1))
- rprintf(FINFO, "generator starting pid=%ld\n", (long)getpid());
+ rprintf(FINFO, "generator starting pid=%d\n", (int)getpid());
+ if (detect_renamed) {
+ delayed_bits = bitbag_create(cur_flist->used);
if (delete_before && !solo_file && cur_flist->used > 0)
do_delete_pass();
if (delete_during == 2) {
-@@ -2068,7 +2224,7 @@ void generate_files(int f_out, const char *local_name)
+@@ -2261,7 +2418,7 @@ void generate_files(int f_out, const char *local_name)
}
info_levels[INFO_FLIST] = info_levels[INFO_PROGRESS] = 0;
whole_file = 0;
if (DEBUG_GTE(FLIST, 1)) {
rprintf(FINFO, "delta-transmission %s\n",
-@@ -2104,7 +2260,7 @@ void generate_files(int f_out, const char *local_name)
+@@ -2297,7 +2454,7 @@ void generate_files(int f_out, const char *local_name)
dirdev = MAKEDEV(DEV_MAJOR(devp), DEV_MINOR(devp));
} else
dirdev = MAKEDEV(0, 0);
-- delete_in_dir(fbuf, fp, &dirdev);
-+ delete_in_dir(fbuf, fp, &dirdev, 0);
+- delete_in_dir(fbuf, fp, dirdev);
++ delete_in_dir(fbuf, fp, dirdev, 0);
} else
change_local_filter_dir(fbuf, strlen(fbuf), F_DEPTH(fp));
}
-@@ -2151,7 +2307,21 @@ void generate_files(int f_out, const char *local_name)
+@@ -2344,7 +2501,21 @@ void generate_files(int f_out, const char *local_name)
} while ((cur_flist = cur_flist->next) != NULL);
if (delete_during)
-- delete_in_dir(NULL, NULL, &dev_zero);
-+ delete_in_dir(NULL, NULL, &dev_zero, 0);
+- delete_in_dir(NULL, NULL, dev_zero);
++ delete_in_dir(NULL, NULL, dev_zero, 0);
+ if (detect_renamed) {
+ if (delete_during < 0)
+ delete_during = 0;
phase++;
if (DEBUG_GTE(GENR, 1))
rprintf(FINFO, "generate_files phase=%d\n", phase);
+diff --git a/main.c b/main.c
+--- a/main.c
++++ b/main.c
+@@ -717,7 +717,7 @@ static char *get_local_name(struct file_list *flist, char *dest_path)
+
+ if (mkpath_dest_arg && statret < 0 && (cp || file_total > 1)) {
+ int save_errno = errno;
+- int ret = make_path(dest_path, file_total > 1 && !trailing_slash ? 0 : MKP_DROP_NAME);
++ int ret = make_path(dest_path, ACCESSPERMS, file_total > 1 && !trailing_slash ? 0 : MKP_DROP_NAME);
+ if (ret < 0)
+ goto mkdir_error;
+ if (ret && (INFO_GTE(NAME, 1) || stdout_format_has_i)) {
diff --git a/options.c b/options.c
--- a/options.c
+++ b/options.c
-@@ -80,6 +80,7 @@ int am_server = 0;
+@@ -88,6 +88,7 @@ int am_server = 0;
int am_sender = 0;
int am_starting_up = 1;
int relative_paths = -1;
int implied_dirs = 1;
int missing_args = 0; /* 0 = FERROR_XFER, 1 = ignore, 2 = delete */
int numeric_ids = 0;
-@@ -743,6 +744,7 @@ void usage(enum logcode F)
- rprintf(F," --modify-window=NUM compare mod-times with reduced accuracy\n");
- rprintf(F," -T, --temp-dir=DIR create temporary files in directory DIR\n");
- rprintf(F," -y, --fuzzy find similar file for basis if no dest file\n");
-+ rprintf(F," --detect-renamed try to find renamed files to speed up the transfer\n");
- rprintf(F," --compare-dest=DIR also compare destination files relative to DIR\n");
- rprintf(F," --copy-dest=DIR ... and include copies of unchanged files\n");
- rprintf(F," --link-dest=DIR hardlink to files in DIR when unchanged\n");
-@@ -938,6 +940,7 @@ static struct poptOption long_options[] = {
+@@ -739,6 +740,7 @@ static struct poptOption long_options[] = {
{"compare-dest", 0, POPT_ARG_STRING, 0, OPT_COMPARE_DEST, 0, 0 },
{"copy-dest", 0, POPT_ARG_STRING, 0, OPT_COPY_DEST, 0, 0 },
{"link-dest", 0, POPT_ARG_STRING, 0, OPT_LINK_DEST, 0, 0 },
+ {"detect-renamed", 0, POPT_ARG_NONE, &detect_renamed, 0, 0, 0 },
- {"fuzzy", 'y', POPT_ARG_VAL, &fuzzy_basis, 1, 0, 0 },
+ {"fuzzy", 'y', POPT_ARG_NONE, 0, 'y', 0, 0 },
{"no-fuzzy", 0, POPT_ARG_VAL, &fuzzy_basis, 0, 0, 0 },
{"no-y", 0, POPT_ARG_VAL, &fuzzy_basis, 0, 0, 0 },
-@@ -2157,7 +2160,7 @@ int parse_arguments(int *argc_p, const char ***argv_p)
+@@ -2375,7 +2377,7 @@ int parse_arguments(int *argc_p, const char ***argv_p)
inplace = 1;
}
partial_dir = tmp_partialdir;
if (inplace) {
-@@ -2166,6 +2169,7 @@ int parse_arguments(int *argc_p, const char ***argv_p)
+@@ -2384,6 +2386,7 @@ int parse_arguments(int *argc_p, const char ***argv_p)
snprintf(err_buf, sizeof err_buf,
"--%s cannot be used with --%s\n",
append_mode ? "append" : "inplace",
delay_updates ? "delay-updates" : "partial-dir");
return 0;
}
-@@ -2528,6 +2532,8 @@ void server_options(char **args, int *argc_p)
+@@ -2790,6 +2793,8 @@ void server_options(char **args, int *argc_p)
args[ac++] = "--super";
if (size_only)
args[ac++] = "--size-only";
if (do_stats)
args[ac++] = "--stats";
} else {
+diff --git a/receiver.c b/receiver.c
+--- a/receiver.c
++++ b/receiver.c
+@@ -218,7 +218,7 @@ int open_tmpfile(char *fnametmp, const char *fname, struct file_struct *file)
+ * information should have been previously transferred, but that may
+ * not be the case with -R */
+ if (fd == -1 && relative_paths && errno == ENOENT
+- && make_path(fnametmp, MKP_SKIP_SLASH | MKP_DROP_NAME) == 0) {
++ && make_path(fnametmp, ACCESSPERMS, MKP_SKIP_SLASH | MKP_DROP_NAME) == 0) {
+ /* Get back to name with XXXXXX in it. */
+ get_tmpname(fnametmp, fname, False);
+ fd = do_mkstemp(fnametmp, (file->mode|added_perms) & INITACCESSPERMS);
+diff --git a/rsync.1.md b/rsync.1.md
+--- a/rsync.1.md
++++ b/rsync.1.md
+@@ -444,6 +444,7 @@ has its own detailed description later in this manpage.
+ --modify-window=NUM, -@ set the accuracy for mod-time comparisons
+ --temp-dir=DIR, -T create temporary files in directory DIR
+ --fuzzy, -y find similar file for basis if no dest file
++--detect-renamed try to find renamed files to speed the xfer
+ --compare-dest=DIR also compare destination files relative to DIR
+ --copy-dest=DIR ... and include copies of unchanged files
+ --link-dest=DIR hardlink to files in DIR when unchanged
+@@ -2499,6 +2500,22 @@ option name from the pathname using a space if you want the shell to expand it.
+ potential fuzzy-match files, so either use [`--delete-after`](#opt) or
+ specify some filename exclusions if you need to prevent this.
+
++0. `--detect-renamed`
++
++ With this option, for each new source file (call it `src/S`), rsync looks
++ for a file `dest/D` anywhere in the destination that passes the quick check
++ with `src/S`. If such a `dest/D` is found, rsync uses it as an alternate
++ basis for transferring `S`. The idea is that if `src/S` was renamed from
++ `src/D` (as opposed to `src/S` passing the quick check with `dest/D` by
++ coincidence), the delta-transfer algorithm will find that all the data
++ matches between `src/S` and `dest/D`, and the transfer will be really fast.
++
++ By default, alternate-basis files are hard-linked into a directory named
++ ".~tmp~" in each file's destination directory, but if you've specified the
++ [`--partial-dir`](#opt) option, that directory will be used instead. These
++ otential alternate-basis files will be removed as the transfer progresses.
++ This option conflicts with [`--inplace`](#opt) and [`--append`](#opt).
++
+ 0. `--compare-dest=DIR`
+
+ This option instructs rsync to use _DIR_ on the destination machine as an
diff --git a/rsync.h b/rsync.h
--- a/rsync.h
+++ b/rsync.h
-@@ -246,7 +246,7 @@ enum msgcode {
+@@ -286,7 +286,7 @@ enum filetype {
#define NDX_DEL_STATS -3
#define NDX_FLIST_OFFSET -101
#define DEL_NO_UID_WRITE (1<<0) /* file/dir has our uid w/o write perm */
#define DEL_RECURSE (1<<1) /* if dir, delete all contents */
#define DEL_DIR_IS_EMPTY (1<<2) /* internal delete_FUNCTIONS use only */
-@@ -256,6 +256,7 @@ enum msgcode {
+@@ -296,6 +296,7 @@ enum filetype {
#define DEL_FOR_DEVICE (1<<6) /* making room for a replacement device */
#define DEL_FOR_SPECIAL (1<<7) /* making room for a replacement special */
#define DEL_FOR_BACKUP (1<<8) /* the delete is for a backup operation */
#define DEL_MAKE_ROOM (DEL_FOR_FILE|DEL_FOR_DIR|DEL_FOR_SYMLINK|DEL_FOR_DEVICE|DEL_FOR_SPECIAL)
-diff --git a/rsync.yo b/rsync.yo
---- a/rsync.yo
-+++ b/rsync.yo
-@@ -397,6 +397,7 @@ to the detailed description below for a complete description. verb(
- --modify-window=NUM compare mod-times with reduced accuracy
- -T, --temp-dir=DIR create temporary files in directory DIR
- -y, --fuzzy find similar file for basis if no dest file
-+ --detect-renamed try to find renamed files to speed the xfer
- --compare-dest=DIR also compare received files relative to DIR
- --copy-dest=DIR ... and include copies of unchanged files
- --link-dest=DIR hardlink to files in DIR when unchanged
-@@ -1670,6 +1671,21 @@ Note that the use of the bf(--delete) option might get rid of any potential
- fuzzy-match files, so either use bf(--delete-after) or specify some
- filename exclusions if you need to prevent this.
-
-+dit(bf(--detect-renamed)) With this option, for each new source file
-+(call it em(src/S)), rsync looks for a file em(dest/D) anywhere in the
-+destination that passes the quick check with em(src/S). If such a em(dest/D)
-+is found, rsync uses it as an alternate basis for transferring em(S). The
-+idea is that if em(src/S) was renamed from em(src/D) (as opposed to em(src/S)
-+passing the quick check with em(dest/D) by coincidence), the delta-transfer
-+algorithm will find that all the data matches between em(src/S) and em(dest/D),
-+and the transfer will be really fast.
-+
-+By default, alternate-basis files are hard-linked into a directory named
-+".~tmp~" in each file's destination directory, but if you've specified
-+the bf(--partial-dir) option, that directory will be used instead. These
-+potential alternate-basis files will be removed as the transfer progresses.
-+This option conflicts with bf(--inplace) and bf(--append).
-+
- dit(bf(--compare-dest=DIR)) This option instructs rsync to use em(DIR) on
- the destination machine as an additional hierarchy to compare destination
- files against doing transfers (if the files are missing in the destination
-diff --git a/util.c b/util.c
---- a/util.c
-+++ b/util.c
-@@ -1076,6 +1076,32 @@ char *normalize_path(char *path, BOOL force_newbuf, unsigned int *len_ptr)
+diff --git a/util1.c b/util1.c
+--- a/util1.c
++++ b/util1.c
+@@ -184,7 +184,7 @@ int set_times(const char *fname, STRUCT_STAT *stp)
+ /* Create any necessary directories in fname. Any missing directories are
+ * created with default permissions. Returns < 0 on error, or the number
+ * of directories created. */
+-int make_path(char *fname, int flags)
++int make_path(char *fname, mode_t mode, int flags)
+ {
+ char *end, *p;
+ int ret = 0;
+@@ -215,7 +215,7 @@ int make_path(char *fname, int flags)
+ else
+ errno = ENOTDIR;
+ }
+- } else if (do_mkdir(fname, ACCESSPERMS) == 0) {
++ } else if (do_mkdir(fname, mode) == 0) {
+ ret++;
+ break;
+ }
+@@ -254,7 +254,7 @@ int make_path(char *fname, int flags)
+ p += strlen(p);
+ if (ret < 0) /* Skip mkdir on error, but keep restoring the path. */
+ continue;
+- if (do_mkdir(fname, ACCESSPERMS) < 0)
++ if (do_mkdir(fname, mode) < 0)
+ ret = -ret - 1;
+ else
+ ret++;
+@@ -1197,6 +1197,32 @@ char *normalize_path(char *path, BOOL force_newbuf, unsigned int *len_ptr)
return path;
}
/**
* Return a quoted string with the full pathname of the indicated filename.
* The string " (in MODNAME)" may also be appended. The returned pointer
+@@ -1290,7 +1316,7 @@ int handle_partial_dir(const char *fname, int create)
+ }
+ statret = -1;
+ }
+- if (statret < 0 && do_mkdir(dir, 0700) < 0) {
++ if (statret < 0 && make_path(dir, 0700, 0) < 0) {
+ *fn = '/';
+ return 0;
+ }
git.samba.org / rsync.git / patches.git / blobdiff