firewire: core: add memo about the caller of show functions for device attributes

[sfrench/cifs-2.6.git] / drivers / firewire / core-device.c

diff --git a/drivers/firewire/core-device.c b/drivers/firewire/core-device.c
index 7d3346b3a2bf320910c72783ab857415d331ed14..e6cdb905eeaca70aec09132606d66996d5b87579 100644 (file)
--- a/drivers/firewire/core-device.c
+++ b/drivers/firewire/core-device.c
@@ -322,7 +322,8 @@ static ssize_t show_immediate(struct device *dev,
        if (value < 0)
                return -ENOENT;
 
-       return snprintf(buf, buf ? PAGE_SIZE : 0, "0x%06x\n", value);
+       // Note that this function is also called by init_fw_attribute_group() with NULL pointer.
+       return buf ? sysfs_emit(buf, "0x%06x\n", value) : 0;
 }
 
 #define IMMEDIATE_ATTR(name, key)                              \
@@ -357,6 +358,7 @@ static ssize_t show_text_leaf(struct device *dev,
                }
        }
 
+       // Note that this function is also called by init_fw_attribute_group() with NULL pointer.
        if (buf) {
                bufsize = PAGE_SIZE - 1;
        } else {
@@ -490,7 +492,7 @@ static ssize_t is_local_show(struct device *dev,
 {
        struct fw_device *device = fw_device(dev);
 
-       return sprintf(buf, "%u\n", device->is_local);
+       return sysfs_emit(buf, "%u\n", device->is_local);
 }
 
 static int units_sprintf(char *buf, const u32 *directory)