Fix --remove-source-files sanity check w/--copy-links the right way.
[rsync.git] / log.c
diff --git a/log.c b/log.c
index adf3a4ad739e65a55f229cd49aedd8e7093d63e8..6143349ce345a62106578a427be52fe009dda8fd 100644 (file)
--- a/log.c
+++ b/log.c
@@ -3,7 +3,7 @@
  *
  * Copyright (C) 1998-2001 Andrew Tridgell <tridge@samba.org>
  * Copyright (C) 2000-2001 Martin Pool <mbp@samba.org>
- * Copyright (C) 2003-2008 Wayne Davison
+ * Copyright (C) 2003-2018 Wayne Davison
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
@@ -20,7 +20,8 @@
  */
 
 #include "rsync.h"
-#include "ifuncs.h"
+#include "itypes.h"
+#include "inums.h"
 
 extern int dry_run;
 extern int am_daemon;
@@ -30,22 +31,23 @@ extern int am_generator;
 extern int local_server;
 extern int quiet;
 extern int module_id;
-extern int msg_fd_out;
-extern int checksum_len;
 extern int allow_8bit_chars;
 extern int protocol_version;
 extern int always_checksum;
 extern int preserve_times;
 extern int msgs2stderr;
-extern int uid_ndx;
-extern int gid_ndx;
+extern int xfersum_type;
+extern int checksum_type;
 extern int stdout_format_has_i;
 extern int stdout_format_has_o_or_i;
 extern int logfile_format_has_i;
 extern int logfile_format_has_o_or_i;
 extern int receiver_symlink_times;
+extern int64 total_data_written;
+extern int64 total_data_read;
 extern mode_t orig_umask;
 extern char *auth_user;
+extern char *checksum_choice;
 extern char *stdout_format;
 extern char *logfile_format;
 extern char *logfile_name;
@@ -56,9 +58,10 @@ extern iconv_t ic_chck;
 extern iconv_t ic_recv;
 #endif
 extern char curr_dir[MAXPATHLEN];
-extern char *module_dir;
+extern char *full_module_path;
 extern unsigned int module_dirlen;
 extern char sender_file_sum[MAX_DIGEST_LEN];
+extern const char undetermined_hostname[];
 
 static int log_initialised;
 static int logfile_was_closed;
@@ -67,6 +70,10 @@ struct stats stats;
 
 int got_xfer_error = 0;
 int output_needs_newline = 0;
+int send_msgs_to_gen = 0;
+
+static int64 initial_data_written;
+static int64 initial_data_read;
 
 struct {
         int code;
@@ -90,13 +97,13 @@ struct {
        { RERR_MALLOC     , "error allocating core memory buffers" },
        { RERR_PARTIAL    , "some files/attrs were not transferred (see previous errors)" },
        { RERR_VANISHED   , "some files vanished before they could be transferred" },
+       { RERR_DEL_LIMIT  , "the --max-delete limit stopped deletions" },
        { RERR_TIMEOUT    , "timeout in data send/receive" },
        { RERR_CONTIMEOUT , "timeout waiting for daemon connection" },
        { RERR_CMD_FAILED , "remote shell failed" },
        { RERR_CMD_KILLED , "remote shell killed" },
        { RERR_CMD_RUN    , "remote command could not be run" },
        { RERR_CMD_NOTFOUND,"remote command not found" },
-       { RERR_DEL_LIMIT  , "the --max-delete limit stopped deletions" },
        { 0, NULL }
 };
 
@@ -118,8 +125,7 @@ static void logit(int priority, const char *buf)
        if (logfile_was_closed)
                logfile_reopen();
        if (logfile_fp) {
-               fprintf(logfile_fp, "%s [%d] %s",
-                       timestring(time(NULL)), (int)getpid(), buf);
+               fprintf(logfile_fp, "%s [%d] %s", timestring(time(NULL)), (int)getpid(), buf);
                fflush(logfile_fp);
        } else {
                syslog(priority, "%s", buf);
@@ -128,21 +134,16 @@ static void logit(int priority, const char *buf)
 
 static void syslog_init()
 {
-       static int been_here = 0;
        int options = LOG_PID;
 
-       if (been_here)
-               return;
-       been_here = 1;
-
 #ifdef LOG_NDELAY
        options |= LOG_NDELAY;
 #endif
 
 #ifdef LOG_DAEMON
-       openlog("rsyncd", options, lp_syslog_facility(module_id));
+       openlog(lp_syslog_tag(module_id), options, lp_syslog_facility(module_id));
 #else
-       openlog("rsyncd", options);
+       openlog(lp_syslog_tag(module_id), options);
 #endif
 
 #ifndef LOG_NDELAY
@@ -162,14 +163,16 @@ static void logfile_open(void)
                rsyserr(FERROR, fopen_errno,
                        "failed to open log-file %s", logfile_name);
                rprintf(FINFO, "Ignoring \"log file\" setting.\n");
+               logfile_name = "";
        }
 }
 
 void log_init(int restart)
 {
        if (log_initialised) {
-               if (!restart)
+               if (!restart) /* Note: a restart only happens with am_daemon */
                        return;
+               assert(logfile_name); /* all am_daemon procs got at least an empty string */
                if (strcmp(logfile_name, lp_log_file(module_id)) != 0) {
                        if (logfile_fp) {
                                fclose(logfile_fp);
@@ -179,7 +182,8 @@ void log_init(int restart)
                        logfile_name = NULL;
                } else if (*logfile_name)
                        return; /* unchanged, non-empty "log file" names */
-               else if (lp_syslog_facility(-1) != lp_syslog_facility(module_id))
+               else if (lp_syslog_facility(-1) != lp_syslog_facility(module_id)
+                     || strcmp(lp_syslog_tag(-1), lp_syslog_tag(module_id)) != 0)
                        closelog();
                else
                        return; /* unchanged syslog settings */
@@ -201,6 +205,7 @@ void log_init(int restart)
                syslog_init();
 }
 
+/* Note that this close & reopen idiom intentionally ignores syslog logging. */
 void logfile_close(void)
 {
        if (logfile_fp) {
@@ -258,10 +263,16 @@ void rwrite(enum logcode code, const char *buf, int len, int is_utf8)
        if (len < 0)
                exit_cleanup(RERR_MESSAGEIO);
 
-       if (msgs2stderr && code != FLOG)
-               goto output_msg;
-
-       if (am_server && msg_fd_out >= 0) {
+       if (msgs2stderr) {
+               if (!am_daemon) {
+                       if (code == FLOG)
+                               return;
+                       goto output_msg;
+               }
+               if (code == FCLIENT)
+                       return;
+               code = FLOG;
+       } else if (send_msgs_to_gen) {
                assert(!is_utf8);
                /* Pass the message to our sibling in native charset. */
                send_msg((enum msgcode)code, buf, len, 0);
@@ -323,13 +334,17 @@ output_msg:
                got_xfer_error = 1;
                /* FALL THROUGH */
        case FERROR:
+       case FERROR_UTF8:
+       case FERROR_SOCKET:
        case FWARNING:
                f = stderr;
                break;
+       case FLOG:
        case FINFO:
        case FCLIENT:
                break;
        default:
+               fprintf(stderr, "Unknown logcode in rwrite(): %d [%s]\n", (int)code, who_am_i());
                exit_cleanup(RERR_MESSAGEIO);
        }
 
@@ -357,7 +372,7 @@ output_msg:
                INIT_XBUF(inbuf, (char*)buf, len, (size_t)-1);
 
                while (inbuf.len) {
-                       iconvbufs(ic, &inbuf, &outbuf, 0);
+                       iconvbufs(ic, &inbuf, &outbuf, inbuf.pos ? 0 : ICB_INIT);
                        ierrno = errno;
                        if (outbuf.len) {
                                filtered_fwrite(f, convbuf, outbuf.len, 0);
@@ -465,10 +480,15 @@ void rflush(enum logcode code)
        fflush(f);
 }
 
+void remember_initial_stats(void)
+{
+       initial_data_read = total_data_read;
+       initial_data_written = total_data_written;
+}
+
 /* A generic logging routine for send/recv, with parameter substitiution. */
 static void log_formatted(enum logcode code, const char *format, const char *op,
-                         struct file_struct *file, const char *fname,
-                         struct stats *initial_stats, int iflags,
+                         struct file_struct *file, const char *fname, int iflags,
                          const char *hlink)
 {
        char buf[MAXPATHLEN+1024], buf2[MAXPATHLEN], fmt[32];
@@ -491,21 +511,36 @@ static void log_formatted(enum logcode code, const char *format, const char *op,
        buf[total] = '\0';
 
        for (p = buf; (p = strchr(p, '%')) != NULL; ) {
+               int humanize = 0;
                s = p++;
                c = fmt + 1;
+               while (*p == '\'') {
+                       humanize++;
+                       p++;
+               }
                if (*p == '-')
                        *c++ = *p++;
                while (isDigit(p) && c - fmt < (int)(sizeof fmt) - 8)
                        *c++ = *p++;
+               while (*p == '\'') {
+                       humanize++;
+                       p++;
+               }
                if (!*p)
                        break;
                *c = '\0';
                n = NULL;
 
+               /* Note for %h and %a: it doesn't matter what fd we pass to
+                * client_{name,addr} because rsync_module will already have
+                * forced the answer to be cached (assuming, of course, for %h
+                * that lp_reverse_lookup(module_id) is true). */
                switch (*p) {
                case 'h':
-                       if (am_daemon)
-                               n = client_name(0);
+                       if (am_daemon) {
+                               n = lp_reverse_lookup(module_id)
+                                 ? client_name(0) : undetermined_hostname;
+                       }
                        break;
                case 'a':
                        if (am_daemon)
@@ -514,7 +549,7 @@ static void log_formatted(enum logcode code, const char *format, const char *op,
                case 'l':
                        strlcat(fmt, "s", sizeof fmt);
                        snprintf(buf2, sizeof buf2, fmt,
-                                comma_num(F_LENGTH(file)));
+                                do_big_num(F_LENGTH(file), humanize, NULL));
                        n = buf2;
                        break;
                case 'U':
@@ -534,9 +569,8 @@ static void log_formatted(enum logcode code, const char *format, const char *op,
                        }
                        break;
                case 'p':
-                       strlcat(fmt, "ld", sizeof fmt);
-                       snprintf(buf2, sizeof buf2, fmt,
-                                (long)getpid());
+                       strlcat(fmt, "d", sizeof fmt);
+                       snprintf(buf2, sizeof buf2, fmt, (int)getpid());
                        n = buf2;
                        break;
                case 'M':
@@ -617,56 +651,39 @@ static void log_formatted(enum logcode code, const char *format, const char *op,
                        n = timestring(time(NULL));
                        break;
                case 'P':
-                       n = module_dir;
+                       n = full_module_path;
                        break;
                case 'u':
                        n = auth_user;
                        break;
                case 'b':
-                       if (am_sender) {
-                               b = stats.total_written -
-                                       initial_stats->total_written;
-                       } else {
-                               b = stats.total_read -
-                                       initial_stats->total_read;
-                       }
-                       strlcat(fmt, "s", sizeof fmt);
-                       snprintf(buf2, sizeof buf2, fmt, comma_num(b));
-                       n = buf2;
-                       break;
                case 'c':
-                       if (!am_sender) {
-                               b = stats.total_written -
-                                       initial_stats->total_written;
-                       } else {
-                               b = stats.total_read -
-                                       initial_stats->total_read;
-                       }
+                       if (!(iflags & ITEM_TRANSFER))
+                               b = 0;
+                       else if ((!!am_sender) ^ (*p == 'c'))
+                               b = total_data_written - initial_data_written;
+                       else
+                               b = total_data_read - initial_data_read;
                        strlcat(fmt, "s", sizeof fmt);
-                       snprintf(buf2, sizeof buf2, fmt, comma_num(b));
+                       snprintf(buf2, sizeof buf2, fmt,
+                                do_big_num(b, humanize, NULL));
                        n = buf2;
                        break;
                case 'C':
-                       if (protocol_version >= 30
-                        && (iflags & ITEM_TRANSFER
-                         || (always_checksum && S_ISREG(file->mode)))) {
-                               int i, x1, x2;
-                               const char *sum = iflags & ITEM_TRANSFER
-                                               ? sender_file_sum : F_SUM(file);
-                               c = buf2 + checksum_len*2;
-                               *c = '\0';
-                               for (i = checksum_len; --i >= 0; ) {
-                                       x1 = CVAL(sum, i);
-                                       x2 = x1 >> 4;
-                                       x1 &= 0xF;
-                                       *--c = x1 <= 9 ? x1 + '0' : x1 + 'a' - 10;
-                                       *--c = x2 <= 9 ? x2 + '0' : x2 + 'a' - 10;
-                               }
-                       } else {
-                               memset(buf2, ' ', checksum_len*2);
-                               buf2[checksum_len*2] = '\0';
+                       n = NULL;
+                       if (S_ISREG(file->mode)) {
+                               if (always_checksum && canonical_checksum(checksum_type))
+                                       n = sum_as_hex(checksum_type, F_SUM(file), 1);
+                               else if (iflags & ITEM_TRANSFER && canonical_checksum(xfersum_type))
+                                       n = sum_as_hex(xfersum_type, sender_file_sum, 0);
+                       }
+                       if (!n) {
+                               int sum_len = csum_len_for_type(always_checksum ? checksum_type : xfersum_type,
+                                                               always_checksum);
+                               memset(buf2, ' ', sum_len*2);
+                               buf2[sum_len*2] = '\0';
+                               n = buf2;
                        }
-                       n = buf2;
                        break;
                case 'i':
                        if (iflags & ITEM_DELETED) {
@@ -766,10 +783,12 @@ int log_format_has(const char *format, char esc)
                return 0;
 
        for (p = format; (p = strchr(p, '%')) != NULL; ) {
-               if (*++p == '-')
+               for (p++; *p == '\''; p++) {} /*SHARED ITERATOR*/
+               if (*p == '-')
                        p++;
                while (isDigit(p))
                        p++;
+               while (*p == '\'') p++;
                if (!*p)
                        break;
                if (*p == esc)
@@ -781,19 +800,14 @@ int log_format_has(const char *format, char esc)
 /* Log the transfer of a file.  If the code is FCLIENT, the output just goes
  * to stdout.  If it is FLOG, it just goes to the log file.  Otherwise we
  * output to both. */
-void log_item(enum logcode code, struct file_struct *file,
-             struct stats *initial_stats, int iflags, const char *hlink)
+void log_item(enum logcode code, struct file_struct *file, int iflags, const char *hlink)
 {
        const char *s_or_r = am_sender ? "send" : "recv";
 
-       if (code != FLOG && stdout_format && !am_server) {
-               log_formatted(FCLIENT, stdout_format, s_or_r,
-                             file, NULL, initial_stats, iflags, hlink);
-       }
-       if (code != FCLIENT && logfile_format && *logfile_format) {
-               log_formatted(FLOG, logfile_format, s_or_r,
-                             file, NULL, initial_stats, iflags, hlink);
-       }
+       if (code != FLOG && stdout_format && !am_server)
+               log_formatted(FCLIENT, stdout_format, s_or_r, file, NULL, iflags, hlink);
+       if (code != FCLIENT && logfile_format && *logfile_format)
+               log_formatted(FLOG, logfile_format, s_or_r, file, NULL, iflags, hlink);
 }
 
 void maybe_log_item(struct file_struct *file, int iflags, int itemizing,
@@ -806,11 +820,11 @@ void maybe_log_item(struct file_struct *file, int iflags, int itemizing,
        if (am_server) {
                if (logfile_name && !dry_run && see_item
                 && (significant_flags || logfile_format_has_i))
-                       log_item(FLOG, file, &stats, iflags, buf);
+                       log_item(FLOG, file, iflags, buf);
        } else if (see_item || local_change || *buf
            || (S_ISDIR(file->mode) && significant_flags)) {
                enum logcode code = significant_flags || logfile_format_has_i ? FINFO : FCLIENT;
-               log_item(code, file, &stats, iflags, buf);
+               log_item(code, file, iflags, buf);
        }
 }
 
@@ -819,29 +833,28 @@ void log_delete(const char *fname, int mode)
        static struct {
                union file_extras ex[4]; /* just in case... */
                struct file_struct file;
-       } x;
+       } x; /* Zero-initialized due to static declaration. */
        int len = strlen(fname);
        const char *fmt;
 
        x.file.mode = mode;
 
-       if (!INFO_GTE(DEL, 1) && !stdout_format)
-               ;
-       else if (am_server && protocol_version >= 29 && len < MAXPATHLEN) {
+       if (am_server && protocol_version >= 29 && len < MAXPATHLEN) {
                if (S_ISDIR(mode))
                        len++; /* directories include trailing null */
                send_msg(MSG_DELETED, fname, len, am_generator);
-       } else {
+       } else if (!INFO_GTE(DEL, 1) && !stdout_format)
+               ;
+       else {
                fmt = stdout_format_has_o_or_i ? stdout_format : "deleting %n";
-               log_formatted(FCLIENT, fmt, "del.", &x.file, fname, &stats,
-                             ITEM_DELETED, NULL);
+               log_formatted(FCLIENT, fmt, "del.", &x.file, fname, ITEM_DELETED, NULL);
        }
 
        if (!logfile_name || dry_run || !logfile_format)
                return;
 
        fmt = logfile_format_has_o_or_i ? logfile_format : "deleting %n";
-       log_formatted(FLOG, fmt, "del.", &x.file, fname, &stats, ITEM_DELETED, NULL);
+       log_formatted(FLOG, fmt, "del.", &x.file, fname, ITEM_DELETED, NULL);
 }
 
 /*
@@ -854,9 +867,9 @@ void log_exit(int code, const char *file, int line)
 {
        if (code == 0) {
                rprintf(FLOG,"sent %s bytes  received %s bytes  total size %s\n",
-                       comma_num(stats.total_written),
-                       comma_num(stats.total_read),
-                       comma_num(stats.total_size));
+                       big_num(stats.total_written),
+                       big_num(stats.total_read),
+                       big_num(stats.total_size));
        } else if (am_server != 2) {
                const char *name;