Fix signing bug found by Volker. That one was *subtle*.
[samba.git] / source / libsmb / clitrans.c
index e6771ac68857a877e66293ea570a2002ac151c82..f43a2aa0284a6c5ccdf2d0444f369eafc45419a7 100644 (file)
@@ -18,8 +18,6 @@
    Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
 */
 
-#define NO_SYSLOG
-
 #include "includes.h"
 
 
@@ -50,6 +48,12 @@ BOOL cli_send_trans(struct cli_state *cli, int trans,
        SCVAL(cli->outbuf,smb_com,trans);
        SSVAL(cli->outbuf,smb_tid, cli->cnum);
        cli_setup_packet(cli);
+
+       /*
+        * Save the mid we're using. We need this for finding
+        * signing replies.
+        */
+
        mid = cli->mid;
 
        if (pipe_name) {
@@ -87,16 +91,13 @@ BOOL cli_send_trans(struct cli_state *cli, int trans,
 
        show_msg(cli->outbuf);
 
-       cli_signing_trans_start(cli);
        if (!cli_send_smb(cli)) {
-               cli_signing_trans_stop(cli);
                return False;
        }
 
        if (this_ldata < ldata || this_lparam < lparam) {
                /* receive interim response */
                if (!cli_receive_smb(cli) || cli_is_error(cli)) {
-                       cli_signing_trans_stop(cli);
                        return(False);
                }
 
@@ -130,15 +131,19 @@ BOOL cli_send_trans(struct cli_state *cli, int trans,
                                memcpy(outdata,data+tot_data,this_ldata);
                        cli_setup_bcc(cli, outdata+this_ldata);
                        
-                       /* Ensure this packet has the same MID as
-                        * the primary. Important in signing. JRA. */
-                       cli->mid = mid;
+                       /*
+                        * Save the mid we're using. We need this for finding
+                        * signing replies.
+                        */
+                       mid = cli->mid;
 
                        show_msg(cli->outbuf);
                        if (!cli_send_smb(cli)) {
-                               cli_signing_trans_stop(cli);
                                return False;
                        }
+
+                       /* Ensure we use the same mid for the secondaries. */
+                       cli->mid = mid;
                        
                        tot_data += this_ldata;
                        tot_param += this_lparam;
@@ -160,13 +165,11 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
        unsigned int total_param=0;
        unsigned int this_data,this_param;
        NTSTATUS status;
-       char *tdata;
-       char *tparam;
+       BOOL ret = False;
 
        *data_len = *param_len = 0;
 
        if (!cli_receive_smb(cli)) {
-               cli_signing_trans_stop(cli);
                return False;
        }
 
@@ -177,20 +180,21 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                DEBUG(0,("Expected %s response, got command 0x%02x\n",
                         trans==SMBtrans?"SMBtrans":"SMBtrans2", 
                         CVAL(cli->inbuf,smb_com)));
-               cli_signing_trans_stop(cli);
-               return(False);
+               return False;
        }
 
        /*
         * An NT RPC pipe call can return ERRDOS, ERRmoredata
         * to a trans call. This is not an error and should not
-        * be treated as such.
+        * be treated as such. Note that STATUS_NO_MORE_FILES is
+        * returned when a trans2 findfirst/next finishes.
         */
        status = cli_nt_error(cli);
        
-       if (NT_STATUS_IS_ERR(status)) {
-               cli_signing_trans_stop(cli);
-               return False;
+       if (NT_STATUS_IS_ERR(status) ||
+            NT_STATUS_EQUAL(status,STATUS_NO_MORE_FILES) ||
+            NT_STATUS_EQUAL(status,STATUS_INACCESSIBLE_SYSTEM_SHORTCUT)) {
+               goto out;
        }
 
        /* parse out the lengths */
@@ -199,25 +203,19 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
 
        /* allocate it */
        if (total_data!=0) {
-               tdata = Realloc(*data,total_data);
-               if (!tdata) {
+               *data = (char *)SMB_REALLOC(*data,total_data);
+               if (!(*data)) {
                        DEBUG(0,("cli_receive_trans: failed to enlarge data buffer\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
-               else
-                       *data = tdata;
        }
 
        if (total_param!=0) {
-               tparam = Realloc(*param,total_param);
-               if (!tparam) {
+               *param = (char *)SMB_REALLOC(*param,total_param);
+               if (!(*param)) {
                        DEBUG(0,("cli_receive_trans: failed to enlarge param buffer\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
-               else
-                       *param = tparam;
        }
 
        for (;;)  {
@@ -227,8 +225,7 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                if (this_data + *data_len > total_data ||
                    this_param + *param_len > total_param) {
                        DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                if (this_data + *data_len < this_data ||
@@ -236,8 +233,7 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                                this_param + *param_len < this_param ||
                                this_param + *param_len < *param_len) {
                        DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                if (this_data) {
@@ -249,16 +245,14 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                                        data_offset_out + this_data < data_offset_out ||
                                        data_offset_out + this_data < this_data) {
                                DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
                        if (data_offset_in > cli->bufsize ||
                                        data_offset_in + this_data >  cli->bufsize ||
                                        data_offset_in + this_data < data_offset_in ||
                                        data_offset_in + this_data < this_data) {
                                DEBUG(1,("Data overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
 
                        memcpy(*data + data_offset_out, smb_base(cli->inbuf) + data_offset_in, this_data);
@@ -272,16 +266,14 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                                        param_offset_out + this_param < param_offset_out ||
                                        param_offset_out + this_param < this_param) {
                                DEBUG(1,("Param overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
                        if (param_offset_in > cli->bufsize ||
                                        param_offset_in + this_param >  cli->bufsize ||
                                        param_offset_in + this_param < param_offset_in ||
                                        param_offset_in + this_param < this_param) {
                                DEBUG(1,("Param overflow in cli_receive_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
 
                        memcpy(*param + param_offset_out, smb_base(cli->inbuf) + param_offset_in, this_param);
@@ -289,12 +281,13 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                *data_len += this_data;
                *param_len += this_param;
 
-               if (total_data <= *data_len && total_param <= *param_len)
+               if (total_data <= *data_len && total_param <= *param_len) {
+                       ret = True;
                        break;
+               }
                
                if (!cli_receive_smb(cli)) {
-                       cli_signing_trans_stop(cli);
-                       return False;   
+                       goto out;
                }
 
                show_msg(cli->inbuf);
@@ -304,12 +297,10 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                        DEBUG(0,("Expected %s response, got command 0x%02x\n",
                                 trans==SMBtrans?"SMBtrans":"SMBtrans2", 
                                 CVAL(cli->inbuf,smb_com)));
-                       cli_signing_trans_stop(cli);
-                       return(False);
+                       goto out;
                }
                if (NT_STATUS_IS_ERR(cli_nt_error(cli))) {
-                       cli_signing_trans_stop(cli);
-                       return(False);
+                       goto out;
                }
 
                /* parse out the total lengths again - they can shrink! */
@@ -318,13 +309,15 @@ BOOL cli_receive_trans(struct cli_state *cli,int trans,
                if (SVAL(cli->inbuf,smb_tprcnt) < total_param)
                        total_param = SVAL(cli->inbuf,smb_tprcnt);
                
-               if (total_data <= *data_len && total_param <= *param_len)
+               if (total_data <= *data_len && total_param <= *param_len) {
+                       ret = True;
                        break;
-               
+               }
        }
-       
-       cli_signing_trans_stop(cli);
-       return(True);
+
+  out:
+
+       return ret;
 }
 
 /****************************************************************************
@@ -352,6 +345,12 @@ BOOL cli_send_nt_trans(struct cli_state *cli,
        SCVAL(cli->outbuf,smb_com,SMBnttrans);
        SSVAL(cli->outbuf,smb_tid, cli->cnum);
        cli_setup_packet(cli);
+
+       /*
+        * Save the mid we're using. We need this for finding
+        * signing replies.
+        */
+
        mid = cli->mid;
 
        outparam = smb_buf(cli->outbuf)+3;
@@ -381,16 +380,13 @@ BOOL cli_send_nt_trans(struct cli_state *cli,
        cli_setup_bcc(cli, outdata+this_ldata);
 
        show_msg(cli->outbuf);
-       cli_signing_trans_start(cli);
        if (!cli_send_smb(cli)) {
-               cli_signing_trans_stop(cli);
                return False;
        }       
 
        if (this_ldata < ldata || this_lparam < lparam) {
                /* receive interim response */
                if (!cli_receive_smb(cli) || cli_is_error(cli)) {
-                       cli_signing_trans_stop(cli);
                        return(False);
                }
 
@@ -423,17 +419,21 @@ BOOL cli_send_nt_trans(struct cli_state *cli,
                                memcpy(outdata,data+tot_data,this_ldata);
                        cli_setup_bcc(cli, outdata+this_ldata);
                        
-                       /* Ensure this packet has the same MID as
-                        * the primary. Important in signing. JRA. */
-                       cli->mid = mid;
+                       /*
+                        * Save the mid we're using. We need this for finding
+                        * signing replies.
+                        */
+                       mid = cli->mid;
 
                        show_msg(cli->outbuf);
 
                        if (!cli_send_smb(cli)) {
-                               cli_signing_trans_stop(cli);
                                return False;
                        }
                        
+                       /* Ensure we use the same mid for the secondaries. */
+                       cli->mid = mid;
+                       
                        tot_data += this_ldata;
                        tot_param += this_lparam;
                }
@@ -443,8 +443,8 @@ BOOL cli_send_nt_trans(struct cli_state *cli,
 }
 
 /****************************************************************************
-  receive a SMB nttrans response allocating the necessary memory
-  ****************************************************************************/
+ Receive a SMB nttrans response allocating the necessary memory.
+****************************************************************************/
 
 BOOL cli_receive_nt_trans(struct cli_state *cli,
                          char **param, unsigned int *param_len,
@@ -455,13 +455,11 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
        unsigned int this_data,this_param;
        uint8 eclass;
        uint32 ecode;
-       char *tdata;
-       char *tparam;
+       BOOL ret = False;
 
        *data_len = *param_len = 0;
 
        if (!cli_receive_smb(cli)) {
-               cli_signing_trans_stop(cli);
                return False;
        }
 
@@ -471,7 +469,6 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
        if (CVAL(cli->inbuf,smb_com) != SMBnttrans) {
                DEBUG(0,("Expected SMBnttrans response, got command 0x%02x\n",
                         CVAL(cli->inbuf,smb_com)));
-               cli_signing_trans_stop(cli);
                return(False);
        }
 
@@ -482,9 +479,18 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
         */
        if (cli_is_dos_error(cli)) {
                 cli_dos_error(cli, &eclass, &ecode);
-               if (cli->nt_pipe_fnum == 0 || !(eclass == ERRDOS && ecode == ERRmoredata)) {
-                       cli_signing_trans_stop(cli);
-                       return(False);
+               if (!(eclass == ERRDOS && ecode == ERRmoredata)) {
+                       goto out;
+               }
+       }
+
+       /*
+        * Likewise for NT_STATUS_BUFFER_TOO_SMALL
+        */
+       if (cli_is_nt_error(cli)) {
+               if (!NT_STATUS_EQUAL(cli_nt_error(cli),
+                                    NT_STATUS_BUFFER_TOO_SMALL)) {
+                       goto out;
                }
        }
 
@@ -494,24 +500,18 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
 
        /* allocate it */
        if (total_data) {
-               tdata = Realloc(*data,total_data);
-               if (!tdata) {
+               *data = (char *)SMB_REALLOC(*data,total_data);
+               if (!(*data)) {
                        DEBUG(0,("cli_receive_nt_trans: failed to enlarge data buffer to %d\n",total_data));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               } else {
-                       *data = tdata;
+                       goto out;
                }
        }
 
        if (total_param) {
-               tparam = Realloc(*param,total_param);
-               if (!tparam) {
+               *param = (char *)SMB_REALLOC(*param,total_param);
+               if (!(*param)) {
                        DEBUG(0,("cli_receive_nt_trans: failed to enlarge param buffer to %d\n", total_param));
-                       cli_signing_trans_stop(cli);
-                       return False;
-               } else {
-                       *param = tparam;
+                       goto out;
                }
        }
 
@@ -522,8 +522,7 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                if (this_data + *data_len > total_data ||
                    this_param + *param_len > total_param) {
                        DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                if (this_data + *data_len < this_data ||
@@ -531,8 +530,7 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                                this_param + *param_len < this_param ||
                                this_param + *param_len < *param_len) {
                        DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                if (this_data) {
@@ -544,16 +542,14 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                                        data_offset_out + this_data < data_offset_out ||
                                        data_offset_out + this_data < this_data) {
                                DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
                        if (data_offset_in > cli->bufsize ||
                                        data_offset_in + this_data >  cli->bufsize ||
                                        data_offset_in + this_data < data_offset_in ||
                                        data_offset_in + this_data < this_data) {
                                DEBUG(1,("Data overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
 
                        memcpy(*data + data_offset_out, smb_base(cli->inbuf) + data_offset_in, this_data);
@@ -568,16 +564,14 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                                        param_offset_out + this_param < param_offset_out ||
                                        param_offset_out + this_param < this_param) {
                                DEBUG(1,("Param overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
                        if (param_offset_in > cli->bufsize ||
                                        param_offset_in + this_param >  cli->bufsize ||
                                        param_offset_in + this_param < param_offset_in ||
                                        param_offset_in + this_param < this_param) {
                                DEBUG(1,("Param overflow in cli_receive_nt_trans\n"));
-                               cli_signing_trans_stop(cli);
-                               return False;
+                               goto out;
                        }
 
                        memcpy(*param + param_offset_out, smb_base(cli->inbuf) + param_offset_in, this_param);
@@ -586,12 +580,13 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                *data_len += this_data;
                *param_len += this_param;
 
-               if (total_data <= *data_len && total_param <= *param_len)
+               if (total_data <= *data_len && total_param <= *param_len) {
+                       ret = True;
                        break;
+               }
                
                if (!cli_receive_smb(cli)) {
-                       cli_signing_trans_stop(cli);
-                       return False;
+                       goto out;
                }
 
                show_msg(cli->inbuf);
@@ -600,26 +595,37 @@ BOOL cli_receive_nt_trans(struct cli_state *cli,
                if (CVAL(cli->inbuf,smb_com) != SMBnttrans) {
                        DEBUG(0,("Expected SMBnttrans response, got command 0x%02x\n",
                                 CVAL(cli->inbuf,smb_com)));
-                       cli_signing_trans_stop(cli);
-                       return(False);
+                       goto out;
                }
                if (cli_is_dos_error(cli)) {
                         cli_dos_error(cli, &eclass, &ecode);
-                       if(cli->nt_pipe_fnum == 0 || !(eclass == ERRDOS && ecode == ERRmoredata)) {
-                               cli_signing_trans_stop(cli);
-                               return(False);
+                       if(!(eclass == ERRDOS && ecode == ERRmoredata)) {
+                               goto out;
+                       }
+               }
+               /*
+                * Likewise for NT_STATUS_BUFFER_TOO_SMALL
+                */
+               if (cli_is_nt_error(cli)) {
+                       if (!NT_STATUS_EQUAL(cli_nt_error(cli),
+                                            NT_STATUS_BUFFER_TOO_SMALL)) {
+                               goto out;
                        }
                }
+
                /* parse out the total lengths again - they can shrink! */
                if (SVAL(cli->inbuf,smb_ntr_TotalDataCount) < total_data)
                        total_data = SVAL(cli->inbuf,smb_ntr_TotalDataCount);
                if (SVAL(cli->inbuf,smb_ntr_TotalParameterCount) < total_param)
                        total_param = SVAL(cli->inbuf,smb_ntr_TotalParameterCount);
                
-               if (total_data <= *data_len && total_param <= *param_len)
+               if (total_data <= *data_len && total_param <= *param_len) {
+                       ret = True;
                        break;
+               }
        }
-       
-       cli_signing_trans_stop(cli);
-       return(True);
+
+  out:
+
+       return ret;
 }