Fix denial of service - memory corruption.
[samba.git] / source3 / lib / readline.c
index 8b90c32c7f9f1066c388f2c3bef10248b5b5baab..70a82f27ab7b5abf325af0051de2480c5ddd9d23 100644 (file)
@@ -6,7 +6,7 @@
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
@@ -15,8 +15,7 @@
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
 #  define RL_COMPLETION_CAST
 #endif /* HAVE_NEW_LIBREADLINE */
 
+static bool smb_rl_done;
+
+#if HAVE_LIBREADLINE
+/*
+ * MacOS/X does not have rl_done in readline.h, but
+ * readline.so has it
+ */
+extern int rl_done;
+#endif
+
+void smb_readline_done(void)
+{
+       smb_rl_done = true;
+#if HAVE_LIBREADLINE
+       rl_done = 1;
+#endif
+}
+
 /****************************************************************************
  Display the prompt and wait for input. Call callback() regularly
 ****************************************************************************/
 
-static char *smb_readline_replacement(char *prompt, void (*callback)(void), 
-                               char **(completion_fn)(char *text, int start, int end))
+static char *smb_readline_replacement(const char *prompt, void (*callback)(void), 
+                               char **(completion_fn)(const char *text, int start, int end))
 {
        fd_set fds;
-       static pstring line;
+       char *line = NULL;
        struct timeval timeout;
        int fd = x_fileno(x_stdin);
        char *ret;
 
-       x_fprintf(dbf, "%s", prompt);
-       x_fflush(dbf);
+       /* Prompt might be NULL in non-interactive mode. */
+       if (prompt) {
+               x_fprintf(x_stdout, "%s", prompt);
+               x_fflush(x_stdout);
+       }
+
+       line = (char *)SMB_MALLOC(BUFSIZ);
+       if (!line) {
+               return NULL;
+       }
 
-       while (1) {
+       while (!smb_rl_done) {
                timeout.tv_sec = 5;
                timeout.tv_usec = 0;
 
+               if (fd < 0 || fd >= FD_SETSIZE) {
+                       errno = EBADF;
+                       break;
+               }
+
                FD_ZERO(&fds);
                FD_SET(fd,&fds);
-       
+
                if (sys_select_intr(fd+1,&fds,NULL,NULL,&timeout) == 1) {
-                       ret = x_fgets(line, sizeof(line), x_stdin);
+                       ret = x_fgets(line, BUFSIZ, x_stdin);
+                       if (ret == 0) {
+                               SAFE_FREE(line);
+                       }
                        return ret;
                }
-               if (callback)
+               if (callback) {
                        callback();
+               }
        }
+       SAFE_FREE(line);
+       return NULL;
 }
 
 /****************************************************************************
  Display the prompt and wait for input. Call callback() regularly.
 ****************************************************************************/
 
-char *smb_readline(char *prompt, void (*callback)(void), 
-                  char **(completion_fn)(char *text, int start, int end))
+char *smb_readline(const char *prompt, void (*callback)(void),
+                  char **(completion_fn)(const char *text, int start, int end))
 {
+       char *ret;
+       bool interactive;
+
+       interactive = isatty(x_fileno(x_stdin)) || getenv("CLI_FORCE_INTERACTIVE");
+       if (!interactive) {
+               return smb_readline_replacement(NULL, callback, completion_fn);
+       }
+
 #if HAVE_LIBREADLINE
-       if (isatty(x_fileno(x_stdin))) {
-               char *ret;
-
-               /* Aargh!  Readline does bizzare things with the terminal width
-               that mucks up expect(1).  Set CLI_NO_READLINE in the environment
-               to force readline not to be used. */
-
-               if (getenv("CLI_NO_READLINE"))
-                       return smb_readline_replacement(prompt, callback, completion_fn);
-
-               if (completion_fn) {
-                       /* The callback prototype has changed slightly between
-                       different versions of Readline, so the same function
-                       works in all of them to date, but we get compiler
-                       warnings in some.  */
-                       rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
-               }
 
-               if (callback)
-                       rl_event_hook = (Function *)callback;
-               ret = readline(prompt);
-               if (ret && *ret)
-                       add_history(ret);
-               return ret;
-       } else
+       /* Aargh!  Readline does bizzare things with the terminal width
+       that mucks up expect(1).  Set CLI_NO_READLINE in the environment
+       to force readline not to be used. */
+
+       if (getenv("CLI_NO_READLINE"))
+               return smb_readline_replacement(prompt, callback, completion_fn);
+
+       if (completion_fn) {
+               /* The callback prototype has changed slightly between
+               different versions of Readline, so the same function
+               works in all of them to date, but we get compiler
+               warnings in some.  */
+               rl_attempted_completion_function = RL_COMPLETION_CAST completion_fn;
+       }
+
+#if HAVE_DECL_RL_EVENT_HOOK
+       if (callback)
+               rl_event_hook = (Function *)callback;
+#endif
+       ret = readline(prompt);
+       if (ret && *ret)
+               add_history(ret);
+
+#else
+       ret = smb_readline_replacement(prompt, callback, completion_fn);
+#endif
+
+       return ret;
+}
+
+/****************************************************************************
+ * return line buffer text
+ ****************************************************************************/
+const char *smb_readline_get_line_buffer(void)
+{
+#if defined(HAVE_LIBREADLINE)
+       return rl_line_buffer;
+#else
+       return NULL;
+#endif
+}
+
+
+/****************************************************************************
+ * set completion append character
+ ***************************************************************************/
+void smb_readline_ca_char(char c)
+{
+#if defined(HAVE_LIBREADLINE)
+       rl_completion_append_character = c;
 #endif
-       return smb_readline_replacement(prompt, callback, completion_fn);
 }
 
 /****************************************************************************
@@ -120,12 +189,12 @@ history
 ****************************************************************************/
 int cmd_history(void)
 {
-#if defined(HAVE_LIBREADLINE)
+#if defined(HAVE_LIBREADLINE) && defined(HAVE_HISTORY_LIST)
        HIST_ENTRY **hlist;
        int i;
 
        hlist = history_list();
-       
+
        for (i = 0; hlist && hlist[i]; i++) {
                DEBUG(0, ("%d: %s\n", i, hlist[i]->line));
        }