s3-libads: Map LDAP_TIMELIMIT_EXCEEDED as NT_STATUS_IO_TIMEOUT

[ddiss/samba.git] / source3 / libads / ads_status.c

diff --git a/source3/libads/ads_status.c b/source3/libads/ads_status.c
index 536ef766e374a6ece9e47c2d2b4abe370337c029..8039534e3df50fa17b053b4040eb07f62074eb76 100644 (file)
--- a/source3/libads/ads_status.c
+++ b/source3/libads/ads_status.c
@@ -8,7 +8,7 @@
    
    This program is free software; you can redistribute it and/or modify
    it under the terms of the GNU General Public License as published by
-   the Free Software Foundation; either version 2 of the License, or
+   the Free Software Foundation; either version 3 of the License, or
    (at your option) any later version.
    
    This program is distributed in the hope that it will be useful,
@@ -17,11 +17,13 @@
    GNU General Public License for more details.
    
    You should have received a copy of the GNU General Public License
-   along with this program; if not, write to the Free Software
-   Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+   along with this program.  If not, see <http://www.gnu.org/licenses/>.
 */
 
 #include "includes.h"
+#include "smb_krb5.h"
+#include "smb_ldap.h"
+#include "libads/ads_status.h"
 
 /*
   build a ADS_STATUS structure
@@ -69,25 +71,32 @@ ADS_STATUS ads_build_nt_error(enum ads_error_type etype,
 */
 NTSTATUS ads_ntstatus(ADS_STATUS status)
 {
-       if (status.error_type == ENUM_ADS_ERROR_NT){
+       switch (status.error_type) {
+       case ENUM_ADS_ERROR_NT:
                return status.err.nt_status;    
-       }
+       case ENUM_ADS_ERROR_SYSTEM:
+               return map_nt_error_from_unix(status.err.rc);
 #ifdef HAVE_LDAP
-       if ((status.error_type == ENUM_ADS_ERROR_LDAP) 
-           && (status.err.rc == LDAP_NO_MEMORY)) {
-               return NT_STATUS_NO_MEMORY;
-       }
+       case ENUM_ADS_ERROR_LDAP:
+               if (status.err.rc == LDAP_SUCCESS) {
+                       return NT_STATUS_OK;
+               }
+               if (status.err.rc == LDAP_TIMELIMIT_EXCEEDED) {
+                       return NT_STATUS_IO_TIMEOUT;
+               }
+               return NT_STATUS_LDAP(status.err.rc);
 #endif
 #ifdef HAVE_KRB5
-       if (status.error_type == ENUM_ADS_ERROR_KRB5) { 
-               if (status.err.rc == KRB5KDC_ERR_PREAUTH_FAILED) {
-                       return NT_STATUS_LOGON_FAILURE;
-               } else if (status.err.rc == KRB5_KDC_UNREACH) {
-                       return NT_STATUS_NO_LOGON_SERVERS;
-               }
-       }
+       case ENUM_ADS_ERROR_KRB5:
+               return krb5_to_nt_status(status.err.rc);
 #endif
-       if (ADS_ERR_OK(status)) return NT_STATUS_OK;
+       default:
+               break;
+       }
+
+       if (ADS_ERR_OK(status)) {
+               return NT_STATUS_OK;
+       }
        return NT_STATUS_UNSUCCESSFUL;
 }
 
@@ -96,10 +105,6 @@ NTSTATUS ads_ntstatus(ADS_STATUS status)
 */
 const char *ads_errstr(ADS_STATUS status)
 {
-       static char *ret;
-
-       SAFE_FREE(ret);
-
        switch (status.error_type) {
        case ENUM_ADS_ERROR_SYSTEM:
                return strerror(status.err.rc);
@@ -114,6 +119,7 @@ const char *ads_errstr(ADS_STATUS status)
 #ifdef HAVE_GSSAPI
        case ENUM_ADS_ERROR_GSS:
        {
+               char *ret;
                uint32 msg_ctx;
                uint32 minor;
                gss_buffer_desc msg1, msg2;
@@ -126,7 +132,9 @@ const char *ads_errstr(ADS_STATUS status)
                                   GSS_C_NULL_OID, &msg_ctx, &msg1);
                gss_display_status(&minor, status.minor_status, GSS_C_MECH_CODE,
                                   GSS_C_NULL_OID, &msg_ctx, &msg2);
-               asprintf(&ret, "%s : %s", (char *)msg1.value, (char *)msg2.value);
+               ret = talloc_asprintf(talloc_tos(), "%s : %s",
+                                     (char *)msg1.value, (char *)msg2.value);
+               SMB_ASSERT(ret != NULL);
                gss_release_buffer(&minor, &msg1);
                gss_release_buffer(&minor, &msg2);
                return ret;
@@ -137,7 +145,14 @@ const char *ads_errstr(ADS_STATUS status)
        default:
                return "Unknown ADS error type!? (not compiled in?)";
        }
-
 }
 
-
+#ifdef HAVE_GSSAPI
+NTSTATUS gss_err_to_ntstatus(uint32 maj, uint32 min)
+{
+        ADS_STATUS adss = ADS_ERROR_GSS(maj, min);
+        DEBUG(10,("gss_err_to_ntstatus: Error %s\n",
+                ads_errstr(adss) ));
+        return ads_ntstatus(adss);
+}
+#endif