Revert "s3:libsmb: remove unused show_sessetup handling from do_connect()"
[metze/samba/wip.git] / source3 / libsmb / clidfs.c
index 4d0e97a9b5a2ef05363d24e3a420b9091e60ff4b..d49c48859fff9dae90d081b2cd1e83bed0a71ac2 100644 (file)
@@ -25,6 +25,8 @@
 #include "msdfs.h"
 #include "trans2.h"
 #include "libsmb/nmblib.h"
+#include "../libcli/smb/smbXcli_base.h"
+#include "auth/credentials/credentials.h"
 
 /********************************************************************
  Important point.
  Ensure a connection is encrypted.
 ********************************************************************/
 
-NTSTATUS cli_cm_force_encryption(struct cli_state *c,
-                       const char *username,
-                       const char *password,
-                       const char *domain,
-                       const char *sharename)
+NTSTATUS cli_cm_force_encryption_creds(struct cli_state *c,
+                                      struct cli_credentials *creds,
+                                      const char *sharename)
 {
-       NTSTATUS status = cli_force_encryption(c,
-                                       username,
-                                       password,
-                                       domain);
+       uint16_t major, minor;
+       uint32_t caplow, caphigh;
+       NTSTATUS status;
+
+       if (smbXcli_conn_protocol(c->conn) >= PROTOCOL_SMB2_02) {
+               status = smb2cli_session_encryption_on(c->smb2.session);
+               if (NT_STATUS_EQUAL(status,NT_STATUS_NOT_SUPPORTED)) {
+                       d_printf("Encryption required and "
+                               "server doesn't support "
+                               "SMB3 encryption - failing connect\n");
+               } else if (!NT_STATUS_IS_OK(status)) {
+                       d_printf("Encryption required and "
+                               "setup failed with error %s.\n",
+                               nt_errstr(status));
+               }
+               return status;
+       }
 
-       if (NT_STATUS_EQUAL(status,NT_STATUS_NOT_SUPPORTED)) {
+       if (!SERVER_HAS_UNIX_CIFS(c)) {
                d_printf("Encryption required and "
                        "server that doesn't support "
                        "UNIX extensions - failing connect\n");
-       } else if (NT_STATUS_EQUAL(status,NT_STATUS_UNKNOWN_REVISION)) {
+               return NT_STATUS_NOT_SUPPORTED;
+       }
+
+       status = cli_unix_extensions_version(c, &major, &minor, &caplow,
+                                            &caphigh);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("Encryption required and "
                        "can't get UNIX CIFS extensions "
                        "version from server.\n");
-       } else if (NT_STATUS_EQUAL(status,NT_STATUS_UNSUPPORTED_COMPRESSION)) {
+               return NT_STATUS_UNKNOWN_REVISION;
+       }
+
+       if (!(caplow & CIFS_UNIX_TRANSPORT_ENCRYPTION_CAP)) {
                d_printf("Encryption required and "
                        "share %s doesn't support "
                        "encryption.\n", sharename);
-       } else if (!NT_STATUS_IS_OK(status)) {
+               return NT_STATUS_UNSUPPORTED_COMPRESSION;
+       }
+
+       status = cli_smb1_setup_encryption(c, creds);
+       if (!NT_STATUS_IS_OK(status)) {
                d_printf("Encryption required and "
                        "setup failed with error %s.\n",
                        nt_errstr(status));
+               return status;
        }
 
+       return NT_STATUS_OK;
+}
+
+NTSTATUS cli_cm_force_encryption(struct cli_state *c,
+                       const char *username,
+                       const char *password,
+                       const char *domain,
+                       const char *sharename)
+{
+       struct cli_credentials *creds = NULL;
+       NTSTATUS status;
+
+       creds = cli_session_creds_init(c,
+                                      username,
+                                      domain,
+                                      NULL, /* default realm */
+                                      password,
+                                      c->use_kerberos,
+                                      c->fallback_after_kerberos,
+                                      c->use_ccache,
+                                      c->pw_nt_hash);
+       if (creds == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       status = cli_cm_force_encryption_creds(c, creds, sharename);
+       /* gensec currently references the creds so we can't free them here */
+       talloc_unlink(c, creds);
        return status;
 }
 
@@ -92,10 +146,15 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
        char *servicename;
        char *sharename;
        char *newserver, *newshare;
-       const char *username;
-       const char *password;
        NTSTATUS status;
        int flags = 0;
+       enum protocol_types protocol = PROTOCOL_NONE;
+       int signing_state = get_cmdline_auth_info_signing_state(auth_info);
+       struct cli_credentials *creds = NULL;
+
+       if (force_encrypt) {
+               signing_state = SMB_SIGNING_REQUIRED;
+       }
 
        /* make a copy so we don't modify the global string 'service' */
        servicename = talloc_strdup(ctx,share);
@@ -128,25 +187,34 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
        if (get_cmdline_auth_info_use_ccache(auth_info)) {
                flags |= CLI_FULL_CONNECTION_USE_CCACHE;
        }
+       if (get_cmdline_auth_info_use_pw_nt_hash(auth_info)) {
+               flags |= CLI_FULL_CONNECTION_USE_NT_HASH;
+       }
 
        status = cli_connect_nb(
                server, NULL, port, name_type, NULL,
-               get_cmdline_auth_info_signing_state(auth_info),
+               signing_state,
                flags, &c);
 
        if (!NT_STATUS_IS_OK(status)) {
-               d_printf("Connection to %s failed (Error %s)\n",
-                               server,
-                               nt_errstr(status));
+               if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED)) {
+                       DBG_ERR("NetBIOS support disabled, unable to connect");
+               }
+
+               DBG_WARNING("Connection to %s failed (Error %s)\n",
+                           server,
+                           nt_errstr(status));
                return status;
        }
 
        if (max_protocol == 0) {
-               max_protocol = PROTOCOL_NT1;
+               max_protocol = PROTOCOL_LATEST;
        }
        DEBUG(4,(" session request ok\n"));
 
-       status = cli_negprot(c, max_protocol);
+       status = smbXcli_negprot(c->conn, c->timeout,
+                                lp_client_min_protocol(),
+                                max_protocol);
 
        if (!NT_STATUS_IS_OK(status)) {
                d_printf("protocol negotiation failed: %s\n",
@@ -154,23 +222,27 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
                cli_shutdown(c);
                return status;
        }
+       protocol = smbXcli_conn_protocol(c->conn);
+       DEBUG(4,(" negotiated dialect[%s] against server[%s]\n",
+                smb_protocol_types_string(protocol),
+                smbXcli_conn_remote_name(c->conn)));
 
-       username = get_cmdline_auth_info_username(auth_info);
-       password = get_cmdline_auth_info_password(auth_info);
+       if (protocol >= PROTOCOL_SMB2_02) {
+               /* Ensure we ask for some initial credits. */
+               smb2cli_conn_set_max_credits(c->conn, DEFAULT_SMB2_MAX_CREDITS);
+       }
 
-       status = cli_session_setup(c, username,
-                                  password, strlen(password),
-                                  password, strlen(password),
-                                  lp_workgroup());
+       creds = get_cmdline_auth_info_creds(auth_info);
+
+       status = cli_session_setup_creds(c, creds);
        if (!NT_STATUS_IS_OK(status)) {
                /* If a password was not supplied then
                 * try again with a null username. */
-               if (password[0] || !username[0] ||
-                       get_cmdline_auth_info_use_kerberos(auth_info) ||
-                       !NT_STATUS_IS_OK(status = cli_session_setup(c, "",
-                                               "", 0,
-                                               "", 0,
-                                              lp_workgroup()))) {
+               if (force_encrypt || smbXcli_conn_signing_mandatory(c->conn) ||
+                       cli_credentials_authentication_requested(creds) ||
+                       cli_credentials_is_anonymous(creds) ||
+                       !NT_STATUS_IS_OK(status = cli_session_setup_anon(c)))
+               {
                        d_printf("session setup failed: %s\n",
                                 nt_errstr(status));
                        if (NT_STATUS_EQUAL(status,
@@ -180,9 +252,6 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
                        return status;
                }
                d_printf("Anonymous login successful\n");
-               status = cli_init_creds(c, "", lp_workgroup(), "");
-       } else {
-               status = cli_init_creds(c, username, lp_workgroup(), password);
        }
 
        if (!NT_STATUS_IS_OK(status)) {
@@ -207,13 +276,10 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
           here before trying to connect to the original share.
           cli_check_msdfs_proxy() will fail if it is a normal share. */
 
-       if ((cli_state_capabilities(c) & CAP_DFS) &&
+       if (smbXcli_conn_dfs_supported(c->conn) &&
                        cli_check_msdfs_proxy(ctx, c, sharename,
                                &newserver, &newshare,
-                               force_encrypt,
-                               username,
-                               password,
-                               lp_workgroup())) {
+                               force_encrypt, creds)) {
                cli_shutdown(c);
                return do_connect(ctx, newserver,
                                newshare, auth_info, false,
@@ -223,8 +289,7 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
 
        /* must be a normal share */
 
-       status = cli_tcon_andx(c, sharename, "?????",
-                              password, strlen(password)+1);
+       status = cli_tree_connect_creds(c, sharename, "?????", creds);
        if (!NT_STATUS_IS_OK(status)) {
                d_printf("tree connect failed: %s\n", nt_errstr(status));
                cli_shutdown(c);
@@ -232,11 +297,9 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
        }
 
        if (force_encrypt) {
-               status = cli_cm_force_encryption(c,
-                                       username,
-                                       password,
-                                       lp_workgroup(),
-                                       sharename);
+               status = cli_cm_force_encryption_creds(c,
+                                                      creds,
+                                                      sharename);
                if (!NT_STATUS_IS_OK(status)) {
                        cli_shutdown(c);
                        return status;
@@ -253,13 +316,15 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
 
 static void cli_set_mntpoint(struct cli_state *cli, const char *mnt)
 {
-       char *name = clean_name(NULL, mnt);
+       TALLOC_CTX *frame = talloc_stackframe();
+       char *name = clean_name(frame, mnt);
        if (!name) {
+               TALLOC_FREE(frame);
                return;
        }
        TALLOC_FREE(cli->dfs_mountpoint);
        cli->dfs_mountpoint = talloc_strdup(cli, name);
-       TALLOC_FREE(name);
+       TALLOC_FREE(frame);
 }
 
 /********************************************************************
@@ -272,7 +337,6 @@ static NTSTATUS cli_cm_connect(TALLOC_CTX *ctx,
                               const char *server,
                               const char *share,
                               const struct user_auth_info *auth_info,
-                              bool show_hdr,
                               bool force_encrypt,
                               int max_protocol,
                               int port,
@@ -293,12 +357,12 @@ static NTSTATUS cli_cm_connect(TALLOC_CTX *ctx,
 
        /* Enter into the list. */
        if (referring_cli) {
-               DLIST_ADD_END(referring_cli, cli, struct cli_state *);
+               DLIST_ADD_END(referring_cli, cli);
        }
 
        if (referring_cli && referring_cli->requested_posix_capabilities) {
-               uint16 major, minor;
-               uint32 caplow, caphigh;
+               uint16_t major, minor;
+               uint32_t caplow, caphigh;
                status = cli_unix_extensions_version(cli, &major, &minor,
                                                     &caplow, &caphigh);
                if (NT_STATUS_IS_OK(status)) {
@@ -329,7 +393,7 @@ static struct cli_state *cli_cm_find(struct cli_state *cli,
        /* Search to the start of the list. */
        for (p = cli; p; p = DLIST_PREV(p)) {
                const char *remote_name =
-                       cli_state_remote_name(p);
+                       smbXcli_conn_remote_name(p->conn);
 
                if (strequal(server, remote_name) &&
                                strequal(share,p->share)) {
@@ -340,7 +404,7 @@ static struct cli_state *cli_cm_find(struct cli_state *cli,
        /* Search to the end of the list. */
        for (p = cli->next; p; p = p->next) {
                const char *remote_name =
-                       cli_state_remote_name(p);
+                       smbXcli_conn_remote_name(p->conn);
 
                if (strequal(server, remote_name) &&
                                strequal(share,p->share)) {
@@ -360,7 +424,6 @@ NTSTATUS cli_cm_open(TALLOC_CTX *ctx,
                                const char *server,
                                const char *share,
                                const struct user_auth_info *auth_info,
-                               bool show_hdr,
                                bool force_encrypt,
                                int max_protocol,
                                int port,
@@ -390,7 +453,6 @@ NTSTATUS cli_cm_open(TALLOC_CTX *ctx,
                                server,
                                share,
                                auth_info,
-                               show_hdr,
                                force_encrypt,
                                max_protocol,
                                port,
@@ -412,7 +474,7 @@ void cli_cm_display(struct cli_state *cli)
 
        for (i=0; cli; cli = cli->next,i++ ) {
                d_printf("%d:\tserver=%s, share=%s\n",
-                       i, cli_state_remote_name(cli), cli->share);
+                       i, smbXcli_conn_remote_name(cli->conn), cli->share);
        }
 }
 
@@ -579,7 +641,7 @@ static char *cli_dfs_make_full_path(TALLOC_CTX *ctx,
        }
        return talloc_asprintf(ctx, "%c%s%c%s%c%s",
                        path_sep,
-                       cli_state_remote_name(cli),
+                       smbXcli_conn_remote_name(cli->conn),
                        path_sep,
                        cli->share,
                        path_sep,
@@ -595,10 +657,10 @@ static bool cli_dfs_check_error(struct cli_state *cli, NTSTATUS expected,
 {
        /* only deal with DS when we negotiated NT_STATUS codes and UNICODE */
 
-       if (!(cli_state_capabilities(cli) & CAP_UNICODE)) {
+       if (!(smbXcli_conn_use_unicode(cli->conn))) {
                return false;
        }
-       if (!(cli_state_capabilities(cli) & CAP_STATUS32)) {
+       if (!(smb1cli_conn_capabilities(cli->conn) & CAP_STATUS32)) {
                return false;
        }
        if (NT_STATUS_EQUAL(status, expected)) {
@@ -611,16 +673,15 @@ static bool cli_dfs_check_error(struct cli_state *cli, NTSTATUS expected,
  Get the dfs referral link.
 ********************************************************************/
 
-NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
+NTSTATUS cli_dfs_get_referral_ex(TALLOC_CTX *ctx,
                        struct cli_state *cli,
                        const char *path,
+                       uint16_t max_referral_level,
                        struct client_dfs_referral **refs,
                        size_t *num_refs,
                        size_t *consumed)
 {
-       unsigned int data_len = 0;
        unsigned int param_len = 0;
-       uint16_t setup[1];
        uint16_t recv_flags2;
        uint8_t *param = NULL;
        uint8_t *rdata = NULL;
@@ -629,7 +690,7 @@ NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
        smb_ucs2_t *path_ucs;
        char *consumed_path = NULL;
        uint16_t consumed_ucs;
-       uint16 num_referrals;
+       uint16_t num_referrals;
        struct client_dfs_referral *referrals = NULL;
        NTSTATUS status;
        TALLOC_CTX *frame = talloc_stackframe();
@@ -637,16 +698,14 @@ NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
        *num_refs = 0;
        *refs = NULL;
 
-       SSVAL(setup, 0, TRANSACT2_GET_DFS_REFERRAL);
-
        param = talloc_array(talloc_tos(), uint8_t, 2);
        if (!param) {
                status = NT_STATUS_NO_MEMORY;
                goto out;
        }
-       SSVAL(param, 0, 0x03);  /* max referral level */
+       SSVAL(param, 0, max_referral_level);
 
-       param = trans2_bytes_push_str(param, cli_ucs2(cli),
+       param = trans2_bytes_push_str(param, smbXcli_conn_use_unicode(cli->conn),
                                      path, strlen(path)+1,
                                      NULL);
        if (!param) {
@@ -656,20 +715,63 @@ NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
        param_len = talloc_get_size(param);
        path_ucs = (smb_ucs2_t *)&param[2];
 
-       status = cli_trans(talloc_tos(), cli, SMBtrans2,
-                          NULL, 0xffff, 0, 0,
-                          setup, 1, 0,
-                          param, param_len, 2,
-                          NULL, 0, CLI_BUFFER_SIZE,
-                          &recv_flags2,
-                          NULL, 0, NULL, /* rsetup */
-                          NULL, 0, NULL,
-                          &rdata, 4, &data_len);
-       if (!NT_STATUS_IS_OK(status)) {
-               goto out;
-       }
+       if (smbXcli_conn_protocol(cli->conn) >= PROTOCOL_SMB2_02) {
+               DATA_BLOB in_input_buffer;
+               DATA_BLOB in_output_buffer = data_blob_null;
+               DATA_BLOB out_input_buffer = data_blob_null;
+               DATA_BLOB out_output_buffer = data_blob_null;
+
+               in_input_buffer.data = param;
+               in_input_buffer.length = param_len;
+
+               status = smb2cli_ioctl(cli->conn,
+                                      cli->timeout,
+                                      cli->smb2.session,
+                                      cli->smb2.tcon,
+                                      UINT64_MAX, /* in_fid_persistent */
+                                      UINT64_MAX, /* in_fid_volatile */
+                                      FSCTL_DFS_GET_REFERRALS,
+                                      0, /* in_max_input_length */
+                                      &in_input_buffer,
+                                      CLI_BUFFER_SIZE, /* in_max_output_length */
+                                      &in_output_buffer,
+                                      SMB2_IOCTL_FLAG_IS_FSCTL,
+                                      talloc_tos(),
+                                      &out_input_buffer,
+                                      &out_output_buffer);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto out;
+               }
 
-       endp = (char *)rdata + data_len;
+               if (out_output_buffer.length < 4) {
+                       status = NT_STATUS_INVALID_NETWORK_RESPONSE;
+                       goto out;
+               }
+
+               recv_flags2 = FLAGS2_UNICODE_STRINGS;
+               rdata = out_output_buffer.data;
+               endp = (char *)rdata + out_output_buffer.length;
+       } else {
+               unsigned int data_len = 0;
+               uint16_t setup[1];
+
+               SSVAL(setup, 0, TRANSACT2_GET_DFS_REFERRAL);
+
+               status = cli_trans(talloc_tos(), cli, SMBtrans2,
+                                  NULL, 0xffff, 0, 0,
+                                  setup, 1, 0,
+                                  param, param_len, 2,
+                                  NULL, 0, CLI_BUFFER_SIZE,
+                                  &recv_flags2,
+                                  NULL, 0, NULL, /* rsetup */
+                                  NULL, 0, NULL,
+                                  &rdata, 4, &data_len);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto out;
+               }
+
+               endp = (char *)rdata + data_len;
+       }
 
        consumed_ucs  = SVAL(rdata, 0);
        num_referrals = SVAL(rdata, 2);
@@ -703,10 +805,10 @@ NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
        *consumed = strlen(consumed_path);
 
        if (num_referrals != 0) {
-               uint16 ref_version;
-               uint16 ref_size;
+               uint16_t ref_version;
+               uint16_t ref_size;
                int i;
-               uint16 node_offset;
+               uint16_t node_offset;
 
                referrals = talloc_array(ctx, struct client_dfs_referral,
                                         num_referrals);
@@ -767,8 +869,29 @@ NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
        return status;
 }
 
+NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
+                       struct cli_state *cli,
+                       const char *path,
+                       struct client_dfs_referral **refs,
+                       size_t *num_refs,
+                       size_t *consumed)
+{
+       return cli_dfs_get_referral_ex(ctx,
+                               cli,
+                               path,
+                               3,
+                               refs, /* Max referral level we want */
+                               num_refs,
+                               consumed);
+}
+
 /********************************************************************
 ********************************************************************/
+struct cli_dfs_path_split {
+       char *server;
+       char *share;
+       char *extrapath;
+};
 
 NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
                          const char *mountpt,
@@ -786,15 +909,18 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
        char *cleanpath = NULL;
        char *extrapath = NULL;
        int pathlen;
-       char *server = NULL;
-       char *share = NULL;
        struct cli_state *newcli = NULL;
+       struct cli_state *ccli = NULL;
+       int count = 0;
        char *newpath = NULL;
        char *newmount = NULL;
        char *ppath = NULL;
        SMB_STRUCT_STAT sbuf;
-       uint32 attributes;
+       uint32_t attributes;
        NTSTATUS status;
+       struct smbXcli_tcon *root_tcon = NULL;
+       struct smbXcli_tcon *target_tcon = NULL;
+       struct cli_dfs_path_split *dfs_refs = NULL;
 
        if ( !rootcli || !path || !targetcli ) {
                return NT_STATUS_INVALID_PARAMETER;
@@ -802,7 +928,20 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
 
        /* Don't do anything if this is not a DFS root. */
 
-       if ( !rootcli->dfsroot) {
+       if (smbXcli_conn_protocol(rootcli->conn) >= PROTOCOL_SMB2_02) {
+               root_tcon = rootcli->smb2.tcon;
+       } else {
+               root_tcon = rootcli->smb1.tcon;
+       }
+
+       /*
+        * Avoid more than one leading directory separator
+        */
+       while (IS_DIRECTORY_SEP(path[0]) && IS_DIRECTORY_SEP(path[1])) {
+               path++;
+       }
+
+       if (!smbXcli_tcon_is_dfs_share(root_tcon)) {
                *targetcli = rootcli;
                *pp_targetpath = talloc_strdup(ctx, path);
                if (!*pp_targetpath) {
@@ -859,12 +998,11 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
 
        status = cli_cm_open(ctx,
                             rootcli,
-                            cli_state_remote_name(rootcli),
+                            smbXcli_conn_remote_name(rootcli->conn),
                             "IPC$",
                             dfs_auth_info,
-                            false,
-                            cli_state_encryption_on(rootcli),
-                            cli_state_protocol(rootcli),
+                            cli_state_is_encryption_on(rootcli),
+                            smbXcli_conn_protocol(rootcli->conn),
                             0,
                             0x20,
                             &cli_ipc);
@@ -874,30 +1012,86 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
 
        status = cli_dfs_get_referral(ctx, cli_ipc, dfs_path, &refs,
                                      &num_refs, &consumed);
-       if (!NT_STATUS_IS_OK(status) || !num_refs) {
+       if (!NT_STATUS_IS_OK(status)) {
                return status;
        }
 
-       /* Just store the first referral for now. */
-
-       if (!refs[0].dfspath) {
+       if (!num_refs || !refs[0].dfspath) {
                return NT_STATUS_NOT_FOUND;
        }
-       if (!split_dfs_path(ctx, refs[0].dfspath, &server, &share,
-                           &extrapath)) {
-               return NT_STATUS_NOT_FOUND;
+
+       /*
+        * Bug#10123 - DFS referal entries can be provided in a random order,
+        * so check the connection cache for each item to avoid unnecessary
+        * reconnections.
+        */
+       dfs_refs = talloc_array(ctx, struct cli_dfs_path_split, num_refs);
+       if (dfs_refs == NULL) {
+               return NT_STATUS_NO_MEMORY;
+       }
+
+       for (count = 0; count < num_refs; count++) {
+               if (!split_dfs_path(dfs_refs, refs[count].dfspath,
+                                   &dfs_refs[count].server,
+                                   &dfs_refs[count].share,
+                                   &dfs_refs[count].extrapath)) {
+                       TALLOC_FREE(dfs_refs);
+                       return NT_STATUS_NOT_FOUND;
+               }
+
+               ccli = cli_cm_find(rootcli, dfs_refs[count].server,
+                                  dfs_refs[count].share);
+               if (ccli != NULL) {
+                       extrapath = dfs_refs[count].extrapath;
+                       *targetcli = ccli;
+                       break;
+               }
+       }
+
+       /*
+        * If no cached connection was found, then connect to the first live
+        * referral server in the list.
+        */
+       for (count = 0; (ccli == NULL) && (count < num_refs); count++) {
+               /* Connect to the target server & share */
+               status = cli_cm_connect(ctx, rootcli,
+                               dfs_refs[count].server,
+                               dfs_refs[count].share,
+                               dfs_auth_info,
+                               cli_state_is_encryption_on(rootcli),
+                               smbXcli_conn_protocol(rootcli->conn),
+                               0,
+                               0x20,
+                               targetcli);
+               if (!NT_STATUS_IS_OK(status)) {
+                       d_printf("Unable to follow dfs referral [\\%s\\%s]\n",
+                                dfs_refs[count].server,
+                                dfs_refs[count].share);
+                       continue;
+               } else {
+                       extrapath = dfs_refs[count].extrapath;
+                       break;
+               }
+       }
+
+       /* No available referral server for the connection */
+       if (*targetcli == NULL) {
+               TALLOC_FREE(dfs_refs);
+               return status;
        }
 
        /* Make sure to recreate the original string including any wildcards. */
 
        dfs_path = cli_dfs_make_full_path(ctx, rootcli, path);
        if (!dfs_path) {
+               TALLOC_FREE(dfs_refs);
                return NT_STATUS_NO_MEMORY;
        }
        pathlen = strlen(dfs_path);
        consumed = MIN(pathlen, consumed);
        *pp_targetpath = talloc_strdup(ctx, &dfs_path[consumed]);
        if (!*pp_targetpath) {
+               TALLOC_FREE(dfs_refs);
                return NT_STATUS_NO_MEMORY;
        }
        dfs_path[consumed] = '\0';
@@ -908,23 +1102,6 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
         * (in \server\share\path format).
         */
 
-       /* Open the connection to the target server & share */
-       status = cli_cm_open(ctx, rootcli,
-                            server,
-                            share,
-                            dfs_auth_info,
-                            false,
-                            cli_state_encryption_on(rootcli),
-                            cli_state_protocol(rootcli),
-                            0,
-                            0x20,
-                            targetcli);
-       if (!NT_STATUS_IS_OK(status)) {
-               d_printf("Unable to follow dfs referral [\\%s\\%s]\n",
-                       server, share );
-               return status;
-       }
-
        if (extrapath && strlen(extrapath) > 0) {
                /* EMC Celerra NAS version 5.6.50 (at least) doesn't appear to */
                /* put the trailing \ on the path, so to be save we put one in if needed */
@@ -940,6 +1117,7 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
                                                  *pp_targetpath);
                }
                if (!*pp_targetpath) {
+                       TALLOC_FREE(dfs_refs);
                        return NT_STATUS_NO_MEMORY;
                }
        }
@@ -953,18 +1131,21 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
                d_printf("cli_resolve_path: "
                        "dfs_path (%s) not in correct format.\n",
                        dfs_path );
+               TALLOC_FREE(dfs_refs);
                return NT_STATUS_NOT_FOUND;
        }
 
        ppath++; /* Now pointing at start of server name. */
 
        if ((ppath = strchr_m( dfs_path, '\\' )) == NULL) {
+               TALLOC_FREE(dfs_refs);
                return NT_STATUS_NOT_FOUND;
        }
 
        ppath++; /* Now pointing at start of share name. */
 
        if ((ppath = strchr_m( ppath+1, '\\' )) == NULL) {
+               TALLOC_FREE(dfs_refs);
                return NT_STATUS_NOT_FOUND;
        }
 
@@ -972,6 +1153,7 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
 
        newmount = talloc_asprintf(ctx, "%s\\%s", mountpt, ppath );
        if (!newmount) {
+               TALLOC_FREE(dfs_refs);
                return NT_STATUS_NOT_FOUND;
        }
 
@@ -996,24 +1178,34 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
                         */
                        *targetcli = newcli;
                        *pp_targetpath = newpath;
+                       TALLOC_FREE(dfs_refs);
                        return status;
                }
        }
 
   done:
 
+       if (smbXcli_conn_protocol((*targetcli)->conn) >= PROTOCOL_SMB2_02) {
+               target_tcon = (*targetcli)->smb2.tcon;
+       } else {
+               target_tcon = (*targetcli)->smb1.tcon;
+       }
+
        /* If returning true ensure we return a dfs root full path. */
-       if ((*targetcli)->dfsroot) {
+       if (smbXcli_tcon_is_dfs_share(target_tcon)) {
                dfs_path = talloc_strdup(ctx, *pp_targetpath);
                if (!dfs_path) {
+                       TALLOC_FREE(dfs_refs);
                        return NT_STATUS_NO_MEMORY;
                }
                *pp_targetpath = cli_dfs_make_full_path(ctx, *targetcli, dfs_path);
                if (*pp_targetpath == NULL) {
+                       TALLOC_FREE(dfs_refs);
                        return NT_STATUS_NO_MEMORY;
                }
        }
 
+       TALLOC_FREE(dfs_refs);
        return NT_STATUS_OK;
 }
 
@@ -1026,16 +1218,14 @@ bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
                                char **pp_newserver,
                                char **pp_newshare,
                                bool force_encrypt,
-                               const char *username,
-                               const char *password,
-                               const char *domain)
+                               struct cli_credentials *creds)
 {
        struct client_dfs_referral *refs = NULL;
        size_t num_refs = 0;
        size_t consumed = 0;
        char *fullpath = NULL;
        bool res;
-       uint16 cnum;
+       struct smbXcli_tcon *orig_tcon = NULL;
        char *newextrapath = NULL;
        NTSTATUS status;
        const char *remote_name;
@@ -1044,8 +1234,7 @@ bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
                return false;
        }
 
-       remote_name = cli_state_remote_name(cli);
-       cnum = cli_state_get_tid(cli);
+       remote_name = smbXcli_conn_remote_name(cli->conn);
 
        /* special case.  never check for a referral on the IPC$ share */
 
@@ -1060,19 +1249,25 @@ bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
                return false;
        }
 
+       /* Store tcon state. */
+       if (cli_state_has_tcon(cli)) {
+               orig_tcon = cli_state_save_tcon(cli);
+               if (orig_tcon == NULL) {
+                       return false;
+               }
+       }
+
        /* check for the referral */
 
-       if (!NT_STATUS_IS_OK(cli_tcon_andx(cli, "IPC$", "IPC", NULL, 0))) {
+       if (!NT_STATUS_IS_OK(cli_tree_connect(cli, "IPC$", "IPC", NULL))) {
+               cli_state_restore_tcon(cli, orig_tcon);
                return false;
        }
 
        if (force_encrypt) {
-               status = cli_cm_force_encryption(cli,
-                                       username,
-                                       password,
-                                       lp_workgroup(),
-                                       "IPC$");
+               status = cli_cm_force_encryption_creds(cli, creds, "IPC$");
                if (!NT_STATUS_IS_OK(status)) {
+                       cli_state_restore_tcon(cli, orig_tcon);
                        return false;
                }
        }
@@ -1082,12 +1277,13 @@ bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
        res = NT_STATUS_IS_OK(status);
 
        status = cli_tdis(cli);
+
+       cli_state_restore_tcon(cli, orig_tcon);
+
        if (!NT_STATUS_IS_OK(status)) {
                return false;
        }
 
-       cli_state_set_tid(cli, cnum);
-
        if (!res || !num_refs) {
                return false;
        }