Revert "s3:libsmb: remove unused show_sessetup handling from do_connect()"
[metze/samba/wip.git] / source3 / libsmb / clidfs.c
index fc6c30a01c4b64e235c1e5cae4c3760be6b4990a..d49c48859fff9dae90d081b2cd1e83bed0a71ac2 100644 (file)
@@ -26,6 +26,7 @@
 #include "trans2.h"
 #include "libsmb/nmblib.h"
 #include "../libcli/smb/smbXcli_base.h"
+#include "auth/credentials/credentials.h"
 
 /********************************************************************
  Important point.
@@ -145,11 +146,9 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
        char *servicename;
        char *sharename;
        char *newserver, *newshare;
-       const char *username;
-       const char *password;
-       const char *domain;
        NTSTATUS status;
        int flags = 0;
+       enum protocol_types protocol = PROTOCOL_NONE;
        int signing_state = get_cmdline_auth_info_signing_state(auth_info);
        struct cli_credentials *creds = NULL;
 
@@ -198,14 +197,18 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
                flags, &c);
 
        if (!NT_STATUS_IS_OK(status)) {
-               d_printf("Connection to %s failed (Error %s)\n",
-                               server,
-                               nt_errstr(status));
+               if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_SUPPORTED)) {
+                       DBG_ERR("NetBIOS support disabled, unable to connect");
+               }
+
+               DBG_WARNING("Connection to %s failed (Error %s)\n",
+                           server,
+                           nt_errstr(status));
                return status;
        }
 
        if (max_protocol == 0) {
-               max_protocol = PROTOCOL_NT1;
+               max_protocol = PROTOCOL_LATEST;
        }
        DEBUG(4,(" session request ok\n"));
 
@@ -219,27 +222,25 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
                cli_shutdown(c);
                return status;
        }
+       protocol = smbXcli_conn_protocol(c->conn);
+       DEBUG(4,(" negotiated dialect[%s] against server[%s]\n",
+                smb_protocol_types_string(protocol),
+                smbXcli_conn_remote_name(c->conn)));
 
-       if (smbXcli_conn_protocol(c->conn) >= PROTOCOL_SMB2_02) {
+       if (protocol >= PROTOCOL_SMB2_02) {
                /* Ensure we ask for some initial credits. */
                smb2cli_conn_set_max_credits(c->conn, DEFAULT_SMB2_MAX_CREDITS);
        }
 
-       username = get_cmdline_auth_info_username(auth_info);
-       password = get_cmdline_auth_info_password(auth_info);
-       domain = get_cmdline_auth_info_domain(auth_info);
-       if ((domain == NULL) || (domain[0] == '\0')) {
-               domain = lp_workgroup();
-       }
-
        creds = get_cmdline_auth_info_creds(auth_info);
 
        status = cli_session_setup_creds(c, creds);
        if (!NT_STATUS_IS_OK(status)) {
                /* If a password was not supplied then
                 * try again with a null username. */
-               if (password[0] || !username[0] ||
-                       get_cmdline_auth_info_use_kerberos(auth_info) ||
+               if (force_encrypt || smbXcli_conn_signing_mandatory(c->conn) ||
+                       cli_credentials_authentication_requested(creds) ||
+                       cli_credentials_is_anonymous(creds) ||
                        !NT_STATUS_IS_OK(status = cli_session_setup_anon(c)))
                {
                        d_printf("session setup failed: %s\n",
@@ -278,10 +279,7 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
        if (smbXcli_conn_dfs_supported(c->conn) &&
                        cli_check_msdfs_proxy(ctx, c, sharename,
                                &newserver, &newshare,
-                               force_encrypt,
-                               username,
-                               password,
-                               domain)) {
+                               force_encrypt, creds)) {
                cli_shutdown(c);
                return do_connect(ctx, newserver,
                                newshare, auth_info, false,
@@ -299,11 +297,9 @@ static NTSTATUS do_connect(TALLOC_CTX *ctx,
        }
 
        if (force_encrypt) {
-               status = cli_cm_force_encryption(c,
-                                       username,
-                                       password,
-                                       domain,
-                                       sharename);
+               status = cli_cm_force_encryption_creds(c,
+                                                      creds,
+                                                      sharename);
                if (!NT_STATUS_IS_OK(status)) {
                        cli_shutdown(c);
                        return status;
@@ -341,7 +337,6 @@ static NTSTATUS cli_cm_connect(TALLOC_CTX *ctx,
                               const char *server,
                               const char *share,
                               const struct user_auth_info *auth_info,
-                              bool show_hdr,
                               bool force_encrypt,
                               int max_protocol,
                               int port,
@@ -429,7 +424,6 @@ NTSTATUS cli_cm_open(TALLOC_CTX *ctx,
                                const char *server,
                                const char *share,
                                const struct user_auth_info *auth_info,
-                               bool show_hdr,
                                bool force_encrypt,
                                int max_protocol,
                                int port,
@@ -459,7 +453,6 @@ NTSTATUS cli_cm_open(TALLOC_CTX *ctx,
                                server,
                                share,
                                auth_info,
-                               show_hdr,
                                force_encrypt,
                                max_protocol,
                                port,
@@ -680,9 +673,10 @@ static bool cli_dfs_check_error(struct cli_state *cli, NTSTATUS expected,
  Get the dfs referral link.
 ********************************************************************/
 
-NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
+NTSTATUS cli_dfs_get_referral_ex(TALLOC_CTX *ctx,
                        struct cli_state *cli,
                        const char *path,
+                       uint16_t max_referral_level,
                        struct client_dfs_referral **refs,
                        size_t *num_refs,
                        size_t *consumed)
@@ -709,7 +703,7 @@ NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
                status = NT_STATUS_NO_MEMORY;
                goto out;
        }
-       SSVAL(param, 0, 0x03);  /* max referral level */
+       SSVAL(param, 0, max_referral_level);
 
        param = trans2_bytes_push_str(param, smbXcli_conn_use_unicode(cli->conn),
                                      path, strlen(path)+1,
@@ -875,6 +869,22 @@ NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
        return status;
 }
 
+NTSTATUS cli_dfs_get_referral(TALLOC_CTX *ctx,
+                       struct cli_state *cli,
+                       const char *path,
+                       struct client_dfs_referral **refs,
+                       size_t *num_refs,
+                       size_t *consumed)
+{
+       return cli_dfs_get_referral_ex(ctx,
+                               cli,
+                               path,
+                               3,
+                               refs, /* Max referral level we want */
+                               num_refs,
+                               consumed);
+}
+
 /********************************************************************
 ********************************************************************/
 struct cli_dfs_path_split {
@@ -924,6 +934,13 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
                root_tcon = rootcli->smb1.tcon;
        }
 
+       /*
+        * Avoid more than one leading directory separator
+        */
+       while (IS_DIRECTORY_SEP(path[0]) && IS_DIRECTORY_SEP(path[1])) {
+               path++;
+       }
+
        if (!smbXcli_tcon_is_dfs_share(root_tcon)) {
                *targetcli = rootcli;
                *pp_targetpath = talloc_strdup(ctx, path);
@@ -984,8 +1001,7 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
                             smbXcli_conn_remote_name(rootcli->conn),
                             "IPC$",
                             dfs_auth_info,
-                            false,
-                            smb1cli_conn_encryption_on(rootcli->conn),
+                            cli_state_is_encryption_on(rootcli),
                             smbXcli_conn_protocol(rootcli->conn),
                             0,
                             0x20,
@@ -1042,8 +1058,7 @@ NTSTATUS cli_resolve_path(TALLOC_CTX *ctx,
                                dfs_refs[count].server,
                                dfs_refs[count].share,
                                dfs_auth_info,
-                               false,
-                               smb1cli_conn_encryption_on(rootcli->conn),
+                               cli_state_is_encryption_on(rootcli),
                                smbXcli_conn_protocol(rootcli->conn),
                                0,
                                0x20,
@@ -1203,16 +1218,14 @@ bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
                                char **pp_newserver,
                                char **pp_newshare,
                                bool force_encrypt,
-                               const char *username,
-                               const char *password,
-                               const char *domain)
+                               struct cli_credentials *creds)
 {
        struct client_dfs_referral *refs = NULL;
        size_t num_refs = 0;
        size_t consumed = 0;
        char *fullpath = NULL;
        bool res;
-       uint16_t cnum;
+       struct smbXcli_tcon *orig_tcon = NULL;
        char *newextrapath = NULL;
        NTSTATUS status;
        const char *remote_name;
@@ -1222,7 +1235,6 @@ bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
        }
 
        remote_name = smbXcli_conn_remote_name(cli->conn);
-       cnum = cli_state_get_tid(cli);
 
        /* special case.  never check for a referral on the IPC$ share */
 
@@ -1237,19 +1249,25 @@ bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
                return false;
        }
 
+       /* Store tcon state. */
+       if (cli_state_has_tcon(cli)) {
+               orig_tcon = cli_state_save_tcon(cli);
+               if (orig_tcon == NULL) {
+                       return false;
+               }
+       }
+
        /* check for the referral */
 
        if (!NT_STATUS_IS_OK(cli_tree_connect(cli, "IPC$", "IPC", NULL))) {
+               cli_state_restore_tcon(cli, orig_tcon);
                return false;
        }
 
        if (force_encrypt) {
-               status = cli_cm_force_encryption(cli,
-                                       username,
-                                       password,
-                                       domain,
-                                       "IPC$");
+               status = cli_cm_force_encryption_creds(cli, creds, "IPC$");
                if (!NT_STATUS_IS_OK(status)) {
+                       cli_state_restore_tcon(cli, orig_tcon);
                        return false;
                }
        }
@@ -1259,12 +1277,13 @@ bool cli_check_msdfs_proxy(TALLOC_CTX *ctx,
        res = NT_STATUS_IS_OK(status);
 
        status = cli_tdis(cli);
+
+       cli_state_restore_tcon(cli, orig_tcon);
+
        if (!NT_STATUS_IS_OK(status)) {
                return false;
        }
 
-       cli_state_set_tid(cli, cnum);
-
        if (!res || !num_refs) {
                return false;
        }