Check error returns from strupper_m() (in all reasonable places).

[samba.git] / source3 / passdb / machine_account_secrets.c

diff --git a/source3/passdb/machine_account_secrets.c b/source3/passdb/machine_account_secrets.c
index 30f5f822ff9dc5f8c0bfd68926cc75e5dd4a4341..a4b5709b283e1ca52efa748ddd625b0083800fa8 100644 (file)
--- a/source3/passdb/machine_account_secrets.c
+++ b/source3/passdb/machine_account_secrets.c
@@ -148,7 +148,9 @@ bool secrets_store_domain_guid(const char *domain, struct GUID *guid)
 #endif
 
        slprintf(key, sizeof(key)-1, "%s/%s", SECRETS_DOMAIN_GUID, domain);
-       strupper_m(key);
+       if (!strupper_m(key)) {
+               return false;
+       }
        return secrets_store(key, guid, sizeof(struct GUID));
 }
 
@@ -160,7 +162,9 @@ bool secrets_fetch_domain_guid(const char *domain, struct GUID *guid)
        struct GUID new_guid;
 
        slprintf(key, sizeof(key)-1, "%s/%s", SECRETS_DOMAIN_GUID, domain);
-       strupper_m(key);
+       if (!strupper_m(key)) {
+               return false;
+       }
        dyn_guid = (struct GUID *)secrets_fetch(key, &size);
 
        if (!dyn_guid) {