s3-printing: rename queue->job sysjob
[ddiss/samba.git] / source3 / printing / print_cups.c
index 6e62306d671e22394ec13b78bddf6828a3442b26..88f143c0c7381788513046b4db775286ff2e17cf 100644 (file)
@@ -2,28 +2,46 @@
  * Support code for the Common UNIX Printing System ("CUPS")
  *
  * Copyright 1999-2003 by Michael R Sweet.
+ * Copyright 2008 Jeremy Allison.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
  * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
  * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+/*
+ * JRA. Converted to utf8 pull/push.
+ */
+
 #include "includes.h"
 #include "printing.h"
+#include "printing/pcap.h"
+#include "librpc/gen_ndr/ndr_printcap.h"
 
 #ifdef HAVE_CUPS
 #include <cups/cups.h>
 #include <cups/language.h>
 
+static SIG_ATOMIC_T gotalarm;
+
+/***************************************************************
+ Signal function to tell us we timed out.
+****************************************************************/
+
+static void gotalarm_sig(int signum)
+{
+        gotalarm = 1;
+}
+
 extern userdom_struct current_user_info;
 
 /*
@@ -40,16 +58,23 @@ cups_passwd_cb(const char *prompt)  /* I - Prompt */
        return (NULL);
 }
 
-static http_t *cups_connect(void)
+static http_t *cups_connect(TALLOC_CTX *frame)
 {
-       http_t *http;
-       char *server, *p;
+       http_t *http = NULL;
+       char *server = NULL, *p = NULL;
        int port;
-       
+       int timeout = lp_cups_connection_timeout();
+       size_t size;
+
        if (lp_cups_server() != NULL && strlen(lp_cups_server()) > 0) {
-               server = smb_xstrdup(lp_cups_server());
+               if (!push_utf8_talloc(frame, &server, lp_cups_server(), &size)) {
+                       return NULL;
+               }
        } else {
-               server = smb_xstrdup(cupsServer());
+               server = talloc_strdup(frame,cupsServer());
+       }
+       if (!server) {
+               return NULL;
        }
 
        p = strchr(server, ':');
@@ -59,36 +84,195 @@ static http_t *cups_connect(void)
        } else {
                port = ippPort();
        }
-       
+
        DEBUG(10, ("connecting to cups server %s:%d\n",
                   server, port));
 
-       if ((http = httpConnect(server, port)) == NULL) {
-               DEBUG(0,("Unable to connect to CUPS server %s:%d - %s\n", 
+       gotalarm = 0;
+
+       if (timeout) {
+                CatchSignal(SIGALRM, gotalarm_sig);
+                alarm(timeout);
+        }
+
+#ifdef HAVE_HTTPCONNECTENCRYPT
+       http = httpConnectEncrypt(server, port, lp_cups_encrypt());
+#else
+       http = httpConnect(server, port);
+#endif
+
+
+       CatchSignal(SIGALRM, SIG_IGN);
+        alarm(0);
+
+       if (http == NULL) {
+               DEBUG(0,("Unable to connect to CUPS server %s:%d - %s\n",
                         server, port, strerror(errno)));
-               SAFE_FREE(server);
-               return NULL;
        }
 
-       SAFE_FREE(server);
        return http;
 }
 
-bool cups_cache_reload(void)
+static bool send_pcap_blob(DATA_BLOB *pcap_blob, int fd)
+{
+       size_t ret;
+
+       ret = sys_write(fd, &pcap_blob->length, sizeof(pcap_blob->length));
+       if (ret != sizeof(pcap_blob->length)) {
+               return false;
+       }
+
+       ret = sys_write(fd, pcap_blob->data, pcap_blob->length);
+       if (ret != pcap_blob->length) {
+               return false;
+       }
+
+       DEBUG(10, ("successfully sent blob of len %d\n", (int)ret));
+       return true;
+}
+
+static bool recv_pcap_blob(TALLOC_CTX *mem_ctx, int fd, DATA_BLOB *pcap_blob)
+{
+       size_t blob_len;
+       size_t ret;
+
+       ret = sys_read(fd, &blob_len, sizeof(blob_len));
+       if (ret != sizeof(blob_len)) {
+               return false;
+       }
+
+       *pcap_blob = data_blob_talloc_named(mem_ctx, NULL, blob_len,
+                                          "cups pcap");
+       if (pcap_blob->length != blob_len) {
+               return false;
+       }
+       ret = sys_read(fd, pcap_blob->data, blob_len);
+       if (ret != blob_len) {
+               talloc_free(pcap_blob->data);
+               return false;
+       }
+
+       DEBUG(10, ("successfully recvd blob of len %d\n", (int)ret));
+       return true;
+}
+
+static bool process_cups_printers_response(TALLOC_CTX *mem_ctx,
+                                          ipp_t *response,
+                                          struct pcap_data *pcap_data)
+{
+       ipp_attribute_t *attr;
+       char *name;
+       char *info;
+       char *location = NULL;
+       struct pcap_printer *printer;
+       bool ret_ok = false;
+
+       for (attr = response->attrs; attr != NULL;) {
+              /*
+               * Skip leading attributes until we hit a printer...
+               */
+
+               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
+                       attr = attr->next;
+
+               if (attr == NULL)
+                       break;
+
+              /*
+               * Pull the needed attributes from this printer...
+               */
+
+               name       = NULL;
+               info       = NULL;
+
+               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
+                       size_t size;
+                       if (strcmp(attr->name, "printer-name") == 0 &&
+                           attr->value_tag == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(mem_ctx,
+                                               &name,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto err_out;
+                               }
+                       }
+
+                       if (strcmp(attr->name, "printer-info") == 0 &&
+                           attr->value_tag == IPP_TAG_TEXT) {
+                               if (!pull_utf8_talloc(mem_ctx,
+                                               &info,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto err_out;
+                               }
+                       }
+
+                       if (strcmp(attr->name, "printer-location") == 0 &&
+                           attr->value_tag == IPP_TAG_TEXT) {
+                               if (!pull_utf8_talloc(mem_ctx,
+                                               &location,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto err_out;
+                               }
+                       }
+
+                       attr = attr->next;
+               }
+
+              /*
+               * See if we have everything needed...
+               */
+
+               if (name == NULL)
+                       break;
+
+               if (pcap_data->count == 0) {
+                       printer = talloc_array(mem_ctx, struct pcap_printer, 1);
+               } else {
+                       printer = talloc_realloc(mem_ctx, pcap_data->printers,
+                                                struct pcap_printer,
+                                                pcap_data->count + 1);
+               }
+               if (printer == NULL) {
+                       goto err_out;
+               }
+               pcap_data->printers = printer;
+               pcap_data->printers[pcap_data->count].name = name;
+               pcap_data->printers[pcap_data->count].info = info;
+               pcap_data->printers[pcap_data->count].location = location;
+               pcap_data->count++;
+       }
+
+       ret_ok = true;
+err_out:
+       return ret_ok;
+}
+
+/*
+ * request printer list from cups, send result back to up parent via fd.
+ * returns true if the (possibly failed) result was successfuly sent to parent.
+ */
+static bool cups_cache_reload_async(int fd)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct pcap_data pcap_data;
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
-       ipp_attribute_t *attr;          /* Current attribute */
        cups_lang_t     *language = NULL;       /* Default language */
-       char            *name,          /* printer-name attribute */
-                       *info;          /* printer-info attribute */
        static const char *requested[] =/* Requested attributes */
                        {
                          "printer-name",
-                         "printer-info"
-                       };       
+                         "printer-info",
+                         "printer-location"
+                       };
        bool ret = False;
+       enum ndr_err_code ndr_ret;
+       DATA_BLOB pcap_blob;
+
+       ZERO_STRUCT(pcap_data);
+       pcap_data.status = NT_STATUS_UNSUCCESSFUL;
 
        DEBUG(5, ("reloading cups printcap cache\n"));
 
@@ -98,11 +282,7 @@ bool cups_cache_reload(void)
 
         cupsSetPasswordCB(cups_passwd_cb);
 
-       /*
-       * Try to connect to the server...
-       */
-
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -123,7 +303,7 @@ bool cups_cache_reload(void)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -133,56 +313,16 @@ bool cups_cache_reload(void)
                      (sizeof(requested) / sizeof(requested[0])),
                      NULL, requested);
 
-       /*
-       * Do the request and get back a response...
-       */
-
        if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
                goto out;
        }
 
-       for (attr = response->attrs; attr != NULL;) {
-              /*
-               * Skip leading attributes until we hit a printer...
-               */
-
-               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                       attr = attr->next;
-
-               if (attr == NULL)
-                       break;
-
-              /*
-               * Pull the needed attributes from this printer...
-               */
-
-               name       = NULL;
-               info       = NULL;
-
-               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
-                       if (strcmp(attr->name, "printer-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               name = attr->values[0].string.text;
-
-                       if (strcmp(attr->name, "printer-info") == 0 &&
-                           attr->value_tag == IPP_TAG_TEXT)
-                               info = attr->values[0].string.text;
-
-                       attr = attr->next;
-               }
-
-              /*
-               * See if we have everything needed...
-               */
-
-               if (name == NULL)
-                       break;
-
-               if (!pcap_cache_add(name, info)) {
-                       goto out;
-               }
+       ret = process_cups_printers_response(frame, response, &pcap_data);
+       if (!ret) {
+               DEBUG(0,("failed to process cups response\n"));
+               goto out;
        }
 
        ippDelete(response);
@@ -203,7 +343,7 @@ bool cups_cache_reload(void)
        request->request.op.request_id   = 1;
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -213,73 +353,211 @@ bool cups_cache_reload(void)
                      (sizeof(requested) / sizeof(requested[0])),
                      NULL, requested);
 
-       /*
-       * Do the request and get back a response...
-       */
-
        if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
                goto out;
        }
 
-       for (attr = response->attrs; attr != NULL;) {
-              /*
-               * Skip leading attributes until we hit a printer...
-               */
+       ret = process_cups_printers_response(frame, response, &pcap_data);
+       if (!ret) {
+               DEBUG(0,("failed to process cups response\n"));
+               goto out;
+       }
 
-               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                       attr = attr->next;
+       pcap_data.status = NT_STATUS_OK;
+ out:
+       if (response)
+               ippDelete(response);
 
-               if (attr == NULL)
-                       break;
+       if (language)
+               cupsLangFree(language);
 
-              /*
-               * Pull the needed attributes from this printer...
-               */
+       if (http)
+               httpClose(http);
 
-               name       = NULL;
-               info       = NULL;
+       ret = false;
+       ndr_ret = ndr_push_struct_blob(&pcap_blob, frame, &pcap_data,
+                                      (ndr_push_flags_fn_t)ndr_push_pcap_data);
+       if (ndr_ret == NDR_ERR_SUCCESS) {
+               ret = send_pcap_blob(&pcap_blob, fd);
+       }
 
-               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
-                       if (strcmp(attr->name, "printer-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               name = attr->values[0].string.text;
+       TALLOC_FREE(frame);
+       return ret;
+}
 
-                       if (strcmp(attr->name, "printer-info") == 0 &&
-                           attr->value_tag == IPP_TAG_TEXT)
-                               info = attr->values[0].string.text;
+static struct fd_event *cache_fd_event;
 
-                       attr = attr->next;
-               }
+static bool cups_pcap_load_async(struct tevent_context *ev,
+                                struct messaging_context *msg_ctx,
+                                int *pfd)
+{
+       int fds[2];
+       pid_t pid;
+       NTSTATUS status;
 
-              /*
-               * See if we have everything needed...
-               */
+       *pfd = -1;
 
-               if (name == NULL)
-                       break;
+       if (cache_fd_event) {
+               DEBUG(3,("cups_pcap_load_async: already waiting for "
+                       "a refresh event\n" ));
+               return false;
+       }
 
-               if (!pcap_cache_add(name, info)) {
-                       goto out;
-               }
+       DEBUG(5,("cups_pcap_load_async: asynchronously loading cups printers\n"));
+
+       if (pipe(fds) == -1) {
+               return false;
        }
 
-       ret = True;
+       pid = fork();
+       if (pid == (pid_t)-1) {
+               DEBUG(10,("cups_pcap_load_async: fork failed %s\n",
+                       strerror(errno) ));
+               close(fds[0]);
+               close(fds[1]);
+               return false;
+       }
 
- out:
-       if (response)
-               ippDelete(response);
+       if (pid) {
+               DEBUG(10,("cups_pcap_load_async: child pid = %u\n",
+                       (unsigned int)pid ));
+               /* Parent. */
+               close(fds[1]);
+               *pfd = fds[0];
+               return true;
+       }
 
-       if (language)
-               cupsLangFree(language);
+       /* Child. */
 
-       if (http)
-               httpClose(http);
+       close_all_print_db();
 
-       return ret;
+       status = reinit_after_fork(msg_ctx, ev, true);
+       if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(0,("cups_pcap_load_async: reinit_after_fork() failed\n"));
+               smb_panic("cups_pcap_load_async: reinit_after_fork() failed");
+       }
+
+       close(fds[0]);
+       cups_cache_reload_async(fds[1]);
+       close(fds[1]);
+       _exit(0);
+}
+
+struct cups_async_cb_args {
+       int pipe_fd;
+       struct event_context *event_ctx;
+       struct messaging_context *msg_ctx;
+       void (*post_cache_fill_fn)(struct event_context *,
+                                  struct messaging_context *);
+};
+
+static void cups_async_callback(struct event_context *event_ctx,
+                               struct fd_event *event,
+                               uint16 flags,
+                               void *p)
+{
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct cups_async_cb_args *cb_args = (struct cups_async_cb_args *)p;
+       struct pcap_cache *tmp_pcap_cache = NULL;
+       bool ret_ok;
+       struct pcap_data pcap_data;
+       DATA_BLOB pcap_blob;
+       enum ndr_err_code ndr_ret;
+       int i;
+
+       DEBUG(5,("cups_async_callback: callback received for printer data. "
+               "fd = %d\n", cb_args->pipe_fd));
+
+       ret_ok = recv_pcap_blob(frame, cb_args->pipe_fd, &pcap_blob);
+       if (!ret_ok) {
+               DEBUG(0,("failed to recv pcap blob\n"));
+               goto err_out;
+       }
+
+       ndr_ret = ndr_pull_struct_blob(&pcap_blob, frame, &pcap_data,
+                                      (ndr_pull_flags_fn_t)ndr_pull_pcap_data);
+       if (ndr_ret != NDR_ERR_SUCCESS) {
+               goto err_out;
+       }
+
+       if (!NT_STATUS_IS_OK(pcap_data.status)) {
+               DEBUG(0,("failed to retrieve printer list: %s\n",
+                        nt_errstr(pcap_data.status)));
+               goto err_out;
+       }
+
+       for (i = 0; i < pcap_data.count; i++) {
+               ret_ok = pcap_cache_add_specific(&tmp_pcap_cache,
+                                                pcap_data.printers[i].name,
+                                                pcap_data.printers[i].info,
+                                                pcap_data.printers[i].location);
+               if (!ret_ok) {
+                       DEBUG(0, ("failed to add to tmp pcap cache\n"));
+                       goto err_out;
+               }
+       }
+
+       /* replace the system-wide pcap cache with a (possibly empty) new one */
+       ret_ok = pcap_cache_replace(tmp_pcap_cache);
+       if (!ret_ok) {
+               DEBUG(0, ("failed to replace pcap cache\n"));
+       } else if (cb_args->post_cache_fill_fn != NULL) {
+               /* Caller requested post cache fill callback */
+               cb_args->post_cache_fill_fn(cb_args->event_ctx,
+                                           cb_args->msg_ctx);
+       }
+err_out:
+       pcap_cache_destroy_specific(&tmp_pcap_cache);
+       TALLOC_FREE(frame);
+       close(cb_args->pipe_fd);
+       TALLOC_FREE(cb_args);
+       TALLOC_FREE(cache_fd_event);
 }
 
+bool cups_cache_reload(struct tevent_context *ev,
+                      struct messaging_context *msg_ctx,
+                      void (*post_cache_fill_fn)(struct tevent_context *,
+                                                 struct messaging_context *))
+{
+       struct cups_async_cb_args *cb_args;
+       int *p_pipe_fd;
+
+       cb_args = talloc(NULL, struct cups_async_cb_args);
+       if (cb_args == NULL) {
+               return false;
+       }
+
+       cb_args->post_cache_fill_fn = post_cache_fill_fn;
+       cb_args->event_ctx = ev;
+       cb_args->msg_ctx = msg_ctx;
+       p_pipe_fd = &cb_args->pipe_fd;
+       *p_pipe_fd = -1;
+
+       /* Set up an async refresh. */
+       if (!cups_pcap_load_async(ev, msg_ctx, p_pipe_fd)) {
+               talloc_free(cb_args);
+               return false;
+       }
+
+       DEBUG(10,("cups_cache_reload: async read on fd %d\n",
+               *p_pipe_fd ));
+
+       /* Trigger an event when the pipe can be read. */
+       cache_fd_event = event_add_fd(ev,
+                               NULL, *p_pipe_fd,
+                               EVENT_FD_READ,
+                               cups_async_callback,
+                               (void *)cb_args);
+       if (!cache_fd_event) {
+               close(*p_pipe_fd);
+               TALLOC_FREE(cb_args);
+               return false;
+       }
+
+       return true;
+}
 
 /*
  * 'cups_job_delete()' - Delete a job.
@@ -287,13 +565,15 @@ bool cups_cache_reload(void)
 
 static int cups_job_delete(const char *sharename, const char *lprm_command, struct printjob *pjob)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
+       char *user = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       size_t size;
 
        DEBUG(5,("cups_job_delete(%s, %p (%d))\n", sharename, pjob, pjob->sysjob));
 
@@ -307,7 +587,7 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -329,7 +609,7 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
@@ -338,8 +618,12 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
+
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, pjob->user);
+                    NULL, user);
 
        /*
        * Do the request and get back a response...
@@ -367,6 +651,7 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -377,13 +662,15 @@ static int cups_job_delete(const char *sharename, const char *lprm_command, stru
 
 static int cups_job_pause(int snum, struct printjob *pjob)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
+       char *user = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       size_t size;
 
        DEBUG(5,("cups_job_pause(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
 
@@ -397,7 +684,7 @@ static int cups_job_pause(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -419,7 +706,7 @@ static int cups_job_pause(int snum, struct printjob *pjob)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
@@ -428,8 +715,11 @@ static int cups_job_pause(int snum, struct printjob *pjob)
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, pjob->user);
+                    NULL, user);
 
        /*
        * Do the request and get back a response...
@@ -457,6 +747,7 @@ static int cups_job_pause(int snum, struct printjob *pjob)
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -467,13 +758,15 @@ static int cups_job_pause(int snum, struct printjob *pjob)
 
 static int cups_job_resume(int snum, struct printjob *pjob)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
+       char *user = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       size_t size;
 
        DEBUG(5,("cups_job_resume(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
 
@@ -487,7 +780,7 @@ static int cups_job_resume(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -509,7 +802,7 @@ static int cups_job_resume(int snum, struct printjob *pjob)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
@@ -518,8 +811,11 @@ static int cups_job_resume(int snum, struct printjob *pjob)
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, pjob->user);
+                    NULL, user);
 
        /*
        * Do the request and get back a response...
@@ -547,6 +843,7 @@ static int cups_job_resume(int snum, struct printjob *pjob)
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -557,19 +854,25 @@ static int cups_job_resume(int snum, struct printjob *pjob)
 
 static int cups_job_submit(int snum, struct printjob *pjob)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
+       ipp_attribute_t *attr_job_id = NULL;    /* IPP Attribute "job-id" */
        cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-       const char      *clientname = NULL;     /* hostname of client for job-originating-host attribute */
        char *new_jobname = NULL;
        int             num_options = 0;
        cups_option_t   *options = NULL;
-       char addr[INET6_ADDRSTRLEN];
+       char *printername = NULL;
+       char *user = NULL;
+       char *jobname = NULL;
+       char *cupsoptions = NULL;
+       char *filename = NULL;
+       size_t size;
 
-       DEBUG(5,("cups_job_submit(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
+       DEBUG(5,("cups_job_submit(%d, %p)\n", snum, pjob));
 
        /*
         * Make sure we don't ask for passwords...
@@ -581,7 +884,7 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -604,63 +907,85 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
+       if (!push_utf8_talloc(frame, &printername, lp_printername(snum),
+                             &size)) {
+               goto out;
+       }
        slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+                printername);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
                     "printer-uri", NULL, uri);
 
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, pjob->user);
-
-       clientname = client_name(get_client_fd());
-       if (strcmp(clientname, "UNKNOWN") == 0) {
-               clientname = client_addr(get_client_fd(),addr,sizeof(addr));
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
        }
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
+                    NULL, user);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
                     "job-originating-host-name", NULL,
-                     clientname);
+                    pjob->clientmachine);
 
-       if (asprintf(&new_jobname,"%s%.8u %s", PRINT_SPOOL_PREFIX,
-                       (unsigned int)pjob->smbjob, pjob->jobname) < 0) {
+       if (!push_utf8_talloc(frame, &jobname, pjob->jobname, &size)) {
+               goto out;
+       }
+       new_jobname = talloc_asprintf(frame,
+                       "%s%.8u %s", PRINT_SPOOL_PREFIX,
+                       pjob->jobid, jobname);
+       if (new_jobname == NULL) {
                goto out;
        }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "job-name", NULL,
                     new_jobname);
 
-       /* 
-        * add any options defined in smb.conf 
+       /*
+        * add any options defined in smb.conf
         */
 
+       if (!push_utf8_talloc(frame, &cupsoptions, lp_cups_options(snum), &size)) {
+               goto out;
+       }
        num_options = 0;
        options     = NULL;
-       num_options = cupsParseOptions(lp_cups_options(snum), num_options, &options);
+       num_options = cupsParseOptions(cupsoptions, num_options, &options);
 
        if ( num_options )
-               cupsEncodeOptions(request, num_options, options); 
+               cupsEncodeOptions(request, num_options, options);
 
        /*
        * Do the request and get back a response...
        */
 
-       slprintf(uri, sizeof(uri) - 1, "/printers/%s", PRINTERNAME(snum));
+       slprintf(uri, sizeof(uri) - 1, "/printers/%s", printername);
 
+       if (!push_utf8_talloc(frame, &filename, pjob->filename, &size)) {
+               goto out;
+       }
        if ((response = cupsDoFileRequest(http, request, uri, pjob->filename)) != NULL) {
                if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                       DEBUG(0,("Unable to print file to %s - %s\n", PRINTERNAME(snum),
+                       DEBUG(0,("Unable to print file to %s - %s\n",
+                                lp_printername(snum),
                                 ippErrorString(cupsLastError())));
                } else {
                        ret = 0;
+                       attr_job_id = ippFindAttribute(response, "job-id", IPP_TAG_INTEGER);
+                       if(attr_job_id) {
+                               pjob->sysjob = attr_job_id->values[0].integer;
+                               DEBUG(5,("cups_job_submit: job-id %d\n", pjob->sysjob));
+                       } else {
+                               DEBUG(0,("Missing job-id attribute in IPP response"));
+                       }
                }
        } else {
-               DEBUG(0,("Unable to print file to `%s' - %s\n", PRINTERNAME(snum),
+               DEBUG(0,("Unable to print file to `%s' - %s\n",
+                        lp_printername(snum),
                         ippErrorString(cupsLastError())));
        }
 
@@ -678,7 +1003,7 @@ static int cups_job_submit(int snum, struct printjob *pjob)
        if (http)
                httpClose(http);
 
-       SAFE_FREE(new_jobname);
+       TALLOC_FREE(frame);
 
        return ret;
 }
@@ -690,10 +1015,11 @@ static int cups_job_submit(int snum, struct printjob *pjob)
 static int cups_queue_get(const char *sharename,
                enum printing_types printing_type,
                char *lpq_command,
-               print_queue_struct **q, 
+               print_queue_struct **q,
                print_status_struct *status)
 {
-       fstring         printername;
+       TALLOC_CTX *frame = talloc_stackframe();
+       char *printername = NULL;
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
@@ -704,13 +1030,14 @@ static int cups_queue_get(const char *sharename,
                        qalloc = 0;             /* Number of queue entries allocated */
        print_queue_struct *queue = NULL,       /* Queue entries */
                        *temp;          /* Temporary pointer for queue */
-       const char      *user_name,     /* job-originating-user-name attribute */
-                       *job_name;      /* job-name attribute */
+       char            *user_name = NULL,      /* job-originating-user-name attribute */
+                       *job_name = NULL;       /* job-name attribute */
        int             job_id;         /* job-id attribute */
        int             job_k_octets;   /* job-k-octets attribute */
        time_t          job_time;       /* time-at-creation attribute */
        ipp_jstate_t    job_status;     /* job-status attribute */
        int             job_priority;   /* job-priority attribute */
+       size_t size;
        static const char *jattrs[] =   /* Requested job attributes */
                        {
                          "job-id",
@@ -729,15 +1056,16 @@ static int cups_queue_get(const char *sharename,
 
        *q = NULL;
 
-       /* HACK ALERT!!!  The problem with support the 'printer name' 
-          option is that we key the tdb off the sharename.  So we will 
-          overload the lpq_command string to pass in the printername 
-          (which is basically what we do for non-cups printers ... using 
+       /* HACK ALERT!!!  The problem with support the 'printer name'
+          option is that we key the tdb off the sharename.  So we will
+          overload the lpq_command string to pass in the printername
+          (which is basically what we do for non-cups printers ... using
           the lpq_command to get the queue listing). */
 
-       fstrcpy( printername, lpq_command );
-
-       DEBUG(5,("cups_queue_get(%s, %p, %p)\n", printername, q, status));
+       if (!push_utf8_talloc(frame, &printername, lpq_command, &size)) {
+               goto out;
+       }
+       DEBUG(5,("cups_queue_get(%s, %p, %p)\n", lpq_command, q, status));
 
        /*
         * Make sure we don't ask for passwords...
@@ -749,7 +1077,7 @@ static int cups_queue_get(const char *sharename,
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -777,7 +1105,7 @@ static int cups_queue_get(const char *sharename,
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -882,12 +1210,24 @@ static int cups_queue_get(const char *sharename,
                                job_time = attr->values[0].integer;
 
                        if (strcmp(attr->name, "job-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               job_name = attr->values[0].string.text;
+                           attr->value_tag == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(frame,
+                                               &job_name,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
 
                        if (strcmp(attr->name, "job-originating-user-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               user_name = attr->values[0].string.text;
+                           attr->value_tag == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(frame,
+                                               &user_name,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
 
                        attr = attr->next;
                }
@@ -903,7 +1243,7 @@ static int cups_queue_get(const char *sharename,
                                continue;
                }
 
-               temp->job      = job_id;
+               temp->sysjob   = job_id;
                temp->size     = job_k_octets * 1024;
                temp->status   = job_status == IPP_JOB_PENDING ? LPQ_QUEUED :
                                 job_status == IPP_JOB_STOPPED ? LPQ_PAUSED :
@@ -911,8 +1251,8 @@ static int cups_queue_get(const char *sharename,
                                 LPQ_PRINTING;
                temp->priority = job_priority;
                temp->time     = job_time;
-               strncpy(temp->fs_user, user_name, sizeof(temp->fs_user) - 1);
-               strncpy(temp->fs_file, job_name, sizeof(temp->fs_file) - 1);
+               strlcpy(temp->fs_user, user_name, sizeof(temp->fs_user));
+               strlcpy(temp->fs_file, job_name, sizeof(temp->fs_file));
 
                qcount ++;
 
@@ -939,7 +1279,7 @@ static int cups_queue_get(const char *sharename,
        request->request.op.request_id   = 1;
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -959,14 +1299,12 @@ static int cups_queue_get(const char *sharename,
        if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
                         ippErrorString(cupsLastError())));
-               *q = queue;
                goto out;
        }
 
        if (response->request.status.status_code >= IPP_OK_CONFLICT) {
                DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
                         ippErrorString(response->request.status.status_code)));
-               *q = queue;
                goto out;
        }
 
@@ -982,8 +1320,19 @@ static int cups_queue_get(const char *sharename,
        }
 
         if ((attr = ippFindAttribute(response, "printer-state-message",
-                                    IPP_TAG_TEXT)) != NULL)
-               fstrcpy(status->message, attr->values[0].string.text);
+                                    IPP_TAG_TEXT)) != NULL) {
+               char *msg = NULL;
+               if (!pull_utf8_talloc(frame, &msg,
+                               attr->values[0].string.text,
+                               &size)) {
+                       SAFE_FREE(queue);
+                       qcount = 0;
+                       goto out;
+               }
+               fstrcpy(status->message, msg);
+       }
+
+ out:
 
        /*
         * Return the job queue...
@@ -991,7 +1340,6 @@ static int cups_queue_get(const char *sharename,
 
        *q = queue;
 
- out:
        if (response)
                ippDelete(response);
 
@@ -1001,6 +1349,7 @@ static int cups_queue_get(const char *sharename,
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return qcount;
 }
 
@@ -1011,13 +1360,16 @@ static int cups_queue_get(const char *sharename,
 
 static int cups_queue_pause(int snum)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
+       char *printername = NULL;
+       char *username = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       size_t size;
 
        DEBUG(5,("cups_queue_pause(%d)\n", snum));
 
@@ -1031,7 +1383,7 @@ static int cups_queue_pause(int snum)
         * Try to connect to the server...
         */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -1053,18 +1405,25 @@ static int cups_queue_pause(int snum)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
+       if (!push_utf8_talloc(frame, &printername, lp_printername(snum),
+                             &size)) {
+               goto out;
+       }
        slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+                printername);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &username, current_user_info.unix_name, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, current_user_info.unix_name);
+                    NULL, username);
 
        /*
        * Do the request and get back a response...
@@ -1072,13 +1431,15 @@ static int cups_queue_pause(int snum)
 
        if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
                if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                       DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
+                       DEBUG(0,("Unable to pause printer %s - %s\n",
+                                lp_printername(snum),
                                ippErrorString(cupsLastError())));
                } else {
                        ret = 0;
                }
        } else {
-               DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
+               DEBUG(0,("Unable to pause printer %s - %s\n",
+                        lp_printername(snum),
                        ippErrorString(cupsLastError())));
        }
 
@@ -1092,6 +1453,7 @@ static int cups_queue_pause(int snum)
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -1102,13 +1464,16 @@ static int cups_queue_pause(int snum)
 
 static int cups_queue_resume(int snum)
 {
+       TALLOC_CTX *frame = talloc_stackframe();
        int             ret = 1;                /* Return value */
        http_t          *http = NULL;           /* HTTP connection to server */
        ipp_t           *request = NULL,        /* IPP Request */
                        *response = NULL;       /* IPP Response */
        cups_lang_t     *language = NULL;       /* Default language */
+       char *printername = NULL;
+       char *username = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       size_t size;
 
        DEBUG(5,("cups_queue_resume(%d)\n", snum));
 
@@ -1122,7 +1487,7 @@ static int cups_queue_resume(int snum)
        * Try to connect to the server...
        */
 
-       if ((http = cups_connect()) == NULL) {
+       if ((http = cups_connect(frame)) == NULL) {
                goto out;
        }
 
@@ -1144,18 +1509,25 @@ static int cups_queue_resume(int snum)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
+       if (!push_utf8_talloc(frame, &printername, lp_printername(snum),
+                             &size)) {
+               goto out;
+       }
        slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+                printername);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &username, current_user_info.unix_name, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, current_user_info.unix_name);
+                    NULL, username);
 
        /*
        * Do the request and get back a response...
@@ -1163,13 +1535,15 @@ static int cups_queue_resume(int snum)
 
        if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
                if (response->request.status.status_code >= IPP_OK_CONFLICT) {
-                       DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+                       DEBUG(0,("Unable to resume printer %s - %s\n",
+                                lp_printername(snum),
                                ippErrorString(cupsLastError())));
                } else {
                        ret = 0;
                }
        } else {
-               DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+               DEBUG(0,("Unable to resume printer %s - %s\n",
+                        lp_printername(snum),
                        ippErrorString(cupsLastError())));
        }
 
@@ -1183,6 +1557,7 @@ static int cups_queue_resume(int snum)
        if (http)
                httpClose(http);
 
+       TALLOC_FREE(frame);
        return ret;
 }
 
@@ -1202,142 +1577,6 @@ struct printif  cups_printif =
        cups_job_submit,
 };
 
-bool cups_pull_comment_location(NT_PRINTER_INFO_LEVEL_2 *printer)
-{
-       http_t          *http = NULL;           /* HTTP connection to server */
-       ipp_t           *request = NULL,        /* IPP Request */
-                       *response = NULL;       /* IPP Response */
-       ipp_attribute_t *attr;          /* Current attribute */
-       cups_lang_t     *language = NULL;       /* Default language */
-       char            *name,          /* printer-name attribute */
-                       *info,          /* printer-info attribute */
-                       *location;      /* printer-location attribute */
-       char            uri[HTTP_MAX_URI];
-       static const char *requested[] =/* Requested attributes */
-                       {
-                         "printer-name",
-                         "printer-info",
-                         "printer-location"
-                       };
-       bool ret = False;
-
-       DEBUG(5, ("pulling %s location\n", printer->sharename));
-
-       /*
-        * Make sure we don't ask for passwords...
-        */
-
-        cupsSetPasswordCB(cups_passwd_cb);
-
-       /*
-        * Try to connect to the server...
-        */
-
-       if ((http = cups_connect()) == NULL) {
-               goto out;
-       }
-
-       request = ippNew();
-
-       request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
-       request->request.op.request_id   = 1;
-
-       language = cupsLangDefault();
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
-                     "attributes-natural-language", NULL, language->language);
-
-       slprintf(uri, sizeof(uri) - 1, "ipp://%s/printers/%s",
-                lp_cups_server(), printer->sharename);
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
-                     "printer-uri", NULL, uri);
-
-        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
-                     "requested-attributes",
-                     (sizeof(requested) / sizeof(requested[0])),
-                     NULL, requested);
-
-       /*
-        * Do the request and get back a response...
-        */
-
-       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
-               DEBUG(0,("Unable to get printer attributes - %s\n",
-                        ippErrorString(cupsLastError())));
-               goto out;
-       }
-
-       for (attr = response->attrs; attr != NULL;) {
-               /*
-                * Skip leading attributes until we hit a printer...
-                */
-
-               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
-                       attr = attr->next;
-
-               if (attr == NULL)
-                       break;
-
-               /*
-                * Pull the needed attributes from this printer...
-                */
-
-               name       = NULL;
-               info       = NULL;
-               location   = NULL;
-
-               while ( attr && (attr->group_tag == IPP_TAG_PRINTER) ) {
-                       /* Grab the comment if we don't have one */
-                       if ( (strcmp(attr->name, "printer-info") == 0)
-                            && (attr->value_tag == IPP_TAG_TEXT)
-                            && !strlen(printer->comment) ) 
-                       {
-                               DEBUG(5,("cups_pull_comment_location: Using cups comment: %s\n",
-                                        attr->values[0].string.text));                         
-                               pstrcpy(printer->comment,attr->values[0].string.text);
-                       }
-
-                       /* Grab the location if we don't have one */ 
-                       if ( (strcmp(attr->name, "printer-location") == 0)
-                            && (attr->value_tag == IPP_TAG_TEXT) 
-                            && !strlen(printer->location) )
-                       {
-                               DEBUG(5,("cups_pull_comment_location: Using cups location: %s\n",
-                                        attr->values[0].string.text));                         
-                               fstrcpy(printer->location,attr->values[0].string.text);
-                       }
-
-                       attr = attr->next;
-               }
-
-               /*
-                * See if we have everything needed...
-                */
-
-               if (name == NULL)
-                       break;
-
-       }
-
-       ret = True;
-
- out:
-       if (response)
-               ippDelete(response);
-
-       if (language)
-               cupsLangFree(language);
-
-       if (http)
-               httpClose(http);
-
-       return ret;
-}
-
 #else
  /* this keeps fussy compilers happy */
  void print_cups_dummy(void);