Revert "Revert "s3-printing: reload shares after pcap cache fill""
[samba.git] / source3 / printing / print_cups.c
index b9929c4823a2d05ed4d0d71a6ebb72862e6b992e..a8cc538942ea32d250abfb7a70c1e26c5bf888da 100644 (file)
 /*
  * Support code for the Common UNIX Printing System ("CUPS")
  *
- * Copyright 1999-2001 by Easy Software Products
+ * Copyright 1999-2003 by Michael R Sweet.
+ * Copyright 2008 Jeremy Allison.
  *
  * This program is free software; you can redistribute it and/or modify
  * it under the terms of the GNU General Public License as published by
- * the Free Software Foundation; either version 2 of the License, or
+ * the Free Software Foundation; either version 3 of the License, or
  * (at your option) any later version.
- * 
+ *
  * This program is distributed in the hope that it will be useful,
  * but WITHOUT ANY WARRANTY; without even the implied warranty of
  * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
  * GNU General Public License for more details.
- * 
+ *
  * You should have received a copy of the GNU General Public License
- * along with this program; if not, write to the Free Software
- * Foundation, Inc., 675 Mass Ave, Cambridge, MA 02139, USA.
+ * along with this program; if not, see <http://www.gnu.org/licenses/>.
  */
 
+/*
+ * JRA. Converted to utf8 pull/push.
+ */
+
+#include "includes.h"
 #include "printing.h"
-#include "smb.h"
 
-#ifdef HAVE_LIBCUPS
+#ifdef HAVE_CUPS
 #include <cups/cups.h>
 #include <cups/language.h>
 
+static SIG_ATOMIC_T gotalarm;
 
-/*
- * CUPS printing interface definitions...
- */
-
-static int cups_job_delete(int snum, struct printjob *pjob);
-static int cups_job_pause(int snum, struct printjob *pjob);
-static int cups_job_resume(int snum, struct printjob *pjob);
-static int cups_job_submit(int snum, struct printjob *pjob);
-static int cups_queue_get(int snum, print_queue_struct **q,
-                          print_status_struct *status);
-static int cups_queue_pause(int snum);
-static int cups_queue_resume(int snum);
-
+/***************************************************************
+ Signal function to tell us we timed out.
+****************************************************************/
 
-struct printif cups_printif =
-               {
-                 cups_queue_get,
-                 cups_queue_pause,
-                 cups_queue_resume,
-                 cups_job_delete,
-                 cups_job_pause,
-                 cups_job_resume,
-                 cups_job_submit,
-               };
-
-extern int DEBUGLEVEL;
+static void gotalarm_sig(void)
+{
+        gotalarm = 1;
+}
 
+extern userdom_struct current_user_info;
 
 /*
  * 'cups_passwd_cb()' - The CUPS password callback...
  */
 
-const char *                           /* O - Password or NULL */
+static const char *                            /* O - Password or NULL */
 cups_passwd_cb(const char *prompt)     /* I - Prompt */
 {
- /*
-  * Always return NULL to indicate that no password is available...
-  */
-
-  (void)prompt;
+       /*
+        * Always return NULL to indicate that no password is available...
+        */
 
-  return (NULL);
+       return (NULL);
 }
 
+static http_t *cups_connect(TALLOC_CTX *frame)
+{
+       http_t *http = NULL;
+       char *server = NULL, *p = NULL;
+       int port;
+       int timeout = lp_cups_connection_timeout();
+       size_t size;
+
+       if (lp_cups_server() != NULL && strlen(lp_cups_server()) > 0) {
+               if (!push_utf8_talloc(frame, &server, lp_cups_server(), &size)) {
+                       return NULL;
+               }
+       } else {
+               server = talloc_strdup(frame,cupsServer());
+       }
+       if (!server) {
+               return NULL;
+       }
 
-/*
- * 'cups_printer_fn()' - Call a function for every printer known to the
- *                       system.
- */
+       p = strchr(server, ':');
+       if (p) {
+               port = atoi(p+1);
+               *p = '\0';
+       } else {
+               port = ippPort();
+       }
+
+       DEBUG(10, ("connecting to cups server %s:%d\n",
+                  server, port));
+
+       gotalarm = 0;
+
+       if (timeout) {
+                CatchSignal(SIGALRM, SIGNAL_CAST gotalarm_sig);
+                alarm(timeout);
+        }
+
+       http = httpConnect(server, port);
 
-void
-cups_printer_fn(void (*fn)(char *, char *))    /* I - Function to call */
+       CatchSignal(SIGALRM, SIGNAL_CAST SIG_IGN);
+        alarm(0);
+
+       if (http == NULL) {
+               DEBUG(0,("Unable to connect to CUPS server %s:%d - %s\n",
+                        server, port, strerror(errno)));
+       }
+
+       return http;
+}
+
+static void send_pcap_info(const char *name, const char *info, void *pd)
+{
+       int fd = *(int *)pd;
+       size_t namelen = name ? strlen(name)+1 : 0;
+       size_t infolen = info ? strlen(info)+1 : 0;
+
+       DEBUG(11,("send_pcap_info: writing namelen %u\n", (unsigned int)namelen));
+       if (sys_write(fd, &namelen, sizeof(namelen)) != sizeof(namelen)) {
+               DEBUG(10,("send_pcap_info: namelen write failed %s\n",
+                       strerror(errno)));
+               return;
+       }
+       DEBUG(11,("send_pcap_info: writing infolen %u\n", (unsigned int)infolen));
+       if (sys_write(fd, &infolen, sizeof(infolen)) != sizeof(infolen)) {
+               DEBUG(10,("send_pcap_info: infolen write failed %s\n",
+                       strerror(errno)));
+               return;
+       }
+       if (namelen) {
+               DEBUG(11,("send_pcap_info: writing name %s\n", name));
+               if (sys_write(fd, name, namelen) != namelen) {
+                       DEBUG(10,("send_pcap_info: name write failed %s\n",
+                               strerror(errno)));
+                       return;
+               }
+       }
+       if (infolen) {
+               DEBUG(11,("send_pcap_info: writing info %s\n", info));
+               if (sys_write(fd, info, infolen) != infolen) {
+                       DEBUG(10,("send_pcap_info: info write failed %s\n",
+                               strerror(errno)));
+                       return;
+               }
+       }
+}
+
+static bool cups_cache_reload_async(int fd)
 {
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct pcap_cache *tmp_pcap_cache = NULL;
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
        ipp_attribute_t *attr;          /* Current attribute */
-       cups_lang_t     *language;      /* Default language */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            *name,          /* printer-name attribute */
-                       *make_model,    /* printer-make-and-model attribute */
                        *info;          /* printer-info attribute */
        static const char *requested[] =/* Requested attributes */
                        {
                          "printer-name",
-                         "printer-make-and-model",
                          "printer-info"
-                       };       
-
+                       };
+       bool ret = False;
+       size_t size;
 
-       DEBUG(5,("cups_printer_fn(%p)\n", fn));
+       DEBUG(5, ("reloading cups printcap cache\n"));
 
        /*
         * Make sure we don't ask for passwords...
@@ -107,11 +173,8 @@ cups_printer_fn(void (*fn)(char *, char *))        /* I - Function to call */
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return;
+       if ((http = cups_connect(frame)) == NULL) {
+               goto out;
        }
 
        /*
@@ -131,7 +194,7 @@ cups_printer_fn(void (*fn)(char *, char *)) /* I - Function to call */
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -145,16 +208,13 @@ cups_printer_fn(void (*fn)(char *, char *))       /* I - Function to call */
        * Do the request and get back a response...
        */
 
-       if ((response = cupsDoRequest(http, request, "/")) == NULL)
-       {
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
-               httpClose(http);
-               return;
+               goto out;
        }
 
-       for (attr = response->attrs; attr != NULL;)
-       {
+       for (attr = response->attrs; attr != NULL;) {
               /*
                * Skip leading attributes until we hit a printer...
                */
@@ -170,22 +230,28 @@ cups_printer_fn(void (*fn)(char *, char *))       /* I - Function to call */
                */
 
                name       = NULL;
-               make_model = NULL;
                info       = NULL;
 
-               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER)
-               {
+               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
                        if (strcmp(attr->name, "printer-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               name = attr->values[0].string.text;
-
-                       if (strcmp(attr->name, "printer-make-and-model") == 0 &&
-                           attr->value_tag == IPP_TAG_TEXT)
-                               make_model = attr->values[0].string.text;
+                           attr->value_tag == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(frame,
+                                               &name,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
 
                        if (strcmp(attr->name, "printer-info") == 0 &&
-                           attr->value_tag == IPP_TAG_TEXT)
-                               info = attr->values[0].string.text;
+                           attr->value_tag == IPP_TAG_TEXT) {
+                               if (!pull_utf8_talloc(frame,
+                                               &info,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
 
                        attr = attr->next;
                }
@@ -197,129 +263,375 @@ cups_printer_fn(void (*fn)(char *, char *))     /* I - Function to call */
                if (name == NULL)
                        break;
 
-               if (info == NULL || !info[0])
-                       (*fn)(name, make_model);
-               else
-                       (*fn)(name,info);
-               
-
+               if (!pcap_cache_add_specific(&tmp_pcap_cache, name, info)) {
+                       goto out;
+               }
        }
 
        ippDelete(response);
-       httpClose(http);
-}
-
-
-/*
- * 'cups_printername_ok()' - Provide the equivalent of pcap_printername_ok()
- *                           for CUPS.
- */
-
-int                                    /* O - 1 if printer name OK */
-cups_printername_ok(char *name)                /* I - Name of printer */
-{
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
-       char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
-
-       DEBUG(5,("cups_printername_ok(\"%s\")\n", name));
-
-       /*
-        * Make sure we don't ask for passwords...
-       */
-
-        cupsSetPasswordCB(cups_passwd_cb);
+       response = NULL;
 
        /*
-       * Try to connect to the server...
-       */
-
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (0);
-       }
-
-       /*
-       * Build an IPP_GET_PRINTER_ATTRS request, which requires the following
+       * Build a CUPS_GET_CLASSES request, which requires the following
        * attributes:
        *
        *    attributes-charset
        *    attributes-natural-language
        *    requested-attributes
-       *    printer-uri
        */
 
        request = ippNew();
 
-       request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
+       request->request.op.operation_id = CUPS_GET_CLASSES;
        request->request.op.request_id   = 1;
 
-       language = cupsLangDefault();
-
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
 
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
-                     "requested-attributes", NULL, "printer-uri");
-
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s", name);
-
-       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
-                     "printer-uri", NULL, uri);
+        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
+                     "requested-attributes",
+                     (sizeof(requested) / sizeof(requested[0])),
+                     NULL, requested);
 
        /*
        * Do the request and get back a response...
        */
 
-       if ((response = cupsDoRequest(http, request, "/")) == NULL)
-       {
-               DEBUG(0,("Unable to get printer status for %s - %s\n", name,
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
+               DEBUG(0,("Unable to get printer list - %s\n",
                         ippErrorString(cupsLastError())));
-               httpClose(http);
-               return (0);
+               goto out;
        }
 
-       httpClose(http);
+       for (attr = response->attrs; attr != NULL;) {
+              /*
+               * Skip leading attributes until we hit a printer...
+               */
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT)
-       {
-               DEBUG(0,("Unable to get printer status for %s - %s\n", name,
-                        ippErrorString(response->request.status.status_code)));
-               ippDelete(response);
-               return (0);
+               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
+                       attr = attr->next;
+
+               if (attr == NULL)
+                       break;
+
+              /*
+               * Pull the needed attributes from this printer...
+               */
+
+               name       = NULL;
+               info       = NULL;
+
+               while (attr != NULL && attr->group_tag == IPP_TAG_PRINTER) {
+                       if (strcmp(attr->name, "printer-name") == 0 &&
+                           attr->value_tag == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(frame,
+                                               &name,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
+
+                       if (strcmp(attr->name, "printer-info") == 0 &&
+                           attr->value_tag == IPP_TAG_TEXT) {
+                               if (!pull_utf8_talloc(frame,
+                                               &info,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
+
+                       attr = attr->next;
+               }
+
+              /*
+               * See if we have everything needed...
+               */
+
+               if (name == NULL)
+                       break;
+
+               if (!pcap_cache_add_specific(&tmp_pcap_cache, name, info)) {
+                       goto out;
+               }
        }
-       else
-       {
+
+       ret = True;
+
+ out:
+       if (response)
                ippDelete(response);
-               return (1);
+
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       /* Send all the entries up the pipe. */
+       if (tmp_pcap_cache) {
+               pcap_printer_fn_specific(tmp_pcap_cache,
+                               send_pcap_info,
+                               (void *)&fd);
+
+               pcap_cache_destroy_specific(&tmp_pcap_cache);
+       }
+       TALLOC_FREE(frame);
+       return ret;
+}
+
+static struct pcap_cache *local_pcap_copy;
+struct fd_event *cache_fd_event;
+
+static bool cups_pcap_load_async(int *pfd)
+{
+       int fds[2];
+       pid_t pid;
+
+       *pfd = -1;
+
+       if (cache_fd_event) {
+               DEBUG(3,("cups_pcap_load_async: already waiting for "
+                       "a refresh event\n" ));
+               return false;
+       }
+
+       DEBUG(5,("cups_pcap_load_async: asynchronously loading cups printers\n"));
+
+       if (pipe(fds) == -1) {
+               return false;
+       }
+
+       pid = sys_fork();
+       if (pid == (pid_t)-1) {
+               DEBUG(10,("cups_pcap_load_async: fork failed %s\n",
+                       strerror(errno) ));
+               close(fds[0]);
+               close(fds[1]);
+               return false;
+       }
+
+       if (pid) {
+               DEBUG(10,("cups_pcap_load_async: child pid = %u\n",
+                       (unsigned int)pid ));
+               /* Parent. */
+               close(fds[1]);
+               *pfd = fds[0];
+               return true;
+       }
+
+       /* Child. */
+
+       close_all_print_db();
+
+       if (!NT_STATUS_IS_OK(reinit_after_fork(smbd_messaging_context(),
+                                              smbd_event_context(), true))) {
+               DEBUG(0,("cups_pcap_load_async: reinit_after_fork() failed\n"));
+               smb_panic("cups_pcap_load_async: reinit_after_fork() failed");
+       }
+
+       close(fds[0]);
+       cups_cache_reload_async(fds[1]);
+       close(fds[1]);
+       _exit(0);
+}
+
+struct cups_async_cb_args {
+       int pipe_fd;
+       void (*post_cache_fill_fn)(void);
+};
+
+static void cups_async_callback(struct event_context *event_ctx,
+                               struct fd_event *event,
+                               uint16 flags,
+                               void *p)
+{
+       TALLOC_CTX *frame = talloc_stackframe();
+       struct cups_async_cb_args *cb_args = (struct cups_async_cb_args *)p;
+       int fd = cb_args->pipe_fd;
+       struct pcap_cache *tmp_pcap_cache = NULL;
+
+       DEBUG(5,("cups_async_callback: callback received for printer data. "
+               "fd = %d\n", fd));
+
+       while (1) {
+               char *name = NULL, *info = NULL;
+               size_t namelen = 0, infolen = 0;
+               ssize_t ret = -1;
+
+               ret = sys_read(fd, &namelen, sizeof(namelen));
+               if (ret == 0) {
+                       /* EOF */
+                       break;
+               }
+               if (ret != sizeof(namelen)) {
+                       DEBUG(10,("cups_async_callback: namelen read failed %d %s\n",
+                               errno, strerror(errno)));
+                       break;
+               }
+
+               DEBUG(11,("cups_async_callback: read namelen %u\n",
+                       (unsigned int)namelen));
+
+               ret = sys_read(fd, &infolen, sizeof(infolen));
+               if (ret == 0) {
+                       /* EOF */
+                       break;
+               }
+               if (ret != sizeof(infolen)) {
+                       DEBUG(10,("cups_async_callback: infolen read failed %s\n",
+                               strerror(errno)));
+                       break;
+               }
+
+               DEBUG(11,("cups_async_callback: read infolen %u\n",
+                       (unsigned int)infolen));
+
+               if (namelen) {
+                       name = TALLOC_ARRAY(frame, char, namelen);
+                       if (!name) {
+                               break;
+                       }
+                       ret = sys_read(fd, name, namelen);
+                       if (ret == 0) {
+                               /* EOF */
+                               break;
+                       }
+                       if (ret != namelen) {
+                               DEBUG(10,("cups_async_callback: name read failed %s\n",
+                                       strerror(errno)));
+                               break;
+                       }
+                       DEBUG(11,("cups_async_callback: read name %s\n",
+                               name));
+               } else {
+                       name = NULL;
+               }
+               if (infolen) {
+                       info = TALLOC_ARRAY(frame, char, infolen);
+                       if (!info) {
+                               break;
+                       }
+                       ret = sys_read(fd, info, infolen);
+                       if (ret == 0) {
+                               /* EOF */
+                               break;
+                       }
+                       if (ret != infolen) {
+                               DEBUG(10,("cups_async_callback: info read failed %s\n",
+                                       strerror(errno)));
+                               break;
+                       }
+                       DEBUG(11,("cups_async_callback: read info %s\n",
+                               info));
+               } else {
+                       info = NULL;
+               }
+
+               /* Add to our local pcap cache. */
+               pcap_cache_add_specific(&tmp_pcap_cache, name, info);
+               TALLOC_FREE(name);
+               TALLOC_FREE(info);
        }
+
+       TALLOC_FREE(frame);
+       if (tmp_pcap_cache) {
+               /* We got a namelist, replace our local cache. */
+               pcap_cache_destroy_specific(&local_pcap_copy);
+               local_pcap_copy = tmp_pcap_cache;
+
+               /* And the systemwide pcap cache. */
+               pcap_cache_replace(local_pcap_copy);
+
+               /* Caller may have requested post cache fill callback */
+               if (cb_args->post_cache_fill_fn) {
+                       cb_args->post_cache_fill_fn();
+               }
+       } else {
+               DEBUG(2,("cups_async_callback: failed to read a new "
+                       "printer list\n"));
+       }
+       close(fd);
+       TALLOC_FREE(cb_args);
+       TALLOC_FREE(cache_fd_event);
 }
 
+bool cups_cache_reload(void (*post_cache_fill_fn)(void))
+{
+       struct cups_async_cb_args *cb_args;
+       int *p_pipe_fd;
+
+       cb_args = TALLOC_P(NULL, struct cups_async_cb_args);
+       if (!cb_args) {
+               return false;
+       }
+       cb_args->post_cache_fill_fn = post_cache_fill_fn;
+       p_pipe_fd = &cb_args->pipe_fd;
+       *p_pipe_fd = -1;
+
+       /* Set up an async refresh. */
+       if (!cups_pcap_load_async(p_pipe_fd)) {
+               talloc_free(cb_args);
+               return false;
+       }
+       if (!local_pcap_copy) {
+               /* We have no local cache, wait directly for
+                * async refresh to complete.
+                */
+               DEBUG(10,("cups_cache_reload: sync read on fd %d\n",
+                       *p_pipe_fd ));
+
+               cups_async_callback(smbd_event_context(),
+                                       NULL,
+                                       EVENT_FD_READ,
+                                       (void *)cb_args);
+               if (!local_pcap_copy) {
+                       return false;
+               }
+       } else {
+               /* Replace the system cache with our
+                * local copy. */
+               pcap_cache_replace(local_pcap_copy);
+
+               DEBUG(10,("cups_cache_reload: async read on fd %d\n",
+                       *p_pipe_fd ));
+
+               /* Trigger an event when the pipe can be read. */
+               cache_fd_event = event_add_fd(smbd_event_context(),
+                                       NULL, *p_pipe_fd,
+                                       EVENT_FD_READ,
+                                       cups_async_callback,
+                                       (void *)cb_args);
+               if (!cache_fd_event) {
+                       close(*p_pipe_fd);
+                       talloc_free(cb_args);
+                       return false;
+               }
+       }
+       return true;
+}
 
 /*
  * 'cups_job_delete()' - Delete a job.
  */
 
-static int
-cups_job_delete(int snum, struct printjob *pjob)
+static int cups_job_delete(const char *sharename, const char *lprm_command, struct printjob *pjob)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       TALLOC_CTX *frame = talloc_stackframe();
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
+       char *user = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
+       size_t size;
 
-
-       DEBUG(5,("cups_job_delete(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
+       DEBUG(5,("cups_job_delete(%s, %p (%d))\n", sharename, pjob, pjob->sysjob));
 
        /*
         * Make sure we don't ask for passwords...
@@ -331,11 +643,8 @@ cups_job_delete(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect(frame)) == NULL) {
+               goto out;
        }
 
        /*
@@ -356,7 +665,7 @@ cups_job_delete(int snum, struct printjob *pjob)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
@@ -365,32 +674,41 @@ cups_job_delete(int snum, struct printjob *pjob)
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
+
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, cupsUser());
+                    NULL, user);
 
        /*
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to cancel job %d - %s\n", pjob->sysjob,
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to cancel job %d - %s\n", pjob->sysjob,
-                        ippErrorString(cupsLastError())));
-          else
-               ret = 0;
-
-         ippDelete(response);
+                       ippErrorString(cupsLastError())));
        }
-       else
-         DEBUG(0,("Unable to cancel job %d - %s\n", pjob->sysjob,
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
 
-       return (ret);
+       TALLOC_FREE(frame);
+       return ret;
 }
 
 
@@ -398,16 +716,17 @@ cups_job_delete(int snum, struct printjob *pjob)
  * 'cups_job_pause()' - Pause a job.
  */
 
-static int
-cups_job_pause(int snum, struct printjob *pjob)
+static int cups_job_pause(int snum, struct printjob *pjob)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       TALLOC_CTX *frame = talloc_stackframe();
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
+       char *user = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       size_t size;
 
        DEBUG(5,("cups_job_pause(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
 
@@ -421,11 +740,8 @@ cups_job_pause(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect(frame)) == NULL) {
+               goto out;
        }
 
        /*
@@ -446,7 +762,7 @@ cups_job_pause(int snum, struct printjob *pjob)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
@@ -455,32 +771,40 @@ cups_job_pause(int snum, struct printjob *pjob)
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, cupsUser());
+                    NULL, user);
 
        /*
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to hold job %d - %s\n", pjob->sysjob,
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to hold job %d - %s\n", pjob->sysjob,
-                        ippErrorString(cupsLastError())));
-          else
-               ret = 0;
-
-         ippDelete(response);
+                       ippErrorString(cupsLastError())));
        }
-       else
-         DEBUG(0,("Unable to hold job %d - %s\n", pjob->sysjob,
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
 
-       return (ret);
+       TALLOC_FREE(frame);
+       return ret;
 }
 
 
@@ -488,16 +812,17 @@ cups_job_pause(int snum, struct printjob *pjob)
  * 'cups_job_resume()' - Resume a paused job.
  */
 
-static int
-cups_job_resume(int snum, struct printjob *pjob)
+static int cups_job_resume(int snum, struct printjob *pjob)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       TALLOC_CTX *frame = talloc_stackframe();
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
+       char *user = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       size_t size;
 
        DEBUG(5,("cups_job_resume(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
 
@@ -511,11 +836,8 @@ cups_job_resume(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect(frame)) == NULL) {
+               goto out;
        }
 
        /*
@@ -536,7 +858,7 @@ cups_job_resume(int snum, struct printjob *pjob)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
@@ -545,32 +867,40 @@ cups_job_resume(int snum, struct printjob *pjob)
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "job-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, cupsUser());
+                    NULL, user);
 
        /*
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/jobs")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to release job %d - %s\n", pjob->sysjob,
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to release job %d - %s\n", pjob->sysjob,
-                        ippErrorString(cupsLastError())));
-          else
-               ret = 0;
-
-         ippDelete(response);
+                       ippErrorString(cupsLastError())));
        }
-       else
-         DEBUG(0,("Unable to release job %d - %s\n", pjob->sysjob,
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
 
-       return (ret);
+       if (http)
+               httpClose(http);
+
+       TALLOC_FREE(frame);
+       return ret;
 }
 
 
@@ -578,18 +908,30 @@ cups_job_resume(int snum, struct printjob *pjob)
  * 'cups_job_submit()' - Submit a job for printing.
  */
 
-static int
-cups_job_submit(int snum, struct printjob *pjob)
+static int cups_job_submit(int snum, struct printjob *pjob)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       TALLOC_CTX *frame = talloc_stackframe();
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       ipp_attribute_t *attr_job_id = NULL;    /* IPP Attribute "job-id" */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
-
-       DEBUG(5,("cups_job_submit(%d, %p (%d))\n", snum, pjob, pjob->sysjob));
+       const char      *clientname = NULL;     /* hostname of client for job-originating-host attribute */
+       char *new_jobname = NULL;
+       int             num_options = 0;
+       cups_option_t   *options = NULL;
+       char *printername = NULL;
+       char *user = NULL;
+       char *jobname = NULL;
+       char *cupsoptions = NULL;
+       char *filename = NULL;
+       size_t size;
+       uint32_t jobid = (uint32_t)-1;
+       char addr[INET6_ADDRSTRLEN];
+
+       DEBUG(5,("cups_job_submit(%d, %p)\n", snum, pjob));
 
        /*
         * Make sure we don't ask for passwords...
@@ -601,11 +943,8 @@ cups_job_submit(int snum, struct printjob *pjob)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect(frame)) == NULL) {
+               goto out;
        }
 
        /*
@@ -627,75 +966,148 @@ cups_job_submit(int snum, struct printjob *pjob)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
+       if (!push_utf8_talloc(frame, &printername, PRINTERNAME(snum), &size)) {
+               goto out;
+       }
        slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+                printername);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
                     "printer-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &user, pjob->user, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, cupsUser());
+                    NULL, user);
+
+       clientname = client_name(get_client_fd());
+       if (strcmp(clientname, "UNKNOWN") == 0) {
+               clientname = client_addr(get_client_fd(),addr,sizeof(addr));
+       }
+
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
+                    "job-originating-host-name", NULL,
+                     clientname);
+
+       /* Get the jobid from the filename. */
+       jobid = print_parse_jobid(pjob->filename);
+       if (jobid == (uint32_t)-1) {
+               DEBUG(0,("cups_job_submit: failed to parse jobid from name %s\n",
+                               pjob->filename ));
+               jobid = 0;
+       }
+
+       if (!push_utf8_talloc(frame, &jobname, pjob->jobname, &size)) {
+               goto out;
+       }
+       new_jobname = talloc_asprintf(frame,
+                       "%s%.8u %s", PRINT_SPOOL_PREFIX,
+                       (unsigned int)jobid,
+                       jobname);
+       if (new_jobname == NULL) {
+               goto out;
+       }
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "job-name", NULL,
-                    pjob->jobname);
+                    new_jobname);
+
+       /*
+        * add any options defined in smb.conf
+        */
+
+       if (!push_utf8_talloc(frame, &cupsoptions, lp_cups_options(snum), &size)) {
+               goto out;
+       }
+       num_options = 0;
+       options     = NULL;
+       num_options = cupsParseOptions(cupsoptions, num_options, &options);
+
+       if ( num_options )
+               cupsEncodeOptions(request, num_options, options);
 
        /*
        * Do the request and get back a response...
        */
 
-       slprintf(uri, sizeof(uri) - 1, "/printers/%s", PRINTERNAME(snum));
+       slprintf(uri, sizeof(uri) - 1, "/printers/%s", printername);
 
-        ret = 1;
-       if ((response = cupsDoFileRequest(http, request, uri,
-                                         pjob->filename)) != NULL)
-       {
-               if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if (!push_utf8_talloc(frame, &filename, pjob->filename, &size)) {
+               goto out;
+       }
+       if ((response = cupsDoFileRequest(http, request, uri, pjob->filename)) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
                        DEBUG(0,("Unable to print file to %s - %s\n", PRINTERNAME(snum),
                                 ippErrorString(cupsLastError())));
-               else
+               } else {
                        ret = 0;
-
-               ippDelete(response);
-       }
-       else
+                       attr_job_id = ippFindAttribute(response, "job-id", IPP_TAG_INTEGER);
+                       if(attr_job_id) {
+                               pjob->sysjob = attr_job_id->values[0].integer;
+                               DEBUG(5,("cups_job_submit: job-id %d\n", pjob->sysjob));
+                       } else {
+                               DEBUG(0,("Missing job-id attribute in IPP response"));
+                       }
+               }
+       } else {
                DEBUG(0,("Unable to print file to `%s' - %s\n", PRINTERNAME(snum),
                         ippErrorString(cupsLastError())));
+       }
 
-       httpClose(http);
+       if ( ret == 0 )
+               unlink(pjob->filename);
+       /* else print_job_end will do it for us */
 
-       return (ret);
-}
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
 
+       if (http)
+               httpClose(http);
+
+       TALLOC_FREE(frame);
+
+       return ret;
+}
 
 /*
  * 'cups_queue_get()' - Get all the jobs in the print queue.
  */
 
-static int
-cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
+static int cups_queue_get(const char *sharename,
+               enum printing_types printing_type,
+               char *lpq_command,
+               print_queue_struct **q,
+               print_status_struct *status)
 {
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       ipp_attribute_t *attr;          /* Current attribute */
-       cups_lang_t     *language;      /* Default language */
+       TALLOC_CTX *frame = talloc_stackframe();
+       char *printername = NULL;
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       ipp_attribute_t *attr = NULL;           /* Current attribute */
+       cups_lang_t     *language = NULL;       /* Default language */
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-       int             qcount,         /* Number of active queue entries */
-                       qalloc;         /* Number of queue entries allocated */
-       print_queue_struct *queue,      /* Queue entries */
+       int             qcount = 0,             /* Number of active queue entries */
+                       qalloc = 0;             /* Number of queue entries allocated */
+       print_queue_struct *queue = NULL,       /* Queue entries */
                        *temp;          /* Temporary pointer for queue */
-       const char      *user_name,     /* job-originating-user-name attribute */
-                       *job_name;      /* job-name attribute */
+       char            *user_name = NULL,      /* job-originating-user-name attribute */
+                       *job_name = NULL;       /* job-name attribute */
        int             job_id;         /* job-id attribute */
        int             job_k_octets;   /* job-k-octets attribute */
        time_t          job_time;       /* time-at-creation attribute */
        ipp_jstate_t    job_status;     /* job-status attribute */
        int             job_priority;   /* job-priority attribute */
+       size_t size;
        static const char *jattrs[] =   /* Requested job attributes */
                        {
                          "job-id",
@@ -712,8 +1124,18 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                          "printer-state-message"
                        };
 
+       *q = NULL;
 
-       DEBUG(5,("cups_queue_get(%d, %p, %p)\n", snum, q, status));
+       /* HACK ALERT!!!  The problem with support the 'printer name'
+          option is that we key the tdb off the sharename.  So we will
+          overload the lpq_command string to pass in the printername
+          (which is basically what we do for non-cups printers ... using
+          the lpq_command to get the queue listing). */
+
+       if (!push_utf8_talloc(frame, &printername, lpq_command, &size)) {
+               goto out;
+       }
+       DEBUG(5,("cups_queue_get(%s, %p, %p)\n", lpq_command, q, status));
 
        /*
         * Make sure we don't ask for passwords...
@@ -725,19 +1147,15 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (0);
+       if ((http = cups_connect(frame)) == NULL) {
+               goto out;
        }
 
        /*
         * Generate the printer URI...
        */
 
-       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+       slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s", printername);
 
        /*
        * Build an IPP_GET_JOBS request, which requires the following
@@ -757,7 +1175,7 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -774,22 +1192,16 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        * Do the request and get back a response...
        */
 
-       if ((response = cupsDoRequest(http, request, "/")) == NULL)
-       {
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
                DEBUG(0,("Unable to get jobs for %s - %s\n", uri,
                         ippErrorString(cupsLastError())));
-               httpClose(http);
-               return (0);
+               goto out;
        }
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT)
-       {
+       if (response->request.status.status_code >= IPP_OK_CONFLICT) {
                DEBUG(0,("Unable to get jobs for %s - %s\n", uri,
                         ippErrorString(response->request.status.status_code)));
-               ippDelete(response);
-               httpClose(http);
-
-               return (0);
+               goto out;
        }
 
        /*
@@ -800,8 +1212,7 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        qalloc = 0;
        queue  = NULL;
 
-        for (attr = response->attrs; attr != NULL; attr = attr->next)
-       {
+        for (attr = response->attrs; attr != NULL; attr = attr->next) {
               /*
                * Skip leading attributes until we hit a job...
                */
@@ -815,24 +1226,16 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
               /*
                * Allocate memory as needed...
                */
-               if (qcount >= qalloc)
-               {
+               if (qcount >= qalloc) {
                        qalloc += 16;
 
-                       if (qalloc == 16)
-                               temp = malloc(sizeof(print_queue_struct) * qalloc);
-                       else
-                               temp = realloc(queue, sizeof(print_queue_struct) * qalloc);
-
-                       if (temp == NULL)
-                       {
-                               ippDelete(response);
-                               httpClose(http);
+                       queue = SMB_REALLOC_ARRAY(queue, print_queue_struct, qalloc);
 
-                               return (qcount);
+                       if (queue == NULL) {
+                               DEBUG(0,("cups_queue_get: Not enough memory!"));
+                               qcount = 0;
+                               goto out;
                        }
-
-                       queue = temp;
                }
 
                temp = queue + qcount;
@@ -850,10 +1253,8 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                user_name    = NULL;
                job_name     = NULL;
 
-               while (attr != NULL && attr->group_tag == IPP_TAG_JOB)
-               {
-                       if (attr->name == NULL)
-                       {
+               while (attr != NULL && attr->group_tag == IPP_TAG_JOB) {
+                       if (attr->name == NULL) {
                                attr = attr->next;
                                break;
                        }
@@ -879,12 +1280,24 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                                job_time = attr->values[0].integer;
 
                        if (strcmp(attr->name, "job-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               job_name = attr->values[0].string.text;
+                           attr->value_tag == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(frame,
+                                               &job_name,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
 
                        if (strcmp(attr->name, "job-originating-user-name") == 0 &&
-                           attr->value_tag == IPP_TAG_NAME)
-                               user_name = attr->values[0].string.text;
+                           attr->value_tag == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(frame,
+                                               &user_name,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
 
                        attr = attr->next;
                }
@@ -893,12 +1306,11 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                * See if we have everything needed...
                */
 
-               if (user_name == NULL || job_name == NULL || job_id == 0)
-               {
-                 if (attr == NULL)
-                   break;
-                 else
-                   continue;
+               if (user_name == NULL || job_name == NULL || job_id == 0) {
+                       if (attr == NULL)
+                               break;
+                       else
+                               continue;
                }
 
                temp->job      = job_id;
@@ -909,16 +1321,17 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
                                 LPQ_PRINTING;
                temp->priority = job_priority;
                temp->time     = job_time;
-               strncpy(temp->user, user_name, sizeof(temp->user) - 1);
-               strncpy(temp->file, job_name, sizeof(temp->file) - 1);
+               strlcpy(temp->fs_user, user_name, sizeof(temp->fs_user));
+               strlcpy(temp->fs_file, job_name, sizeof(temp->fs_file));
 
                qcount ++;
 
                if (attr == NULL)
-                 break;
+                       break;
        }
 
        ippDelete(response);
+       response = NULL;
 
        /*
        * Build an IPP_GET_PRINTER_ATTRIBUTES request, which requires the
@@ -935,10 +1348,8 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
        request->request.op.request_id   = 1;
 
-       language = cupsLangDefault();
-
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                     "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                      "attributes-natural-language", NULL, language->language);
@@ -955,30 +1366,25 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        * Do the request and get back a response...
        */
 
-       if ((response = cupsDoRequest(http, request, "/")) == NULL)
-       {
-               DEBUG(0,("Unable to get printer status for %s - %s\n", PRINTERNAME(snum),
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
+               DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
                         ippErrorString(cupsLastError())));
-               httpClose(http);
-               return (qcount);
+               *q = queue;
+               goto out;
        }
 
-       if (response->request.status.status_code >= IPP_OK_CONFLICT)
-       {
-               DEBUG(0,("Unable to get printer status for %s - %s\n", PRINTERNAME(snum),
+       if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+               DEBUG(0,("Unable to get printer status for %s - %s\n", printername,
                         ippErrorString(response->request.status.status_code)));
-               ippDelete(response);
-               httpClose(http);
-
-               return (qcount);
+               *q = queue;
+               goto out;
        }
 
        /*
         * Get the current printer status and convert it to the SAMBA values.
        */
 
-        if ((attr = ippFindAttribute(response, "printer-state", IPP_TAG_ENUM)) != NULL)
-       {
+        if ((attr = ippFindAttribute(response, "printer-state", IPP_TAG_ENUM)) != NULL) {
                if (attr->values[0].integer == IPP_PRINTER_STOPPED)
                        status->status = LPSTAT_STOPPED;
                else
@@ -986,19 +1392,36 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
        }
 
         if ((attr = ippFindAttribute(response, "printer-state-message",
-                                    IPP_TAG_TEXT)) != NULL)
-               fstrcpy(status->message, attr->values[0].string.text);
-
-        ippDelete(response);
+                                    IPP_TAG_TEXT)) != NULL) {
+               char *msg = NULL;
+               if (!pull_utf8_talloc(frame, &msg,
+                               attr->values[0].string.text,
+                               &size)) {
+                       SAFE_FREE(queue);
+                       qcount = 0;
+                       goto out;
+               }
+               fstrcpy(status->message, msg);
+       }
 
        /*
         * Return the job queue...
        */
 
-       httpClose(http);
-
        *q = queue;
-       return (qcount);
+
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       TALLOC_FREE(frame);
+       return qcount;
 }
 
 
@@ -1006,45 +1429,44 @@ cups_queue_get(int snum, print_queue_struct **q, print_status_struct *status)
  * 'cups_queue_pause()' - Pause a print queue.
  */
 
-static int
-cups_queue_pause(int snum)
+static int cups_queue_pause(int snum)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       TALLOC_CTX *frame = talloc_stackframe();
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
+       char *printername = NULL;
+       char *username = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       size_t size;
 
        DEBUG(5,("cups_queue_pause(%d)\n", snum));
 
-       /*
-        * Make sure we don't ask for passwords...
-       */
+       /*
+        * Make sure we don't ask for passwords...
+        */
 
         cupsSetPasswordCB(cups_passwd_cb);
 
-       /*
-       * Try to connect to the server...
-       */
+       /*
+        * Try to connect to the server...
+        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect(frame)) == NULL) {
+               goto out;
        }
 
-       /*
-       * Build an IPP_PAUSE_PRINTER request, which requires the following
-       * attributes:
-       *
-       *    attributes-charset
-       *    attributes-natural-language
-       *    printer-uri
-       *    requesting-user-name
-       */
+       /*
+        * Build an IPP_PAUSE_PRINTER request, which requires the following
+        * attributes:
+        *
+        *    attributes-charset
+        *    attributes-natural-language
+        *    printer-uri
+        *    requesting-user-name
+        */
 
        request = ippNew();
 
@@ -1054,42 +1476,53 @@ cups_queue_pause(int snum)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
+       if (!push_utf8_talloc(frame, &printername, PRINTERNAME(snum), &size)) {
+               goto out;
+       }
        slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+                printername);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &username, current_user_info.unix_name, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, cupsUser());
+                    NULL, username);
 
        /*
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/admin")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
-                        ippErrorString(cupsLastError())));
-          else
-               ret = 0;
-
-         ippDelete(response);
+                       ippErrorString(cupsLastError())));
        }
-       else
-         DEBUG(0,("Unable to pause printer %s - %s\n", PRINTERNAME(snum),
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
 
-       return (ret);
+       if (http)
+               httpClose(http);
+
+       TALLOC_FREE(frame);
+       return ret;
 }
 
 
@@ -1097,16 +1530,18 @@ cups_queue_pause(int snum)
  * 'cups_queue_resume()' - Restart a print queue.
  */
 
-static int
-cups_queue_resume(int snum)
+static int cups_queue_resume(int snum)
 {
-       int             ret;            /* Return value */
-       http_t          *http;          /* HTTP connection to server */
-       ipp_t           *request,       /* IPP Request */
-                       *response;      /* IPP Response */
-       cups_lang_t     *language;      /* Default language */
+       TALLOC_CTX *frame = talloc_stackframe();
+       int             ret = 1;                /* Return value */
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       cups_lang_t     *language = NULL;       /* Default language */
+       char *printername = NULL;
+       char *username = NULL;
        char            uri[HTTP_MAX_URI]; /* printer-uri attribute */
-
+       size_t size;
 
        DEBUG(5,("cups_queue_resume(%d)\n", snum));
 
@@ -1120,11 +1555,8 @@ cups_queue_resume(int snum)
        * Try to connect to the server...
        */
 
-       if ((http = httpConnect(cupsServer(), ippPort())) == NULL)
-       {
-               DEBUG(0,("Unable to connect to CUPS server %s - %s\n", 
-                        cupsServer(), strerror(errno)));
-               return (1);
+       if ((http = cups_connect(frame)) == NULL) {
+               goto out;
        }
 
        /*
@@ -1145,46 +1577,252 @@ cups_queue_resume(int snum)
        language = cupsLangDefault();
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
-                    "attributes-charset", NULL, cupsLangEncoding(language));
+                     "attributes-charset", NULL, "utf-8");
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
                     "attributes-natural-language", NULL, language->language);
 
+       if (!push_utf8_talloc(frame, &printername, PRINTERNAME(snum), &size)) {
+               goto out;
+       }
        slprintf(uri, sizeof(uri) - 1, "ipp://localhost/printers/%s",
-                PRINTERNAME(snum));
+                printername);
 
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI, "printer-uri", NULL, uri);
 
+       if (!push_utf8_talloc(frame, &username, current_user_info.unix_name, &size)) {
+               goto out;
+       }
        ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_NAME, "requesting-user-name",
-                    NULL, cupsUser());
+                    NULL, username);
 
        /*
        * Do the request and get back a response...
        */
 
-        ret = 1;
-
-       if ((response = cupsDoRequest(http, request, "/admin")) != NULL)
-       {
-         if (response->request.status.status_code >= IPP_OK_CONFLICT)
+       if ((response = cupsDoRequest(http, request, "/admin/")) != NULL) {
+               if (response->request.status.status_code >= IPP_OK_CONFLICT) {
+                       DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+                               ippErrorString(cupsLastError())));
+               } else {
+                       ret = 0;
+               }
+       } else {
                DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
+                       ippErrorString(cupsLastError())));
+       }
+
+ out:
+       if (response)
+               ippDelete(response);
+
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       TALLOC_FREE(frame);
+       return ret;
+}
+
+/*******************************************************************
+ * CUPS printing interface definitions...
+ ******************************************************************/
+
+struct printif cups_printif =
+{
+       PRINT_CUPS,
+       cups_queue_get,
+       cups_queue_pause,
+       cups_queue_resume,
+       cups_job_delete,
+       cups_job_pause,
+       cups_job_resume,
+       cups_job_submit,
+};
+
+bool cups_pull_comment_location(NT_PRINTER_INFO_LEVEL_2 *printer)
+{
+       TALLOC_CTX *frame = talloc_stackframe();
+       http_t          *http = NULL;           /* HTTP connection to server */
+       ipp_t           *request = NULL,        /* IPP Request */
+                       *response = NULL;       /* IPP Response */
+       ipp_attribute_t *attr;          /* Current attribute */
+       cups_lang_t     *language = NULL;       /* Default language */
+       char            uri[HTTP_MAX_URI];
+       char *server = NULL;
+       char *sharename = NULL;
+       char *name = NULL;
+       static const char *requested[] =/* Requested attributes */
+                       {
+                         "printer-name",
+                         "printer-info",
+                         "printer-location"
+                       };
+       bool ret = False;
+       size_t size;
+
+       DEBUG(5, ("pulling %s location\n", printer->sharename));
+
+       /*
+        * Make sure we don't ask for passwords...
+        */
+
+        cupsSetPasswordCB(cups_passwd_cb);
+
+       /*
+        * Try to connect to the server...
+        */
+
+       if ((http = cups_connect(frame)) == NULL) {
+               goto out;
+       }
+
+       request = ippNew();
+
+       request->request.op.operation_id = IPP_GET_PRINTER_ATTRIBUTES;
+       request->request.op.request_id   = 1;
+
+       language = cupsLangDefault();
+
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_CHARSET,
+                     "attributes-charset", NULL, "utf-8");
+
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_LANGUAGE,
+                     "attributes-natural-language", NULL, language->language);
+
+       if (lp_cups_server() != NULL && strlen(lp_cups_server()) > 0) {
+               if (!push_utf8_talloc(frame, &server, lp_cups_server(), &size)) {
+                       goto out;
+               }
+       } else {
+               server = talloc_strdup(frame,cupsServer());
+       }
+       if (server) {
+               goto out;
+       }
+       if (!push_utf8_talloc(frame, &sharename, printer->sharename, &size)) {
+               goto out;
+       }
+       slprintf(uri, sizeof(uri) - 1, "ipp://%s/printers/%s",
+                server, sharename);
+
+       ippAddString(request, IPP_TAG_OPERATION, IPP_TAG_URI,
+                     "printer-uri", NULL, uri);
+
+        ippAddStrings(request, IPP_TAG_OPERATION, IPP_TAG_NAME,
+                     "requested-attributes",
+                     (sizeof(requested) / sizeof(requested[0])),
+                     NULL, requested);
+
+       /*
+        * Do the request and get back a response...
+        */
+
+       if ((response = cupsDoRequest(http, request, "/")) == NULL) {
+               DEBUG(0,("Unable to get printer attributes - %s\n",
                         ippErrorString(cupsLastError())));
-          else
-               ret = 0;
+               goto out;
+       }
+
+       for (attr = response->attrs; attr != NULL;) {
+               /*
+                * Skip leading attributes until we hit a printer...
+                */
+
+               while (attr != NULL && attr->group_tag != IPP_TAG_PRINTER)
+                       attr = attr->next;
 
-         ippDelete(response);
+               if (attr == NULL)
+                       break;
+
+               /*
+                * Pull the needed attributes from this printer...
+                */
+
+               while ( attr && (attr->group_tag == IPP_TAG_PRINTER) ) {
+                       if (strcmp(attr->name, "printer-name") == 0 &&
+                           attr->value_tag == IPP_TAG_NAME) {
+                               if (!pull_utf8_talloc(frame,
+                                               &name,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                       }
+
+                       /* Grab the comment if we don't have one */
+                       if ( (strcmp(attr->name, "printer-info") == 0)
+                            && (attr->value_tag == IPP_TAG_TEXT)
+                            && !strlen(printer->comment) )
+                       {
+                               char *comment = NULL;
+                               if (!pull_utf8_talloc(frame,
+                                               &comment,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                               DEBUG(5,("cups_pull_comment_location: Using cups comment: %s\n",
+                                        comment));
+                               strlcpy(printer->comment,
+                                       comment,
+                                       sizeof(printer->comment));
+                       }
+
+                       /* Grab the location if we don't have one */
+                       if ( (strcmp(attr->name, "printer-location") == 0)
+                            && (attr->value_tag == IPP_TAG_TEXT)
+                            && !strlen(printer->location) )
+                       {
+                               char *location = NULL;
+                               if (!pull_utf8_talloc(frame,
+                                               &location,
+                                               attr->values[0].string.text,
+                                               &size)) {
+                                       goto out;
+                               }
+                               DEBUG(5,("cups_pull_comment_location: Using cups location: %s\n",
+                                        location));
+                               strlcpy(printer->location,
+                                       location,
+                                       sizeof(printer->location));
+                       }
+
+                       attr = attr->next;
+               }
+
+               /*
+                * We have everything needed...
+                */
+
+               if (name != NULL)
+                       break;
        }
-       else
-         DEBUG(0,("Unable to resume printer %s - %s\n", PRINTERNAME(snum),
-                  ippErrorString(cupsLastError())));
 
-       httpClose(http);
+       ret = True;
 
-       return (ret);
-}
+ out:
+       if (response)
+               ippDelete(response);
 
+       if (request) {
+               ippDelete(request);
+       }
+
+       if (language)
+               cupsLangFree(language);
+
+       if (http)
+               httpClose(http);
+
+       TALLOC_FREE(frame);
+       return ret;
+}
 
 #else
  /* this keeps fussy compilers happy */
+ void print_cups_dummy(void);
  void print_cups_dummy(void) {}
-#endif /* HAVE_LIBCUPS */
+#endif /* HAVE_CUPS */