s3:smbd/close: use talloc_get_type_abort() as private_data can't be NULL
[kai/samba.git] / source3 / smbd / close.c
index a6610e58f1cf6ba6f144ba669ce2f2535bea57f6..9eedaf9e66bdd2ad81d0a6f506cef45200a5534b 100644 (file)
 */
 
 #include "includes.h"
+#include "system/filesys.h"
 #include "printing.h"
-#include "librpc/gen_ndr/messaging.h"
+#include "smbd/smbd.h"
 #include "smbd/globals.h"
 #include "fake_file.h"
+#include "transfer_file.h"
+#include "auth.h"
+#include "messages.h"
+#include "../librpc/gen_ndr/open_files.h"
 
 /****************************************************************************
  Run a file if it is a magic script.
@@ -155,7 +160,7 @@ static NTSTATUS close_filestruct(files_struct *fsp)
  If any deferred opens are waiting on this close, notify them.
 ****************************************************************************/
 
-static void notify_deferred_opens(struct messaging_context *msg_ctx,
+static void notify_deferred_opens(struct smbd_server_connection *sconn,
                                  struct share_mode_lock *lck)
 {
        int i;
@@ -163,14 +168,14 @@ static void notify_deferred_opens(struct messaging_context *msg_ctx,
        if (!should_notify_deferred_opens()) {
                return;
        }
+
        for (i=0; i<lck->num_share_modes; i++) {
                struct share_mode_entry *e = &lck->share_modes[i];
+
                if (!is_deferred_open_entry(e)) {
                        continue;
                }
+
                if (procid_is_me(&e->pid)) {
                        /*
                         * We need to notify ourself to retry the open.  Do
@@ -178,13 +183,14 @@ static void notify_deferred_opens(struct messaging_context *msg_ctx,
                         * the head of the queue and changing the wait time to
                         * zero.
                         */
-                       schedule_deferred_open_message_smb(e->op_mid);
+                       schedule_deferred_open_message_smb(sconn, e->op_mid);
                } else {
                        char msg[MSG_SMB_SHARE_MODE_ENTRY_SIZE];
 
                        share_mode_entry_to_message(msg, e);
 
-                       messaging_send_buf(msg_ctx, e->pid, MSG_SMB_OPEN_RETRY,
+                       messaging_send_buf(sconn->msg_ctx, e->pid,
+                                          MSG_SMB_OPEN_RETRY,
                                           (uint8 *)msg,
                                           MSG_SMB_SHARE_MODE_ENTRY_SIZE);
                }
@@ -197,14 +203,14 @@ static void notify_deferred_opens(struct messaging_context *msg_ctx,
 
 NTSTATUS delete_all_streams(connection_struct *conn, const char *fname)
 {
-       struct stream_struct *stream_info;
+       struct stream_struct *stream_info = NULL;
        int i;
-       unsigned int num_streams;
+       unsigned int num_streams = 0;
        TALLOC_CTX *frame = talloc_stackframe();
        NTSTATUS status;
 
-       status = SMB_VFS_STREAMINFO(conn, NULL, fname, talloc_tos(),
-                                   &num_streams, &stream_info);
+       status = vfs_streaminfo(conn, NULL, fname, talloc_tos(),
+                               &num_streams, &stream_info);
 
        if (NT_STATUS_EQUAL(status, NT_STATUS_NOT_IMPLEMENTED)) {
                DEBUG(10, ("no streams around\n"));
@@ -213,7 +219,7 @@ NTSTATUS delete_all_streams(connection_struct *conn, const char *fname)
        }
 
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(10, ("SMB_VFS_STREAMINFO failed: %s\n",
+               DEBUG(10, ("vfs_streaminfo failed: %s\n",
                           nt_errstr(status)));
                goto fail;
        }
@@ -275,10 +281,11 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
        NTSTATUS status = NT_STATUS_OK;
        NTSTATUS tmp_status;
        struct file_id id;
+       const struct security_unix_token *del_token = NULL;
 
        /* Ensure any pending write time updates are done. */
        if (fsp->update_write_time_event) {
-               update_write_time_handler(smbd_event_context(),
+               update_write_time_handler(fsp->conn->sconn->ev_ctx,
                                        fsp->update_write_time_event,
                                        timeval_current(),
                                        (void *)fsp);
@@ -328,7 +335,8 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
                          fsp_str_dbg(fsp)));
        }
 
-       if (fsp->initial_delete_on_close && (lck->delete_token == NULL)) {
+       if (fsp->initial_delete_on_close &&
+                       !is_delete_on_close_set(lck, fsp->name_hash)) {
                bool became_user = False;
 
                /* Initial delete on close was set and no one else
@@ -339,21 +347,23 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
                        became_user = True;
                }
                fsp->delete_on_close = true;
-               set_delete_on_close_lck(lck, True, get_current_utok(conn));
+               set_delete_on_close_lck(fsp, lck, True, get_current_utok(conn));
                if (became_user) {
                        unbecome_user();
                }
        }
 
-       delete_file = lck->delete_on_close;
+       delete_file = is_delete_on_close_set(lck, fsp->name_hash);
 
        if (delete_file) {
                int i;
-               /* See if others still have the file open. If this is the
-                * case, then don't delete. If all opens are POSIX delete now. */
+               /* See if others still have the file open via this pathname.
+                  If this is the case, then don't delete. If all opens are
+                  POSIX delete now. */
                for (i=0; i<lck->num_share_modes; i++) {
                        struct share_mode_entry *e = &lck->share_modes[i];
-                       if (is_valid_share_mode_entry(e)) {
+                       if (is_valid_share_mode_entry(e) &&
+                                       e->name_hash == fsp->name_hash) {
                                if (fsp->posix_open && (e->flags & SHARE_MODE_FLAG_POSIX_OPEN)) {
                                        continue;
                                }
@@ -364,7 +374,7 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
        }
 
        /* Notify any deferred opens waiting on this close. */
-       notify_deferred_opens(conn->sconn->msg_ctx, lck);
+       notify_deferred_opens(conn->sconn, lck);
        reply_to_oplock_break_requests(fsp);
 
        /*
@@ -372,9 +382,8 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
         * reference to a file.
         */
 
-       if (!(close_type == NORMAL_CLOSE || close_type == SHUTDOWN_CLOSE)
-           || !delete_file
-           || (lck->delete_token == NULL)) {
+       if (!(close_type == NORMAL_CLOSE || close_type == SHUTDOWN_CLOSE) ||
+                       !delete_file) {
                TALLOC_FREE(lck);
                return NT_STATUS_OK;
        }
@@ -391,23 +400,26 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
         */
        fsp->update_write_time_on_close = false;
 
-       if (!unix_token_equal(lck->delete_token, get_current_utok(conn))) {
+       del_token = get_delete_on_close_token(lck, fsp->name_hash);
+       SMB_ASSERT(del_token != NULL);
+
+       if (!unix_token_equal(del_token, get_current_utok(conn))) {
                /* Become the user who requested the delete. */
 
                DEBUG(5,("close_remove_share_mode: file %s. "
                        "Change user to uid %u\n",
                        fsp_str_dbg(fsp),
-                       (unsigned int)lck->delete_token->uid));
+                       (unsigned int)del_token->uid));
 
                if (!push_sec_ctx()) {
                        smb_panic("close_remove_share_mode: file %s. failed to push "
                                  "sec_ctx.\n");
                }
 
-               set_sec_ctx(lck->delete_token->uid,
-                           lck->delete_token->gid,
-                           lck->delete_token->ngroups,
-                           lck->delete_token->groups,
+               set_sec_ctx(del_token->uid,
+                           del_token->gid,
+                           del_token->ngroups,
+                           del_token->groups,
                            NULL);
 
                changed_user = true;
@@ -481,7 +493,7 @@ static NTSTATUS close_remove_share_mode(files_struct *fsp,
         */
 
        fsp->delete_on_close = false;
-       set_delete_on_close_lck(lck, False, NULL);
+       set_delete_on_close_lck(fsp, lck, false, NULL);
 
  done:
 
@@ -566,8 +578,14 @@ static NTSTATUS update_write_time_on_close(struct files_struct *fsp)
        }
 
        ft.mtime = fsp->close_write_time;
+       /* As this is a close based update, we are not directly changing the
+          file attributes from a client call, but indirectly from a write. */
        status = smb_set_file_time(fsp->conn, fsp, fsp->fsp_name, &ft, false);
        if (!NT_STATUS_IS_OK(status)) {
+               DEBUG(10,("update_write_time_on_close: smb_set_file_time "
+                       "on file %s returned %s\n",
+                       fsp_str_dbg(fsp),
+                       nt_errstr(status)));
                return status;
        }
 
@@ -668,7 +686,7 @@ static NTSTATUS close_normal_file(struct smb_request *req, files_struct *fsp,
        status = ntstatus_keeperror(status, tmp);
 
        DEBUG(2,("%s closed file %s (numopen=%d) %s\n",
-               conn->server_info->unix_name, fsp_str_dbg(fsp),
+               conn->session_info->unix_info->unix_name, fsp_str_dbg(fsp),
                conn->num_files_open - 1,
                nt_errstr(status) ));
 
@@ -944,6 +962,7 @@ static NTSTATUS close_directory(struct smb_request *req, files_struct *fsp,
        bool delete_dir = False;
        NTSTATUS status = NT_STATUS_OK;
        NTSTATUS status1 = NT_STATUS_OK;
+       const struct security_unix_token *del_token = NULL;
 
        /*
         * NT can set delete_on_close of the last open
@@ -978,14 +997,16 @@ static NTSTATUS close_directory(struct smb_request *req, files_struct *fsp,
                }
                send_stat_cache_delete_message(fsp->conn->sconn->msg_ctx,
                                               fsp->fsp_name->base_name);
-               set_delete_on_close_lck(lck, True, get_current_utok(fsp->conn));
+               set_delete_on_close_lck(fsp, lck, true,
+                               get_current_utok(fsp->conn));
                fsp->delete_on_close = true;
                if (became_user) {
                        unbecome_user();
                }
        }
 
-       delete_dir = lck->delete_on_close;
+       del_token = get_delete_on_close_token(lck, fsp->name_hash);
+       delete_dir = (del_token != NULL);
 
        if (delete_dir) {
                int i;
@@ -993,7 +1014,8 @@ static NTSTATUS close_directory(struct smb_request *req, files_struct *fsp,
                 * case, then don't delete. If all opens are POSIX delete now. */
                for (i=0; i<lck->num_share_modes; i++) {
                        struct share_mode_entry *e = &lck->share_modes[i];
-                       if (is_valid_share_mode_entry(e)) {
+                       if (is_valid_share_mode_entry(e) &&
+                                       e->name_hash == fsp->name_hash) {
                                if (fsp->posix_open && (e->flags & SHARE_MODE_FLAG_POSIX_OPEN)) {
                                        continue;
                                }
@@ -1004,8 +1026,7 @@ static NTSTATUS close_directory(struct smb_request *req, files_struct *fsp,
        }
 
        if ((close_type == NORMAL_CLOSE || close_type == SHUTDOWN_CLOSE) &&
-                               delete_dir &&
-                               lck->delete_token) {
+                               delete_dir) {
        
                /* Become the user who requested the delete. */
 
@@ -1013,10 +1034,10 @@ static NTSTATUS close_directory(struct smb_request *req, files_struct *fsp,
                        smb_panic("close_directory: failed to push sec_ctx.\n");
                }
 
-               set_sec_ctx(lck->delete_token->uid,
-                               lck->delete_token->gid,
-                               lck->delete_token->ngroups,
-                               lck->delete_token->groups,
+               set_sec_ctx(del_token->uid,
+                               del_token->gid,
+                               del_token->ngroups,
+                               del_token->groups,
                                NULL);
 
                TALLOC_FREE(lck);
@@ -1052,10 +1073,6 @@ static NTSTATUS close_directory(struct smb_request *req, files_struct *fsp,
                          strerror(errno)));
        }
 
-       if (fsp->dptr) {
-               dptr_CloseDir(fsp->dptr);
-       }
-
        /*
         * Do the code common to files and directories.
         */
@@ -1117,15 +1134,11 @@ void msg_close_file(struct messaging_context *msg_ctx,
                        struct server_id server_id,
                        DATA_BLOB *data)
 {
-       struct smbd_server_connection *sconn;
        files_struct *fsp = NULL;
        struct share_mode_entry e;
-
-       sconn = msg_ctx_to_sconn(msg_ctx);
-       if (sconn == NULL) {
-               DEBUG(1, ("could not find sconn\n"));
-               return;
-       }
+       struct smbd_server_connection *sconn =
+               talloc_get_type_abort(private_data,
+               struct smbd_server_connection);
 
        message_to_share_mode_entry(&e, (char *)data->data);