s3:auth Remove NT_USER_TOKEN
[abartlet/samba.git/.git] / source3 / smbd / open.c
index e01350f2bf32a8da6956afd55159f0b013eeb86f..e9f0e6cd4f68415bed28f4ec32e4de4ad338c836 100644 (file)
 */
 
 #include "includes.h"
+#include "printing.h"
 #include "smbd/globals.h"
+#include "fake_file.h"
+#include "librpc/gen_ndr/messaging.h"
+#include "../librpc/gen_ndr/ndr_security.h"
 
 extern const struct generic_mapping file_generic_mapping;
 
 struct deferred_open_record {
-       bool delayed_for_oplocks;
-       struct file_id id;
+        bool delayed_for_oplocks;
+        struct file_id id;
 };
 
 static NTSTATUS create_file_unixpath(connection_struct *conn,
@@ -39,6 +43,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                                     uint32_t file_attributes,
                                     uint32_t oplock_request,
                                     uint64_t allocation_size,
+                                    uint32_t private_flags,
                                     struct security_descriptor *sd,
                                     struct ea_list *ea_list,
 
@@ -49,11 +54,23 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
  SMB1 file varient of se_access_check. Never test FILE_READ_ATTRIBUTES.
 ****************************************************************************/
 
-NTSTATUS smb1_file_se_access_check(const struct security_descriptor *sd,
-                          const NT_USER_TOKEN *token,
-                          uint32_t access_desired,
-                          uint32_t *access_granted)
+NTSTATUS smb1_file_se_access_check(struct connection_struct *conn,
+                               const struct security_descriptor *sd,
+                               const struct security_token *token,
+                               uint32_t access_desired,
+                               uint32_t *access_granted)
 {
+       *access_granted = 0;
+
+       if (get_current_uid(conn) == (uid_t)0) {
+               /* I'm sorry sir, I didn't know you were root... */
+               *access_granted = access_desired;
+               if (access_desired & SEC_FLAG_MAXIMUM_ALLOWED) {
+                       *access_granted |= FILE_GENERIC_ALL;
+               }
+               return NT_STATUS_OK;
+       }
+
        return se_access_check(sd,
                                token,
                                (access_desired & ~FILE_READ_ATTRIBUTES),
@@ -64,53 +81,51 @@ NTSTATUS smb1_file_se_access_check(const struct security_descriptor *sd,
  Check if we have open rights.
 ****************************************************************************/
 
-static NTSTATUS check_open_rights(struct connection_struct *conn,
+NTSTATUS smbd_check_open_rights(struct connection_struct *conn,
                                const struct smb_filename *smb_fname,
                                uint32_t access_mask,
                                uint32_t *access_granted)
 {
        /* Check if we have rights to open. */
        NTSTATUS status;
-       struct security_descriptor *sd;
-
-       *access_granted = 0;
-
-       if (conn->server_info->utok.uid == 0 || conn->admin_user) {
-               /* I'm sorry sir, I didn't know you were root... */
-               *access_granted = access_mask;
-               if (access_mask & SEC_FLAG_MAXIMUM_ALLOWED) {
-                       *access_granted |= FILE_GENERIC_ALL;
-               }
-               return NT_STATUS_OK;
-       }
+       struct security_descriptor *sd = NULL;
 
        status = SMB_VFS_GET_NT_ACL(conn, smb_fname->base_name,
-                       (OWNER_SECURITY_INFORMATION |
-                       GROUP_SECURITY_INFORMATION |
-                       DACL_SECURITY_INFORMATION),&sd);
+                       (SECINFO_OWNER |
+                       SECINFO_GROUP |
+                       SECINFO_DACL),&sd);
 
        if (!NT_STATUS_IS_OK(status)) {
-               DEBUG(10, ("check_open_rights: Could not get acl "
+               DEBUG(10, ("smbd_check_open_rights: Could not get acl "
                        "on %s: %s\n",
                        smb_fname_str_dbg(smb_fname),
                        nt_errstr(status)));
                return status;
        }
 
-       status = smb1_file_se_access_check(sd,
-                               conn->server_info->ptok,
+       status = smb1_file_se_access_check(conn,
+                               sd,
+                               get_current_nttok(conn),
                                access_mask,
                                access_granted);
 
-       TALLOC_FREE(sd);
-
-       DEBUG(10,("check_open_rights: file %s requesting "
+       DEBUG(10,("smbd_check_open_rights: file %s requesting "
                "0x%x returning 0x%x (%s)\n",
                smb_fname_str_dbg(smb_fname),
                (unsigned int)access_mask,
                (unsigned int)*access_granted,
                nt_errstr(status) ));
 
+       if (!NT_STATUS_IS_OK(status)) {
+               if (DEBUGLEVEL >= 10) {
+                       DEBUG(10,("smbd_check_open_rights: acl for %s is:\n",
+                               smb_fname_str_dbg(smb_fname) ));
+                       NDR_PRINT_DEBUG(security_descriptor, sd);
+               }
+       }
+
+       TALLOC_FREE(sd);
+
        return status;
 }
 
@@ -119,11 +134,11 @@ static NTSTATUS check_open_rights(struct connection_struct *conn,
 ****************************************************************************/
 
 static NTSTATUS fd_open(struct connection_struct *conn,
-                   struct smb_filename *smb_fname,
                    files_struct *fsp,
                    int flags,
                    mode_t mode)
 {
+       struct smb_filename *smb_fname = fsp->fsp_name;
        NTSTATUS status = NT_STATUS_OK;
 
 #ifdef O_NOFOLLOW
@@ -218,13 +233,13 @@ void change_file_owner_to_parent(connection_struct *conn,
        if (ret == -1) {
                DEBUG(0,("change_file_owner_to_parent: failed to fchown "
                         "file %s to parent directory uid %u. Error "
-                        "was %s\n", fsp->fsp_name,
+                        "was %s\n", fsp_str_dbg(fsp),
                         (unsigned int)smb_fname_parent->st.st_ex_uid,
                         strerror(errno) ));
        }
 
        DEBUG(10,("change_file_owner_to_parent: changed new file %s to "
-                 "parent directory uid %u.\n", fsp->fsp_name,
+                 "parent directory uid %u.\n", fsp_str_dbg(fsp),
                  (unsigned int)smb_fname_parent->st.st_ex_uid));
 
        TALLOC_FREE(smb_fname_parent);
@@ -343,17 +358,16 @@ static NTSTATUS open_file(files_struct *fsp,
                          connection_struct *conn,
                          struct smb_request *req,
                          const char *parent_dir,
-                         struct smb_filename *smb_fname,
                          int flags,
                          mode_t unx_mode,
                          uint32 access_mask, /* client requested access mask. */
                          uint32 open_access_mask) /* what we're actually using in the open. */
 {
-       char *path = NULL;
+       struct smb_filename *smb_fname = fsp->fsp_name;
        NTSTATUS status = NT_STATUS_OK;
        int accmode = (flags & O_ACCMODE);
        int local_flags = flags;
-       bool file_existed = VALID_STAT(smb_fname->st);
+       bool file_existed = VALID_STAT(fsp->fsp_name->st);
 
        fsp->fh->fd = -1;
        errno = EPERM;
@@ -434,7 +448,7 @@ static NTSTATUS open_file(files_struct *fsp,
                         * wildcard characters are allowed in stream names
                         * only test the basefilename
                         */
-                       wild = fsp->base_fsp->fsp_name;
+                       wild = fsp->base_fsp->fsp_name->base_name;
                } else {
                        wild = smb_fname->base_name;
                }
@@ -444,7 +458,7 @@ static NTSTATUS open_file(files_struct *fsp,
                }
 
                /* Actually do the open */
-               status = fd_open(conn, smb_fname, fsp, local_flags, unx_mode);
+               status = fd_open(conn, fsp, local_flags, unx_mode);
                if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(3,("Error opening file %s (%s) (local_flags=%d) "
                                 "(flags=%d)\n", smb_fname_str_dbg(smb_fname),
@@ -477,7 +491,7 @@ static NTSTATUS open_file(files_struct *fsp,
                if (file_existed) {
                        uint32_t access_granted = 0;
 
-                       status = check_open_rights(conn,
+                       status = smbd_check_open_rights(conn,
                                        smb_fname,
                                        access_mask,
                                        &access_granted);
@@ -547,7 +561,7 @@ static NTSTATUS open_file(files_struct *fsp,
                                                          smb_fname)));
                                } else {
                                        DEBUG(10,("open_file: "
-                                                 "check_open_rights on file "
+                                                 "smbd_check_open_rights on file "
                                                  "%s returned %s\n",
                                                  smb_fname_str_dbg(smb_fname),
                                                  nt_errstr(status) ));
@@ -605,7 +619,7 @@ static NTSTATUS open_file(files_struct *fsp,
                fsp->can_write = (access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) ?
                        True : False;
        }
-       fsp->print_file = False;
+       fsp->print_file = NULL;
        fsp->modified = False;
        fsp->sent_oplock_break = NO_BREAK_SENT;
        fsp->is_directory = False;
@@ -615,15 +629,6 @@ static NTSTATUS open_file(files_struct *fsp,
                fsp->aio_write_behind = True;
        }
 
-       status = get_full_smb_filename(talloc_tos(), smb_fname,
-                                      &path);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
-
-       string_set(&fsp->fsp_name, path);
-       TALLOC_FREE(path);
-
        fsp->wcp = NULL; /* Write cache pointer. */
 
        DEBUG(2,("%s opened file %s read=%s write=%s (numopen=%d)\n",
@@ -795,7 +800,8 @@ static void validate_my_share_entries(int num,
                str = talloc_asprintf(talloc_tos(),
                        "validate_my_share_entries: "
                        "file %s, oplock_type = 0x%x, op_type = 0x%x\n",
-                        fsp->fsp_name, (unsigned int)fsp->oplock_type,
+                        fsp->fsp_name->base_name,
+                        (unsigned int)fsp->oplock_type,
                         (unsigned int)share_entry->op_type );
                smb_panic(str);
        }
@@ -888,7 +894,7 @@ static bool is_delete_request(files_struct *fsp) {
 
 static NTSTATUS send_break_message(files_struct *fsp,
                                        struct share_mode_entry *exclusive,
-                                       uint16 mid,
+                                       uint64_t mid,
                                        int oplock_request)
 {
        NTSTATUS status;
@@ -905,10 +911,11 @@ static NTSTATUS send_break_message(files_struct *fsp,
           don't want this set in the share mode struct pointed to by lck. */
 
        if (oplock_request & FORCE_OPLOCK_BREAK_TO_NONE) {
-               SSVAL(msg,6,exclusive->op_type | FORCE_OPLOCK_BREAK_TO_NONE);
+               SSVAL(msg,OP_BREAK_MSG_OP_TYPE_OFFSET,
+                       exclusive->op_type | FORCE_OPLOCK_BREAK_TO_NONE);
        }
 
-       status = messaging_send_buf(smbd_messaging_context(), exclusive->pid,
+       status = messaging_send_buf(fsp->conn->sconn->msg_ctx, exclusive->pid,
                                    MSG_SMB_BREAK_REQUEST,
                                    (uint8 *)msg,
                                    MSG_SMB_SHARE_MODE_ENTRY_SIZE);
@@ -932,7 +939,7 @@ static NTSTATUS send_break_message(files_struct *fsp,
 
 static bool delay_for_oplocks(struct share_mode_lock *lck,
                              files_struct *fsp,
-                             uint16 mid,
+                             uint64_t mid,
                              int pass_number,
                              int oplock_request)
 {
@@ -1029,7 +1036,7 @@ static bool delay_for_oplocks(struct share_mode_lock *lck,
        }
 
        DEBUG(10,("delay_for_oplocks: oplock type 0x%x on file %s\n",
-               fsp->oplock_type, fsp->fsp_name));
+                 fsp->oplock_type, fsp_str_dbg(fsp)));
 
        /* No delay. */
        return false;
@@ -1067,7 +1074,8 @@ static void defer_open(struct share_mode_lock *lck,
 
                if (procid_is_me(&e->pid) && (e->op_mid == req->mid)) {
                        DEBUG(0, ("Trying to defer an already deferred "
-                                 "request: mid=%d, exiting\n", req->mid));
+                               "request: mid=%llu, exiting\n",
+                               (unsigned long long)req->mid));
                        exit_server("attempt to defer a deferred request");
                }
        }
@@ -1075,16 +1083,17 @@ static void defer_open(struct share_mode_lock *lck,
        /* End paranoia check */
 
        DEBUG(10,("defer_open_sharing_error: time [%u.%06u] adding deferred "
-                 "open entry for mid %u\n",
+                 "open entry for mid %llu\n",
                  (unsigned int)request_time.tv_sec,
                  (unsigned int)request_time.tv_usec,
-                 (unsigned int)req->mid));
+                 (unsigned long long)req->mid));
 
-       if (!push_deferred_smb_message(req, request_time, timeout,
-                                      (char *)state, sizeof(*state))) {
-               exit_server("push_deferred_smb_message failed");
+       if (!push_deferred_open_message_smb(req, request_time, timeout,
+                                      state->id, (char *)state, sizeof(*state))) {
+               exit_server("push_deferred_open_message_smb failed");
        }
-       add_deferred_open(lck, req->mid, request_time, state->id);
+       add_deferred_open(lck, req->mid, request_time,
+                         sconn_server_id(req->sconn), state->id);
 }
 
 
@@ -1152,13 +1161,6 @@ NTSTATUS fcb_or_dos_open(struct smb_request *req,
                                     uint32 create_options)
 {
        files_struct *fsp;
-       char *fname = NULL;
-       NTSTATUS status;
-
-       status = get_full_smb_filename(talloc_tos(), smb_fname, &fname);
-       if (!NT_STATUS_IS_OK(status)) {
-               return status;
-       }
 
        DEBUG(5,("fcb_or_dos_open: attempting old open semantics for "
                 "file %s.\n", smb_fname_str_dbg(smb_fname)));
@@ -1168,7 +1170,7 @@ NTSTATUS fcb_or_dos_open(struct smb_request *req,
 
                DEBUG(10,("fcb_or_dos_open: checking file %s, fd = %d, "
                          "vuid = %u, file_pid = %u, private_options = 0x%x "
-                         "access_mask = 0x%x\n", fsp->fsp_name,
+                         "access_mask = 0x%x\n", fsp_str_dbg(fsp),
                          fsp->fh->fd, (unsigned int)fsp->vuid,
                          (unsigned int)fsp->file_pid,
                          (unsigned int)fsp->fh->private_options,
@@ -1180,7 +1182,9 @@ NTSTATUS fcb_or_dos_open(struct smb_request *req,
                    (fsp->fh->private_options & (NTCREATEX_OPTIONS_PRIVATE_DENY_DOS |
                                                 NTCREATEX_OPTIONS_PRIVATE_DENY_FCB)) &&
                    (fsp->access_mask & FILE_WRITE_DATA) &&
-                   strequal(fsp->fsp_name, fname)) {
+                   strequal(fsp->fsp_name->base_name, smb_fname->base_name) &&
+                   strequal(fsp->fsp_name->stream_name,
+                            smb_fname->stream_name)) {
                        DEBUG(10,("fcb_or_dos_open: file match\n"));
                        break;
                }
@@ -1198,30 +1202,32 @@ NTSTATUS fcb_or_dos_open(struct smb_request *req,
        }
 
        /* We need to duplicate this fsp. */
-       dup_file_fsp(req, fsp, access_mask, share_access,
-                       create_options, fsp_to_dup_into);
-
-       return NT_STATUS_OK;
+       return dup_file_fsp(req, fsp, access_mask, share_access,
+                           create_options, fsp_to_dup_into);
 }
 
 /****************************************************************************
  Open a file with a share mode - old openX method - map into NTCreate.
 ****************************************************************************/
 
-bool map_open_params_to_ntcreate(const char *fname, int deny_mode, int open_func,
+bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
+                                int deny_mode, int open_func,
                                 uint32 *paccess_mask,
                                 uint32 *pshare_mode,
                                 uint32 *pcreate_disposition,
-                                uint32 *pcreate_options)
+                                uint32 *pcreate_options,
+                                uint32_t *pprivate_flags)
 {
        uint32 access_mask;
        uint32 share_mode;
        uint32 create_disposition;
        uint32 create_options = FILE_NON_DIRECTORY_FILE;
+       uint32_t private_flags = 0;
 
        DEBUG(10,("map_open_params_to_ntcreate: fname = %s, deny_mode = 0x%x, "
                  "open_func = 0x%x\n",
-                 fname, (unsigned int)deny_mode, (unsigned int)open_func ));
+                 smb_fname_str_dbg(smb_fname), (unsigned int)deny_mode,
+                 (unsigned int)open_func ));
 
        /* Create the NT compatible access_mask. */
        switch (GET_OPENX_MODE(deny_mode)) {
@@ -1294,8 +1300,8 @@ bool map_open_params_to_ntcreate(const char *fname, int deny_mode, int open_func
                        break;
 
                case DENY_DOS:
-                       create_options |= NTCREATEX_OPTIONS_PRIVATE_DENY_DOS;
-                       if (is_executable(fname)) {
+                       private_flags |= NTCREATEX_OPTIONS_PRIVATE_DENY_DOS;
+                       if (is_executable(smb_fname->base_name)) {
                                share_mode = FILE_SHARE_READ|FILE_SHARE_WRITE;
                        } else {
                                if (GET_OPENX_MODE(deny_mode) == DOS_OPEN_RDONLY) {
@@ -1307,7 +1313,7 @@ bool map_open_params_to_ntcreate(const char *fname, int deny_mode, int open_func
                        break;
 
                case DENY_FCB:
-                       create_options |= NTCREATEX_OPTIONS_PRIVATE_DENY_FCB;
+                       private_flags |= NTCREATEX_OPTIONS_PRIVATE_DENY_FCB;
                        share_mode = FILE_SHARE_NONE;
                        break;
 
@@ -1319,12 +1325,13 @@ bool map_open_params_to_ntcreate(const char *fname, int deny_mode, int open_func
 
        DEBUG(10,("map_open_params_to_ntcreate: file %s, access_mask = 0x%x, "
                  "share_mode = 0x%x, create_disposition = 0x%x, "
-                 "create_options = 0x%x\n",
-                 fname,
+                 "create_options = 0x%x private_flags = 0x%x\n",
+                 smb_fname_str_dbg(smb_fname),
                  (unsigned int)access_mask,
                  (unsigned int)share_mode,
                  (unsigned int)create_disposition,
-                 (unsigned int)create_options ));
+                 (unsigned int)create_options,
+                 (unsigned int)private_flags));
 
        if (paccess_mask) {
                *paccess_mask = access_mask;
@@ -1338,6 +1345,9 @@ bool map_open_params_to_ntcreate(const char *fname, int deny_mode, int open_func
        if (pcreate_options) {
                *pcreate_options = create_options;
        }
+       if (pprivate_flags) {
+               *pprivate_flags = private_flags;
+       }
 
        return True;
 
@@ -1406,9 +1416,9 @@ static NTSTATUS calculate_access_mask(connection_struct *conn,
                        uint32_t access_granted = 0;
 
                        status = SMB_VFS_GET_NT_ACL(conn, smb_fname->base_name,
-                                       (OWNER_SECURITY_INFORMATION |
-                                       GROUP_SECURITY_INFORMATION |
-                                       DACL_SECURITY_INFORMATION),&sd);
+                                       (SECINFO_OWNER |
+                                       SECINFO_GROUP |
+                                       SECINFO_DACL),&sd);
 
                        if (!NT_STATUS_IS_OK(status)) {
                                DEBUG(10, ("calculate_access_mask: Could not get acl "
@@ -1418,8 +1428,9 @@ static NTSTATUS calculate_access_mask(connection_struct *conn,
                                return NT_STATUS_ACCESS_DENIED;
                        }
 
-                       status = smb1_file_se_access_check(sd,
-                                       conn->server_info->ptok,
+                       status = smb1_file_se_access_check(conn,
+                                       sd,
+                                       get_current_nttok(conn),
                                        access_mask,
                                        &access_granted);
 
@@ -1442,13 +1453,29 @@ static NTSTATUS calculate_access_mask(connection_struct *conn,
        return NT_STATUS_OK;
 }
 
+/****************************************************************************
+ Remove the deferred open entry under lock.
+****************************************************************************/
+
+void remove_deferred_open_entry(struct file_id id, uint64_t mid,
+                               struct server_id pid)
+{
+       struct share_mode_lock *lck = get_share_mode_lock(talloc_tos(), id,
+                       NULL, NULL, NULL);
+       if (lck == NULL) {
+               DEBUG(0, ("could not get share mode lock\n"));
+       } else {
+               del_deferred_open_entry(lck, mid, pid);
+               TALLOC_FREE(lck);
+       }
+}
+
 /****************************************************************************
  Open a file with a share mode. Passed in an already created files_struct *.
 ****************************************************************************/
 
 static NTSTATUS open_file_ntcreate(connection_struct *conn,
                            struct smb_request *req,
-                           struct smb_filename *smb_fname,
                            uint32 access_mask,         /* access bits (FILE_READ_DATA etc.) */
                            uint32 share_access,        /* share constants (FILE_SHARE_READ etc) */
                            uint32 create_disposition,  /* FILE_OPEN_IF etc. */
@@ -1456,9 +1483,11 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                            uint32 new_dos_attributes,  /* attributes used for new file. */
                            int oplock_request,         /* internal Samba oplock codes. */
                                                        /* Information (FILE_EXISTS etc.) */
+                           uint32_t private_flags,     /* Samba specific flags. */
                            int *pinfo,
                            files_struct *fsp)
 {
+       struct smb_filename *smb_fname = fsp->fsp_name;
        int flags=0;
        int flags2=0;
        bool file_existed = VALID_STAT(smb_fname->st);
@@ -1472,12 +1501,10 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        mode_t unx_mode = (mode_t)0;
        int info;
        uint32 existing_dos_attributes = 0;
-       struct pending_message_list *pml = NULL;
        struct timeval request_time = timeval_zero();
        struct share_mode_lock *lck = NULL;
        uint32 open_access_mask = access_mask;
        NTSTATUS status;
-       int ret_flock;
        char *parent_dir;
 
        ZERO_STRUCT(id);
@@ -1501,8 +1528,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                        return NT_STATUS_INTERNAL_ERROR;
                }
 
-               return print_fsp_open(req, conn, smb_fname->base_name,
-                                     req->vuid, fsp, &smb_fname->st);
+               return print_spool_open(fsp, smb_fname->base_name,
+                                       req->vuid);
        }
 
        if (!parent_dirname(talloc_tos(), smb_fname->base_name, &parent_dir,
@@ -1524,10 +1551,11 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        DEBUG(10, ("open_file_ntcreate: fname=%s, dos_attrs=0x%x "
                   "access_mask=0x%x share_access=0x%x "
                   "create_disposition = 0x%x create_options=0x%x "
-                  "unix mode=0%o oplock_request=%d\n",
+                  "unix mode=0%o oplock_request=%d private_flags = 0x%x\n",
                   smb_fname_str_dbg(smb_fname), new_dos_attributes,
                   access_mask, share_access, create_disposition,
-                  create_options, (unsigned int)unx_mode, oplock_request));
+                  create_options, (unsigned int)unx_mode, oplock_request,
+                  (unsigned int)private_flags));
 
        if ((req == NULL) && ((oplock_request & INTERNAL_OPEN_ONLY) == 0)) {
                DEBUG(0, ("No smb request but not an internal only open!\n"));
@@ -1538,29 +1566,25 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         * Only non-internal opens can be deferred at all
         */
 
-       if ((req != NULL)
-           && ((pml = get_open_deferred_message(req->mid)) != NULL)) {
-               struct deferred_open_record *state =
-                       (struct deferred_open_record *)pml->private_data.data;
+       if (req) {
+               void *ptr;
+               if (get_deferred_open_message_state(req,
+                               &request_time,
+                               &ptr)) {
 
-               /* Remember the absolute time of the original
-                  request with this mid. We'll use it later to
-                  see if this has timed out. */
+                       struct deferred_open_record *state = (struct deferred_open_record *)ptr;
+                       /* Remember the absolute time of the original
+                          request with this mid. We'll use it later to
+                          see if this has timed out. */
 
-               request_time = pml->request_time;
+                       /* Remove the deferred open entry under lock. */
+                       remove_deferred_open_entry(
+                               state->id, req->mid,
+                               sconn_server_id(req->sconn));
 
-               /* Remove the deferred open entry under lock. */
-               lck = get_share_mode_lock(talloc_tos(), state->id, NULL, NULL,
-                                         NULL);
-               if (lck == NULL) {
-                       DEBUG(0, ("could not get share mode lock\n"));
-               } else {
-                       del_deferred_open_entry(lck, req->mid);
-                       TALLOC_FREE(lck);
+                       /* Ensure we don't reprocess this message. */
+                       remove_deferred_open_message_smb(req->mid);
                }
-
-               /* Ensure we don't reprocess this message. */
-               remove_deferred_open_smb_message(req->mid);
        }
 
        status = check_name(conn, smb_fname->base_name);
@@ -1576,7 +1600,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        }
 
        /* ignore any oplock requests if oplocks are disabled */
-       if (!lp_oplocks(SNUM(conn)) || global_client_failed_oplock_break ||
+       if (!lp_oplocks(SNUM(conn)) ||
            IS_VETO_OPLOCK_PATH(conn, smb_fname->base_name)) {
                /* Mask off everything except the private Samba bits. */
                oplock_request &= SAMBA_PRIVATE_OPLOCK_MASK;
@@ -1721,7 +1745,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                /* DENY_DOS opens are always underlying read-write on the
                   file handle, no matter what the requested access mask
                    says. */
-               if ((create_options & NTCREATEX_OPTIONS_PRIVATE_DENY_DOS) ||
+               if ((private_flags & NTCREATEX_OPTIONS_PRIVATE_DENY_DOS) ||
                        access_mask & (FILE_READ_ATTRIBUTES|FILE_READ_DATA|FILE_READ_EA|FILE_EXECUTE)) {
                        flags = O_RDWR;
                } else {
@@ -1770,7 +1794,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
        fsp->file_id = vfs_file_id_from_sbuf(conn, &smb_fname->st);
        fsp->share_access = share_access;
-       fsp->fh->private_options = create_options;
+       fsp->fh->private_options = private_flags;
        fsp->access_mask = open_access_mask; /* We change this to the
                                              * requested access_mask after
                                              * the open is done. */
@@ -1838,7 +1862,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
                        /* Check if this can be done with the deny_dos and fcb
                         * calls. */
-                       if (create_options &
+                       if (private_flags &
                            (NTCREATEX_OPTIONS_PRIVATE_DENY_DOS|
                             NTCREATEX_OPTIONS_PRIVATE_DENY_FCB)) {
                                if (req == NULL) {
@@ -1977,7 +2001,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         * open_file strips any O_TRUNC flags itself.
         */
 
-       fsp_open = open_file(fsp, conn, req, parent_dir, smb_fname,
+       fsp_open = open_file(fsp, conn, req, parent_dir,
                             flags|flags2, unx_mode, access_mask,
                             open_access_mask);
 
@@ -2098,7 +2122,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
           note that GPFS supports it as well - jmcd */
 
        if (fsp->fh->fd != -1) {
-               ret_flock = SMB_VFS_KERNEL_FLOCK(fsp, share_access);
+               int ret_flock;
+               ret_flock = SMB_VFS_KERNEL_FLOCK(fsp, share_access, access_mask);
                if(ret_flock == -1 ){
 
                        TALLOC_FREE(lck);
@@ -2118,7 +2143,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         * If requested, truncate the file.
         */
 
-       if (flags2&O_TRUNC) {
+       if (file_existed && (flags2&O_TRUNC)) {
                /*
                 * We are modifing the file after open - update the stat
                 * struct..
@@ -2132,9 +2157,6 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                }
        }
 
-       /* Record the options we were opened with. */
-       fsp->share_access = share_access;
-       fsp->fh->private_options = create_options;
        /*
         * According to Samba4, SEC_FILE_READ_ATTRIBUTE is always granted,
         */
@@ -2173,13 +2195,13 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                new_file_created = True;
        }
 
-       set_share_mode(lck, fsp, conn->server_info->utok.uid, 0,
+       set_share_mode(lck, fsp, get_current_uid(conn), 0,
                       fsp->oplock_type);
 
        /* Handle strange delete on close create semantics. */
        if (create_options & FILE_DELETE_ON_CLOSE) {
 
-               status = can_set_delete_on_close(fsp, True, new_dos_attributes);
+               status = can_set_delete_on_close(fsp, new_dos_attributes);
 
                if (!NT_STATUS_IS_OK(status)) {
                        /* Remember to delete the mode we just added. */
@@ -2255,7 +2277,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        /* If this is a successful open, we must remove any deferred open
         * records. */
        if (req != NULL) {
-               del_deferred_open_entry(lck, req->mid);
+               del_deferred_open_entry(lck, req->mid,
+                                       sconn_server_id(req->sconn));
        }
        TALLOC_FREE(lck);
 
@@ -2296,6 +2319,7 @@ NTSTATUS open_file_fchmod(struct smb_request *req, connection_struct *conn,
                0,                                      /* file_attributes */
                0,                                      /* oplock_request */
                0,                                      /* allocation_size */
+               0,                                      /* private_flags */
                NULL,                                   /* sd */
                NULL,                                   /* ea_list */
                &fsp,                                   /* result */
@@ -2390,7 +2414,7 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
                                         smb_dname->base_name, mode);
        }
 
-       if (!(file_attributes & FILE_FLAG_POSIX_SEMANTICS)) {
+       if (!posix_open) {
                /*
                 * Check if high bits should have been set,
                 * then (if bits are missing): add them.
@@ -2552,8 +2576,8 @@ static NTSTATUS open_directory(connection_struct *conn,
 
        if (info == FILE_WAS_OPENED) {
                uint32_t access_granted = 0;
-               status = check_open_rights(conn, smb_dname, access_mask,
-                                          &access_granted);
+               status = smbd_check_open_rights(conn, smb_dname, access_mask,
+                                               &access_granted);
 
                /* Were we trying to do a directory open
                 * for delete and didn't get DELETE
@@ -2574,7 +2598,7 @@ static NTSTATUS open_directory(connection_struct *conn,
                }
 
                if (!NT_STATUS_IS_OK(status)) {
-                       DEBUG(10, ("open_directory: check_open_rights on "
+                       DEBUG(10, ("open_directory: smbd_check_open_rights on "
                                "file %s failed with %s\n",
                                smb_fname_str_dbg(smb_dname),
                                nt_errstr(status)));
@@ -2600,19 +2624,21 @@ static NTSTATUS open_directory(connection_struct *conn,
        fsp->can_write = False;
 
        fsp->share_access = share_access;
-       fsp->fh->private_options = create_options;
+       fsp->fh->private_options = 0;
        /*
         * According to Samba4, SEC_FILE_READ_ATTRIBUTE is always granted,
         */
        fsp->access_mask = access_mask | FILE_READ_ATTRIBUTES;
-       fsp->print_file = False;
+       fsp->print_file = NULL;
        fsp->modified = False;
        fsp->oplock_type = NO_OPLOCK;
        fsp->sent_oplock_break = NO_BREAK_SENT;
        fsp->is_directory = True;
        fsp->posix_open = (file_attributes & FILE_FLAG_POSIX_SEMANTICS) ? True : False;
-
-       string_set(&fsp->fsp_name, smb_dname->base_name);
+       status = fsp_set_smb_fname(fsp, smb_dname);
+       if (!NT_STATUS_IS_OK(status)) {
+               return status;
+       }
 
        mtimespec = smb_dname->st.st_ex_mtime;
 
@@ -2635,12 +2661,12 @@ static NTSTATUS open_directory(connection_struct *conn,
                return status;
        }
 
-       set_share_mode(lck, fsp, conn->server_info->utok.uid, 0, NO_OPLOCK);
+       set_share_mode(lck, fsp, get_current_uid(conn), 0, NO_OPLOCK);
 
        /* For directories the delete on close bit at open time seems
           always to be honored on close... See test 19 in Samba4 BASE-DELETE. */
        if (create_options & FILE_DELETE_ON_CLOSE) {
-               status = can_set_delete_on_close(fsp, True, 0);
+               status = can_set_delete_on_close(fsp, 0);
                if (!NT_STATUS_IS_OK(status) && !NT_STATUS_EQUAL(status, NT_STATUS_DIRECTORY_NOT_EMPTY)) {
                        TALLOC_FREE(lck);
                        file_free(req, fsp);
@@ -2682,6 +2708,7 @@ NTSTATUS create_directory(connection_struct *conn, struct smb_request *req,
                FILE_ATTRIBUTE_DIRECTORY,               /* file_attributes */
                0,                                      /* oplock_request */
                0,                                      /* allocation_size */
+               0,                                      /* private_flags */
                NULL,                                   /* sd */
                NULL,                                   /* ea_list */
                &fsp,                                   /* result */
@@ -2730,6 +2757,11 @@ void msg_file_was_renamed(struct messaging_context *msg,
        bn_len = strlen(base_name);
        stream_name = sharepath + sp_len + 1 + bn_len + 1;
 
+       /* stream_name must always be NULL if there is no stream. */
+       if (stream_name[0] == '\0') {
+               stream_name = NULL;
+       }
+
        status = create_synthetic_smb_fname(talloc_tos(), base_name,
                                            stream_name, NULL, &smb_fname);
        if (!NT_STATUS_IS_OK(status)) {
@@ -2743,18 +2775,14 @@ void msg_file_was_renamed(struct messaging_context *msg,
 
        for(fsp = file_find_di_first(id); fsp; fsp = file_find_di_next(fsp)) {
                if (memcmp(fsp->conn->connectpath, sharepath, sp_len) == 0) {
-                       char *newname = NULL;
 
                        DEBUG(10,("msg_file_was_renamed: renaming file fnum %d from %s -> %s\n",
-                               fsp->fnum, fsp->fsp_name,
+                               fsp->fnum, fsp_str_dbg(fsp),
                                smb_fname_str_dbg(smb_fname)));
-                       status = get_full_smb_filename(talloc_tos(),
-                                                      smb_fname, &newname);
+                       status = fsp_set_smb_fname(fsp, smb_fname);
                        if (!NT_STATUS_IS_OK(status)) {
                                goto out;
                        }
-                       string_set(&fsp->fsp_name, newname);
-                       TALLOC_FREE(newname);
                } else {
                        /* TODO. JRA. */
                        /* Now we have the complete path we can work out if this is
@@ -2765,7 +2793,7 @@ void msg_file_was_renamed(struct messaging_context *msg,
                                fsp->conn->connectpath,
                                sharepath,
                                fsp->fnum,
-                               fsp->fsp_name,
+                               fsp_str_dbg(fsp),
                                smb_fname_str_dbg(smb_fname)));
                }
         }
@@ -2774,52 +2802,6 @@ void msg_file_was_renamed(struct messaging_context *msg,
        return;
 }
 
-struct case_semantics_state {
-       connection_struct *conn;
-       bool case_sensitive;
-       bool case_preserve;
-       bool short_case_preserve;
-};
-
-/****************************************************************************
- Restore case semantics.
-****************************************************************************/
-static int restore_case_semantics(struct case_semantics_state *state)
-{
-       state->conn->case_sensitive = state->case_sensitive;
-       state->conn->case_preserve = state->case_preserve;
-       state->conn->short_case_preserve = state->short_case_preserve;
-       return 0;
-}
-
-/****************************************************************************
- Save case semantics.
-****************************************************************************/
-struct case_semantics_state *set_posix_case_semantics(TALLOC_CTX *mem_ctx,
-                                                     connection_struct *conn)
-{
-       struct case_semantics_state *result;
-
-       if (!(result = talloc(mem_ctx, struct case_semantics_state))) {
-               DEBUG(0, ("talloc failed\n"));
-               return NULL;
-       }
-
-       result->conn = conn;
-       result->case_sensitive = conn->case_sensitive;
-       result->case_preserve = conn->case_preserve;
-       result->short_case_preserve = conn->short_case_preserve;
-
-       /* Set to POSIX. */
-       conn->case_sensitive = True;
-       conn->case_preserve = True;
-       conn->short_case_preserve = True;
-
-       talloc_set_destructor(result, restore_case_semantics);
-
-       return result;
-}
-
 /*
  * If a main file is opened for delete, all streams need to be checked for
  * !FILE_SHARE_DELETE. Do this by opening with DELETE_ACCESS.
@@ -2896,10 +2878,11 @@ NTSTATUS open_streams_for_delete(connection_struct *conn,
                         (FILE_SHARE_READ |     /* share_access */
                             FILE_SHARE_WRITE | FILE_SHARE_DELETE),
                         FILE_OPEN,             /* create_disposition*/
-                        NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE, /* create_options */
+                        0,                     /* create_options */
                         FILE_ATTRIBUTE_NORMAL, /* file_attributes */
                         0,                     /* oplock_request */
                         0,                     /* allocation_size */
+                        NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE, /* private_flags */
                         NULL,                  /* sd */
                         NULL,                  /* ea_list */
                         &streams[i],           /* result */
@@ -2926,7 +2909,7 @@ NTSTATUS open_streams_for_delete(connection_struct *conn,
                }
 
                DEBUG(10, ("Closing stream # %d, %s\n", i,
-                          streams[i]->fsp_name));
+                          fsp_str_dbg(streams[i])));
                close_file(NULL, streams[i], NORMAL_CLOSE);
        }
 
@@ -2949,6 +2932,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                                     uint32_t file_attributes,
                                     uint32_t oplock_request,
                                     uint64_t allocation_size,
+                                    uint32_t private_flags,
                                     struct security_descriptor *sd,
                                     struct ea_list *ea_list,
 
@@ -2963,7 +2947,8 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
        DEBUG(10,("create_file_unixpath: access_mask = 0x%x "
                  "file_attributes = 0x%x, share_access = 0x%x, "
                  "create_disposition = 0x%x create_options = 0x%x "
-                 "oplock_request = 0x%x ea_list = 0x%p, sd = 0x%p, "
+                 "oplock_request = 0x%x private_flags = 0x%x "
+                 "ea_list = 0x%p, sd = 0x%p, "
                  "fname = %s\n",
                  (unsigned int)access_mask,
                  (unsigned int)file_attributes,
@@ -2971,6 +2956,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                  (unsigned int)create_disposition,
                  (unsigned int)create_options,
                  (unsigned int)oplock_request,
+                 (unsigned int)private_flags,
                  ea_list, sd, smb_fname_str_dbg(smb_fname)));
 
        if (create_options & FILE_OPEN_BY_FILE_ID) {
@@ -3049,7 +3035,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 
        if ((conn->fs_capabilities & FILE_NAMED_STREAMS)
            && is_ntfs_stream_smb_fname(smb_fname)
-           && (!(create_options & NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE))) {
+           && (!(private_flags & NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE))) {
                uint32 base_create_disposition;
                struct smb_filename *smb_fname_base = NULL;
 
@@ -3087,7 +3073,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                                              | FILE_SHARE_WRITE
                                              | FILE_SHARE_DELETE,
                                              base_create_disposition,
-                                             0, 0, 0, 0, NULL, NULL,
+                                             0, 0, 0, 0, 0, NULL, NULL,
                                              &base_fsp, NULL);
                TALLOC_FREE(smb_fname_base);
 
@@ -3141,6 +3127,11 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                        goto fail;
                }
 
+               status = fsp_set_smb_fname(fsp, smb_fname);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto fail;
+               }
+
                /*
                 * We're opening the stream element of a base_fsp
                 * we already opened. Set up the base_fsp pointer.
@@ -3151,13 +3142,13 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 
                status = open_file_ntcreate(conn,
                                            req,
-                                           smb_fname,
                                            access_mask,
                                            share_access,
                                            create_disposition,
                                            create_options,
                                            file_attributes,
                                            oplock_request,
+                                           private_flags,
                                            &info,
                                            fsp);
 
@@ -3225,10 +3216,10 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                security_acl_map_generic(sd->dacl, &file_generic_mapping);
                security_acl_map_generic(sd->sacl, &file_generic_mapping);
 
-               if (sec_info_sent & (OWNER_SECURITY_INFORMATION|
-                                       GROUP_SECURITY_INFORMATION|
-                                       DACL_SECURITY_INFORMATION|
-                                       SACL_SECURITY_INFORMATION)) {
+               if (sec_info_sent & (SECINFO_OWNER|
+                                       SECINFO_GROUP|
+                                       SECINFO_DACL|
+                                       SECINFO_SACL)) {
                        status = SMB_VFS_FSET_NT_ACL(fsp, sec_info_sent, sd);
                }
 
@@ -3241,13 +3232,13 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 
        if ((ea_list != NULL) &&
            ((info == FILE_WAS_CREATED) || (info == FILE_WAS_OVERWRITTEN))) {
-               status = set_ea(conn, fsp, smb_fname, ea_list);
+               status = set_ea(conn, fsp, fsp->fsp_name, ea_list);
                if (!NT_STATUS_IS_OK(status)) {
                        goto fail;
                }
        }
 
-       if (!fsp->is_directory && S_ISDIR(smb_fname->st.st_ex_mode)) {
+       if (!fsp->is_directory && S_ISDIR(fsp->fsp_name->st.st_ex_mode)) {
                status = NT_STATUS_ACCESS_DENIED;
                goto fail;
        }
@@ -3255,7 +3246,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
        /* Save the requested allocation size. */
        if ((info == FILE_WAS_CREATED) || (info == FILE_WAS_OVERWRITTEN)) {
                if (allocation_size
-                   && (allocation_size > smb_fname->st.st_ex_size)) {
+                   && (allocation_size > fsp->fsp_name->st.st_ex_size)) {
                        fsp->initial_allocation_size = smb_roundup(
                                fsp->conn, allocation_size);
                        if (fsp->is_directory) {
@@ -3270,7 +3261,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                        }
                } else {
                        fsp->initial_allocation_size = smb_roundup(
-                               fsp->conn, (uint64_t)smb_fname->st.st_ex_size);
+                               fsp->conn, (uint64_t)fsp->fsp_name->st.st_ex_size);
                }
        }
 
@@ -3280,9 +3271,9 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
        if (pinfo != NULL) {
                *pinfo = info;
        }
-       if ((fsp->fh != NULL) && (fsp->fh->fd != -1)) {
-               SMB_VFS_FSTAT(fsp, &smb_fname->st);
-       }
+
+       smb_fname->st = fsp->fsp_name->st;
+
        return NT_STATUS_OK;
 
  fail:
@@ -3331,6 +3322,11 @@ NTSTATUS get_relative_fid_filename(connection_struct *conn,
                goto out;
        }
 
+       if (is_ntfs_stream_smb_fname(dir_fsp->fsp_name)) {
+               status = NT_STATUS_INVALID_HANDLE;
+               goto out;
+       }
+
        if (!dir_fsp->is_directory) {
 
                /*
@@ -3354,7 +3350,7 @@ NTSTATUS get_relative_fid_filename(connection_struct *conn,
                goto out;
        }
 
-       if (ISDOT(dir_fsp->fsp_name)) {
+       if (ISDOT(dir_fsp->fsp_name->base_name)) {
                /*
                 * We're at the toplevel dir, the final file name
                 * must not contain ./, as this is filtered out
@@ -3367,7 +3363,7 @@ NTSTATUS get_relative_fid_filename(connection_struct *conn,
                        goto out;
                }
        } else {
-               size_t dir_name_len = strlen(dir_fsp->fsp_name);
+               size_t dir_name_len = strlen(dir_fsp->fsp_name->base_name);
 
                /*
                 * Copy in the base directory name.
@@ -3379,7 +3375,7 @@ NTSTATUS get_relative_fid_filename(connection_struct *conn,
                        status = NT_STATUS_NO_MEMORY;
                        goto out;
                }
-               memcpy(parent_fname, dir_fsp->fsp_name,
+               memcpy(parent_fname, dir_fsp->fsp_name->base_name,
                    dir_name_len+1);
 
                /*
@@ -3422,6 +3418,7 @@ NTSTATUS create_file_default(connection_struct *conn,
                             uint32_t file_attributes,
                             uint32_t oplock_request,
                             uint64_t allocation_size,
+                            uint32_t private_flags,
                             struct security_descriptor *sd,
                             struct ea_list *ea_list,
                             files_struct **result,
@@ -3430,11 +3427,13 @@ NTSTATUS create_file_default(connection_struct *conn,
        int info = FILE_WAS_OPENED;
        files_struct *fsp = NULL;
        NTSTATUS status;
+       bool stream_name = false;
 
        DEBUG(10,("create_file: access_mask = 0x%x "
                  "file_attributes = 0x%x, share_access = 0x%x, "
                  "create_disposition = 0x%x create_options = 0x%x "
                  "oplock_request = 0x%x "
+                 "private_flags = 0x%x "
                  "root_dir_fid = 0x%x, ea_list = 0x%p, sd = 0x%p, "
                  "fname = %s\n",
                  (unsigned int)access_mask,
@@ -3443,6 +3442,7 @@ NTSTATUS create_file_default(connection_struct *conn,
                  (unsigned int)create_disposition,
                  (unsigned int)create_options,
                  (unsigned int)oplock_request,
+                 (unsigned int)private_flags,
                  (unsigned int)root_dir_fid,
                  ea_list, sd, smb_fname_str_dbg(smb_fname)));
 
@@ -3462,17 +3462,11 @@ NTSTATUS create_file_default(connection_struct *conn,
         * Check to see if this is a mac fork of some kind.
         */
 
-       if (is_ntfs_stream_smb_fname(smb_fname)) {
-               char *fname = NULL;
+       stream_name = is_ntfs_stream_smb_fname(smb_fname);
+       if (stream_name) {
                enum FAKE_FILE_TYPE fake_file_type;
 
-               status = get_full_smb_filename(talloc_tos(), smb_fname,
-                                              &fname);
-               if (!NT_STATUS_IS_OK(status)) {
-                       goto fail;
-               }
-
-               fake_file_type = is_fake_file(fname);
+               fake_file_type = is_fake_file(smb_fname);
 
                if (fake_file_type != FAKE_FILE_TYPE_NONE) {
 
@@ -3488,9 +3482,8 @@ NTSTATUS create_file_default(connection_struct *conn,
                         * close it
                         */
                        status = open_fake_file(req, conn, req->vuid,
-                                               fake_file_type, fname,
+                                               fake_file_type, smb_fname,
                                                access_mask, &fsp);
-                       TALLOC_FREE(fname);
                        if (!NT_STATUS_IS_OK(status)) {
                                goto fail;
                        }
@@ -3498,7 +3491,6 @@ NTSTATUS create_file_default(connection_struct *conn,
                        ZERO_STRUCT(smb_fname->st);
                        goto done;
                }
-               TALLOC_FREE(fname);
 
                if (!(conn->fs_capabilities & FILE_NAMED_STREAMS)) {
                        status = NT_STATUS_OBJECT_NAME_NOT_FOUND;
@@ -3513,10 +3505,31 @@ NTSTATUS create_file_default(connection_struct *conn,
                goto fail;
        }
 
+       if (stream_name && is_ntfs_default_stream_smb_fname(smb_fname)) {
+               int ret;
+               smb_fname->stream_name = NULL;
+               /* We have to handle this error here. */
+               if (create_options & FILE_DIRECTORY_FILE) {
+                       status = NT_STATUS_NOT_A_DIRECTORY;
+                       goto fail;
+               }
+               if (lp_posix_pathnames()) {
+                       ret = SMB_VFS_LSTAT(conn, smb_fname);
+               } else {
+                       ret = SMB_VFS_STAT(conn, smb_fname);
+               }
+
+               if (ret == 0 && VALID_STAT_OF_DIR(smb_fname->st)) {
+                       status = NT_STATUS_FILE_IS_A_DIRECTORY;
+                       goto fail;
+               }
+       }
+
        status = create_file_unixpath(
                conn, req, smb_fname, access_mask, share_access,
                create_disposition, create_options, file_attributes,
-               oplock_request, allocation_size, sd, ea_list,
+               oplock_request, allocation_size, private_flags,
+               sd, ea_list,
                &fsp, &info);
 
        if (!NT_STATUS_IS_OK(status)) {