Add code to implement SeSecurityPrivilege in net rpc rights, and in the
[abartlet/samba.git/.git] / source3 / smbd / open.c
index 1f48daf9048cd2a257657822735f1358dc27f1ad..f5de607713ced273cb5908256912bafef389a682 100644 (file)
 */
 
 #include "includes.h"
+#include "printing.h"
 #include "smbd/globals.h"
+#include "fake_file.h"
+#include "librpc/gen_ndr/messaging.h"
+#include "../libcli/security/security.h"
+#include "../librpc/gen_ndr/ndr_security.h"
 
 extern const struct generic_mapping file_generic_mapping;
 
 struct deferred_open_record {
-       bool delayed_for_oplocks;
-       struct file_id id;
+        bool delayed_for_oplocks;
+        struct file_id id;
 };
 
 static NTSTATUS create_file_unixpath(connection_struct *conn,
@@ -39,6 +44,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                                     uint32_t file_attributes,
                                     uint32_t oplock_request,
                                     uint64_t allocation_size,
+                                    uint32_t private_flags,
                                     struct security_descriptor *sd,
                                     struct ea_list *ea_list,
 
@@ -49,11 +55,23 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
  SMB1 file varient of se_access_check. Never test FILE_READ_ATTRIBUTES.
 ****************************************************************************/
 
-NTSTATUS smb1_file_se_access_check(const struct security_descriptor *sd,
-                          const NT_USER_TOKEN *token,
-                          uint32_t access_desired,
-                          uint32_t *access_granted)
+NTSTATUS smb1_file_se_access_check(struct connection_struct *conn,
+                               const struct security_descriptor *sd,
+                               const struct security_token *token,
+                               uint32_t access_desired,
+                               uint32_t *access_granted)
 {
+       *access_granted = 0;
+
+       if (get_current_uid(conn) == (uid_t)0) {
+               /* I'm sorry sir, I didn't know you were root... */
+               *access_granted = access_desired;
+               if (access_desired & SEC_FLAG_MAXIMUM_ALLOWED) {
+                       *access_granted |= FILE_GENERIC_ALL;
+               }
+               return NT_STATUS_OK;
+       }
+
        return se_access_check(sd,
                                token,
                                (access_desired & ~FILE_READ_ATTRIBUTES),
@@ -71,40 +89,27 @@ NTSTATUS smbd_check_open_rights(struct connection_struct *conn,
 {
        /* Check if we have rights to open. */
        NTSTATUS status;
-       struct security_descriptor *sd;
-
-       *access_granted = 0;
-
-       if (conn->server_info->utok.uid == 0 || conn->admin_user) {
-               /* I'm sorry sir, I didn't know you were root... */
-               *access_granted = access_mask;
-               if (access_mask & SEC_FLAG_MAXIMUM_ALLOWED) {
-                       *access_granted |= FILE_GENERIC_ALL;
-               }
-               return NT_STATUS_OK;
-       }
+       struct security_descriptor *sd = NULL;
 
        status = SMB_VFS_GET_NT_ACL(conn, smb_fname->base_name,
-                       (OWNER_SECURITY_INFORMATION |
-                       GROUP_SECURITY_INFORMATION |
-                       DACL_SECURITY_INFORMATION),&sd);
+                       (SECINFO_OWNER |
+                       SECINFO_GROUP |
+                       SECINFO_DACL),&sd);
 
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(10, ("smbd_check_open_rights: Could not get acl "
                        "on %s: %s\n",
                        smb_fname_str_dbg(smb_fname),
                        nt_errstr(status)));
-               TALLOC_FREE(sd);
                return status;
        }
 
-       status = smb1_file_se_access_check(sd,
-                               conn->server_info->ptok,
+       status = smb1_file_se_access_check(conn,
+                               sd,
+                               get_current_nttok(conn),
                                access_mask,
                                access_granted);
 
-       TALLOC_FREE(sd);
-
        DEBUG(10,("smbd_check_open_rights: file %s requesting "
                "0x%x returning 0x%x (%s)\n",
                smb_fname_str_dbg(smb_fname),
@@ -112,6 +117,16 @@ NTSTATUS smbd_check_open_rights(struct connection_struct *conn,
                (unsigned int)*access_granted,
                nt_errstr(status) ));
 
+       if (!NT_STATUS_IS_OK(status)) {
+               if (DEBUGLEVEL >= 10) {
+                       DEBUG(10,("smbd_check_open_rights: acl for %s is:\n",
+                               smb_fname_str_dbg(smb_fname) ));
+                       NDR_PRINT_DEBUG(security_descriptor, sd);
+               }
+       }
+
+       TALLOC_FREE(sd);
+
        return status;
 }
 
@@ -120,11 +135,11 @@ NTSTATUS smbd_check_open_rights(struct connection_struct *conn,
 ****************************************************************************/
 
 static NTSTATUS fd_open(struct connection_struct *conn,
-                   struct smb_filename *smb_fname,
                    files_struct *fsp,
                    int flags,
                    mode_t mode)
 {
+       struct smb_filename *smb_fname = fsp->fsp_name;
        NTSTATUS status = NT_STATUS_OK;
 
 #ifdef O_NOFOLLOW
@@ -344,16 +359,16 @@ static NTSTATUS open_file(files_struct *fsp,
                          connection_struct *conn,
                          struct smb_request *req,
                          const char *parent_dir,
-                         struct smb_filename *smb_fname,
                          int flags,
                          mode_t unx_mode,
                          uint32 access_mask, /* client requested access mask. */
                          uint32 open_access_mask) /* what we're actually using in the open. */
 {
+       struct smb_filename *smb_fname = fsp->fsp_name;
        NTSTATUS status = NT_STATUS_OK;
        int accmode = (flags & O_ACCMODE);
        int local_flags = flags;
-       bool file_existed = VALID_STAT(smb_fname->st);
+       bool file_existed = VALID_STAT(fsp->fsp_name->st);
 
        fsp->fh->fd = -1;
        errno = EPERM;
@@ -444,7 +459,7 @@ static NTSTATUS open_file(files_struct *fsp,
                }
 
                /* Actually do the open */
-               status = fd_open(conn, smb_fname, fsp, local_flags, unx_mode);
+               status = fd_open(conn, fsp, local_flags, unx_mode);
                if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(3,("Error opening file %s (%s) (local_flags=%d) "
                                 "(flags=%d)\n", smb_fname_str_dbg(smb_fname),
@@ -605,7 +620,7 @@ static NTSTATUS open_file(files_struct *fsp,
                fsp->can_write = (access_mask & (FILE_WRITE_DATA | FILE_APPEND_DATA)) ?
                        True : False;
        }
-       fsp->print_file = False;
+       fsp->print_file = NULL;
        fsp->modified = False;
        fsp->sent_oplock_break = NO_BREAK_SENT;
        fsp->is_directory = False;
@@ -614,12 +629,6 @@ static NTSTATUS open_file(files_struct *fsp,
                       conn->case_sensitive)) {
                fsp->aio_write_behind = True;
        }
-       status = fsp_set_smb_fname(fsp, smb_fname);
-       if (!NT_STATUS_IS_OK(status)) {
-               fd_close(fsp);
-               errno = map_errno_from_nt_status(status);
-               return status;
-       }
 
        fsp->wcp = NULL; /* Write cache pointer. */
 
@@ -735,7 +744,8 @@ sa = 0x%x, share = 0x%x\n", (num), (unsigned int)(am), (unsigned int)(right), (u
 }
 
 #if defined(DEVELOPER)
-static void validate_my_share_entries(int num,
+static void validate_my_share_entries(struct smbd_server_connection *sconn,
+                                     int num,
                                      struct share_mode_entry *share_entry)
 {
        files_struct *fsp;
@@ -757,7 +767,7 @@ static void validate_my_share_entries(int num,
                return;
        }
 
-       fsp = file_find_dif(share_entry->id,
+       fsp = file_find_dif(sconn, share_entry->id,
                            share_entry->share_file_id);
        if (!fsp) {
                DEBUG(0,("validate_my_share_entries: PANIC : %s\n",
@@ -848,7 +858,8 @@ static NTSTATUS open_mode_check(connection_struct *conn,
        
 #if defined(DEVELOPER)
        for(i = 0; i < lck->num_share_modes; i++) {
-               validate_my_share_entries(i, &lck->share_modes[i]);
+               validate_my_share_entries(conn->sconn, i,
+                                         &lck->share_modes[i]);
        }
 #endif
 
@@ -886,7 +897,7 @@ static bool is_delete_request(files_struct *fsp) {
 
 static NTSTATUS send_break_message(files_struct *fsp,
                                        struct share_mode_entry *exclusive,
-                                       uint16 mid,
+                                       uint64_t mid,
                                        int oplock_request)
 {
        NTSTATUS status;
@@ -903,10 +914,11 @@ static NTSTATUS send_break_message(files_struct *fsp,
           don't want this set in the share mode struct pointed to by lck. */
 
        if (oplock_request & FORCE_OPLOCK_BREAK_TO_NONE) {
-               SSVAL(msg,6,exclusive->op_type | FORCE_OPLOCK_BREAK_TO_NONE);
+               SSVAL(msg,OP_BREAK_MSG_OP_TYPE_OFFSET,
+                       exclusive->op_type | FORCE_OPLOCK_BREAK_TO_NONE);
        }
 
-       status = messaging_send_buf(smbd_messaging_context(), exclusive->pid,
+       status = messaging_send_buf(fsp->conn->sconn->msg_ctx, exclusive->pid,
                                    MSG_SMB_BREAK_REQUEST,
                                    (uint8 *)msg,
                                    MSG_SMB_SHARE_MODE_ENTRY_SIZE);
@@ -930,7 +942,7 @@ static NTSTATUS send_break_message(files_struct *fsp,
 
 static bool delay_for_oplocks(struct share_mode_lock *lck,
                              files_struct *fsp,
-                             uint16 mid,
+                             uint64_t mid,
                              int pass_number,
                              int oplock_request)
 {
@@ -1065,7 +1077,8 @@ static void defer_open(struct share_mode_lock *lck,
 
                if (procid_is_me(&e->pid) && (e->op_mid == req->mid)) {
                        DEBUG(0, ("Trying to defer an already deferred "
-                                 "request: mid=%d, exiting\n", req->mid));
+                               "request: mid=%llu, exiting\n",
+                               (unsigned long long)req->mid));
                        exit_server("attempt to defer a deferred request");
                }
        }
@@ -1073,16 +1086,17 @@ static void defer_open(struct share_mode_lock *lck,
        /* End paranoia check */
 
        DEBUG(10,("defer_open_sharing_error: time [%u.%06u] adding deferred "
-                 "open entry for mid %u\n",
+                 "open entry for mid %llu\n",
                  (unsigned int)request_time.tv_sec,
                  (unsigned int)request_time.tv_usec,
-                 (unsigned int)req->mid));
+                 (unsigned long long)req->mid));
 
-       if (!push_deferred_smb_message(req, request_time, timeout,
-                                      (char *)state, sizeof(*state))) {
-               exit_server("push_deferred_smb_message failed");
+       if (!push_deferred_open_message_smb(req, request_time, timeout,
+                                      state->id, (char *)state, sizeof(*state))) {
+               exit_server("push_deferred_open_message_smb failed");
        }
-       add_deferred_open(lck, req->mid, request_time, state->id);
+       add_deferred_open(lck, req->mid, request_time,
+                         sconn_server_id(req->sconn), state->id);
 }
 
 
@@ -1154,7 +1168,7 @@ NTSTATUS fcb_or_dos_open(struct smb_request *req,
        DEBUG(5,("fcb_or_dos_open: attempting old open semantics for "
                 "file %s.\n", smb_fname_str_dbg(smb_fname)));
 
-       for(fsp = file_find_di_first(id); fsp;
+       for(fsp = file_find_di_first(conn->sconn, id); fsp;
            fsp = file_find_di_next(fsp)) {
 
                DEBUG(10,("fcb_or_dos_open: checking file %s, fd = %d, "
@@ -1204,12 +1218,14 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
                                 uint32 *paccess_mask,
                                 uint32 *pshare_mode,
                                 uint32 *pcreate_disposition,
-                                uint32 *pcreate_options)
+                                uint32 *pcreate_options,
+                                uint32_t *pprivate_flags)
 {
        uint32 access_mask;
        uint32 share_mode;
        uint32 create_disposition;
        uint32 create_options = FILE_NON_DIRECTORY_FILE;
+       uint32_t private_flags = 0;
 
        DEBUG(10,("map_open_params_to_ntcreate: fname = %s, deny_mode = 0x%x, "
                  "open_func = 0x%x\n",
@@ -1287,7 +1303,7 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
                        break;
 
                case DENY_DOS:
-                       create_options |= NTCREATEX_OPTIONS_PRIVATE_DENY_DOS;
+                       private_flags |= NTCREATEX_OPTIONS_PRIVATE_DENY_DOS;
                        if (is_executable(smb_fname->base_name)) {
                                share_mode = FILE_SHARE_READ|FILE_SHARE_WRITE;
                        } else {
@@ -1300,7 +1316,7 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
                        break;
 
                case DENY_FCB:
-                       create_options |= NTCREATEX_OPTIONS_PRIVATE_DENY_FCB;
+                       private_flags |= NTCREATEX_OPTIONS_PRIVATE_DENY_FCB;
                        share_mode = FILE_SHARE_NONE;
                        break;
 
@@ -1312,12 +1328,13 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
 
        DEBUG(10,("map_open_params_to_ntcreate: file %s, access_mask = 0x%x, "
                  "share_mode = 0x%x, create_disposition = 0x%x, "
-                 "create_options = 0x%x\n",
+                 "create_options = 0x%x private_flags = 0x%x\n",
                  smb_fname_str_dbg(smb_fname),
                  (unsigned int)access_mask,
                  (unsigned int)share_mode,
                  (unsigned int)create_disposition,
-                 (unsigned int)create_options ));
+                 (unsigned int)create_options,
+                 (unsigned int)private_flags));
 
        if (paccess_mask) {
                *paccess_mask = access_mask;
@@ -1331,6 +1348,9 @@ bool map_open_params_to_ntcreate(const struct smb_filename *smb_fname,
        if (pcreate_options) {
                *pcreate_options = create_options;
        }
+       if (pprivate_flags) {
+               *pprivate_flags = private_flags;
+       }
 
        return True;
 
@@ -1399,9 +1419,9 @@ static NTSTATUS calculate_access_mask(connection_struct *conn,
                        uint32_t access_granted = 0;
 
                        status = SMB_VFS_GET_NT_ACL(conn, smb_fname->base_name,
-                                       (OWNER_SECURITY_INFORMATION |
-                                       GROUP_SECURITY_INFORMATION |
-                                       DACL_SECURITY_INFORMATION),&sd);
+                                       (SECINFO_OWNER |
+                                       SECINFO_GROUP |
+                                       SECINFO_DACL),&sd);
 
                        if (!NT_STATUS_IS_OK(status)) {
                                DEBUG(10, ("calculate_access_mask: Could not get acl "
@@ -1411,8 +1431,9 @@ static NTSTATUS calculate_access_mask(connection_struct *conn,
                                return NT_STATUS_ACCESS_DENIED;
                        }
 
-                       status = smb1_file_se_access_check(sd,
-                                       conn->server_info->ptok,
+                       status = smb1_file_se_access_check(conn,
+                                       sd,
+                                       get_current_nttok(conn),
                                        access_mask,
                                        &access_granted);
 
@@ -1435,13 +1456,29 @@ static NTSTATUS calculate_access_mask(connection_struct *conn,
        return NT_STATUS_OK;
 }
 
+/****************************************************************************
+ Remove the deferred open entry under lock.
+****************************************************************************/
+
+void remove_deferred_open_entry(struct file_id id, uint64_t mid,
+                               struct server_id pid)
+{
+       struct share_mode_lock *lck = get_share_mode_lock(talloc_tos(), id,
+                       NULL, NULL, NULL);
+       if (lck == NULL) {
+               DEBUG(0, ("could not get share mode lock\n"));
+       } else {
+               del_deferred_open_entry(lck, mid, pid);
+               TALLOC_FREE(lck);
+       }
+}
+
 /****************************************************************************
  Open a file with a share mode. Passed in an already created files_struct *.
 ****************************************************************************/
 
 static NTSTATUS open_file_ntcreate(connection_struct *conn,
                            struct smb_request *req,
-                           struct smb_filename *smb_fname,
                            uint32 access_mask,         /* access bits (FILE_READ_DATA etc.) */
                            uint32 share_access,        /* share constants (FILE_SHARE_READ etc) */
                            uint32 create_disposition,  /* FILE_OPEN_IF etc. */
@@ -1449,9 +1486,11 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                            uint32 new_dos_attributes,  /* attributes used for new file. */
                            int oplock_request,         /* internal Samba oplock codes. */
                                                        /* Information (FILE_EXISTS etc.) */
+                           uint32_t private_flags,     /* Samba specific flags. */
                            int *pinfo,
                            files_struct *fsp)
 {
+       struct smb_filename *smb_fname = fsp->fsp_name;
        int flags=0;
        int flags2=0;
        bool file_existed = VALID_STAT(smb_fname->st);
@@ -1465,16 +1504,20 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        mode_t unx_mode = (mode_t)0;
        int info;
        uint32 existing_dos_attributes = 0;
-       struct pending_message_list *pml = NULL;
        struct timeval request_time = timeval_zero();
        struct share_mode_lock *lck = NULL;
        uint32 open_access_mask = access_mask;
        NTSTATUS status;
-       int ret_flock;
        char *parent_dir;
 
        ZERO_STRUCT(id);
 
+       /* Windows allows a new file to be created and
+          silently removes a FILE_ATTRIBUTE_DIRECTORY
+          sent by the client. Do the same. */
+
+       new_dos_attributes &= ~FILE_ATTRIBUTE_DIRECTORY;
+
        if (conn->printer) {
                /*
                 * Printers are handled completely differently.
@@ -1494,8 +1537,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                        return NT_STATUS_INTERNAL_ERROR;
                }
 
-               return print_fsp_open(req, conn, smb_fname->base_name,
-                                     req->vuid, fsp);
+               return print_spool_open(fsp, smb_fname->base_name,
+                                       req->vuid);
        }
 
        if (!parent_dirname(talloc_tos(), smb_fname->base_name, &parent_dir,
@@ -1517,10 +1560,11 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        DEBUG(10, ("open_file_ntcreate: fname=%s, dos_attrs=0x%x "
                   "access_mask=0x%x share_access=0x%x "
                   "create_disposition = 0x%x create_options=0x%x "
-                  "unix mode=0%o oplock_request=%d\n",
+                  "unix mode=0%o oplock_request=%d private_flags = 0x%x\n",
                   smb_fname_str_dbg(smb_fname), new_dos_attributes,
                   access_mask, share_access, create_disposition,
-                  create_options, (unsigned int)unx_mode, oplock_request));
+                  create_options, (unsigned int)unx_mode, oplock_request,
+                  (unsigned int)private_flags));
 
        if ((req == NULL) && ((oplock_request & INTERNAL_OPEN_ONLY) == 0)) {
                DEBUG(0, ("No smb request but not an internal only open!\n"));
@@ -1531,29 +1575,25 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         * Only non-internal opens can be deferred at all
         */
 
-       if ((req != NULL)
-           && ((pml = get_open_deferred_message(req->mid)) != NULL)) {
-               struct deferred_open_record *state =
-                       (struct deferred_open_record *)pml->private_data.data;
+       if (req) {
+               void *ptr;
+               if (get_deferred_open_message_state(req,
+                               &request_time,
+                               &ptr)) {
 
-               /* Remember the absolute time of the original
-                  request with this mid. We'll use it later to
-                  see if this has timed out. */
+                       struct deferred_open_record *state = (struct deferred_open_record *)ptr;
+                       /* Remember the absolute time of the original
+                          request with this mid. We'll use it later to
+                          see if this has timed out. */
 
-               request_time = pml->request_time;
+                       /* Remove the deferred open entry under lock. */
+                       remove_deferred_open_entry(
+                               state->id, req->mid,
+                               sconn_server_id(req->sconn));
 
-               /* Remove the deferred open entry under lock. */
-               lck = get_share_mode_lock(talloc_tos(), state->id, NULL, NULL,
-                                         NULL);
-               if (lck == NULL) {
-                       DEBUG(0, ("could not get share mode lock\n"));
-               } else {
-                       del_deferred_open_entry(lck, req->mid);
-                       TALLOC_FREE(lck);
+                       /* Ensure we don't reprocess this message. */
+                       remove_deferred_open_message_smb(req->mid);
                }
-
-               /* Ensure we don't reprocess this message. */
-               remove_deferred_open_smb_message(req->mid);
        }
 
        status = check_name(conn, smb_fname->base_name);
@@ -1569,7 +1609,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        }
 
        /* ignore any oplock requests if oplocks are disabled */
-       if (!lp_oplocks(SNUM(conn)) || global_client_failed_oplock_break ||
+       if (!lp_oplocks(SNUM(conn)) ||
            IS_VETO_OPLOCK_PATH(conn, smb_fname->base_name)) {
                /* Mask off everything except the private Samba bits. */
                oplock_request &= SAMBA_PRIVATE_OPLOCK_MASK;
@@ -1714,7 +1754,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                /* DENY_DOS opens are always underlying read-write on the
                   file handle, no matter what the requested access mask
                    says. */
-               if ((create_options & NTCREATEX_OPTIONS_PRIVATE_DENY_DOS) ||
+               if ((private_flags & NTCREATEX_OPTIONS_PRIVATE_DENY_DOS) ||
                        access_mask & (FILE_READ_ATTRIBUTES|FILE_READ_DATA|FILE_READ_EA|FILE_EXECUTE)) {
                        flags = O_RDWR;
                } else {
@@ -1763,7 +1803,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
        fsp->file_id = vfs_file_id_from_sbuf(conn, &smb_fname->st);
        fsp->share_access = share_access;
-       fsp->fh->private_options = create_options;
+       fsp->fh->private_options = private_flags;
        fsp->access_mask = open_access_mask; /* We change this to the
                                              * requested access_mask after
                                              * the open is done. */
@@ -1831,7 +1871,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
                        /* Check if this can be done with the deny_dos and fcb
                         * calls. */
-                       if (create_options &
+                       if (private_flags &
                            (NTCREATEX_OPTIONS_PRIVATE_DENY_DOS|
                             NTCREATEX_OPTIONS_PRIVATE_DENY_FCB)) {
                                if (req == NULL) {
@@ -1957,7 +1997,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
 
         if ((flags2 & O_CREAT) && lp_inherit_acls(SNUM(conn)) &&
            (def_acl = directory_has_default_acl(conn, parent_dir))) {
-               unx_mode = 0777;
+               unx_mode = (0777 & lp_create_mask(SNUM(conn)));
        }
 
        DEBUG(4,("calling open_file with flags=0x%X flags2=0x%X mode=0%o, "
@@ -1970,7 +2010,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         * open_file strips any O_TRUNC flags itself.
         */
 
-       fsp_open = open_file(fsp, conn, req, parent_dir, smb_fname,
+       fsp_open = open_file(fsp, conn, req, parent_dir,
                             flags|flags2, unx_mode, access_mask,
                             open_access_mask);
 
@@ -2091,6 +2131,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
           note that GPFS supports it as well - jmcd */
 
        if (fsp->fh->fd != -1) {
+               int ret_flock;
                ret_flock = SMB_VFS_KERNEL_FLOCK(fsp, share_access, access_mask);
                if(ret_flock == -1 ){
 
@@ -2111,7 +2152,7 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
         * If requested, truncate the file.
         */
 
-       if (flags2&O_TRUNC) {
+       if (file_existed && (flags2&O_TRUNC)) {
                /*
                 * We are modifing the file after open - update the stat
                 * struct..
@@ -2125,9 +2166,6 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                }
        }
 
-       /* Record the options we were opened with. */
-       fsp->share_access = share_access;
-       fsp->fh->private_options = create_options;
        /*
         * According to Samba4, SEC_FILE_READ_ATTRIBUTE is always granted,
         */
@@ -2166,13 +2204,13 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
                new_file_created = True;
        }
 
-       set_share_mode(lck, fsp, conn->server_info->utok.uid, 0,
+       set_share_mode(lck, fsp, get_current_uid(conn), 0,
                       fsp->oplock_type);
 
        /* Handle strange delete on close create semantics. */
        if (create_options & FILE_DELETE_ON_CLOSE) {
 
-               status = can_set_delete_on_close(fsp, True, new_dos_attributes);
+               status = can_set_delete_on_close(fsp, new_dos_attributes);
 
                if (!NT_STATUS_IS_OK(status)) {
                        /* Remember to delete the mode we just added. */
@@ -2248,7 +2286,8 @@ static NTSTATUS open_file_ntcreate(connection_struct *conn,
        /* If this is a successful open, we must remove any deferred open
         * records. */
        if (req != NULL) {
-               del_deferred_open_entry(lck, req->mid);
+               del_deferred_open_entry(lck, req->mid,
+                                       sconn_server_id(req->sconn));
        }
        TALLOC_FREE(lck);
 
@@ -2289,6 +2328,7 @@ NTSTATUS open_file_fchmod(struct smb_request *req, connection_struct *conn,
                0,                                      /* file_attributes */
                0,                                      /* oplock_request */
                0,                                      /* allocation_size */
+               0,                                      /* private_flags */
                NULL,                                   /* sd */
                NULL,                                   /* ea_list */
                &fsp,                                   /* result */
@@ -2383,7 +2423,7 @@ static NTSTATUS mkdir_internal(connection_struct *conn,
                                         smb_dname->base_name, mode);
        }
 
-       if (!(file_attributes & FILE_FLAG_POSIX_SEMANTICS)) {
+       if (!posix_open) {
                /*
                 * Check if high bits should have been set,
                 * then (if bits are missing): add them.
@@ -2435,6 +2475,9 @@ static NTSTATUS open_directory(connection_struct *conn,
 
        SMB_ASSERT(!is_ntfs_stream_smb_fname(smb_dname));
 
+       /* Ensure we have a directory attribute. */
+       file_attributes |= FILE_ATTRIBUTE_DIRECTORY;
+
        DEBUG(5,("open_directory: opening directory %s, access_mask = 0x%x, "
                 "share_access = 0x%x create_options = 0x%x, "
                 "create_disposition = 0x%x, file_attributes = 0x%x\n",
@@ -2463,8 +2506,9 @@ static NTSTATUS open_directory(connection_struct *conn,
                return status;
        }
 
-       /* We need to support SeSecurityPrivilege for this. */
-       if (access_mask & SEC_FLAG_SYSTEM_SECURITY) {
+       if ((access_mask & SEC_FLAG_SYSTEM_SECURITY) &
+                       !security_token_has_privilege(get_current_nttok(conn),
+                                       SEC_PRIV_SECURITY)) {
                DEBUG(10, ("open_directory: open on %s "
                        "failed - SEC_FLAG_SYSTEM_SECURITY denied.\n",
                        smb_fname_str_dbg(smb_dname)));
@@ -2593,12 +2637,12 @@ static NTSTATUS open_directory(connection_struct *conn,
        fsp->can_write = False;
 
        fsp->share_access = share_access;
-       fsp->fh->private_options = create_options;
+       fsp->fh->private_options = 0;
        /*
         * According to Samba4, SEC_FILE_READ_ATTRIBUTE is always granted,
         */
        fsp->access_mask = access_mask | FILE_READ_ATTRIBUTES;
-       fsp->print_file = False;
+       fsp->print_file = NULL;
        fsp->modified = False;
        fsp->oplock_type = NO_OPLOCK;
        fsp->sent_oplock_break = NO_BREAK_SENT;
@@ -2630,12 +2674,12 @@ static NTSTATUS open_directory(connection_struct *conn,
                return status;
        }
 
-       set_share_mode(lck, fsp, conn->server_info->utok.uid, 0, NO_OPLOCK);
+       set_share_mode(lck, fsp, get_current_uid(conn), 0, NO_OPLOCK);
 
        /* For directories the delete on close bit at open time seems
           always to be honored on close... See test 19 in Samba4 BASE-DELETE. */
        if (create_options & FILE_DELETE_ON_CLOSE) {
-               status = can_set_delete_on_close(fsp, True, 0);
+               status = can_set_delete_on_close(fsp, 0);
                if (!NT_STATUS_IS_OK(status) && !NT_STATUS_EQUAL(status, NT_STATUS_DIRECTORY_NOT_EMPTY)) {
                        TALLOC_FREE(lck);
                        file_free(req, fsp);
@@ -2677,6 +2721,7 @@ NTSTATUS create_directory(connection_struct *conn, struct smb_request *req,
                FILE_ATTRIBUTE_DIRECTORY,               /* file_attributes */
                0,                                      /* oplock_request */
                0,                                      /* allocation_size */
+               0,                                      /* private_flags */
                NULL,                                   /* sd */
                NULL,                                   /* ea_list */
                &fsp,                                   /* result */
@@ -2700,6 +2745,7 @@ void msg_file_was_renamed(struct messaging_context *msg,
                          struct server_id server_id,
                          DATA_BLOB *data)
 {
+       struct smbd_server_connection *sconn;
        files_struct *fsp;
        char *frm = (char *)data->data;
        struct file_id id;
@@ -2710,6 +2756,12 @@ void msg_file_was_renamed(struct messaging_context *msg,
        size_t sp_len, bn_len;
        NTSTATUS status;
 
+       sconn = msg_ctx_to_sconn(msg);
+       if (sconn == NULL) {
+               DEBUG(1, ("could not find sconn\n"));
+               return;
+       }
+
        if (data->data == NULL
            || data->length < MSG_FILE_RENAMED_MIN_SIZE + 2) {
                 DEBUG(0, ("msg_file_was_renamed: Got invalid msg len %d\n",
@@ -2741,7 +2793,8 @@ void msg_file_was_renamed(struct messaging_context *msg,
                sharepath, smb_fname_str_dbg(smb_fname),
                file_id_string_tos(&id)));
 
-       for(fsp = file_find_di_first(id); fsp; fsp = file_find_di_next(fsp)) {
+       for(fsp = file_find_di_first(sconn, id); fsp;
+           fsp = file_find_di_next(fsp)) {
                if (memcmp(fsp->conn->connectpath, sharepath, sp_len) == 0) {
 
                        DEBUG(10,("msg_file_was_renamed: renaming file fnum %d from %s -> %s\n",
@@ -2770,52 +2823,6 @@ void msg_file_was_renamed(struct messaging_context *msg,
        return;
 }
 
-struct case_semantics_state {
-       connection_struct *conn;
-       bool case_sensitive;
-       bool case_preserve;
-       bool short_case_preserve;
-};
-
-/****************************************************************************
- Restore case semantics.
-****************************************************************************/
-static int restore_case_semantics(struct case_semantics_state *state)
-{
-       state->conn->case_sensitive = state->case_sensitive;
-       state->conn->case_preserve = state->case_preserve;
-       state->conn->short_case_preserve = state->short_case_preserve;
-       return 0;
-}
-
-/****************************************************************************
- Save case semantics.
-****************************************************************************/
-struct case_semantics_state *set_posix_case_semantics(TALLOC_CTX *mem_ctx,
-                                                     connection_struct *conn)
-{
-       struct case_semantics_state *result;
-
-       if (!(result = talloc(mem_ctx, struct case_semantics_state))) {
-               DEBUG(0, ("talloc failed\n"));
-               return NULL;
-       }
-
-       result->conn = conn;
-       result->case_sensitive = conn->case_sensitive;
-       result->case_preserve = conn->case_preserve;
-       result->short_case_preserve = conn->short_case_preserve;
-
-       /* Set to POSIX. */
-       conn->case_sensitive = True;
-       conn->case_preserve = True;
-       conn->short_case_preserve = True;
-
-       talloc_set_destructor(result, restore_case_semantics);
-
-       return result;
-}
-
 /*
  * If a main file is opened for delete, all streams need to be checked for
  * !FILE_SHARE_DELETE. Do this by opening with DELETE_ACCESS.
@@ -2892,10 +2899,11 @@ NTSTATUS open_streams_for_delete(connection_struct *conn,
                         (FILE_SHARE_READ |     /* share_access */
                             FILE_SHARE_WRITE | FILE_SHARE_DELETE),
                         FILE_OPEN,             /* create_disposition*/
-                        NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE, /* create_options */
+                        0,                     /* create_options */
                         FILE_ATTRIBUTE_NORMAL, /* file_attributes */
                         0,                     /* oplock_request */
                         0,                     /* allocation_size */
+                        NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE, /* private_flags */
                         NULL,                  /* sd */
                         NULL,                  /* ea_list */
                         &streams[i],           /* result */
@@ -2945,6 +2953,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                                     uint32_t file_attributes,
                                     uint32_t oplock_request,
                                     uint64_t allocation_size,
+                                    uint32_t private_flags,
                                     struct security_descriptor *sd,
                                     struct ea_list *ea_list,
 
@@ -2959,7 +2968,8 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
        DEBUG(10,("create_file_unixpath: access_mask = 0x%x "
                  "file_attributes = 0x%x, share_access = 0x%x, "
                  "create_disposition = 0x%x create_options = 0x%x "
-                 "oplock_request = 0x%x ea_list = 0x%p, sd = 0x%p, "
+                 "oplock_request = 0x%x private_flags = 0x%x "
+                 "ea_list = 0x%p, sd = 0x%p, "
                  "fname = %s\n",
                  (unsigned int)access_mask,
                  (unsigned int)file_attributes,
@@ -2967,6 +2977,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                  (unsigned int)create_disposition,
                  (unsigned int)create_options,
                  (unsigned int)oplock_request,
+                 (unsigned int)private_flags,
                  ea_list, sd, smb_fname_str_dbg(smb_fname)));
 
        if (create_options & FILE_OPEN_BY_FILE_ID) {
@@ -3019,33 +3030,19 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                goto fail;
        }
 
-#if 0
-       /* We need to support SeSecurityPrivilege for this. */
        if ((access_mask & SEC_FLAG_SYSTEM_SECURITY) &&
-           !user_has_privileges(current_user.nt_user_token,
-                                &se_security)) {
-               status = NT_STATUS_PRIVILEGE_NOT_HELD;
-               goto fail;
-       }
-#else
-       /* We need to support SeSecurityPrivilege for this. */
-       if (access_mask & SEC_FLAG_SYSTEM_SECURITY) {
-               status = NT_STATUS_PRIVILEGE_NOT_HELD;
-               goto fail;
-       }
-       /* Don't allow a SACL set from an NTtrans create until we
-        * support SeSecurityPrivilege. */
-       if (!VALID_STAT(smb_fname->st) &&
-                       lp_nt_acl_support(SNUM(conn)) &&
-                       sd && (sd->sacl != NULL)) {
+                       !security_token_has_privilege(get_current_nttok(conn),
+                                       SEC_PRIV_SECURITY)) {
+               DEBUG(10, ("create_file_unixpath: open on %s "
+                       "failed - SEC_FLAG_SYSTEM_SECURITY denied.\n",
+                       smb_fname_str_dbg(smb_fname)));
                status = NT_STATUS_PRIVILEGE_NOT_HELD;
                goto fail;
        }
-#endif
 
        if ((conn->fs_capabilities & FILE_NAMED_STREAMS)
            && is_ntfs_stream_smb_fname(smb_fname)
-           && (!(create_options & NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE))) {
+           && (!(private_flags & NTCREATEX_OPTIONS_PRIVATE_STREAM_DELETE))) {
                uint32 base_create_disposition;
                struct smb_filename *smb_fname_base = NULL;
 
@@ -3083,7 +3080,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                                              | FILE_SHARE_WRITE
                                              | FILE_SHARE_DELETE,
                                              base_create_disposition,
-                                             0, 0, 0, 0, NULL, NULL,
+                                             0, 0, 0, 0, 0, NULL, NULL,
                                              &base_fsp, NULL);
                TALLOC_FREE(smb_fname_base);
 
@@ -3137,6 +3134,11 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                        goto fail;
                }
 
+               status = fsp_set_smb_fname(fsp, smb_fname);
+               if (!NT_STATUS_IS_OK(status)) {
+                       goto fail;
+               }
+
                /*
                 * We're opening the stream element of a base_fsp
                 * we already opened. Set up the base_fsp pointer.
@@ -3147,13 +3149,13 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 
                status = open_file_ntcreate(conn,
                                            req,
-                                           smb_fname,
                                            access_mask,
                                            share_access,
                                            create_disposition,
                                            create_options,
                                            file_attributes,
                                            oplock_request,
+                                           private_flags,
                                            &info,
                                            fsp);
 
@@ -3221,10 +3223,10 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
                security_acl_map_generic(sd->dacl, &file_generic_mapping);
                security_acl_map_generic(sd->sacl, &file_generic_mapping);
 
-               if (sec_info_sent & (OWNER_SECURITY_INFORMATION|
-                                       GROUP_SECURITY_INFORMATION|
-                                       DACL_SECURITY_INFORMATION|
-                                       SACL_SECURITY_INFORMATION)) {
+               if (sec_info_sent & (SECINFO_OWNER|
+                                       SECINFO_GROUP|
+                                       SECINFO_DACL|
+                                       SECINFO_SACL)) {
                        status = SMB_VFS_FSET_NT_ACL(fsp, sec_info_sent, sd);
                }
 
@@ -3237,7 +3239,7 @@ static NTSTATUS create_file_unixpath(connection_struct *conn,
 
        if ((ea_list != NULL) &&
            ((info == FILE_WAS_CREATED) || (info == FILE_WAS_OVERWRITTEN))) {
-               status = set_ea(conn, fsp, smb_fname, ea_list);
+               status = set_ea(conn, fsp, fsp->fsp_name, ea_list);
                if (!NT_STATUS_IS_OK(status)) {
                        goto fail;
                }
@@ -3423,6 +3425,7 @@ NTSTATUS create_file_default(connection_struct *conn,
                             uint32_t file_attributes,
                             uint32_t oplock_request,
                             uint64_t allocation_size,
+                            uint32_t private_flags,
                             struct security_descriptor *sd,
                             struct ea_list *ea_list,
                             files_struct **result,
@@ -3431,11 +3434,13 @@ NTSTATUS create_file_default(connection_struct *conn,
        int info = FILE_WAS_OPENED;
        files_struct *fsp = NULL;
        NTSTATUS status;
+       bool stream_name = false;
 
        DEBUG(10,("create_file: access_mask = 0x%x "
                  "file_attributes = 0x%x, share_access = 0x%x, "
                  "create_disposition = 0x%x create_options = 0x%x "
                  "oplock_request = 0x%x "
+                 "private_flags = 0x%x "
                  "root_dir_fid = 0x%x, ea_list = 0x%p, sd = 0x%p, "
                  "fname = %s\n",
                  (unsigned int)access_mask,
@@ -3444,6 +3449,7 @@ NTSTATUS create_file_default(connection_struct *conn,
                  (unsigned int)create_disposition,
                  (unsigned int)create_options,
                  (unsigned int)oplock_request,
+                 (unsigned int)private_flags,
                  (unsigned int)root_dir_fid,
                  ea_list, sd, smb_fname_str_dbg(smb_fname)));
 
@@ -3463,7 +3469,8 @@ NTSTATUS create_file_default(connection_struct *conn,
         * Check to see if this is a mac fork of some kind.
         */
 
-       if (is_ntfs_stream_smb_fname(smb_fname)) {
+       stream_name = is_ntfs_stream_smb_fname(smb_fname);
+       if (stream_name) {
                enum FAKE_FILE_TYPE fake_file_type;
 
                fake_file_type = is_fake_file(smb_fname);
@@ -3505,10 +3512,31 @@ NTSTATUS create_file_default(connection_struct *conn,
                goto fail;
        }
 
+       if (stream_name && is_ntfs_default_stream_smb_fname(smb_fname)) {
+               int ret;
+               smb_fname->stream_name = NULL;
+               /* We have to handle this error here. */
+               if (create_options & FILE_DIRECTORY_FILE) {
+                       status = NT_STATUS_NOT_A_DIRECTORY;
+                       goto fail;
+               }
+               if (lp_posix_pathnames()) {
+                       ret = SMB_VFS_LSTAT(conn, smb_fname);
+               } else {
+                       ret = SMB_VFS_STAT(conn, smb_fname);
+               }
+
+               if (ret == 0 && VALID_STAT_OF_DIR(smb_fname->st)) {
+                       status = NT_STATUS_FILE_IS_A_DIRECTORY;
+                       goto fail;
+               }
+       }
+
        status = create_file_unixpath(
                conn, req, smb_fname, access_mask, share_access,
                create_disposition, create_options, file_attributes,
-               oplock_request, allocation_size, sd, ea_list,
+               oplock_request, allocation_size, private_flags,
+               sd, ea_list,
                &fsp, &info);
 
        if (!NT_STATUS_IS_OK(status)) {