s3:ntlm_auth: fix memory leak in the raw ntlmssp code path
[metze/samba/wip.git] / source3 / utils / ntlm_auth.c
index 049aa309e65d70271401f7fba6e6a9c698d535ee..666bb5bbea6053ad0eba31190262bc71124f4514 100644 (file)
 */
 
 #include "includes.h"
+#include "popt_common.h"
 #include "utils/ntlm_auth.h"
 #include "../libcli/auth/libcli_auth.h"
 #include "../libcli/auth/spnego.h"
-#include "ntlmssp.h"
+#include "../libcli/auth/ntlmssp.h"
 #include "smb_krb5.h"
 #include <iniparser.h>
+#include "../lib/crypto/arcfour.h"
+#include "libads/kerberos_proto.h"
+#include "nsswitch/winbind_client.h"
+#include "librpc/gen_ndr/krb5pac.h"
 
 #ifndef PAM_WINBIND_CONFIG_FILE
 #define PAM_WINBIND_CONFIG_FILE "/etc/security/pam_winbind.conf"
@@ -561,7 +566,8 @@ static NTSTATUS contact_winbind_change_pswd_auth_crap(const char *username,
     return nt_status;
 }
 
-static NTSTATUS winbind_pw_check(struct ntlmssp_state *ntlmssp_state, DATA_BLOB *user_session_key, DATA_BLOB *lm_session_key) 
+static NTSTATUS winbind_pw_check(struct ntlmssp_state *ntlmssp_state, TALLOC_CTX *mem_ctx,
+                                DATA_BLOB *user_session_key, DATA_BLOB *lm_session_key)
 {
        static const char zeros[16] = { 0, };
        NTSTATUS nt_status;
@@ -581,13 +587,13 @@ static NTSTATUS winbind_pw_check(struct ntlmssp_state *ntlmssp_state, DATA_BLOB
 
        if (NT_STATUS_IS_OK(nt_status)) {
                if (memcmp(lm_key, zeros, 8) != 0) {
-                       *lm_session_key = data_blob_talloc(ntlmssp_state, NULL, 16);
+                       *lm_session_key = data_blob_talloc(mem_ctx, NULL, 16);
                        memcpy(lm_session_key->data, lm_key, 8);
                        memset(lm_session_key->data+8, '\0', 8);
                }
 
                if (memcmp(user_sess_key, zeros, 16) != 0) {
-                       *user_session_key = data_blob_talloc(ntlmssp_state, user_sess_key, 16);
+                       *user_session_key = data_blob_talloc(mem_ctx, user_sess_key, 16);
                }
                ntlmssp_state->callback_private = talloc_strdup(ntlmssp_state,
                                                                unix_name);
@@ -605,14 +611,15 @@ static NTSTATUS winbind_pw_check(struct ntlmssp_state *ntlmssp_state, DATA_BLOB
        return nt_status;
 }
 
-static NTSTATUS local_pw_check(struct ntlmssp_state *ntlmssp_state, DATA_BLOB *user_session_key, DATA_BLOB *lm_session_key) 
+static NTSTATUS local_pw_check(struct ntlmssp_state *ntlmssp_state, TALLOC_CTX *mem_ctx,
+                              DATA_BLOB *user_session_key, DATA_BLOB *lm_session_key)
 {
        NTSTATUS nt_status;
        struct samr_Password lm_pw, nt_pw;
 
        nt_lm_owf_gen (opt_password, nt_pw.hash, lm_pw.hash);
 
-       nt_status = ntlm_password_check(ntlmssp_state,
+       nt_status = ntlm_password_check(mem_ctx,
                                        true, true, 0,
                                        &ntlmssp_state->chal,
                                        &ntlmssp_state->lm_resp,
@@ -655,7 +662,7 @@ static NTSTATUS ntlm_auth_start_ntlmssp_client(struct ntlmssp_state **client_ntl
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(1, ("Could not start NTLMSSP client: %s\n",
                          nt_errstr(status)));
-               ntlmssp_end(client_ntlmssp_state);
+               TALLOC_FREE(*client_ntlmssp_state);
                return status;
        }
 
@@ -664,7 +671,7 @@ static NTSTATUS ntlm_auth_start_ntlmssp_client(struct ntlmssp_state **client_ntl
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(1, ("Could not set username: %s\n",
                          nt_errstr(status)));
-               ntlmssp_end(client_ntlmssp_state);
+               TALLOC_FREE(*client_ntlmssp_state);
                return status;
        }
 
@@ -673,7 +680,7 @@ static NTSTATUS ntlm_auth_start_ntlmssp_client(struct ntlmssp_state **client_ntl
        if (!NT_STATUS_IS_OK(status)) {
                DEBUG(1, ("Could not set domain: %s\n",
                          nt_errstr(status)));
-               ntlmssp_end(client_ntlmssp_state);
+               TALLOC_FREE(*client_ntlmssp_state);
                return status;
        }
 
@@ -683,7 +690,7 @@ static NTSTATUS ntlm_auth_start_ntlmssp_client(struct ntlmssp_state **client_ntl
                if (!NT_STATUS_IS_OK(status)) {
                        DEBUG(1, ("Could not set password: %s\n",
                                  nt_errstr(status)));
-                       ntlmssp_end(client_ntlmssp_state);
+                       TALLOC_FREE(*client_ntlmssp_state);
                        return status;
                }
        }
@@ -758,7 +765,7 @@ static NTSTATUS do_ccache_ntlm_auth(DATA_BLOB initial_msg, DATA_BLOB challenge_m
         * child of the trusted domain. If we ask the primary domain for
         * ntlm_ccache_auth, it will fail. So, we have to ask the trusted
         * domain's child for ccache_ntlm_auth. that is to say, we have to 
-        * set WBFALG_PAM_CONTACT_TRUSTDOM in request.flags.
+        * set WBFLAG_PAM_CONTACT_TRUSTDOM in request.flags.
         */
        ctrl = get_pam_winbind_config();
 
@@ -806,15 +813,17 @@ static NTSTATUS do_ccache_ntlm_auth(DATA_BLOB initial_msg, DATA_BLOB challenge_m
        return NT_STATUS_MORE_PROCESSING_REQUIRED;
 }
 
-static void manage_squid_ntlmssp_request(struct ntlm_auth_state *state,
-                                               char *buf, int length)
+static void manage_squid_ntlmssp_request_int(struct ntlm_auth_state *state,
+                                            char *buf, int length,
+                                            TALLOC_CTX *mem_ctx,
+                                            char **response)
 {
        DATA_BLOB request, reply;
        NTSTATUS nt_status;
 
        if (strlen(buf) < 2) {
-               DEBUG(1, ("NTLMSSP query [%s] invalid", buf));
-               x_fprintf(x_stdout, "BH NTLMSSP query invalid\n");
+               DEBUG(1, ("NTLMSSP query [%s] invalid\n", buf));
+               *response = talloc_strdup(mem_ctx, "BH NTLMSSP query invalid");
                return;
        }
 
@@ -824,7 +833,7 @@ static void manage_squid_ntlmssp_request(struct ntlm_auth_state *state,
                        TALLOC_FREE(state->want_feature_list);
                        state->want_feature_list = talloc_strdup(state->mem_ctx,
                                        buf+3);
-                       x_fprintf(x_stdout, "OK\n");
+                       *response = talloc_strdup(mem_ctx, "OK");
                        return;
                }
                request = base64_decode_data_blob(buf + 3);
@@ -841,19 +850,18 @@ static void manage_squid_ntlmssp_request(struct ntlm_auth_state *state,
 
                if (opt_password == NULL) {
                        DEBUG(1, ("Out of memory\n"));
-                       x_fprintf(x_stdout, "BH Out of memory\n");
+                       *response = talloc_strdup(mem_ctx, "BH Out of memory");
                        data_blob_free(&request);
                        return;
                }
 
-               x_fprintf(x_stdout, "OK\n");
+               *response = talloc_strdup(mem_ctx, "OK");
                data_blob_free(&request);
                return;
        }
 
        if (strncmp(buf, "YR", 2) == 0) {
-               if (state->ntlmssp_state)
-                       ntlmssp_end(&state->ntlmssp_state);
+               TALLOC_FREE(state->ntlmssp_state);
                state->svr_state = SERVER_INITIAL;
        } else if (strncmp(buf, "KK", 2) == 0) {
                /* No special preprocessing required */
@@ -861,10 +869,11 @@ static void manage_squid_ntlmssp_request(struct ntlm_auth_state *state,
                DEBUG(10, ("Requested negotiated NTLMSSP flags\n"));
 
                if (state->svr_state == SERVER_FINISHED) {
-                       x_fprintf(x_stdout, "GF 0x%08x\n", state->neg_flags);
+                       *response = talloc_asprintf(mem_ctx, "GF 0x%08x",
+                                                state->neg_flags);
                }
                else {
-                       x_fprintf(x_stdout, "BH\n");
+                       *response = talloc_strdup(mem_ctx, "BH\n");
                }
                data_blob_free(&request);
                return;
@@ -873,17 +882,18 @@ static void manage_squid_ntlmssp_request(struct ntlm_auth_state *state,
                if(state->have_session_key) {
                        char *key64 = base64_encode_data_blob(state->mem_ctx,
                                        state->session_key);
-                       x_fprintf(x_stdout, "GK %s\n", key64?key64:"<NULL>");
+                       *response = talloc_asprintf(mem_ctx, "GK %s",
+                                                key64 ? key64 : "<NULL>");
                        TALLOC_FREE(key64);
                } else {
-                       x_fprintf(x_stdout, "BH\n");
+                       *response = talloc_strdup(mem_ctx, "BH");
                }
 
                data_blob_free(&request);
                return;
        } else {
-               DEBUG(1, ("NTLMSSP query [%s] invalid", buf));
-               x_fprintf(x_stdout, "BH NTLMSSP query invalid\n");
+               DEBUG(1, ("NTLMSSP query [%s] invalid\n", buf));
+               *response = talloc_strdup(mem_ctx, "BH NTLMSSP query invalid");
                return;
        }
 
@@ -891,7 +901,8 @@ static void manage_squid_ntlmssp_request(struct ntlm_auth_state *state,
                nt_status = ntlm_auth_start_ntlmssp_server(
                                &state->ntlmssp_state);
                if (!NT_STATUS_IS_OK(nt_status)) {
-                       x_fprintf(x_stdout, "BH %s\n", nt_errstr(nt_status));
+                       *response = talloc_asprintf(
+                               mem_ctx, "BH %s", nt_errstr(nt_status));
                        return;
                }
                ntlmssp_want_feature_list(state->ntlmssp_state,
@@ -906,22 +917,25 @@ static void manage_squid_ntlmssp_request(struct ntlm_auth_state *state,
        if (NT_STATUS_EQUAL(nt_status, NT_STATUS_MORE_PROCESSING_REQUIRED)) {
                char *reply_base64 = base64_encode_data_blob(state->mem_ctx,
                                reply);
-               x_fprintf(x_stdout, "TT %s\n", reply_base64);
+               *response = talloc_asprintf(mem_ctx, "TT %s", reply_base64);
                TALLOC_FREE(reply_base64);
                data_blob_free(&reply);
                state->svr_state = SERVER_CHALLENGE;
                DEBUG(10, ("NTLMSSP challenge\n"));
        } else if (NT_STATUS_EQUAL(nt_status, NT_STATUS_ACCESS_DENIED)) {
-               x_fprintf(x_stdout, "BH %s\n", nt_errstr(nt_status));
+               *response = talloc_asprintf(mem_ctx, "BH %s",
+                                        nt_errstr(nt_status));
                DEBUG(0, ("NTLMSSP BH: %s\n", nt_errstr(nt_status)));
 
-               ntlmssp_end(&state->ntlmssp_state);
+               TALLOC_FREE(state->ntlmssp_state);
        } else if (!NT_STATUS_IS_OK(nt_status)) {
-               x_fprintf(x_stdout, "NA %s\n", nt_errstr(nt_status));
+               *response = talloc_asprintf(mem_ctx, "NA %s",
+                                        nt_errstr(nt_status));
                DEBUG(10, ("NTLMSSP %s\n", nt_errstr(nt_status)));
        } else {
-               x_fprintf(x_stdout, "AF %s\n",
-                               (char *)state->ntlmssp_state->callback_private);
+               *response = talloc_asprintf(
+                       mem_ctx, "AF %s",
+                       (char *)state->ntlmssp_state->callback_private);
                DEBUG(10, ("NTLMSSP OK!\n"));
 
                if(state->have_session_key)
@@ -937,6 +951,22 @@ static void manage_squid_ntlmssp_request(struct ntlm_auth_state *state,
        data_blob_free(&request);
 }
 
+static void manage_squid_ntlmssp_request(struct ntlm_auth_state *state,
+                                        char *buf, int length)
+{
+       char *response;
+
+       manage_squid_ntlmssp_request_int(state, buf, length,
+                                        talloc_tos(), &response);
+
+       if (response == NULL) {
+               x_fprintf(x_stdout, "BH Out of memory\n");
+               return;
+       }
+       x_fprintf(x_stdout, "%s\n", response);
+       TALLOC_FREE(response);
+}
+
 static void manage_client_ntlmssp_request(struct ntlm_auth_state *state,
                                                char *buf, int length)
 {
@@ -949,7 +979,7 @@ static void manage_client_ntlmssp_request(struct ntlm_auth_state *state,
        }
 
        if (strlen(buf) < 2) {
-               DEBUG(1, ("NTLMSSP query [%s] invalid", buf));
+               DEBUG(1, ("NTLMSSP query [%s] invalid\n", buf));
                x_fprintf(x_stdout, "BH NTLMSSP query invalid\n");
                return;
        }
@@ -1008,8 +1038,7 @@ static void manage_client_ntlmssp_request(struct ntlm_auth_state *state,
        }
 
        if (strncmp(buf, "YR", 2) == 0) {
-               if (state->ntlmssp_state)
-                       ntlmssp_end(&state->ntlmssp_state);
+               TALLOC_FREE(state->ntlmssp_state);
                state->cli_state = CLIENT_INITIAL;
        } else if (strncmp(buf, "TT", 2) == 0) {
                /* No special preprocessing required */
@@ -1041,7 +1070,7 @@ static void manage_client_ntlmssp_request(struct ntlm_auth_state *state,
                data_blob_free(&request);
                return;
        } else {
-               DEBUG(1, ("NTLMSSP query [%s] invalid", buf));
+               DEBUG(1, ("NTLMSSP query [%s] invalid\n", buf));
                x_fprintf(x_stdout, "BH NTLMSSP query invalid\n");
                return;
        }
@@ -1100,14 +1129,12 @@ static void manage_client_ntlmssp_request(struct ntlm_auth_state *state,
 
                DEBUG(10, ("NTLMSSP OK!\n"));
                state->cli_state = CLIENT_FINISHED;
-               if (state->ntlmssp_state)
-                       ntlmssp_end(&state->ntlmssp_state);
+               TALLOC_FREE(state->ntlmssp_state);
        } else {
                x_fprintf(x_stdout, "BH %s\n", nt_errstr(nt_status));
                DEBUG(0, ("NTLMSSP BH: %s\n", nt_errstr(nt_status)));
                state->cli_state = CLIENT_ERROR;
-               if (state->ntlmssp_state)
-                       ntlmssp_end(&state->ntlmssp_state);
+               TALLOC_FREE(state->ntlmssp_state);
        }
 
        data_blob_free(&request);
@@ -1165,18 +1192,18 @@ static void offer_gss_spnego_mechs(void) {
 
        /* Server negTokenInit (mech offerings) */
        spnego.type = SPNEGO_NEG_TOKEN_INIT;
-       spnego.negTokenInit.mechTypes = SMB_XMALLOC_ARRAY(const char *, 2);
+       spnego.negTokenInit.mechTypes = talloc_array(ctx, const char *, 3);
 #ifdef HAVE_KRB5
-       spnego.negTokenInit.mechTypes[0] = smb_xstrdup(OID_KERBEROS5_OLD);
-       spnego.negTokenInit.mechTypes[1] = smb_xstrdup(OID_NTLMSSP);
+       spnego.negTokenInit.mechTypes[0] = talloc_strdup(ctx, OID_KERBEROS5_OLD);
+       spnego.negTokenInit.mechTypes[1] = talloc_strdup(ctx, OID_NTLMSSP);
        spnego.negTokenInit.mechTypes[2] = NULL;
 #else
-       spnego.negTokenInit.mechTypes[0] = smb_xstrdup(OID_NTLMSSP);
+       spnego.negTokenInit.mechTypes[0] = talloc_strdup(ctx, OID_NTLMSSP);
        spnego.negTokenInit.mechTypes[1] = NULL;
 #endif
 
 
-       spnego.negTokenInit.mechListMIC = data_blob(principal,
+       spnego.negTokenInit.mechListMIC = data_blob_talloc(ctx, principal,
                                                    strlen(principal));
 
        len = spnego_write_data(ctx, &token, &spnego);
@@ -1197,6 +1224,45 @@ static void offer_gss_spnego_mechs(void) {
        return;
 }
 
+bool spnego_parse_krb5_wrap(TALLOC_CTX *ctx, DATA_BLOB blob, DATA_BLOB *ticket, uint8 tok_id[2])
+{
+       bool ret;
+       ASN1_DATA *data;
+       int data_remaining;
+
+       data = asn1_init(talloc_tos());
+       if (data == NULL) {
+               return false;
+       }
+
+       asn1_load(data, blob);
+       asn1_start_tag(data, ASN1_APPLICATION(0));
+       asn1_check_OID(data, OID_KERBEROS5);
+
+       data_remaining = asn1_tag_remaining(data);
+
+       if (data_remaining < 3) {
+               data->has_error = True;
+       } else {
+               asn1_read(data, tok_id, 2);
+               data_remaining -= 2;
+               *ticket = data_blob_talloc(ctx, NULL, data_remaining);
+               asn1_read(data, ticket->data, ticket->length);
+       }
+
+       asn1_end_tag(data);
+
+       ret = !data->has_error;
+
+       if (data->has_error) {
+               data_blob_free(ticket);
+       }
+
+       asn1_free(data);
+
+       return ret;
+}
+
 static void manage_gss_spnego_request(struct ntlm_auth_state *state,
                                        char *buf, int length)
 {
@@ -1215,18 +1281,17 @@ static void manage_gss_spnego_request(struct ntlm_auth_state *state,
        char *reply_argument = NULL;
 
        if (strlen(buf) < 2) {
-               DEBUG(1, ("SPENGO query [%s] invalid", buf));
+               DEBUG(1, ("SPENGO query [%s] invalid\n", buf));
                x_fprintf(x_stdout, "BH SPENGO query invalid\n");
                return;
        }
 
        if (strncmp(buf, "YR", 2) == 0) {
-               if (ntlmssp_state)
-                       ntlmssp_end(&ntlmssp_state);
+               TALLOC_FREE(ntlmssp_state);
        } else if (strncmp(buf, "KK", 2) == 0) {
                ;
        } else {
-               DEBUG(1, ("SPENGO query [%s] invalid", buf));
+               DEBUG(1, ("SPENGO query [%s] invalid\n", buf));
                x_fprintf(x_stdout, "BH SPENGO query invalid\n");
                return;
        }
@@ -1249,11 +1314,38 @@ static void manage_gss_spnego_request(struct ntlm_auth_state *state,
        }
 
        token = base64_decode_data_blob(buf + 3);
+
+       if ((token.length >= 7)
+           && (strncmp((char *)token.data, "NTLMSSP", 7) == 0)) {
+               char *reply;
+
+               data_blob_free(&token);
+
+               DEBUG(10, ("Could not parse GSS-SPNEGO, trying raw "
+                          "ntlmssp\n"));
+
+               manage_squid_ntlmssp_request_int(state, buf, length,
+                                                talloc_tos(), &reply);
+               if (reply == NULL) {
+                       x_fprintf(x_stdout, "BH Out of memory\n");
+                       return;
+               }
+
+               if (strncmp(reply, "AF ", 3) == 0) {
+                       x_fprintf(x_stdout, "AF * %s\n", reply+3);
+               } else {
+                       x_fprintf(x_stdout, "%s *\n", reply);
+               }
+
+               TALLOC_FREE(reply);
+               return;
+       }
+
        len = spnego_read_data(ctx, token, &request);
        data_blob_free(&token);
 
        if (len == -1) {
-               DEBUG(1, ("GSS-SPNEGO query [%s] invalid", buf));
+               DEBUG(1, ("GSS-SPNEGO query [%s] invalid\n", buf));
                x_fprintf(x_stdout, "BH GSS-SPNEGO query invalid\n");
                return;
        }
@@ -1265,7 +1357,7 @@ static void manage_gss_spnego_request(struct ntlm_auth_state *state,
 
                if ( (request.negTokenInit.mechTypes == NULL) ||
                     (request.negTokenInit.mechTypes[0] == NULL) ) {
-                       DEBUG(1, ("Client did not offer any mechanism"));
+                       DEBUG(1, ("Client did not offer any mechanism\n"));
                        x_fprintf(x_stdout, "BH Client did not offer any "
                                            "mechanism\n");
                        return;
@@ -1287,7 +1379,7 @@ static void manage_gss_spnego_request(struct ntlm_auth_state *state,
                                x_fprintf(x_stdout, "BH Client wants a new "
                                                    "NTLMSSP challenge, but "
                                                    "already got one\n");
-                               ntlmssp_end(&ntlmssp_state);
+                               TALLOC_FREE(ntlmssp_state);
                                return;
                        }
 
@@ -1301,8 +1393,8 @@ static void manage_gss_spnego_request(struct ntlm_auth_state *state,
                                  request.negTokenInit.mechToken.length);
 
                        response.type = SPNEGO_NEG_TOKEN_TARG;
-                       response.negTokenTarg.supportedMech = SMB_STRDUP(OID_NTLMSSP);
-                       response.negTokenTarg.mechListMIC = data_blob_null;
+                       response.negTokenTarg.supportedMech = talloc_strdup(ctx, OID_NTLMSSP);
+                       response.negTokenTarg.mechListMIC = data_blob_talloc(ctx, NULL, 0);
 
                        status = ntlmssp_update(ntlmssp_state,
                                                       request.negTokenInit.mechToken,
@@ -1316,7 +1408,9 @@ static void manage_gss_spnego_request(struct ntlm_auth_state *state,
                        char *principal;
                        DATA_BLOB ap_rep;
                        DATA_BLOB session_key;
-                       struct PAC_DATA *pac_data = NULL;
+                       struct PAC_LOGON_INFO *logon_info = NULL;
+                       DATA_BLOB ticket;
+                       uint8_t tok_id[2];
 
                        if ( request.negTokenInit.mechToken.data == NULL ) {
                                DEBUG(1, ("Client did not provide Kerberos data\n"));
@@ -1325,14 +1419,24 @@ static void manage_gss_spnego_request(struct ntlm_auth_state *state,
                                return;
                        }
 
+                       dump_data(10, request.negTokenInit.mechToken.data,
+                                 request.negTokenInit.mechToken.length);
+
+                       if (!spnego_parse_krb5_wrap(ctx, request.negTokenInit.mechToken,
+                                                   &ticket, tok_id)) {
+                               DEBUG(1, ("spnego_parse_krb5_wrap failed\n"));
+                               x_fprintf(x_stdout, "BH spnego_parse_krb5_wrap failed\n");
+                               return;
+                       }
+
                        response.type = SPNEGO_NEG_TOKEN_TARG;
-                       response.negTokenTarg.supportedMech = SMB_STRDUP(OID_KERBEROS5_OLD);
-                       response.negTokenTarg.mechListMIC = data_blob_null;
-                       response.negTokenTarg.responseToken = data_blob_null;
+                       response.negTokenTarg.supportedMech = talloc_strdup(ctx, OID_KERBEROS5_OLD);
+                       response.negTokenTarg.mechListMIC = data_blob_talloc(ctx, NULL, 0);
+                       response.negTokenTarg.responseToken = data_blob_talloc(ctx, NULL, 0);
 
                        status = ads_verify_ticket(mem_ctx, lp_realm(), 0,
-                                                  &request.negTokenInit.mechToken,
-                                                  &principal, &pac_data, &ap_rep,
+                                                  &ticket,
+                                                  &principal, &logon_info, &ap_rep,
                                                   &session_key, True);
 
                        /* Now in "principal" we have the name we are
@@ -1355,6 +1459,9 @@ static void manage_gss_spnego_request(struct ntlm_auth_state *state,
                                domain = SMB_STRDUP(domain);
                                user = SMB_STRDUP(principal);
 
+                               netsamlogon_cache_store(
+                                       user, &logon_info->info3);
+
                                data_blob_free(&ap_rep);
                        }
 
@@ -1387,13 +1494,13 @@ static void manage_gss_spnego_request(struct ntlm_auth_state *state,
                                               &response.negTokenTarg.responseToken);
 
                response.type = SPNEGO_NEG_TOKEN_TARG;
-               response.negTokenTarg.supportedMech = SMB_STRDUP(OID_NTLMSSP);
-               response.negTokenTarg.mechListMIC = data_blob_null;
+               response.negTokenTarg.supportedMech = talloc_strdup(ctx, OID_NTLMSSP);
+               response.negTokenTarg.mechListMIC = data_blob_talloc(ctx, NULL, 0);
 
                if (NT_STATUS_IS_OK(status)) {
                        user = SMB_STRDUP(ntlmssp_state->user);
                        domain = SMB_STRDUP(ntlmssp_state->domain);
-                       ntlmssp_end(&ntlmssp_state);
+                       TALLOC_FREE(ntlmssp_state);
                }
        }
 
@@ -1494,7 +1601,7 @@ static bool manage_client_ntlmssp_init(struct spnego_data spnego)
                        NT_STATUS_IS_OK(status)) ) {
                DEBUG(1, ("Expected OK or MORE_PROCESSING_REQUIRED, got: %s\n",
                          nt_errstr(status)));
-               ntlmssp_end(&client_ntlmssp_state);
+               TALLOC_FREE(client_ntlmssp_state);
                return False;
        }
 
@@ -1527,13 +1634,13 @@ static void manage_client_ntlmssp_targ(struct spnego_data spnego)
 
        if (spnego.negTokenTarg.negResult == SPNEGO_REJECT) {
                x_fprintf(x_stdout, "NA\n");
-               ntlmssp_end(&client_ntlmssp_state);
+               TALLOC_FREE(client_ntlmssp_state);
                return;
        }
 
        if (spnego.negTokenTarg.negResult == SPNEGO_ACCEPT_COMPLETED) {
                x_fprintf(x_stdout, "AF\n");
-               ntlmssp_end(&client_ntlmssp_state);
+               TALLOC_FREE(client_ntlmssp_state);
                return;
        }
 
@@ -1548,7 +1655,7 @@ static void manage_client_ntlmssp_targ(struct spnego_data spnego)
                x_fprintf(x_stdout, "BH Expected MORE_PROCESSING_REQUIRED from "
                                    "ntlmssp_client_update\n");
                data_blob_free(&request);
-               ntlmssp_end(&client_ntlmssp_state);
+               TALLOC_FREE(client_ntlmssp_state);
                return;
        }
 
@@ -1601,8 +1708,9 @@ static bool manage_client_krb5_init(struct spnego_data spnego)
               spnego.negTokenInit.mechListMIC.length);
        principal[spnego.negTokenInit.mechListMIC.length] = '\0';
 
-       retval = cli_krb5_get_ticket(principal, 0, &tkt, &session_key_krb5, 0, NULL, NULL, NULL);
-
+       retval = cli_krb5_get_ticket(ctx, principal, 0,
+                                         &tkt, &session_key_krb5,
+                                         0, NULL, NULL, NULL);
        if (retval) {
                char *user = NULL;
 
@@ -1625,8 +1733,9 @@ static bool manage_client_krb5_init(struct spnego_data spnego)
                        return False;
                }
 
-               retval = cli_krb5_get_ticket(principal, 0, &tkt, &session_key_krb5, 0, NULL, NULL, NULL);
-
+               retval = cli_krb5_get_ticket(ctx, principal, 0,
+                                                 &tkt, &session_key_krb5,
+                                                 0, NULL, NULL, NULL);
                if (retval) {
                        DEBUG(10, ("Kinit suceeded, but getting a ticket failed: %s\n", error_message(retval)));
                        return False;
@@ -1797,7 +1906,7 @@ static void manage_gss_spnego_client_request(struct ntlm_auth_state *state,
                                                    "negResult\n");
                        }
 
-                       ntlmssp_end(&client_ntlmssp_state);
+                       TALLOC_FREE(client_ntlmssp_state);
                        goto out;
                }
 
@@ -2316,7 +2425,9 @@ static void squid_stream(enum stdio_helper_mode stdio_mode, stdio_helper_functio
        state->helper_mode = stdio_mode;
 
        while(1) {
+               TALLOC_CTX *frame = talloc_stackframe();
                manage_squid_request(state, fn);
+               TALLOC_FREE(frame);
        }
 }
 
@@ -2435,7 +2546,9 @@ enum {
                { "request-lm-key", 0, POPT_ARG_NONE, &request_lm_key, OPT_LM_KEY, "Retrieve LM session key"},
                { "request-nt-key", 0, POPT_ARG_NONE, &request_user_session_key, OPT_USER_SESSION_KEY, "Retrieve User (NT) session key"},
                { "use-cached-creds", 0, POPT_ARG_NONE, &use_cached_creds, OPT_USE_CACHED_CREDS, "Use cached credentials if no password is given"},
-               { "diagnostics", 0, POPT_ARG_NONE, &diagnostics, OPT_DIAGNOSTICS, "Perform diagnostics on the authentictaion chain"},
+               { "diagnostics", 0, POPT_ARG_NONE, &diagnostics,
+                 OPT_DIAGNOSTICS,
+                 "Perform diagnostics on the authentication chain"},
                { "require-membership-of", 0, POPT_ARG_STRING, &require_membership_of, OPT_REQUIRE_MEMBERSHIP, "Require that a user be a member of this group (either name or SID) for authentication to succeed" },
                { "pam-winbind-conf", 0, POPT_ARG_STRING, &opt_pam_winbind_conf, OPT_PAM_WINBIND_CONF, "Require that request must set WBFLAG_PAM_CONTACT_TRUSTDOM when krb5 auth is required" },
                POPT_COMMON_CONFIGFILE
@@ -2446,7 +2559,7 @@ enum {
        /* Samba client initialisation */
        load_case_tables();
 
-       dbf = x_stderr;
+       setup_logging("ntlm_auth", DEBUG_STDERR);
 
        /* Parse options */