s3: remove now unneeded call to cmdline_messaging_context()
[metze/samba/wip.git] / source3 / utils / sharesec.c
index ed4c3ee94ab3cc2203450f1ab28d5fdf9380d73a..510505f00327d589c6bd620e0070057c6b7c92ee 100644 (file)
@@ -28,6 +28,7 @@ struct cli_state;
 #include "../libcli/security/security.h"
 #include "passdb/machine_sid.h"
 #include "util_sd.h"
+#include "cmdline_contexts.h"
 
 static TALLOC_CTX *ctx;
 
@@ -136,7 +137,7 @@ static int ace_compare(struct security_ace *ace1, struct security_ace *ace2)
 
 static void sort_acl(struct security_acl *the_acl)
 {
-       uint32 i;
+       uint32_t i;
        if (!the_acl) return;
 
        TYPESAFE_QSORT(the_acl->aces, the_acl->num_aces, ace_compare);
@@ -161,7 +162,7 @@ static int change_share_sec(TALLOC_CTX *mem_ctx, const char *sharename, char *th
        struct security_descriptor *sd = NULL;
        struct security_descriptor *old = NULL;
        size_t sd_size = 0;
-       uint32 i, j;
+       uint32_t i, j;
 
        if (mode != SMB_ACL_SET && mode != SMB_SD_DELETE) {
            if (!(old = get_share_security( mem_ctx, sharename, &sd_size )) ) {
@@ -182,7 +183,7 @@ static int change_share_sec(TALLOC_CTX *mem_ctx, const char *sharename, char *th
                /* should not happen */
                return 0;
        case SMB_ACL_VIEW:
-               sec_desc_print(NULL, stdout, old, true);
+               sec_desc_print(NULL, stdout, old, false);
                return 0;
        case SMB_ACL_DELETE:
            for (i=0;sd->dacl && i<sd->dacl->num_aces;i++) {
@@ -191,7 +192,7 @@ static int change_share_sec(TALLOC_CTX *mem_ctx, const char *sharename, char *th
                for (j=0;old->dacl && j<old->dacl->num_aces;j++) {
                    if (security_ace_equal(&sd->dacl->aces[i],
                                           &old->dacl->aces[j])) {
-                       uint32 k;
+                       uint32_t k;
                        for (k=j; k<old->dacl->num_aces-1;k++) {
                            old->dacl->aces[k] = old->dacl->aces[k+1];
                        }
@@ -203,7 +204,7 @@ static int change_share_sec(TALLOC_CTX *mem_ctx, const char *sharename, char *th
 
                if (!found) {
                        printf("ACL for ACE:");
-                       print_ace(NULL, stdout, &sd->dacl->aces[i], true);
+                       print_ace(NULL, stdout, &sd->dacl->aces[i], false);
                        printf(" not found\n");
                }
            }
@@ -221,8 +222,9 @@ static int change_share_sec(TALLOC_CTX *mem_ctx, const char *sharename, char *th
                }
 
                if (!found) {
+                   struct dom_sid_buf buf;
                    printf("ACL for SID %s not found\n",
-                          sid_string_tos(&sd->dacl->aces[i].trustee));
+                          dom_sid_str_buf(&sd->dacl->aces[i].trustee, &buf));
                }
            }
 
@@ -332,22 +334,101 @@ int main(int argc, const char *argv[])
        bool initialize_sid = False;
        struct poptOption long_options[] = {
                POPT_AUTOHELP
-               { "remove", 'r', POPT_ARG_STRING, &the_acl, 'r', "Remove ACEs", "ACL" },
-               { "modify", 'm', POPT_ARG_STRING, &the_acl, 'm', "Modify existing ACEs", "ACL" },
-               { "add", 'a', POPT_ARG_STRING, &the_acl, 'a', "Add ACEs", "ACL" },
-               { "replace", 'R', POPT_ARG_STRING, &the_acl, 'R', "Overwrite share permission ACL", "ACLS" },
-               { "delete", 'D', POPT_ARG_NONE, NULL, 'D', "Delete the entire security descriptor" },
-               { "setsddl", 'S', POPT_ARG_STRING, the_acl, 'S',
-                 "Set the SD in sddl format" },
-               { "viewsddl", 'V', POPT_ARG_NONE, the_acl, 'V',
-                 "View the SD in sddl format" },
-               { "view", 'v', POPT_ARG_NONE, NULL, 'v', "View current share permissions" },
-               { "view-all", 0, POPT_ARG_NONE, NULL, OPT_VIEW_ALL,
-                 "View all current share permissions" },
-               { "machine-sid", 'M', POPT_ARG_NONE, NULL, 'M', "Initialize the machine SID" },
-               { "force", 'F', POPT_ARG_NONE, NULL, 'F', "Force storing the ACL", "ACLS" },
+               {
+                       .longName   = "remove",
+                       .shortName  = 'r',
+                       .argInfo    = POPT_ARG_STRING,
+                       .arg        = &the_acl,
+                       .val        = 'r',
+                       .descrip    = "Remove ACEs",
+                       .argDescrip = "ACL",
+               },
+               {
+                       .longName   = "modify",
+                       .shortName  = 'm',
+                       .argInfo    = POPT_ARG_STRING,
+                       .arg        = &the_acl,
+                       .val        = 'm',
+                       .descrip    = "Modify existing ACEs",
+                       .argDescrip = "ACL",
+               },
+               {
+                       .longName   = "add",
+                       .shortName  = 'a',
+                       .argInfo    = POPT_ARG_STRING,
+                       .arg        = &the_acl,
+                       .val        = 'a',
+                       .descrip    = "Add ACEs",
+                       .argDescrip = "ACL",
+               },
+               {
+                       .longName   = "replace",
+                       .shortName  = 'R',
+                       .argInfo    = POPT_ARG_STRING,
+                       .arg        = &the_acl,
+                       .val        = 'R',
+                       .descrip    = "Overwrite share permission ACL",
+                       .argDescrip = "ACLS",
+               },
+               {
+                       .longName   = "delete",
+                       .shortName  = 'D',
+                       .argInfo    = POPT_ARG_NONE,
+                       .arg        = NULL,
+                       .val        = 'D',
+                       .descrip    = "Delete the entire security descriptor",
+               },
+               {
+                       .longName   = "setsddl",
+                       .shortName  = 'S',
+                       .argInfo    = POPT_ARG_STRING,
+                       .arg        = the_acl,
+                       .val        = 'S',
+                       .descrip    = "Set the SD in sddl format",
+               },
+               {
+                       .longName   = "viewsddl",
+                       .shortName  = 'V',
+                       .argInfo    = POPT_ARG_NONE,
+                       .arg        = the_acl,
+                       .val        = 'V',
+                       .descrip    = "View the SD in sddl format",
+               },
+               {
+                       .longName   = "view",
+                       .shortName  = 'v',
+                       .argInfo    = POPT_ARG_NONE,
+                       .arg        = NULL,
+                       .val        = 'v',
+                       .descrip    = "View current share permissions",
+               },
+               {
+                       .longName   = "view-all",
+                       .shortName  = 0,
+                       .argInfo    = POPT_ARG_NONE,
+                       .arg        = NULL,
+                       .val        = OPT_VIEW_ALL,
+                       .descrip    = "View all current share permissions",
+               },
+               {
+                       .longName   = "machine-sid",
+                       .shortName  = 'M',
+                       .argInfo    = POPT_ARG_NONE,
+                       .arg        = NULL,
+                       .val        = 'M',
+                       .descrip    = "Initialize the machine SID",
+               },
+               {
+                       .longName   = "force",
+                       .shortName  = 'F',
+                       .argInfo    = POPT_ARG_NONE,
+                       .arg        = NULL,
+                       .val        = 'F',
+                       .descrip    = "Force storing the ACL",
+                       .argDescrip = "ACLS",
+               },
                POPT_COMMON_SAMBA
-               { NULL }
+               POPT_TABLEEND
        };
 
        if ( !(ctx = talloc_stackframe()) ) {
@@ -426,19 +507,23 @@ int main(int argc, const char *argv[])
 
        if ( initialize_sid ) {
                struct dom_sid *sid = get_global_sam_sid();
+               struct dom_sid_buf buf;
 
                if ( !sid ) {
                        fprintf( stderr, "Failed to retrieve Machine SID!\n");
-                       return 3;
+                       retval = 3;
+                       goto done;
                }
 
-               printf ("%s\n", sid_string_tos( sid ) );
-               return 0;
+               printf ("%s\n", dom_sid_str_buf(sid, &buf) );
+               retval = 0;
+               goto done;
        }
 
        if ( mode == SMB_ACL_VIEW && force_acl ) {
                fprintf( stderr, "Invalid combination of -F and -v\n");
-               return -1;
+               retval = -1;
+               goto done;
        }
 
        if (mode == SMB_ACL_VIEW_ALL) {
@@ -464,7 +549,8 @@ int main(int argc, const char *argv[])
 
        if(!poptPeekArg(pc)) {
                poptPrintUsage(pc, stderr, 0);
-               return -1;
+               retval = -1;
+               goto done;
        }
 
        fstrcpy(sharename, poptGetArg(pc));
@@ -473,7 +559,8 @@ int main(int argc, const char *argv[])
 
        if ( snum == -1 && !force_acl ) {
                fprintf( stderr, "Invalid sharename: %s\n", sharename);
-               return -1;
+               retval = -1;
+               goto done;
        }
 
        switch (mode) {
@@ -489,6 +576,7 @@ int main(int argc, const char *argv[])
        }
 
 done:
+       poptFreeContext(pc);
        talloc_destroy(ctx);
 
        return retval;