s4:dsdb Use the schema from our local provision to decode the schema
[kamenim/samba.git] / source4 / libnet / libnet_vampire.c
index 42d6f72dd14303ff4234c349655023980c796aed..8a9ba12141b93454475c58340b9a1492b23c42fc 100644 (file)
@@ -26,7 +26,7 @@
 #include "libnet/libnet.h"
 #include "lib/events/events.h"
 #include "dsdb/samdb/samdb.h"
-#include "lib/util/dlinklist.h"
+#include "../lib/util/dlinklist.h"
 #include "lib/ldb/include/ldb.h"
 #include "lib/ldb/include/ldb_errors.h"
 #include "librpc/ndr/libndr.h"
 #include "system/time.h"
 #include "lib/ldb_wrap.h"
 #include "auth/auth.h"
+#include "auth/credentials/credentials.h"
 #include "param/param.h"
 #include "param/provision.h"
+#include "libcli/security/dom_sid.h"
 
 /* 
 List of tasks vampire.py must perform:
@@ -52,9 +54,10 @@ List of tasks vampire.py must perform:
 - Write out the secrets database, using the code from libnet_Join
 
 */
-struct vampire_state {
+struct libnet_vampire_cb_state {
        const char *netbios_name;
-       struct libnet_JoinDomain *join;
+       const char *domain_name;
+       const char *realm;
        struct cli_credentials *machine_account;
        struct dsdb_schema *self_made_schema;
        const struct dsdb_schema *schema;
@@ -70,27 +73,62 @@ struct vampire_state {
        const char *targetdir;
 
        struct loadparm_context *lp_ctx;
-       struct event_context *event_ctx;
+       struct tevent_context *event_ctx;
+       unsigned total_objects;
+       char *last_partition;
 };
 
-static NTSTATUS vampire_prepare_db(void *private_data,
-                                             const struct libnet_BecomeDC_PrepareDB *p)
+/* Caller is expected to keep supplied pointers around for the lifetime of the structure */
+void *libnet_vampire_cb_state_init(TALLOC_CTX *mem_ctx,
+                                  struct loadparm_context *lp_ctx, struct tevent_context *event_ctx,
+                                  const char *netbios_name, const char *domain_name, const char *realm,
+                                  const char *targetdir)
+{
+       struct libnet_vampire_cb_state *s = talloc_zero(mem_ctx, struct libnet_vampire_cb_state);
+       if (!s) {
+               return NULL;
+       }
+
+       s->lp_ctx = lp_ctx;
+       s->event_ctx = event_ctx;
+       s->netbios_name = netbios_name;
+       s->domain_name = domain_name;
+       s->realm = realm;
+       s->targetdir = targetdir;
+       return s;
+}
+
+struct ldb_context *libnet_vampire_cb_ldb(struct libnet_vampire_cb_state *state)
+{
+       state = talloc_get_type_abort(state, struct libnet_vampire_cb_state);
+       return state->ldb;
+}
+
+struct loadparm_context *libnet_vampire_cb_lp_ctx(struct libnet_vampire_cb_state *state)
+{
+       state = talloc_get_type_abort(state, struct libnet_vampire_cb_state);
+       return state->lp_ctx;
+}
+
+NTSTATUS libnet_vampire_cb_prepare_db(void *private_data,
+                                     const struct libnet_BecomeDC_PrepareDB *p)
 {
-       struct vampire_state *s = talloc_get_type(private_data, struct vampire_state);
+       struct libnet_vampire_cb_state *s = talloc_get_type(private_data, struct libnet_vampire_cb_state);
        struct provision_settings settings;
        struct provision_result result;
        NTSTATUS status;
 
+       ZERO_STRUCT(settings);
        settings.site_name = p->dest_dsa->site_name;
        settings.root_dn_str = p->forest->root_dn_str;
        settings.domain_dn_str = p->domain->dn_str;
        settings.config_dn_str = p->forest->config_dn_str;
        settings.schema_dn_str = p->forest->schema_dn_str;
        settings.netbios_name = p->dest_dsa->netbios_name;
-       settings.realm = s->join->out.realm;
-       settings.domain = s->join->out.domain_name;
+       settings.realm = s->realm;
+       settings.domain = s->domain_name;
        settings.server_dn_str = p->dest_dsa->server_dn_str;
-       settings.machine_password = generate_random_str(s, 16);
+       settings.machine_password = generate_random_password(s, 16, 255);
        settings.targetdir = s->targetdir;
 
        status = provision_bare(s, s->lp_ctx, &settings, &result);
@@ -99,18 +137,31 @@ static NTSTATUS vampire_prepare_db(void *private_data,
                return status;
        }
 
-       s->ldb = result.samdb;
-       s->lp_ctx = result.lp_ctx;
+       s->ldb = talloc_steal(s, result.samdb);
+       s->lp_ctx = talloc_steal(s, result.lp_ctx);
+
+       /* wrap the entire vapire operation in a transaction.  This
+          isn't just cosmetic - we use this to ensure that linked
+          attribute back links are added at the end by relying on a
+          transaction commit hook in the linked attributes module. We
+          need to do this as the order of objects coming from the
+          server is not sufficiently deterministic to know that the
+          record that a backlink needs to be created in has itself
+          been created before the object containing the forward link
+          has come over the wire */
+       if (ldb_transaction_start(s->ldb) != LDB_SUCCESS) {
+               return NT_STATUS_FOOBAR;
+       }
 
         return NT_STATUS_OK;
 
 
 }
 
-static NTSTATUS vampire_check_options(void *private_data,
-                                            const struct libnet_BecomeDC_CheckOptions *o)
+NTSTATUS libnet_vampire_cb_check_options(void *private_data,
+                                        const struct libnet_BecomeDC_CheckOptions *o)
 {
-       struct vampire_state *s = talloc_get_type(private_data, struct vampire_state);
+       struct libnet_vampire_cb_state *s = talloc_get_type(private_data, struct libnet_vampire_cb_state);
 
        DEBUG(0,("Become DC [%s] of Domain[%s]/[%s]\n",
                s->netbios_name,
@@ -131,18 +182,17 @@ static NTSTATUS vampire_check_options(void *private_data,
        return NT_STATUS_OK;
 }
 
-static NTSTATUS vampire_apply_schema(struct vampire_state *s,
-                                 const struct libnet_BecomeDC_StoreChunk *c)
+static NTSTATUS libnet_vampire_cb_apply_schema(struct libnet_vampire_cb_state *s,
+                                              const struct libnet_BecomeDC_StoreChunk *c)
 {
        WERROR status;
        const struct drsuapi_DsReplicaOIDMapping_Ctr *mapping_ctr;
        uint32_t object_count;
        struct drsuapi_DsReplicaObjectListItemEx *first_object;
-       struct drsuapi_DsReplicaObjectListItemEx *cur;
        uint32_t linked_attributes_count;
        struct drsuapi_DsReplicaLinkedAttribute *linked_attributes;
        const struct drsuapi_DsReplicaCursor2CtrEx *uptodateness_vector;
-       struct dsdb_extended_replicated_objects *objs;
+       struct dsdb_extended_replicated_objects *schema_objs_1, *schema_objs_2;
        struct repsFromTo1 *s_dsa;
        char *tmp_dns_name;
        struct ldb_message *msg;
@@ -152,6 +202,7 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
        uint32_t i;
        int ret;
        bool ok;
+       uint64_t seq_num;
 
        DEBUG(0,("Analyze and apply schema objects\n"));
 
@@ -176,8 +227,8 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
                mapping_ctr                     = &c->ctr6->mapping_ctr;
                object_count                    = s->schema_part.object_count;
                first_object                    = s->schema_part.first_object;
-               linked_attributes_count         = 0; /* TODO: ! */
-               linked_attributes               = NULL; /* TODO: ! */;
+               linked_attributes_count         = c->ctr6->linked_attributes_count;
+               linked_attributes               = c->ctr6->linked_attributes;
                s_dsa->highwatermark            = c->ctr6->new_highwatermark;
                s_dsa->source_dsa_obj_guid      = c->ctr6->source_dsa_guid;
                s_dsa->source_dsa_invocation_id = c->ctr6->source_dsa_invocation_id;
@@ -187,9 +238,9 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       s_dsa->replica_flags            = DRSUAPI_DS_REPLICA_NEIGHBOUR_WRITEABLE
-                                       | DRSUAPI_DS_REPLICA_NEIGHBOUR_SYNC_ON_STARTUP
-                                       | DRSUAPI_DS_REPLICA_NEIGHBOUR_DO_SCHEDULED_SYNCS;
+       s_dsa->replica_flags            = DRSUAPI_DRS_WRIT_REP
+                                       | DRSUAPI_DRS_INIT_SYNC
+                                       | DRSUAPI_DRS_PER_SYNC;
        memset(s_dsa->schedule, 0x11, sizeof(s_dsa->schedule));
 
        tmp_dns_name    = GUID_string(s_dsa->other_info, &s_dsa->source_dsa_obj_guid);
@@ -198,113 +249,84 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
        NT_STATUS_HAVE_NO_MEMORY(tmp_dns_name);
        s_dsa->other_info->dns_name = tmp_dns_name;
 
-       for (cur = first_object; cur; cur = cur->next_object) {
-               bool is_attr = false;
-               bool is_class = false;
-
-               for (i=0; i < cur->object.attribute_ctr.num_attributes; i++) {
-                       struct drsuapi_DsReplicaAttribute *a;
-                       uint32_t j;
-                       const char *oid = NULL;
-
-                       a = &cur->object.attribute_ctr.attributes[i];
-                       status = dsdb_map_int2oid(s->self_made_schema, a->attid, s, &oid);
-                       if (!W_ERROR_IS_OK(status)) {
-                               return werror_to_ntstatus(status);
-                       }
-
-                       switch (a->attid) {
-                       case DRSUAPI_ATTRIBUTE_objectClass:
-                               for (j=0; j < a->value_ctr.num_values; j++) {
-                                       uint32_t val = 0xFFFFFFFF;
-
-                                       if (a->value_ctr.values[i].blob
-                                           && a->value_ctr.values[i].blob->length == 4) {
-                                               val = IVAL(a->value_ctr.values[i].blob->data,0);
-                                       }
-
-                                       if (val == DRSUAPI_OBJECTCLASS_attributeSchema) {
-                                               is_attr = true;
-                                       }
-                                       if (val == DRSUAPI_OBJECTCLASS_classSchema) {
-                                               is_class = true;
-                                       }
-                               }
-
-                               break;
-                       default:
-                               break;
-                       }
-               }
-
-               if (is_attr) {
-                       struct dsdb_attribute *sa;
-
-                       sa = talloc_zero(s->self_made_schema, struct dsdb_attribute);
-                       NT_STATUS_HAVE_NO_MEMORY(sa);
-
-                       status = dsdb_attribute_from_drsuapi(s->self_made_schema, &cur->object, s, sa);
-                       if (!W_ERROR_IS_OK(status)) {
-                               return werror_to_ntstatus(status);
-                       }
-
-                       DLIST_ADD_END(s->self_made_schema->attributes, sa, struct dsdb_attribute *);
-               }
-
-               if (is_class) {
-                       struct dsdb_class *sc;
-
-                       sc = talloc_zero(s->self_made_schema, struct dsdb_class);
-                       NT_STATUS_HAVE_NO_MEMORY(sc);
-
-                       status = dsdb_class_from_drsuapi(s->self_made_schema, &cur->object, s, sc);
-                       if (!W_ERROR_IS_OK(status)) {
-                               return werror_to_ntstatus(status);
-                       }
+       /* Now convert the schema elements again, using the schema we just imported */
+       status = dsdb_extended_replicated_objects_convert(s->ldb,
+                                                         c->partition->nc.dn,
+                                                         mapping_ctr,
+                                                         object_count,
+                                                         first_object,
+                                                         linked_attributes_count,
+                                                         linked_attributes,
+                                                         s_dsa,
+                                                         uptodateness_vector,
+                                                         c->gensec_skey,
+                                                         s, &schema_objs_1);
+       if (!W_ERROR_IS_OK(status)) {
+               DEBUG(0,("Failed to convert objects: %s\n", win_errstr(status)));
+               return werror_to_ntstatus(status);
+       }
 
-                       DLIST_ADD_END(s->self_made_schema->classes, sc, struct dsdb_class *);
+       for (i=0; i < schema_objs_1->num_objects; i++) {
+               status = dsdb_schema_set_el_from_ldb_msg(s->ldb, s->self_made_schema, schema_objs_1->objects[i].msg);
+               if (!W_ERROR_IS_OK(status)) {
+                       DEBUG(0,("Failed to convert object %s into a schema element: %s\n",
+                                ldb_dn_get_linearized(schema_objs_1->objects[i].msg->dn),
+                                win_errstr(status)));
+                       return werror_to_ntstatus(status);
                }
        }
+       /* We don't need the first conversion of the schema any more */
+       talloc_free(schema_objs_1);
 
-       /* attach the schema to the ldb */
+       /* attach the schema we just brought over DRS to the ldb */
        ret = dsdb_set_schema(s->ldb, s->self_made_schema);
        if (ret != LDB_SUCCESS) {
+               DEBUG(0,("Failed to attach schema from DRS.\n"));
                return NT_STATUS_FOOBAR;
        }
+
        /* we don't want to access the self made schema anymore */
+       s->schema = s->self_made_schema;
        s->self_made_schema = NULL;
-       s->schema = dsdb_get_schema(s->ldb);
 
-       status = dsdb_extended_replicated_objects_commit(s->ldb,
-                                                        c->partition->nc.dn,
-                                                        mapping_ctr,
-                                                        object_count,
-                                                        first_object,
-                                                        linked_attributes_count,
-                                                        linked_attributes,
-                                                        s_dsa,
-                                                        uptodateness_vector,
-                                                        c->gensec_skey,
-                                                        s, &objs);
+       /* Now convert the schema elements again, using the schema we just imported - we do this
+          'just in case' the schema in our LDIF was wrong, but correct enough to read a valid schema */
+       status = dsdb_extended_replicated_objects_convert(s->ldb, 
+                                                         c->partition->nc.dn,
+                                                         mapping_ctr,
+                                                         object_count,
+                                                         first_object,
+                                                         linked_attributes_count,
+                                                         linked_attributes,
+                                                         s_dsa,
+                                                         uptodateness_vector,
+                                                         c->gensec_skey,
+                                                         s, &schema_objs_2);
        if (!W_ERROR_IS_OK(status)) {
-               DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
+               DEBUG(0,("Failed to convert objects: %s\n", win_errstr(status)));
                return werror_to_ntstatus(status);
        }
 
        if (lp_parm_bool(s->lp_ctx, NULL, "become dc", "dump objects", false)) {
-               for (i=0; i < objs->num_objects; i++) {
+               for (i=0; i < schema_objs_2->num_objects; i++) {
                        struct ldb_ldif ldif;
                        fprintf(stdout, "#\n");
                        ldif.changetype = LDB_CHANGETYPE_NONE;
-                       ldif.msg = objs->objects[i].msg;
+                       ldif.msg = schema_objs_2->objects[i].msg;
                        ldb_ldif_write_file(s->ldb, stdout, &ldif);
-                       NDR_PRINT_DEBUG(replPropertyMetaDataBlob, objs->objects[i].meta_data);
+                       NDR_PRINT_DEBUG(replPropertyMetaDataBlob, schema_objs_2->objects[i].meta_data);
                }
        }
 
-       msg = ldb_msg_new(objs);
+       status = dsdb_extended_replicated_objects_commit(s->ldb, schema_objs_2, &seq_num);
+       if (!W_ERROR_IS_OK(status)) {
+               DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
+               return werror_to_ntstatus(status);
+       }
+
+       msg = ldb_msg_new(schema_objs_2);
        NT_STATUS_HAVE_NO_MEMORY(msg);
-       msg->dn = objs->partition_dn;
+       msg->dn = schema_objs_2->partition_dn;
 
        status = dsdb_get_oid_mappings_ldb(s->schema, msg, &prefixMap_val, &schemaInfo_val);
        if (!W_ERROR_IS_OK(status)) {
@@ -321,26 +343,15 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
 
        ret = ldb_modify(s->ldb, msg);
        if (ret != LDB_SUCCESS) {
-               DEBUG(0,("Failed to add prefixMap and schemaInfo %s\n", ldb_strerror(ret)));
+               DEBUG(0,("Failed to add prefixMap: %s\n", ldb_strerror(ret)));
                return NT_STATUS_FOOBAR;
        }
 
        talloc_free(s_dsa);
-       talloc_free(objs);
-
-       /* reopen the ldb */
-       talloc_free(s->ldb); /* this also free's the s->schema, because dsdb_set_schema() steals it */
-       s->schema = NULL;
-
-       DEBUG(0,("Reopen the SAM LDB with system credentials and a already stored schema\n"));
-       s->ldb = samdb_connect(s, s->event_ctx, s->lp_ctx, 
-                              system_session(s, s->lp_ctx));
-       if (!s->ldb) {
-               DEBUG(0,("Failed to reopen sam.ldb\n"));
-               return NT_STATUS_INTERNAL_DB_ERROR;
-       }
+       talloc_free(schema_objs_2);
 
-       /* We must set these up to ensure the replMetaData is written correctly, before our NTDS Settings entry is replicated */
+       /* We must set these up to ensure the replMetaData is written
+        * correctly, before our NTDS Settings entry is replicated */
        ok = samdb_set_ntds_invocation_id(s->ldb, &c->dest_dsa->invocation_id);
        if (!ok) {
                DEBUG(0,("Failed to set cached ntds invocationId\n"));
@@ -352,7 +363,7 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
                return NT_STATUS_FOOBAR;
        }
 
-       s->schema = dsdb_get_schema(s->ldb);
+       s->schema = dsdb_get_schema(s->ldb, s);
        if (!s->schema) {
                DEBUG(0,("Failed to get loaded dsdb_schema\n"));
                return NT_STATUS_FOOBAR;
@@ -361,10 +372,10 @@ static NTSTATUS vampire_apply_schema(struct vampire_state *s,
        return NT_STATUS_OK;
 }
 
-static NTSTATUS vampire_schema_chunk(void *private_data,
-                                           const struct libnet_BecomeDC_StoreChunk *c)
+NTSTATUS libnet_vampire_cb_schema_chunk(void *private_data,
+                                       const struct libnet_BecomeDC_StoreChunk *c)
 {
-       struct vampire_state *s = talloc_get_type(private_data, struct vampire_state);
+       struct libnet_vampire_cb_state *s = talloc_get_type(private_data, struct libnet_vampire_cb_state);
        WERROR status;
        const struct drsuapi_DsReplicaOIDMapping_Ctr *mapping_ctr;
        uint32_t nc_object_count;
@@ -373,6 +384,7 @@ static NTSTATUS vampire_schema_chunk(void *private_data,
        struct drsuapi_DsReplicaObjectListItemEx *cur;
        uint32_t nc_linked_attributes_count;
        uint32_t linked_attributes_count;
+       struct drsuapi_DsReplicaLinkedAttribute *linked_attributes;
 
        switch (c->ctr_level) {
        case 1:
@@ -382,6 +394,7 @@ static NTSTATUS vampire_schema_chunk(void *private_data,
                first_object                    = c->ctr1->first_object;
                nc_linked_attributes_count      = 0;
                linked_attributes_count         = 0;
+               linked_attributes               = NULL;
                break;
        case 6:
                mapping_ctr                     = &c->ctr6->mapping_ctr;
@@ -390,6 +403,7 @@ static NTSTATUS vampire_schema_chunk(void *private_data,
                first_object                    = c->ctr6->first_object;
                nc_linked_attributes_count      = c->ctr6->nc_linked_attributes_count;
                linked_attributes_count         = c->ctr6->linked_attributes_count;
+               linked_attributes               = c->ctr6->linked_attributes;
                break;
        default:
                return NT_STATUS_INVALID_PARAMETER;
@@ -400,23 +414,23 @@ static NTSTATUS vampire_schema_chunk(void *private_data,
                        c->partition->nc.dn, object_count, nc_object_count,
                        linked_attributes_count, nc_linked_attributes_count));
        } else {
-               DEBUG(0,("Schema-DN[%s] objects[%u] linked_values[%u\n",
+               DEBUG(0,("Schema-DN[%s] objects[%u] linked_values[%u]\n",
                c->partition->nc.dn, object_count, linked_attributes_count));
        }
 
        if (!s->schema) {
-               s->self_made_schema = dsdb_new_schema(s, lp_iconv_convenience(s->lp_ctx));
+               s->self_made_schema = dsdb_new_schema(s);
 
                NT_STATUS_HAVE_NO_MEMORY(s->self_made_schema);
 
-               status = dsdb_load_oid_mappings_drsuapi(s->self_made_schema, mapping_ctr);
+               status = dsdb_load_prefixmap_from_drsuapi(s->self_made_schema, mapping_ctr);
                if (!W_ERROR_IS_OK(status)) {
                        return werror_to_ntstatus(status);
                }
 
                s->schema = s->self_made_schema;
        } else {
-               status = dsdb_verify_oid_mappings_drsuapi(s->schema, mapping_ctr);
+               status = dsdb_schema_pfm_contains_drsuapi_pfm(s->schema->prefixmap, mapping_ctr);
                if (!W_ERROR_IS_OK(status)) {
                        return werror_to_ntstatus(status);
                }
@@ -434,16 +448,16 @@ static NTSTATUS vampire_schema_chunk(void *private_data,
        s->schema_part.last_object = cur;
 
        if (!c->partition->more_data) {
-               return vampire_apply_schema(s, c);
+               return libnet_vampire_cb_apply_schema(s, c);
        }
 
        return NT_STATUS_OK;
 }
 
-static NTSTATUS vampire_store_chunk(void *private_data,
-                                          const struct libnet_BecomeDC_StoreChunk *c)
+NTSTATUS libnet_vampire_cb_store_chunk(void *private_data,
+                            const struct libnet_BecomeDC_StoreChunk *c)
 {
-       struct vampire_state *s = talloc_get_type(private_data, struct vampire_state);
+       struct libnet_vampire_cb_state *s = talloc_get_type(private_data, struct libnet_vampire_cb_state);
        WERROR status;
        const struct drsuapi_DsReplicaOIDMapping_Ctr *mapping_ctr;
        uint32_t nc_object_count;
@@ -457,6 +471,7 @@ static NTSTATUS vampire_store_chunk(void *private_data,
        struct repsFromTo1 *s_dsa;
        char *tmp_dns_name;
        uint32_t i;
+       uint64_t seq_num;
 
        s_dsa                   = talloc_zero(s, struct repsFromTo1);
        NT_STATUS_HAVE_NO_MEMORY(s_dsa);
@@ -494,9 +509,9 @@ static NTSTATUS vampire_store_chunk(void *private_data,
                return NT_STATUS_INVALID_PARAMETER;
        }
 
-       s_dsa->replica_flags            = DRSUAPI_DS_REPLICA_NEIGHBOUR_WRITEABLE
-                                       | DRSUAPI_DS_REPLICA_NEIGHBOUR_SYNC_ON_STARTUP
-                                       | DRSUAPI_DS_REPLICA_NEIGHBOUR_DO_SCHEDULED_SYNCS;
+       s_dsa->replica_flags            = DRSUAPI_DRS_WRIT_REP
+                                       | DRSUAPI_DRS_INIT_SYNC
+                                       | DRSUAPI_DRS_PER_SYNC;
        memset(s_dsa->schedule, 0x11, sizeof(s_dsa->schedule));
 
        tmp_dns_name    = GUID_string(s_dsa->other_info, &s_dsa->source_dsa_obj_guid);
@@ -505,28 +520,37 @@ static NTSTATUS vampire_store_chunk(void *private_data,
        NT_STATUS_HAVE_NO_MEMORY(tmp_dns_name);
        s_dsa->other_info->dns_name = tmp_dns_name;
 
+       /* we want to show a count per partition */
+       if (!s->last_partition || strcmp(s->last_partition, c->partition->nc.dn) != 0) {
+               s->total_objects = 0;
+               talloc_free(s->last_partition);
+               s->last_partition = talloc_strdup(s, c->partition->nc.dn);
+       }
+       s->total_objects += object_count;
+
        if (nc_object_count) {
                DEBUG(0,("Partition[%s] objects[%u/%u] linked_values[%u/%u]\n",
-                       c->partition->nc.dn, object_count, nc_object_count,
+                       c->partition->nc.dn, s->total_objects, nc_object_count,
                        linked_attributes_count, nc_linked_attributes_count));
        } else {
-               DEBUG(0,("Partition[%s] objects[%u] linked_values[%u\n",
-               c->partition->nc.dn, object_count, linked_attributes_count));
-       }
-
-       status = dsdb_extended_replicated_objects_commit(s->ldb,
-                                                        c->partition->nc.dn,
-                                                        mapping_ctr,
-                                                        object_count,
-                                                        first_object,
-                                                        linked_attributes_count,
-                                                        linked_attributes,
-                                                        s_dsa,
-                                                        uptodateness_vector,
-                                                        c->gensec_skey,
-                                                        s, &objs);
+               DEBUG(0,("Partition[%s] objects[%u] linked_values[%u]\n",
+               c->partition->nc.dn, s->total_objects, linked_attributes_count));
+       }
+
+
+       status = dsdb_extended_replicated_objects_convert(s->ldb,
+                                                         c->partition->nc.dn,
+                                                         mapping_ctr,
+                                                         object_count,
+                                                         first_object,
+                                                         linked_attributes_count,
+                                                         linked_attributes,
+                                                         s_dsa,
+                                                         uptodateness_vector,
+                                                         c->gensec_skey,
+                                                         s, &objs);
        if (!W_ERROR_IS_OK(status)) {
-               DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
+               DEBUG(0,("Failed to convert objects: %s\n", win_errstr(status)));
                return werror_to_ntstatus(status);
        }
 
@@ -540,6 +564,13 @@ static NTSTATUS vampire_store_chunk(void *private_data,
                        NDR_PRINT_DEBUG(replPropertyMetaDataBlob, objs->objects[i].meta_data);
                }
        }
+       status = dsdb_extended_replicated_objects_commit(s->ldb,
+                                                        objs, &seq_num);
+       if (!W_ERROR_IS_OK(status)) {
+               DEBUG(0,("Failed to commit objects: %s\n", win_errstr(status)));
+               return werror_to_ntstatus(status);
+       }
+
        talloc_free(s_dsa);
        talloc_free(objs);
 
@@ -576,10 +607,11 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
                        struct libnet_Vampire *r)
 {
        struct libnet_JoinDomain *join;
-       struct libnet_set_join_secrets *set_secrets;
+       struct provision_store_self_join_settings *set_secrets;
        struct libnet_BecomeDC b;
-       struct vampire_state *s;
+       struct libnet_vampire_cb_state *s;
        struct ldb_message *msg;
+       const char *error_string;
        int ldb_ret;
        uint32_t i;
        NTSTATUS status;
@@ -589,15 +621,7 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        
        r->out.error_string = NULL;
 
-       s = talloc_zero(mem_ctx, struct vampire_state);
-       if (!s) {
-               return NT_STATUS_NO_MEMORY;
-       }
-
-       s->lp_ctx = ctx->lp_ctx;
-       s->event_ctx = ctx->event_ctx;
-
-       join = talloc_zero(s, struct libnet_JoinDomain);
+       join = talloc_zero(mem_ctx, struct libnet_JoinDomain);
        if (!join) {
                return NT_STATUS_NO_MEMORY;
        }
@@ -607,19 +631,24 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        } else {
                netbios_name = talloc_reference(join, lp_netbios_name(ctx->lp_ctx));
                if (!netbios_name) {
+                       talloc_free(join);
                        r->out.error_string = NULL;
-                       talloc_free(s);
                        return NT_STATUS_NO_MEMORY;
                }
        }
 
        account_name = talloc_asprintf(join, "%s$", netbios_name);
        if (!account_name) {
+               talloc_free(join);
                r->out.error_string = NULL;
-               talloc_free(s);
                return NT_STATUS_NO_MEMORY;
        }
        
+       /* Re-use the domain we are joining as the domain for the user
+        * to be authenticated with, unless they specified
+        * otherwise */
+       cli_credentials_set_domain(ctx->cred, r->in.domain_name, CRED_GUESS_ENV);
+
        join->in.domain_name    = r->in.domain_name;
        join->in.account_name   = account_name;
        join->in.netbios_name   = netbios_name;
@@ -629,15 +658,33 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        status = libnet_JoinDomain(ctx, join, join);
        if (!NT_STATUS_IS_OK(status)) {
                r->out.error_string = talloc_steal(mem_ctx, join->out.error_string);
-               talloc_free(s);
+               talloc_free(join);
                return status;
        }
        
-       s->join = join;
-
-       s->targetdir = r->in.targetdir;
+       s = libnet_vampire_cb_state_init(mem_ctx, ctx->lp_ctx, ctx->event_ctx,
+                                        netbios_name, join->out.domain_name, join->out.realm,
+                                        r->in.targetdir);
+       if (!s) {
+               return NT_STATUS_NO_MEMORY;
+       }
+       talloc_steal(s, join);
 
        ZERO_STRUCT(b);
+
+       /* Be more robust:
+        * We now know the domain and realm for sure - if they didn't
+        * put one on the command line, use this for the rest of the
+        * join */
+       cli_credentials_set_realm(ctx->cred, join->out.realm, CRED_GUESS_ENV);
+       cli_credentials_set_domain(ctx->cred, join->out.domain_name, CRED_GUESS_ENV);
+
+       /* Now set these values into the smb.conf - we probably had
+        * empty or useless defaults here from whatever smb.conf we
+        * started with */
+       lp_set_cmdline(s->lp_ctx, "realm", join->out.realm);
+       lp_set_cmdline(s->lp_ctx, "workgroup", join->out.domain_name);
+
        b.in.domain_dns_name            = join->out.realm;
        b.in.domain_netbios_name        = join->out.domain_name;
        b.in.domain_sid                 = join->out.domain_sid;
@@ -645,11 +692,13 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        b.in.dest_dsa_netbios_name      = netbios_name;
 
        b.in.callbacks.private_data     = s;
-       b.in.callbacks.check_options    = vampire_check_options;
-       b.in.callbacks.prepare_db       = vampire_prepare_db;
-       b.in.callbacks.schema_chunk     = vampire_schema_chunk;
-       b.in.callbacks.config_chunk     = vampire_store_chunk;
-       b.in.callbacks.domain_chunk     = vampire_store_chunk;
+       b.in.callbacks.check_options    = libnet_vampire_cb_check_options;
+       b.in.callbacks.prepare_db       = libnet_vampire_cb_prepare_db;
+       b.in.callbacks.schema_chunk     = libnet_vampire_cb_schema_chunk;
+       b.in.callbacks.config_chunk     = libnet_vampire_cb_store_chunk;
+       b.in.callbacks.domain_chunk     = libnet_vampire_cb_store_chunk;
+
+       b.in.rodc_join = lp_parm_bool(s->lp_ctx, NULL, "repl", "RODC", false);
 
        status = libnet_BecomeDC(ctx, s, &b);
        if (!NT_STATUS_IS_OK(status)) {
@@ -685,36 +734,56 @@ NTSTATUS libnet_Vampire(struct libnet_context *ctx, TALLOC_CTX *mem_ctx,
        printf("mark ROOTDSE with isSynchronized=TRUE\n");
        ldb_ret = ldb_modify(s->ldb, msg);
        if (ldb_ret != LDB_SUCCESS) {
-               printf("ldb_modify() failed: %d\n", ldb_ret);
+               printf("ldb_modify() failed: %d : %s\n", ldb_ret, ldb_errstring(s->ldb));
                talloc_free(s);
                return NT_STATUS_INTERNAL_DB_ERROR;
        }
 
-       set_secrets = talloc_zero(s, struct libnet_set_join_secrets);
+       /* prepare the transaction - this prepares to commit all the changes in
+          the ldb from the whole vampire.  Note that this 
+          triggers the writing of the linked attribute backlinks.
+       */
+       if (ldb_transaction_prepare_commit(s->ldb) != LDB_SUCCESS) {
+               printf("Failed to prepare_commit vampire transaction: %s\n", ldb_errstring(s->ldb));
+               return NT_STATUS_INTERNAL_DB_ERROR;
+       }
+
+       set_secrets = talloc(s, struct provision_store_self_join_settings);
        if (!set_secrets) {
+               r->out.error_string = NULL;
+               talloc_free(s);
                return NT_STATUS_NO_MEMORY;
        }
-               
-       set_secrets->in.domain_name = join->out.domain_name;
-       set_secrets->in.realm = join->out.realm;
-       set_secrets->in.account_name = account_name;
-       set_secrets->in.netbios_name = netbios_name;
-       set_secrets->in.join_type = SEC_CHAN_BDC;
-       set_secrets->in.join_password = join->out.join_password;
-       set_secrets->in.kvno = join->out.kvno;
-       set_secrets->in.domain_sid = join->out.domain_sid;
        
-       status = libnet_set_join_secrets(ctx, set_secrets, set_secrets);
+       ZERO_STRUCTP(set_secrets);
+       set_secrets->domain_name = join->out.domain_name;
+       set_secrets->realm = join->out.realm;
+       set_secrets->netbios_name = netbios_name;
+       set_secrets->secure_channel_type = SEC_CHAN_BDC;
+       set_secrets->machine_password = join->out.join_password;
+       set_secrets->key_version_number = join->out.kvno;
+       set_secrets->domain_sid = join->out.domain_sid;
+       
+       status = provision_store_self_join(ctx, s->lp_ctx, ctx->event_ctx, set_secrets, &error_string);
        if (!NT_STATUS_IS_OK(status)) {
-               r->out.error_string = talloc_steal(mem_ctx, set_secrets->out.error_string);
+               r->out.error_string = talloc_steal(mem_ctx, error_string);
                talloc_free(s);
                return status;
        }
 
-       r->out.domain_name = talloc_steal(r, join->out.domain_name);
-       r->out.domain_sid = talloc_steal(r, join->out.domain_sid);
-       talloc_free(s);
+       r->out.domain_name = talloc_steal(mem_ctx, join->out.domain_name);
+       r->out.domain_sid = dom_sid_dup(mem_ctx, join->out.domain_sid);
        
+       /* commit the transaction now we know the secrets were written
+        * out properly
+       */
+       if (ldb_transaction_commit(s->ldb) != LDB_SUCCESS) {
+               printf("Failed to commit vampire transaction\n");
+               return NT_STATUS_INTERNAL_DB_ERROR;
+       }
+
+       talloc_free(s);
+
        return NT_STATUS_OK;
 
 }