net/packet: check length in getsockopt() called with PACKET_HDRLEN
authorAlexander Potapenko <glider@google.com>
Tue, 25 Apr 2017 16:51:46 +0000 (18:51 +0200)
committerWilly Tarreau <w@1wt.eu>
Thu, 2 Nov 2017 06:16:24 +0000 (07:16 +0100)
commit055ad9609c623acfc679a3e9049774f414e3a189
treefcc22eb3281897e15b2d5085f944343bff76b28d
parent83fef5222fb220e232d106704d9e0abe838d8b0b
net/packet: check length in getsockopt() called with PACKET_HDRLEN

commit fd2c83b35752f0a8236b976978ad4658df14a59f upstream.

In the case getsockopt() is called with PACKET_HDRLEN and optlen < 4
|val| remains uninitialized and the syscall may behave differently
depending on its value, and even copy garbage to userspace on certain
architectures. To fix this we now return -EINVAL if optlen is too small.

This bug has been detected with KMSAN.

Signed-off-by: Alexander Potapenko <glider@google.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Willy Tarreau <w@1wt.eu>
net/packet/af_packet.c