vfs_fruit: lp_case_sensitive() does not return a bool
authorRalph Boehme <slow@samba.org>
Wed, 19 Apr 2017 11:12:55 +0000 (13:12 +0200)
committerKarolin Seeger <kseeger@samba.org>
Fri, 28 Apr 2017 07:12:27 +0000 (09:12 +0200)
commit30586d36be13507fb4f8fabb806b69035fc98096
tree3f21070aaf6299be24a33973f6f87f523b3c9056
parent6ffea89a6d62f3a8684614c735b09f5a8043fa6b
vfs_fruit: lp_case_sensitive() does not return a bool

lp_case_sensitive() returns an int, not a bool, so with the default
setting of "Auto" by default we set the AAPL flag
SMB2_CRTCTX_AAPL_CASE_SENSITIVE.

This caused the client to believe the volume is case sensitive where it
wasn't, leading to an error when trying to rename files changing only
the case of the name.

Also fix the existing torture test that verifies AAPL context
negotiation and actually expected the server to return "case sensitive",
while the Samba default is really "case insensitive".

Bug: https://bugzilla.samba.org/show_bug.cgi?id=12749

Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>
(cherry picked from commit 36612723b2b18675116b6197183bdfe5e1d9e06f)
source3/modules/vfs_fruit.c
source4/torture/vfs/fruit.c