Eventscripts: split 50.samba into 49.winbind and 50.samba
authorMartin Schwenke <martin@meltin.net>
Thu, 16 Aug 2012 04:41:11 +0000 (14:41 +1000)
committerAmitay Isaacs <amitay@gmail.com>
Tue, 2 Oct 2012 22:46:32 +0000 (08:46 +1000)
commit34535ae64420926b9a3bf7d453fed4e6f4c90115
treeaf2b3ae3d4ac05f95413f09123e6cc2e05aef577
parent043ef77086797a703aec436a26a05c56a1bcbf2b
Eventscripts: split 50.samba into 49.winbind and 50.samba

winbind and samba can be separately managed.  This makes the service
starting and stopping code way too complicated, and even adds a small
amount of complexity to the monitoring code.  The sensible option is
to split this eventscript in two.

There are two potentially backward incompatible changes here:

* Functionality has been removed that allowed 50.samba to manage
  winbind when CTDB_MANAGES_WINBIND was unset but the smb.conf
  "security" parameter was set to "ADS" or "DOMAIN".

  Maintaining this functionality would have required moving the
  testparm-related code to the functions file, deciding where the
  cache file should go, and then calling it from both 49.winbind and
  50.samba.  This feature wasn't of great value and asking
  administrators to set an extra variable in exchange for code
  simplicity seems like a reasonable deal.

* External code will need to be changed if it calls 50.samba directly
  with winbind-related expectations.  This is fairly obvious!

Signed-off-by: Martin Schwenke <martin@meltin.net>
12 files changed:
Makefile.in
config/events.d/49.winbind [new file with mode: 0755]
config/events.d/50.samba
packaging/RPM/ctdb.spec.in
tests/eventscripts/49.winbind.monitor.001.sh [new file with mode: 0755]
tests/eventscripts/49.winbind.monitor.050.sh [new file with mode: 0755]
tests/eventscripts/49.winbind.monitor.051.sh [new file with mode: 0755]
tests/eventscripts/49.winbind.monitor.101.sh [new file with mode: 0755]
tests/eventscripts/49.winbind.monitor.102.sh [moved from tests/eventscripts/50.samba.monitor.102.sh with 91% similarity]
tests/eventscripts/50.samba.monitor.050.sh
tests/eventscripts/50.samba.monitor.051.sh
tests/eventscripts/scripts/local.sh