[PATCH] tty: fix leakage of -ERESTARTSYS to userland
authorOleg Nesterov <oleg@tv-sign.ru>
Fri, 1 Jun 2007 07:46:53 +0000 (00:46 -0700)
committerChris Wright <chrisw@sous-sol.org>
Mon, 11 Jun 2007 18:36:48 +0000 (11:36 -0700)
commit36323d56d52a634758f1288b8a92653b5e6bc1fa
treefac336372bb536ea5bdb2394b78679cd4ccd1d5a
parented556debe2d3409491283b1a037d9b4417ba97c1
[PATCH] tty: fix leakage of -ERESTARTSYS to userland

Spotted by Satoru Takeuchi.

kill_pgrp(task_pgrp(current)) sends the signal to the current's thread
group, but can choose any sub-thread as a target for signal_wake_up().
This means that job_control() and tty_check_change() may return
-ERESTARTSYS without signal_pending().

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Cc: Satoru Takeuchi <takeuchi_satoru@jp.fujitsu.com>
Cc: Roland McGrath <roland@redhat.com>
Cc: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: <stable@kernel.org>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/char/n_tty.c
drivers/char/tty_io.c