s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol...
authorJeremy Allison <jra@samba.org>
Tue, 26 Nov 2019 20:53:09 +0000 (12:53 -0800)
committerKarolin Seeger <kseeger@samba.org>
Fri, 13 Dec 2019 12:30:56 +0000 (12:30 +0000)
commit36da9ac22d893219bfeff2e019b332716e4733ca
tree64a3dcf84b51467d17c2453dfa0183f9aa168223
parentcfa22afe0a77cd56f25b6b7aa93f36a790ed6deb
s3: smbd: Only set xconn->smb1.negprot.done = true after supported_protocols[protocol].proto_reply_fn() succeeds.

Otherwise we can end up with negprot.done set, but
without smbXsrv_connection_init_tables() being called.

This can cause a client self-crash.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14205

Signed-off-by: Jeremy Allison <jra@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Jeremy Allison <jra@samba.org>
Autobuild-Date(master): Wed Dec  4 21:27:24 UTC 2019 on sn-devel-184

(cherry picked from commit 8db0c1bff6f42feabd2e4d9dfb13ae12cc29607b)

Autobuild-User(v4-11-test): Karolin Seeger <kseeger@samba.org>
Autobuild-Date(v4-11-test): Fri Dec 13 12:30:57 UTC 2019 on sn-devel-184
selftest/knownfail.d/smb1_fuzz_smbd [deleted file]
source3/smbd/negprot.c