pptp: fix stack info leak in pptp_getname()
authorMathias Krause <minipli@googlemail.com>
Wed, 19 Nov 2014 17:05:26 +0000 (18:05 +0100)
committerJiri Slaby <jslaby@suse.cz>
Thu, 27 Nov 2014 10:14:06 +0000 (11:14 +0100)
commit416b05bc9db9b9cd48418391538478a438e762b3
tree26e78b95cd5330924a919109d776dce76197c16d
parent6d986f090a2f895a0d3a3f42122402aa3d3427b7
pptp: fix stack info leak in pptp_getname()

[ Upstream commit a5f6fc28d6e6cc379c6839f21820e62262419584 ]

pptp_getname() only partially initializes the stack variable sa,
particularly only fills the pptp part of the sa_addr union. The code
thereby discloses 16 bytes of kernel stack memory via getsockname().

Fix this by memset(0)'ing the union before.

Cc: Dmitry Kozlov <xeb@mail.ru>
Signed-off-by: Mathias Krause <minipli@googlemail.com>
Signed-off-by: David S. Miller <davem@davemloft.net>
Signed-off-by: Jiri Slaby <jslaby@suse.cz>
drivers/net/ppp/pptp.c