cifs: remove check of list iterator against head past the loop body
authorJakob Koschel <jakobkoschel@gmail.com>
Thu, 31 Mar 2022 21:55:41 +0000 (23:55 +0200)
committerSteve French <stfrench@microsoft.com>
Wed, 20 Apr 2022 14:41:07 +0000 (09:41 -0500)
commit475f3f09e79a079a29a7489f103b7873b7ef4b83
tree0732c7b979195f193da40e5754b4a2890e142aaf
parent239852007bd222b4e37d2badf12d0ecfe7d05814
cifs: remove check of list iterator against head past the loop body

When list_for_each_entry() completes the iteration over the whole list
without breaking the loop, the iterator value will be a bogus pointer
computed based on the head element.

While it is safe to use the pointer to determine if it was computed
based on the head element, either with list_entry_is_head() or
&pos->member == head, using the iterator variable after the loop should
be avoided.

In preparation to limit the scope of a list iterator to the list
traversal loop, use a dedicated pointer to point to the found element [1].

Link: https://lore.kernel.org/all/CAHk-=wgRr_D8CB-D9Kg-c=EHreAsk5SqXPwr9Y7k9sA6cWXJ6w@mail.gmail.com/
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Jakob Koschel <jakobkoschel@gmail.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/smb2misc.c