smb3: fix unusable share after force unmount failure smb3-client-fixes-6.3-rc3
authorSteve French <stfrench@microsoft.com>
Thu, 23 Mar 2023 21:20:02 +0000 (16:20 -0500)
committerSteve French <stfrench@microsoft.com>
Fri, 24 Mar 2023 19:37:12 +0000 (14:37 -0500)
commit491eafce1a51c457701351a4bf40733799745314
tree300db71a141c34da469ac2e96b58355b41d6ca8b
parentbe4fde79812f02914e350bde0bc4cfeae8429378
smb3: fix unusable share after force unmount failure

If user does forced unmount ("umount -f") while files are still open
on the share (as was seen in a Kubernetes example running on SMB3.1.1
mount) then we were marking the share as "TID_EXITING" in umount_begin()
which caused all subsequent operations (except write) to fail ... but
unfortunately when umount_begin() is called we do not know yet that
there are open files or active references on the share that would prevent
unmount from succeeding.  Kubernetes had example when they were doing
umount -f when files were open which caused the share to become
unusable until the files were closed (and the umount retried).

Fix this so that TID_EXITING is not set until we are about to send
the tree disconnect (not at the beginning of forced umounts in
umount_begin) so that if "umount -f" fails (due to open files or
references) the mount is still usable.

Cc: stable@vger.kernel.org
Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Reviewed-by: Paulo Alcantara (SUSE) <pc@manguebit.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/cifsfs.c
fs/cifs/cifssmb.c
fs/cifs/connect.c
fs/cifs/smb2pdu.c