drm/i915/gvt: fix double free bug in split_2MB_gtt_entry
authorZheng Wang <zyytlz.wz@163.com>
Thu, 29 Dec 2022 16:56:41 +0000 (00:56 +0800)
committerZhenyu Wang <zhenyuw@linux.intel.com>
Wed, 4 Jan 2023 15:21:19 +0000 (23:21 +0800)
commit4a61648af68f5ba4884f0e3b494ee1cabc4b6620
treea99dac423d942fb2bee8d1c5418bbf75577658c3
parenta06d4b9e15c0ea4e05b200cfb1f1050e785a5e87
drm/i915/gvt: fix double free bug in split_2MB_gtt_entry

If intel_gvt_dma_map_guest_page failed, it will call
ppgtt_invalidate_spt, which will finally free the spt.
But the caller function ppgtt_populate_spt_by_guest_entry
does not notice that, it will free spt again in its error
path.

Fix this by canceling the mapping of DMA address and freeing sub_spt.
Besides, leave the handle of spt destroy to caller function instead
of callee function when error occurs.

Fixes: b901b252b6cf ("drm/i915/gvt: Add 2M huge gtt support")
Signed-off-by: Zheng Wang <zyytlz.wz@163.com>
Reviewed-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Signed-off-by: Zhenyu Wang <zhenyuw@linux.intel.com>
Link: http://patchwork.freedesktop.org/patch/msgid/20221229165641.1192455-1-zyytlz.wz@163.com
drivers/gpu/drm/i915/gvt/gtt.c