libata: assume no device is attached if both IDENTIFYs are aborted
authorTejun Heo <htejun@gmail.com>
Sun, 23 Mar 2008 06:16:53 +0000 (15:16 +0900)
committerChris Wright <chrisw@sous-sol.org>
Sat, 19 Apr 2008 01:53:27 +0000 (18:53 -0700)
commit6cee5037c7c0950a80bd82f1c8c7dd6a22cd5422
treedaa16b77bbef443dd30dffd71c197d0d3f3298f9
parent3923d91d2ade70e9fcfe22aa965710ff8a2ae535
libata: assume no device is attached if both IDENTIFYs are aborted

upstream commit: 1ffc151fcddf524d0c76709d7e7a2af0255acb6b

This is to fix bugzilla #10254.  QSI cdrom attached to pata_sis as
secondary master appears as phantom device for the slave.
Interestingly, instead of not setting DRQ after IDENTIFY which
triggers NODEV_HINT, it aborts both IDENTIFY and IDENTIFY PACKET which
makes EH retry.

Modify EH such that it assumes no device is attached if both flavors
of IDENTIFY are aborted by the device.  There really isn't much point
in retrying when the device actively aborts the commands.

While at it, convert NODEV detection message to ata_dev_printk() to
help debugging obscure detection problems.

This problem was reported by Jan Bücken.

Signed-off-by: Tejun Heo <htejun@gmail.com>
Cc: Jan Bücken <jb.faq@gmx.de>
Acked-by: Alan Cox <alan@redhat.com>
Signed-off-by: Jeff Garzik <jeff@garzik.org>
dsd@gentoo.org notes:

This patch fixes http://bugs.gentoo.org/211369

Cc: Daniel Drake <dsd@gentoo.org>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
drivers/ata/libata-core.c