locking/atomic: scripts: Clarify ordering of conditional atomics
authorMark Rutland <mark.rutland@arm.com>
Fri, 9 Feb 2024 12:40:10 +0000 (12:40 +0000)
committerIngo Molnar <mingo@kernel.org>
Tue, 20 Feb 2024 08:55:09 +0000 (09:55 +0100)
commit6dfee110c6cc7a6c3c1f45a07428c15820b87c1d
tree0b2250a9838dc5b57e2fa55b5ff7932c946149db
parentb401b621758e46812da61fa58a67c3fd8d91de0d
locking/atomic: scripts: Clarify ordering of conditional atomics

Conditional atomic operations (e.g. cmpxchg()) only provide ordering
when the condition holds; when the condition does not hold, the location
is not modified and relaxed ordering is provided. Where ordering is
needed for failed conditional atomics, it is necessary to use
smp_mb__before_atomic() and/or smp_mb__after_atomic().

This is explained tersely in memory-barriers.txt, and is implied but not
explicitly stated in the kerneldoc comments for the conditional
operations. The lack of an explicit statement has lead to some off-list
queries about the ordering semantics of failing conditional operations,
so evidently this is confusing.

Update the kerneldoc comments to explicitly describe the lack of ordering
for failed conditional atomic operations.

For most conditional atomic operations, this is written as:

  | If (${condition}), atomically updates @v to (${new}) with ${desc_order} ordering.
  | Otherwise, @v is not modified and relaxed ordering is provided.

For the try_cmpxchg() operations, this is written as:

  | If (${condition}), atomically updates @v to @new with ${desc_order} ordering.
  | Otherwise, @v is not modified, @old is updated to the current value of @v,
  | and relaxed ordering is provided.

Signed-off-by: Mark Rutland <mark.rutland@arm.com>
Signed-off-by: Ingo Molnar <mingo@kernel.org>
Reviewed-by: Paul E. McKenney <paulmck@kernel.org>
Reviewed-by: Nhat Pham <nphamcs@gmail.com>
Link: https://lore.kernel.org/r/20240209124010.2096198-1-mark.rutland@arm.com
include/linux/atomic/atomic-arch-fallback.h
include/linux/atomic/atomic-instrumented.h
include/linux/atomic/atomic-long.h
scripts/atomic/kerneldoc/add_unless
scripts/atomic/kerneldoc/cmpxchg
scripts/atomic/kerneldoc/dec_if_positive
scripts/atomic/kerneldoc/dec_unless_positive
scripts/atomic/kerneldoc/inc_not_zero
scripts/atomic/kerneldoc/inc_unless_negative
scripts/atomic/kerneldoc/try_cmpxchg