md: use kzalloc() when bitmap is disabled
authorBenjamin Randazzo <benjamin@randazzo.fr>
Sat, 25 Jul 2015 14:36:50 +0000 (16:36 +0200)
committerZefan Li <lizefan@huawei.com>
Fri, 18 Sep 2015 01:20:46 +0000 (09:20 +0800)
commit842c36214f1d1715a30ede9430658411a349c839
tree0cac9bb099f674c0b1021bfc3c6a8a25686014f8
parent97186c0935bcdf8b9a72d1d7063577c845c25ef9
md: use kzalloc() when bitmap is disabled

commit b6878d9e03043695dbf3fa1caa6dfc09db225b16 upstream.

In drivers/md/md.c get_bitmap_file() uses kmalloc() for creating a
mdu_bitmap_file_t called "file".

5769         file = kmalloc(sizeof(*file), GFP_NOIO);
5770         if (!file)
5771                 return -ENOMEM;

This structure is copied to user space at the end of the function.

5786         if (err == 0 &&
5787             copy_to_user(arg, file, sizeof(*file)))
5788                 err = -EFAULT

But if bitmap is disabled only the first byte of "file" is initialized
with zero, so it's possible to read some bytes (up to 4095) of kernel
space memory from user space. This is an information leak.

5775         /* bitmap disabled, zero the first byte and copy out */
5776         if (!mddev->bitmap_info.file)
5777                 file->pathname[0] = '\0';

Signed-off-by: Benjamin Randazzo <benjamin@randazzo.fr>
Signed-off-by: NeilBrown <neilb@suse.com>
[lizf: Backported to 3.4: fix both branches]
Signed-off-by: Zefan Li <lizefan@huawei.com>
drivers/md/md.c