pstore: ram_core: fix possible overflow in persistent_ram_init_ecc()
authorSergey Shtylyov <s.shtylyov@omp.ru>
Sun, 5 Nov 2023 20:29:36 +0000 (23:29 +0300)
committerKees Cook <keescook@chromium.org>
Fri, 8 Dec 2023 22:15:00 +0000 (14:15 -0800)
commit86222a8fc16ec517de8da2604d904c9df3a08e5d
treedca05bc86de3551da6e4b9de323861992f86970d
parentd49270a04623ce3c0afddbf3e984cb245aa48e9c
pstore: ram_core: fix possible overflow in persistent_ram_init_ecc()

In persistent_ram_init_ecc(), on 64-bit arches DIV_ROUND_UP() will return
64-bit value since persistent_ram_zone::buffer_size has type size_t which
is derived from the 64-bit *unsigned long*, while the ecc_blocks variable
this value gets assigned to has (always 32-bit) *int* type.  Even if that
value fits into *int* type, an overflow is still possible when calculating
the size_t typed ecc_total variable further below since there's no cast to
any 64-bit type before multiplication.  Declaring the ecc_blocks variable
as *size_t* should fix this mess...

Found by Linux Verification Center (linuxtesting.org) with the SVACE static
analysis tool.

Fixes: 9cc05ad97c57 ("staging: android: persistent_ram: refactor ecc support")
Signed-off-by: Sergey Shtylyov <s.shtylyov@omp.ru>
Link: https://lore.kernel.org/r/20231105202936.25694-1-s.shtylyov@omp.ru
Signed-off-by: Kees Cook <keescook@chromium.org>
fs/pstore/ram_core.c