cifs: do not search for channel if server is terminating
authorShyam Prasad N <sprasad@microsoft.com>
Thu, 1 Feb 2024 11:15:28 +0000 (11:15 +0000)
committerSteve French <stfrench@microsoft.com>
Thu, 1 Feb 2024 18:12:17 +0000 (12:12 -0600)
commit88675b22d34e6e815ad4bde09c590ccb2d50c59d
treea189fbadbbeaed3abca0f5f750e0fa43dfcf2a15
parente77e15fa5eb1c830597c5ca53ea7af973bae2f78
cifs: do not search for channel if server is terminating

In order to scale down the channels, the following sequence
of operations happen:
1. server struct is marked for terminate
2. the channel is deallocated in the ses->chans array
3. at a later point the cifsd thread actually terminates the server

Between 2 and 3, there can be calls to find the channel for
a server struct. When that happens, there can be an ugly warning
that's logged. But this is expected.

So this change does two things:
1. in cifs_ses_get_chan_index, if server->terminate is set, return
2. always make sure server->terminate is set with chan_lock held

Signed-off-by: Shyam Prasad N <sprasad@microsoft.com>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/smb/client/sess.c
fs/smb/client/smb2pdu.c