pch_phub: Improve ADE(Address Decode Enable) control
authorTomoya MORINAGA <tomoya.rohm@gmail.com>
Fri, 11 Nov 2011 01:12:17 +0000 (10:12 +0900)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sun, 22 Apr 2012 23:21:42 +0000 (16:21 -0700)
commita1fdbba66d5a3a7ec0cc78ac8c1f19d99d37454e
tree66ca5a7a5fa87a6ba9e3da101dfd8c05d96fa1d5
parent7657523f93d637688488eb91a3ea86be12073827
pch_phub: Improve ADE(Address Decode Enable) control

commit 9914a0de7a27ef2cb5d9aacfe50ae97ebb532f28 upstream.

Currently, external ROM access is enabled/disabled in probe()/remove().
So, when a buggy software access unanticipated memory area,
in case of enabling this ADE bit,
external ROM memory area can be broken.

This patch enables the ADE bit only accessing external ROM area.

Signed-off-by: Tomoya MORINAGA <tomoya.rohm@gmail.com>
Cc: Masayuki Ohtak <masa-korg@dsn.okisemi.com>
Cc: Alexander Stein <alexander.stein@systec-electronic.com>
Cc: Denis Turischev <denis@compulab.co.il>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/misc/pch_phub.c