CVE-2018-14629 dns: fix CNAME loop prevention using counter regression
authorStefan Metzmacher <metze@samba.org>
Wed, 28 Nov 2018 14:21:56 +0000 (15:21 +0100)
committerKarolin Seeger <kseeger@samba.org>
Fri, 7 Dec 2018 09:28:30 +0000 (10:28 +0100)
commitc81921da2e5b2c42c9db25cdbb443891656a4df7
tree82280ab827cb0de5a80b816867171ecca0b28e86
parent9d58994621f37e3d1be1eb1ddf68d0675d188cd2
CVE-2018-14629 dns: fix CNAME loop prevention using counter regression

The loop prevention should only be done for CNAME records!

Otherwise we truncate the answer records for A, AAAA or
SRV queries, which is a bad idea if you have more than 20 DCs.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=13600

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Douglas Bagnall <douglas.bagnall@catalyst.net.nz>
Autobuild-User(master): Andrew Bartlett <abartlet@samba.org>
Autobuild-Date(master): Tue Dec  4 08:52:29 CET 2018 on sn-devel-144

(cherry picked from commit 34f4491d79b47b2fe2457b8882f11644cf773bc4)
selftest/knownfail.d/dns
source4/dns_server/dns_query.c