drivers: fix dma_get_required_mask
authorJames Bottomley <James.Bottomley@HansenPartnership.com>
Tue, 11 Mar 2008 01:50:07 +0000 (01:50 +0000)
committerChris Wright <chrisw@sous-sol.org>
Mon, 24 Mar 2008 18:47:11 +0000 (11:47 -0700)
commitc9ef5a43530e7dbec05c1dad59356f85516d2c0b
tree0b6186ae6fe2debc83fcfc58cea05ff1bc333c9f
parentb6845726368e5b7b086e6d6438c9380bf5b7bc1c
drivers: fix dma_get_required_mask

commit: e88a0c2ca81207a75afe5bbb8020541dabf606ac
Date: Sun, 9 Mar 2008 11:57:56 -0500
Subject: drivers: fix dma_get_required_mask

There's a bug in the current implementation of dma_get_required_mask()
where it ands the returned mask with the current device mask.  This
rather defeats the purpose if you're using the call to determine what
your mask should be (since you will at that time have the default
DMA_32BIT_MASK).  This bug results in any driver that uses this function
*always* getting a 32 bit mask, which is wrong.

Fix by removing the and with dev->dma_mask.

Signed-off-by: James Bottomley <James.Bottomley@HansenPartnership.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
Signed-off-by: Chris Wright <chrisw@sous-sol.org>
Signed-off-by: Greg Kroah-Hartman <gregkh@suse.de>
drivers/base/platform.c