thermal/debugfs: Prevent use-after-free from occurring after cdev removal
authorRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 26 Apr 2024 09:10:10 +0000 (11:10 +0200)
committerRafael J. Wysocki <rafael.j.wysocki@intel.com>
Fri, 26 Apr 2024 12:57:50 +0000 (14:57 +0200)
commitd351eb0ab04c3e8109895fc33250cebbce9c11da
tree69d658b6e9ac585c988866c1a4c9406e13d9dbfb
parentc7f7c37271787a7f77d7eedc132b0b419a76b4c8
thermal/debugfs: Prevent use-after-free from occurring after cdev removal

Since thermal_debug_cdev_remove() does not run under cdev->lock, it can
run in parallel with thermal_debug_cdev_state_update() and it may free
the struct thermal_debugfs object used by the latter after it has been
checked against NULL.

If that happens, thermal_debug_cdev_state_update() will access memory
that has been freed already causing the kernel to crash.

Address this by using cdev->lock in thermal_debug_cdev_remove() around
the cdev->debugfs value check (in case the same cdev is removed at the
same time in two different threads) and its reset to NULL.

Fixes: 755113d76786 ("thermal/debugfs: Add thermal cooling device debugfs information")
Cc :6.8+ <stable@vger.kernel.org> # 6.8+
Signed-off-by: Rafael J. Wysocki <rafael.j.wysocki@intel.com>
Reviewed-by: Lukasz Luba <lukasz.luba@arm.com>
drivers/thermal/thermal_debugfs.c