cifs: move debug print out of spinlock
authorSteve French <stfrench@microsoft.com>
Tue, 16 Nov 2021 03:00:08 +0000 (21:00 -0600)
committerSteve French <stfrench@microsoft.com>
Tue, 16 Nov 2021 16:46:09 +0000 (10:46 -0600)
It is better to print debug messages outside of the chan_lock
spinlock where possible.

Reviewed-by: Shyam Prasad N <sprasad@microsoft.com>
Addresses-Coverity: 1493854 ("Thread deadlock")
Reviewed-by: Paulo Alcantara (SUSE) <pc@cjr.nz>
Signed-off-by: Steve French <stfrench@microsoft.com>
fs/cifs/sess.c

index 2c10b186ed6ee6444c43c852500fb4714bf291b5..7db8b22edac98fd601cb34e54798d797eed8c6cb 100644 (file)
@@ -95,9 +95,9 @@ int cifs_try_adding_channels(struct cifs_sb_info *cifs_sb, struct cifs_ses *ses)
        }
 
        if (!(ses->server->capabilities & SMB2_GLOBAL_CAP_MULTI_CHANNEL)) {
-               cifs_dbg(VFS, "server %s does not support multichannel\n", ses->server->hostname);
                ses->chan_max = 1;
                spin_unlock(&ses->chan_lock);
+               cifs_dbg(VFS, "server %s does not support multichannel\n", ses->server->hostname);
                return 0;
        }
        spin_unlock(&ses->chan_lock);