s3:rpc_client: don't randomly fragment rpc pdu's in developer mode
authorStefan Metzmacher <metze@samba.org>
Sun, 20 Sep 2009 21:29:11 +0000 (23:29 +0200)
committerKarolin Seeger <kseeger@samba.org>
Tue, 20 Oct 2009 13:00:25 +0000 (15:00 +0200)
This is really confusing and also breaks against windows,
as it doesn't accept fragmented bind requests.

metze
(cherry picked from commit 68b8149d1fb26b2fe1138c99d971754b0a30378b)
(cherry picked from commit 10ff61b24f0604c9686e728ac92c1a2987a31aed)

source3/rpc_client/cli_pipe.c

index 9990f1b7a0184d40e1c08c064a77324b8791c09a..0d1d5e8dbda9a1a57743ba7152255bb81a52ee67 100644 (file)
@@ -1280,7 +1280,7 @@ static struct async_req *rpc_api_pipe_send(TALLOC_CTX *mem_ctx,
 
        max_recv_frag = cli->max_recv_frag;
 
-#ifdef DEVELOPER
+#if 0
        max_recv_frag = RPC_HEADER_LEN + 10 + (sys_random() % 32);
 #endif
 
@@ -1966,7 +1966,7 @@ static uint32 calculate_data_len_tosend(struct rpc_pipe_client *cli,
 {
        uint32 data_space, data_len;
 
-#ifdef DEVELOPER
+#if 0
        if ((data_left > 0) && (sys_random() % 2)) {
                data_left = MAX(data_left/2, 1);
        }