libcli/auth: fix usage of an uninitialized variable in netlogon_creds_cli_check_caps()
authorStefan Metzmacher <metze@samba.org>
Wed, 8 Jan 2014 11:04:22 +0000 (12:04 +0100)
committerStefan Metzmacher <metze@samba.org>
Wed, 8 Jan 2014 13:34:13 +0000 (14:34 +0100)
If status is RPC_PROCNUM_OUT_OF_RANGE, result might be uninitialized.

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Günther Deschner <gd@samba.org>
libcli/auth/netlogon_creds_cli.c

index 17240640ca83578f45a2936e468f332c7ba8df56..51b30a14b787f2d9175d224c49cde4d2e27f4132 100644 (file)
@@ -1390,7 +1390,7 @@ struct netlogon_creds_cli_check_state {
 };
 
 static void netlogon_creds_cli_check_cleanup(struct tevent_req *req,
-                                                    NTSTATUS status);
+                                            NTSTATUS status);
 static void netlogon_creds_cli_check_locked(struct tevent_req *subreq);
 
 struct tevent_req *netlogon_creds_cli_check_send(TALLOC_CTX *mem_ctx,
@@ -1582,7 +1582,7 @@ static void netlogon_creds_cli_check_caps(struct tevent_req *subreq)
                 * with the next request as the sequence number processing
                 * gets out of sync.
                 */
-               netlogon_creds_cli_check_cleanup(req, result);
+               netlogon_creds_cli_check_cleanup(req, status);
                tevent_req_done(req);
                return;
        }