smbd: remove directory changing from become_user*()

This was the behavior in versions before 4.9 and
it is hopefully not required by current callers of
become_user*().

Pair-Programmed-With: Ralph Boehme <slow@samba.org>

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source3/smbd/uid.c b/source3/smbd/uid.c
index 5b0afcb1e9a6337dee79dfa38561298b0bc890cb..106f143001184aecc878d07fe111a9a611e0ecb4 100644 (file)
--- a/source3/smbd/uid.c
+++ b/source3/smbd/uid.c
@@ -686,7 +686,7 @@ bool become_user(connection_struct *conn, uint64_t vuid)
 
        push_conn_ctx();
 
-       ok = change_to_user_internal(conn, vuser->session_info, vuid);
+       ok = change_to_user_impersonate(conn, vuser->session_info, vuid);
        if (!ok) {
                pop_sec_ctx();
                pop_conn_ctx();
@@ -716,7 +716,7 @@ bool become_user_by_session(connection_struct *conn,
 
        push_conn_ctx();
 
-       ok = change_to_user_internal(conn, session_info, UID_FIELD_INVALID);
+       ok = change_to_user_impersonate(conn, session_info, UID_FIELD_INVALID);
        if (!ok) {
                pop_sec_ctx();
                pop_conn_ctx();