s4/dnsserver: Don't call memcpy() with a NULL pointer

Doing so is undefined behaviour.

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Jeremy Allison <jra@samba.org>

diff --git a/source4/dns_server/dnsserver_common.c b/source4/dns_server/dnsserver_common.c
index d1f896d67551a26c04980b7668eb7c3f3f07909d..984c65dbdf80e7dfd89c734f561afbc58cdf7f97 100644 (file)
--- a/source4/dns_server/dnsserver_common.c
+++ b/source4/dns_server/dnsserver_common.c
@@ -292,8 +292,10 @@ static struct ldb_parse_tree *build_equality_operation(
        value->length = length;
        if (add_asterix) {
                value->data[0] = '*';
-               memcpy(&value->data[1], name, size);
-       } else {
+               if (name != NULL) {
+                       memcpy(&value->data[1], name, size);
+               }
+       } else if (name != NULL) {
                memcpy(value->data, name, size);
        }
        return el;