]> git.samba.org - samba.git/commitdiff
lib/util: clang: Fix Value stored during its initialization is never read
authorNoel Power <noel.power@suse.com>
Thu, 13 Jun 2019 18:26:18 +0000 (18:26 +0000)
committerNoel Power <npower@samba.org>
Wed, 26 Jun 2019 10:30:23 +0000 (10:30 +0000)
Fixes:

lib/util/util_tdb.c:385:11: warning: Value stored to 'result' during its initialization is never read <--[clang]

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
lib/util/util_tdb.c

index 24fb6584899760329b9836b51f1de6a9af69656d..7b57e83395dbfaa3154f31c3e285ccb3bb09968b 100644 (file)
@@ -382,7 +382,7 @@ int tdb_traverse_delete_fn(struct tdb_context *the_tdb, TDB_DATA key, TDB_DATA d
 
 NTSTATUS map_nt_error_from_tdb(enum TDB_ERROR err)
 {
-       NTSTATUS result = NT_STATUS_INTERNAL_ERROR;
+       NTSTATUS result;
 
        switch (err) {
        case TDB_SUCCESS:
@@ -430,6 +430,9 @@ NTSTATUS map_nt_error_from_tdb(enum TDB_ERROR err)
        case TDB_ERR_NESTING:
                result = NT_STATUS_INTERNAL_ERROR;
                break;
+       default:
+               result = NT_STATUS_INTERNAL_ERROR;
+               break;
        };
        return result;
 }