tests: Move setresuid test to own executable

Signed-off-by: Andreas Schneider <asn@samba.org>
Reviewed-by: Stefan Metzmacher <metze@samba.org>

diff --git a/tests/CMakeLists.txt b/tests/CMakeLists.txt
index d0a1c5a705b19b13cc49c102e2e5b51271da590a..1741c088282f171e7cb31a63b2de33ed62b8593b 100644 (file)
--- a/tests/CMakeLists.txt
+++ b/tests/CMakeLists.txt
@@ -25,6 +25,10 @@ if (HAVE_SETREUID)
     list(APPEND UWRAP_UID_TESTS test_setreuid)
 endif (HAVE_SETREUID)
 
+if (HAVE_SETRESUID)
+    list(APPEND UWRAP_UID_TESTS test_setresuid)
+endif (HAVE_SETRESUID)
+
 set(UWRAP_TESTS
     ${UWRAP_UID_TESTS}
     test_uid

diff --git a/tests/test_setresuid.c b/tests/test_setresuid.c
new file mode 100644 (file)
index 0000000..9feda5f
--- /dev/null
+++ b/tests/test_setresuid.c
@@ -0,0 +1,256 @@
+#include "config.h"
+
+#include <stdarg.h>
+#include <stddef.h>
+#include <setjmp.h>
+#include <cmocka.h>
+
+#include <errno.h>
+#include <sys/types.h>
+#include <unistd.h>
+#include <errno.h>
+
+#include <pwd.h>
+
+static void test_uwrap_setresuid(void **state)
+{
+       int rc;
+       uid_t u;
+#ifdef HAVE_GETRESUID
+       uid_t cp_ruid, cp_euid, cp_suid;
+#endif
+
+       (void) state; /* unused */
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 0);
+       assert_int_equal(cp_euid, 0);
+       assert_int_equal(cp_suid, 0);
+#endif
+       u = geteuid();
+       assert_int_equal(u, 0);
+
+       rc = setresuid(-1, -1, -1);
+       assert_return_code(rc, errno);
+
+       rc = setresuid(0x4444, 0x5555, -1);
+       assert_return_code(rc, errno);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 0x4444);
+       assert_int_equal(cp_euid, 0x5555);
+       assert_int_equal(cp_suid, 0);
+#endif
+
+       u = getuid();
+       assert_int_equal(u, 0x4444);
+
+       u = geteuid();
+       assert_int_equal(u, 0x5555);
+
+       /* We can go back cause the suid is 0 */
+       rc = setresuid(0, -1, -1);
+       assert_return_code(rc, errno);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 0);
+       assert_int_equal(cp_euid, 0x5555);
+       assert_int_equal(cp_suid, 0);
+#endif
+
+       u = getuid();
+       assert_int_equal(u, 0);
+
+       rc = setresuid(-1, 0, -1);
+       assert_return_code(rc, errno);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 0);
+       assert_int_equal(cp_euid, 0);
+       assert_int_equal(cp_suid, 0);
+#endif
+
+       u = geteuid();
+       assert_int_equal(u, 0);
+
+       rc = setresuid(0, 0x5555, 0x6666);
+       assert_return_code(rc, errno);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 0);
+       assert_int_equal(cp_euid, 0x5555);
+       assert_int_equal(cp_suid, 0x6666);
+#endif
+
+       /*
+        * The euid needs to be 0 in order to change to an
+        * unknown value (here 0x4444)
+        */
+       rc = setresuid(0x5555, 0x6666, 0x4444);
+       assert_int_equal(rc, -1);
+       assert_int_equal(errno, EPERM);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 0);
+       assert_int_equal(cp_euid, 0x5555);
+       assert_int_equal(cp_suid, 0x6666);
+#endif
+
+       /* But we can rotate the values */
+       errno = 0;
+       rc = setresuid(0x5555, 0x6666, 0);
+       assert_return_code(rc, errno);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 0x5555);
+       assert_int_equal(cp_euid, 0x6666);
+       assert_int_equal(cp_suid, 0);
+#endif
+
+       /*
+        * The euid needs to be 0 in order to change to an
+        * unknown value (here 0x4444)
+        */
+       rc = setresuid(0x5555, 0x6666, 0x4444);
+       assert_int_equal(rc, -1);
+       assert_int_equal(errno, EPERM);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 0x5555);
+       assert_int_equal(cp_euid, 0x6666);
+       assert_int_equal(cp_suid, 0);
+#endif
+
+       /* But we can rotate the values */
+       rc = setresuid(0x5555, 0, 0x6666);
+       assert_return_code(rc, errno);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 0x5555);
+       assert_int_equal(cp_euid, 0);
+       assert_int_equal(cp_suid, 0x6666);
+#endif
+
+       /*
+        * With euid == 0 we can change to completely unrelated values.
+        */
+       rc = setresuid(1111, 2222, 3333);
+       assert_return_code(rc, errno);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 1111);
+       assert_int_equal(cp_euid, 2222);
+       assert_int_equal(cp_suid, 3333);
+#endif
+
+       rc = setresuid(0, -1, -1);
+       assert_int_equal(rc, -1);
+       assert_int_equal(errno, EPERM);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 1111);
+       assert_int_equal(cp_euid, 2222);
+       assert_int_equal(cp_suid, 3333);
+#endif
+
+       rc = setresuid(-1, 0, -1);
+       assert_int_equal(rc, -1);
+       assert_int_equal(errno, EPERM);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 1111);
+       assert_int_equal(cp_euid, 2222);
+       assert_int_equal(cp_suid, 3333);
+#endif
+
+       rc = setresuid(-1, -1, 0);
+       assert_int_equal(rc, -1);
+       assert_int_equal(errno, EPERM);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 1111);
+       assert_int_equal(cp_euid, 2222);
+       assert_int_equal(cp_suid, 3333);
+#endif
+
+       /*
+        * We can still roate the values
+        */
+       rc = setresuid(2222, 3333, 1111);
+       assert_return_code(rc, errno);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 2222);
+       assert_int_equal(cp_euid, 3333);
+       assert_int_equal(cp_suid, 1111);
+#endif
+
+       /*
+        * We can still roate the values
+        */
+       rc = setresuid(3333, 1111, 2222);
+       assert_return_code(rc, errno);
+
+#ifdef HAVE_GETRESUID
+       cp_ruid = cp_euid = cp_suid = -1;
+       rc = getresuid(&cp_ruid, &cp_euid, &cp_suid);
+       assert_return_code(rc, errno);
+       assert_int_equal(cp_ruid, 3333);
+       assert_int_equal(cp_euid, 1111);
+       assert_int_equal(cp_suid, 2222);
+#endif
+}
+
+int main(void) {
+       int rc;
+
+       const struct CMUnitTest uwrap_tests[] = {
+               cmocka_unit_test(test_uwrap_setresuid),
+       };
+
+       rc = cmocka_run_group_tests(uwrap_tests, NULL, NULL);
+
+       return rc;
+}

diff --git a/tests/test_uid.c b/tests/test_uid.c
index bb73ea7602d7a08ea12d7d1643ae278b7a442c63..ef01e3cfb377cec0412c41073370f8d5d5dd845e 100644 (file)
--- a/tests/test_uid.c
+++ b/tests/test_uid.c
@@ -10,25 +10,6 @@
 
 #include <pwd.h>
 
-#ifdef HAVE_SETRESUID
-static void test_uwrap_setresuid(void **state)
-{
-       int rc;
-       uid_t u;
-
-       (void) state; /* unused */
-
-       rc = setresuid(1, 2, -1);
-       assert_int_equal(rc, 0);
-
-       u = getuid();
-       assert_int_equal(u, 1);
-
-       u = geteuid();
-       assert_int_equal(u, 2);
-}
-#endif
-
 #ifdef HAVE_GETRESUID
 static void test_uwrap_getresuid(void **state)
 {
@@ -56,9 +37,6 @@ int main(void) {
        int rc;
 
        const struct CMUnitTest uwrap_tests[] = {
-#ifdef HAVE_SETRESUID
-               cmocka_unit_test(test_uwrap_setresuid),
-#endif
 #ifdef HAVE_GETRESUID
                cmocka_unit_test(test_uwrap_getresuid),
 #endif