netfilter: nft_osf: simplify init path

Remove useless branch to check for errors in nft_parse_register_store().

Signed-off-by: Pablo Neira Ayuso <pablo@netfilter.org>
Signed-off-by: Florian Westphal <fw@strlen.de>

diff --git a/net/netfilter/nft_osf.c b/net/netfilter/nft_osf.c
index 7f61506e5b44bd6501577a110fe09259c2a0aa4d..7fec57ff736f65bace26955e646111d57fe9bbb9 100644 (file)
--- a/net/netfilter/nft_osf.c
+++ b/net/netfilter/nft_osf.c
@@ -63,7 +63,6 @@ static int nft_osf_init(const struct nft_ctx *ctx,
 {
        struct nft_osf *priv = nft_expr_priv(expr);
        u32 flags;
-       int err;
        u8 ttl;
 
        if (!tb[NFTA_OSF_DREG])
@@ -83,13 +82,9 @@ static int nft_osf_init(const struct nft_ctx *ctx,
                priv->flags = flags;
        }
 
-       err = nft_parse_register_store(ctx, tb[NFTA_OSF_DREG], &priv->dreg,
-                                      NULL, NFT_DATA_VALUE,
-                                      NFT_OSF_MAXGENRELEN);
-       if (err < 0)
-               return err;
-
-       return 0;
+       return nft_parse_register_store(ctx, tb[NFTA_OSF_DREG], &priv->dreg,
+                                       NULL, NFT_DATA_VALUE,
+                                       NFT_OSF_MAXGENRELEN);
 }
 
 static int nft_osf_dump(struct sk_buff *skb,