s3: Don't overwrite password in pam_winbind, subsequent pam modules might use the...
authorBo Yang <boyang@samba.org>
Wed, 16 Sep 2009 15:57:01 +0000 (23:57 +0800)
committerKarolin Seeger <kseeger@samba.org>
Sat, 19 Sep 2009 16:55:17 +0000 (18:55 +0200)
Signed-off-by: Bo Yang <boyang@samba.org>
Fix bug #6735.

nsswitch/pam_winbind.c

index 4a44248e8ea90604c6a25398f76265608ff6a196..35cbc3b17bb35f61a0a350df8e2ac1ab75555fe0 100644 (file)
@@ -3056,8 +3056,6 @@ int pam_sm_chauthtok(pam_handle_t * pamh, int flags,
                ret = winbind_chauthtok_request(ctx, user, pass_old,
                                                pass_new, pwdlastset_update);
                if (ret) {
-                       _pam_overwrite(pass_new);
-                       _pam_overwrite(pass_old);
                        pass_old = pass_new = NULL;
                        goto out;
                }
@@ -3086,8 +3084,6 @@ int pam_sm_chauthtok(pam_handle_t * pamh, int flags,
                                                   member, cctype, 0,
                                                   &error, &info, &policy,
                                                   NULL, &username_ret);
-                       _pam_overwrite(pass_new);
-                       _pam_overwrite(pass_old);
                        pass_old = pass_new = NULL;
 
                        if (ret == PAM_SUCCESS) {