pstore: Make sure CONFIG_PSTORE_PMSG selects CONFIG_RT_MUTEXES
authorJohn Stultz <jstultz@google.com>
Wed, 21 Dec 2022 05:18:55 +0000 (05:18 +0000)
committerKees Cook <keescook@chromium.org>
Fri, 23 Dec 2022 18:33:27 +0000 (10:33 -0800)
In commit 76d62f24db07 ("pstore: Switch pmsg_lock to an rt_mutex
to avoid priority inversion") I changed a lock to an rt_mutex.

However, its possible that CONFIG_RT_MUTEXES is not enabled,
which then results in a build failure, as the 0day bot detected:
  https://lore.kernel.org/linux-mm/202212211244.TwzWZD3H-lkp@intel.com/

Thus this patch changes CONFIG_PSTORE_PMSG to select
CONFIG_RT_MUTEXES, which ensures the build will not fail.

Cc: Wei Wang <wvw@google.com>
Cc: Midas Chien<midaschieh@google.com>
Cc: Connor O'Brien <connoro@google.com>
Cc: Kees Cook <keescook@chromium.org>
Cc: Anton Vorontsov <anton@enomsg.org>
Cc: Colin Cross <ccross@android.com>
Cc: Tony Luck <tony.luck@intel.com>
Cc: kernel test robot <lkp@intel.com>
Cc: kernel-team@android.com
Fixes: 76d62f24db07 ("pstore: Switch pmsg_lock to an rt_mutex to avoid priority inversion")
Reported-by: kernel test robot <lkp@intel.com>
Signed-off-by: John Stultz <jstultz@google.com>
Signed-off-by: Kees Cook <keescook@chromium.org>
Link: https://lore.kernel.org/r/20221221051855.15761-1-jstultz@google.com
fs/pstore/Kconfig

index 8adabde685f132f2375114bef345e27db85a9265..c49d554cc9ae9f80aa07a19ae8c4a83b19135b6b 100644 (file)
@@ -126,6 +126,7 @@ config PSTORE_CONSOLE
 config PSTORE_PMSG
        bool "Log user space messages"
        depends on PSTORE
+       select RT_MUTEXES
        help
          When the option is enabled, pstore will export a character
          interface /dev/pmsg0 to log user space messages. On reboot