auth/spnego: fix gensec_update_ev() argument order for the SPNEGO_FALLBACK case
authorStefan Metzmacher <metze@samba.org>
Fri, 12 May 2017 07:10:19 +0000 (09:10 +0200)
committerAndrew Bartlett <abartlet@samba.org>
Sun, 21 May 2017 19:05:08 +0000 (21:05 +0200)
This went unnoticed so long as we don't use -Wc++-compat
and gensec_update_ev() used the sync update() hook for all
NTLMSSP and Kerberos.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=12788

Signed-off-by: Stefan Metzmacher <metze@samba.org>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
auth/gensec/spnego.c

index 484f49175fca486ea415e24987bf72d3b82593d4..645c8b2e0871b66607813b01fe1a1d9fe5482c3e 100644 (file)
@@ -366,7 +366,7 @@ static NTSTATUS gensec_spnego_server_try_fallback(struct gensec_security *gensec
                        return nt_status;
                }
                nt_status = gensec_update_ev(spnego_state->sub_sec_security,
-                                         ev, out_mem_ctx, in, out);
+                                            out_mem_ctx, ev, in, out);
                return nt_status;
        }
        DEBUG(1, ("Failed to parse SPNEGO request\n"));
@@ -804,8 +804,8 @@ static NTSTATUS gensec_spnego_update(struct gensec_security *gensec_security, TA
 
        switch (spnego_state->state_position) {
        case SPNEGO_FALLBACK:
-               return gensec_update_ev(spnego_state->sub_sec_security, ev,
-                                    out_mem_ctx, in, out);
+               return gensec_update_ev(spnego_state->sub_sec_security,
+                                       out_mem_ctx, ev, in, out);
        case SPNEGO_SERVER_START:
        {
                NTSTATUS nt_status;