s3: Make is_stat_open() a bit more readable

diff --git a/source3/smbd/open.c b/source3/smbd/open.c
index d142d960f7ec6e2577003ff1d5870faf0851a2f2..eff78d45339d0fa3e60f15760f20381de167c011 100644 (file)
--- a/source3/smbd/open.c
+++ b/source3/smbd/open.c
@@ -1066,11 +1066,14 @@ static void validate_my_share_entries(struct smbd_server_connection *sconn,
 
 bool is_stat_open(uint32 access_mask)
 {
+       const uint32_t stat_open_bits =
+               (SYNCHRONIZE_ACCESS|
+                FILE_READ_ATTRIBUTES|
+                FILE_WRITE_ATTRIBUTES);
+
        return (access_mask &&
-               ((access_mask & ~(SYNCHRONIZE_ACCESS| FILE_READ_ATTRIBUTES|
-                                 FILE_WRITE_ATTRIBUTES))==0) &&
-               ((access_mask & (SYNCHRONIZE_ACCESS|FILE_READ_ATTRIBUTES|
-                                FILE_WRITE_ATTRIBUTES)) != 0));
+               ((access_mask & ~stat_open_bits) == 0) &&
+               ((access_mask & stat_open_bits) != 0));
 }
 
 /****************************************************************************