vfs_gpfs: remove ENOSYS fallback from vfs_gpfs_fset_dos_attributes()
authorRalph Boehme <slow@samba.org>
Fri, 13 Aug 2021 09:39:05 +0000 (11:39 +0200)
committerRalph Boehme <slow@samba.org>
Thu, 26 Aug 2021 19:18:31 +0000 (19:18 +0000)
This API call has existed for a long time, so we can safely assume that this
always works.

BUG: https://bugzilla.samba.org/show_bug.cgi?id=14771

Pair-Programmed-With: Christof Schmitt <cs@samba.org>
Signed-off-by: Ralph Boehme <slow@samba.org>
Signed-off-by: Christof Schmitt <cs@samba.org>
source3/modules/vfs_gpfs.c

index a8e50b82a17f6319a55a520972161514679da9b3..94d0258b38d4a776e659c909cdd8184971a78930 100644 (file)
@@ -1584,13 +1584,9 @@ static NTSTATUS vfs_gpfs_fset_dos_attributes(struct vfs_handle_struct *handle,
        }
 
        attrs.winAttrs = vfs_gpfs_dosmode_to_winattrs(dosmode);
+
        ret = gpfswrap_set_winattrs(fsp_get_io_fd(fsp),
                                    GPFS_WINATTR_SET_ATTRS, &attrs);
-
-       if (ret == -1 && errno == ENOSYS) {
-               return SMB_VFS_NEXT_FSET_DOS_ATTRIBUTES(handle, fsp, dosmode);
-       }
-
        if (ret == -1) {
                DBG_WARNING("Setting winattrs failed for %s: %s\n",
                            fsp->fsp_name->base_name, strerror(errno));