When fopen() fails it return NULL, so condition where return value
less than zero never evaluated to truth.
Found by cppcheck.
sprintf(fname, "/tmp/getgrent_r-%s.out-%d", id, getpid());
- if ((fptr = fopen(fname, "w")) < 0) {
+ if ((fptr = fopen(fname, "w")) == NULL) {
fprintf(stderr, "ERROR: could not open file %s: %s\n", fname,
sys_errlist[errno]);
return;
sprintf(fname, "/tmp/getpwent_r-%s.out-%d", id, getpid());
- if ((fptr = fopen(fname, "w")) < 0) {
+ if ((fptr = fopen(fname, "w")) == 0) {
fprintf(stderr, "ERROR: could not open file %s: %s\n", fname,
sys_errlist[errno]);
return;