s4-smbserver: removed bogus initialisation of two union arms
authorAndrew Tridgell <tridge@samba.org>
Sat, 17 Oct 2009 02:12:24 +0000 (13:12 +1100)
committerAndrew Tridgell <tridge@samba.org>
Sat, 17 Oct 2009 02:12:24 +0000 (13:12 +1100)
Thanks to Metze for spotting this.

source4/smb_server/smb/nttrans.c
source4/smb_server/smb/reply.c

index 316305aa29a4de73a8a9ec82672441d2e6267c7f..91b6aba0963bb002aa2cda183af20935fe6faf8a 100644 (file)
@@ -119,7 +119,6 @@ static NTSTATUS nttrans_create(struct smbsrv_request *req,
        params = trans->in.params.data;
 
        io->ntcreatex.in.flags            = IVAL(params,  0);
-       io->ntcreatex.in.root_fid.fnum    = IVAL(params,  4);
        io->ntcreatex.in.root_fid.ntvfs   = smbsrv_pull_fnum(req, params, 4);
        io->ntcreatex.in.access_mask      = IVAL(params,  8);
        io->ntcreatex.in.alloc_size       = BVAL(params, 12);
index 4baea4703af5e3db6c54d3ada068121791c53220..2c99a38575c04eafbc8d932acbf4b031eea7653d 100644 (file)
@@ -2216,7 +2216,6 @@ void smbsrv_reply_ntcreate_and_X(struct smbsrv_request *req)
        /* notice that the word parameters are not word aligned, so we don't use VWV() */
        fname_len =                         SVAL(req->in.vwv, 5);
        io->ntcreatex.in.flags =            IVAL(req->in.vwv, 7);
-       io->ntcreatex.in.root_fid.fnum  =   IVAL(req->in.vwv, 11);
        io->ntcreatex.in.root_fid.ntvfs =   smbsrv_pull_fnum(req, req->in.vwv, 11);
        io->ntcreatex.in.access_mask =      IVAL(req->in.vwv, 15);
        io->ntcreatex.in.alloc_size =       BVAL(req->in.vwv, 19);